)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a42aaafa7f0d16e42158dd2ebaa3f34f6de3fc6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f05cb16f_8defc42a","updated":"2025-08-18 19:25:15.000000000","message":"Hi Alfredo, I think that we are also missing the documentation updates with the new fields: https://docs.openstack.org/watcher/latest/contributor/notifications.html\nThanks for the proposal","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d6f5f6eb5c732b055161cea4b98ac869864fd8ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6cc56556_38101b1f","in_reply_to":"f05cb16f_8defc42a","updated":"2025-08-19 08:51:51.000000000","message":"right, thanks","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8fac73f79b72e955ea21d5f64d820907a401f795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d703c94f_4a8094eb","updated":"2025-08-20 17:06:45.000000000","message":"this LGTM thanks Alfredo","commit_id":"5048a6e3ba55f3be6a2b831e33975bee9dd5ec3a"}],"watcher/notifications/action_plan.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a42aaafa7f0d16e42158dd2ebaa3f34f6de3fc6c","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"@base.WatcherObjectRegistry.register_notification"},{"line_number":74,"context_line":"class ActionPlanPayload(TerseActionPlanPayload):"},{"line_number":75,"context_line":"    SCHEMA \u003d {"},{"line_number":76,"context_line":"        \u0027uuid\u0027: (\u0027action_plan\u0027, \u0027uuid\u0027),"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        \u0027state\u0027: (\u0027action_plan\u0027, \u0027state\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"6229095a_b43a536b","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":10},"updated":"2025-08-18 19:25:15.000000000","message":"hum, don\u0027t you need to update the schema here too?","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d6f5f6eb5c732b055161cea4b98ac869864fd8ed","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"@base.WatcherObjectRegistry.register_notification"},{"line_number":74,"context_line":"class ActionPlanPayload(TerseActionPlanPayload):"},{"line_number":75,"context_line":"    SCHEMA \u003d {"},{"line_number":76,"context_line":"        \u0027uuid\u0027: (\u0027action_plan\u0027, \u0027uuid\u0027),"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        \u0027state\u0027: (\u0027action_plan\u0027, \u0027state\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ca6c76b_85cf5b76","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":10},"in_reply_to":"6229095a_b43a536b","updated":"2025-08-19 08:51:51.000000000","message":"right","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8fac73f79b72e955ea21d5f64d820907a401f795","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"@base.WatcherObjectRegistry.register_notification"},{"line_number":74,"context_line":"class ActionPlanPayload(TerseActionPlanPayload):"},{"line_number":75,"context_line":"    SCHEMA \u003d {"},{"line_number":76,"context_line":"        \u0027uuid\u0027: (\u0027action_plan\u0027, \u0027uuid\u0027),"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        \u0027state\u0027: (\u0027action_plan\u0027, \u0027state\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"159e2327_312e99a7","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":10},"in_reply_to":"9ca6c76b_85cf5b76","updated":"2025-08-20 17:06:45.000000000","message":"Done","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"}],"watcher/objects/action.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3a70de507f51e9f50038acb1468d272b1d9edfc0","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # Version 1.1: Added \u0027action_plan\u0027 object field"},{"line_number":42,"context_line":"    # Version 2.0: Removed \u0027next\u0027 object field, Added \u0027parents\u0027 object field"},{"line_number":43,"context_line":"    # Version 2.1: Added \u0027status_message\u0027 object field"},{"line_number":44,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ecdce68_03f47aae","line":44,"updated":"2025-08-19 10:55:49.000000000","message":"this is unrelated to the patch, but I wondering, do we have any convention for the versioning? I see that this object went from 1.1 to 2.0 and the commit does not have any reasoning why https://github.com/openstack/watcher/commit/0e440d37ee09c35134478fe594d3224f8e4935e7\nJust leaving the question here in case someone knows","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8fac73f79b72e955ea21d5f64d820907a401f795","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # Version 1.1: Added \u0027action_plan\u0027 object field"},{"line_number":42,"context_line":"    # Version 2.0: Removed \u0027next\u0027 object field, Added \u0027parents\u0027 object field"},{"line_number":43,"context_line":"    # Version 2.1: Added \u0027status_message\u0027 object field"},{"line_number":44,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ce4906f_05ac3b60","line":44,"in_reply_to":"2c17cc1d_e6746b0a","updated":"2025-08-20 17:06:45.000000000","message":"Acknowledged","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ae500154bb763179a0290e68313a9bcfcbbaf49f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # Version 1.1: Added \u0027action_plan\u0027 object field"},{"line_number":42,"context_line":"    # Version 2.0: Removed \u0027next\u0027 object field, Added \u0027parents\u0027 object field"},{"line_number":43,"context_line":"    # Version 2.1: Added \u0027status_message\u0027 object field"},{"line_number":44,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c5de9bd3_989e53dc","line":44,"in_reply_to":"5ecdce68_03f47aae","updated":"2025-08-19 11:18:46.000000000","message":"probably because it is a breaking change, by removing a field from previous version. If it was just adding a new one, it could bump the minor value only.","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"906ed82150d473aa4ba15f937ce4e61602691157","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # Version 1.1: Added \u0027action_plan\u0027 object field"},{"line_number":42,"context_line":"    # Version 2.0: Removed \u0027next\u0027 object field, Added \u0027parents\u0027 object field"},{"line_number":43,"context_line":"    # Version 2.1: Added \u0027status_message\u0027 object field"},{"line_number":44,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    dbapi \u003d db_api.get_instance()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2c17cc1d_e6746b0a","line":44,"in_reply_to":"c5de9bd3_989e53dc","updated":"2025-08-20 08:17:41.000000000","message":"I assume we follow semantic versioning standard https://semver.org/ . As Doug mentioned, removing a field is a breaking change.","commit_id":"685d32fe0d044ec88eb60f6321f940d1e1ac32ea"}]}
