)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"31d26b1e478d46cac0d14e21f4084173a9ba704f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b629b3c0_c413ffa9","updated":"2025-09-01 11:36:22.000000000","message":"Thanks, this looks good to me.\naetos job shuould get fixed by [1], then we can recheck again\n\n[1] https://review.opendev.org/c/openstack/watcher/+/958760","commit_id":"a4b785e4f1d5b1766e31c03355319e89a372f04a"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a55b6ae5e7d0956d593a770e1723041ad371c7ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f8c6ce0_ce57116d","updated":"2025-09-01 12:11:28.000000000","message":"recheck\n\n\naetos fix merged: Update aetos fake data job to disable real metrics  https://review.opendev.org/c/openstack/watcher/+/958760","commit_id":"a4b785e4f1d5b1766e31c03355319e89a372f04a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b976a3a5550d439707d57dc81671f584fd9bd90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"867f2cac_b8ebbbae","updated":"2025-09-01 12:54:00.000000000","message":"recheck https://review.opendev.org/c/openstack/watcher/+/958760 is now merged","commit_id":"a4b785e4f1d5b1766e31c03355319e89a372f04a"}],"doc/source/configuration/configuring.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e8f04e6dba60dbc2e554f2c35a2c08cd75f3d25","unresolved":true,"context_lines":[{"line_number":431,"context_line":"order to build or update, in real time, its cluster data model related to"},{"line_number":432,"context_line":"storage resources. To do so, you have to update the Cinder configuration"},{"line_number":433,"context_line":"file on controller and volume nodes, in order to let Watcher receive Cinder"},{"line_number":434,"context_line":"notifications in a dedicated ``watcher_notifications`` channel."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"  * In the file ``/etc/cinder/cinder.conf``, update the section"},{"line_number":437,"context_line":"    ``[oslo_messaging_notifications]``, by redefining the list of topics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"24f92046_2f44dbbb","line":434,"updated":"2025-08-22 14:16:13.000000000","message":"why are we documenting this.\n\nyou can do this but that is not how notificatons are generally used.\n\nnormally we have all notifcaiotn use the same topic for all services.","commit_id":"9ed1fdb5b4794e6009456a163a5a314b8b88a644"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"900cf90dd4f4a0493c9c498713c46fd332f2d285","unresolved":true,"context_lines":[{"line_number":431,"context_line":"order to build or update, in real time, its cluster data model related to"},{"line_number":432,"context_line":"storage resources. To do so, you have to update the Cinder configuration"},{"line_number":433,"context_line":"file on controller and volume nodes, in order to let Watcher receive Cinder"},{"line_number":434,"context_line":"notifications in a dedicated ``watcher_notifications`` channel."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"  * In the file ``/etc/cinder/cinder.conf``, update the section"},{"line_number":437,"context_line":"    ``[oslo_messaging_notifications]``, by redefining the list of topics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7c42bc1a_06447507","line":434,"in_reply_to":"1eec6c98_b5b7f56c","updated":"2025-08-25 12:29:10.000000000","message":"@smooney@redhat.com thanks for taking the time to explain this! You\u0027re right, in my devstack environment I removed the cinder conf that is currently in the documentation and configured watcher to listen to `openstack.notifications` and it works. I\u0027ll create a docs bug and update the patch accordingly","commit_id":"9ed1fdb5b4794e6009456a163a5a314b8b88a644"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6101e500d8d68147f5f4546b764a59051c901a73","unresolved":true,"context_lines":[{"line_number":431,"context_line":"order to build or update, in real time, its cluster data model related to"},{"line_number":432,"context_line":"storage resources. To do so, you have to update the Cinder configuration"},{"line_number":433,"context_line":"file on controller and volume nodes, in order to let Watcher receive Cinder"},{"line_number":434,"context_line":"notifications in a dedicated ``watcher_notifications`` channel."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"  * In the file ``/etc/cinder/cinder.conf``, update the section"},{"line_number":437,"context_line":"    ``[oslo_messaging_notifications]``, by redefining the list of topics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b80647b7_50d99b41","line":434,"in_reply_to":"24f92046_2f44dbbb","updated":"2025-08-25 06:41:16.000000000","message":"not sure, tbh, I need to dig more into how notifications work in openstack. I tried what was documented in devstack and did not work. I guess because watcher by default listens to `watcher.watcher_notifications` (https://docs.openstack.org/watcher/latest/configuration/watcher.html#watcher_decision_engine.notification_topics) so I opened this patch with the discovery to not forget about it","commit_id":"9ed1fdb5b4794e6009456a163a5a314b8b88a644"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"5294800f182155feead69a4e89db2c3b55b5de47","unresolved":false,"context_lines":[{"line_number":431,"context_line":"order to build or update, in real time, its cluster data model related to"},{"line_number":432,"context_line":"storage resources. To do so, you have to update the Cinder configuration"},{"line_number":433,"context_line":"file on controller and volume nodes, in order to let Watcher receive Cinder"},{"line_number":434,"context_line":"notifications in a dedicated ``watcher_notifications`` channel."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"  * In the file ``/etc/cinder/cinder.conf``, update the section"},{"line_number":437,"context_line":"    ``[oslo_messaging_notifications]``, by redefining the list of topics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dceca232_644725d7","line":434,"in_reply_to":"7c42bc1a_06447507","updated":"2025-09-01 09:27:59.000000000","message":"Done","commit_id":"9ed1fdb5b4794e6009456a163a5a314b8b88a644"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5aee18cf14515c8ab6a7a8d1f8d0241a959f9f00","unresolved":true,"context_lines":[{"line_number":431,"context_line":"order to build or update, in real time, its cluster data model related to"},{"line_number":432,"context_line":"storage resources. To do so, you have to update the Cinder configuration"},{"line_number":433,"context_line":"file on controller and volume nodes, in order to let Watcher receive Cinder"},{"line_number":434,"context_line":"notifications in a dedicated ``watcher_notifications`` channel."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"  * In the file ``/etc/cinder/cinder.conf``, update the section"},{"line_number":437,"context_line":"    ``[oslo_messaging_notifications]``, by redefining the list of topics"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1eec6c98_b5b7f56c","line":434,"in_reply_to":"b80647b7_50d99b41","updated":"2025-08-25 11:48:31.000000000","message":"i think there may have been some confution in the past \n\n\u0027watcher.watcher_notifications\u0027 woudl be the dedicated topic that wacher woudl send too if not using the the unified \"notifcations\" topic.\n\nwatcher shoudl not listen to its own notifications and we do not expect other service to be confirued to explcitly send notifcaton too watcher we expect them to use the standard queue\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#notifications.versioned_notifications_topics\n\nit looks like watcher has deciend not to follow the convention of declaring the exchange seperate form the topic \nhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.control_exchange\n\nwhich is why it nova.versioned_notifications and \u0027watcher.watcher_notifications\u0027\n\nthe part before the . is the exchange\n\n\nthe code you are modifying below it diffenet then teh decision enging.\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#oslo_messaging_notifications.topics\n\nit the topic to send notificaiotn too\n\nby default it shoudl jsut be notifications.\n\nnova has the option to send noticiation and versioned_notifications to two diffent topics. versioned notifications are OVOs where as legacy notifications are unversioned json.\n\nthe generic oslo code dose not accept the exchange in the topic as far as i am aware.\n\nthis doc shoudl not eb telling tyou to modify the cidner config.\n\nit should be tellign you to modify the https://docs.openstack.org/watcher/latest/configuration/watcher.html#watcher_decision_engine.notification_topics\n\nto be \n\n```\n    [\u0027nova.versioned_notifications\u0027, \u0027openstack.notifications\u0027]\n    \n```\n\nhttps://github.com/openstack-k8s-operators/cinder-operator/blob/08df4f0d0fb5a2260b3622a08aa33f6e27ff769b/templates/cinder/config/00-global-defaults.conf#L29\n\n\nhttps://docs.openstack.org/cinder/latest/configuration/block-storage/samples/cinder.conf.html\n\nfor some reason cinder default to openstack as its exchange name.\n\nwhich is not terrible its also what neutron uses\n\nhttps://docs.openstack.org/neutron/latest/configuration/neutron.html#DEFAULT.control_exchange\n\nbut the reason nova uses its own exchange is two service cannot have the same topic excluding \"notification\" which is special without potentially breaking things\n\nexchanges are a way to namespace topics without requireing seperate vhost or rabbit clusters.\n\nfor example ironic also has conductors as might ocativai? not sure about that one\n\nboth ironic and nova have a conductor topic and you cannot propelry run them on the same exchange without poticial problems.\nironic took the openstack namespace https://docs.openstack.org/ironic/latest/configuration/config.html#DEFAULT.control_exchange\nso nova has to continue to run in its own exchange.\n\n\nif we just updated  watcher_decision_engine.notification_topics to\n [\u0027nova.versioned_notifications\u0027, \u0027openstack.notifications\u0027] by default then we wont need to document anything sepcial here and you will not need to modify other service to work with watcher.\n \n so that is the correct thing to do in this change.","commit_id":"9ed1fdb5b4794e6009456a163a5a314b8b88a644"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"e73d32c7dc2f5e2f652fbcb41ff9adfc03275913","unresolved":true,"context_lines":[{"line_number":424,"context_line":"      notification_format \u003d both"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Configure Cinder Notifications"},{"line_number":428,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Watcher can also consume notifications generated by the Cinder services, in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fc98cdce_460ffec3","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":30},"updated":"2025-08-29 19:32:01.000000000","message":"So here you are actually moving to: how we should configure Watcher to listen to Cinder notifications, but originally it was explaining how to configure Cinder (which we may not need to explain, just reference Cinder docs).\nThe issue that I see here is that it diverges from the section above, called \"Configure Nova Notifications\", which explain how we should configure nova. We may need to refactor things here. I would suggest to rename this section.","commit_id":"5482d12d952e96974b2427bd1afdcbcdb5f2d3e3"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"31d26b1e478d46cac0d14e21f4084173a9ba704f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"      notification_format \u003d both"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Configure Cinder Notifications"},{"line_number":428,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Watcher can also consume notifications generated by the Cinder services, in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2ff2cfcc_3e70a5cd","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":30},"in_reply_to":"065d8cb0_9c022de8","updated":"2025-09-01 11:36:22.000000000","message":"Thanks Joan, sorry to make you change again, but since you were touching this file :)","commit_id":"5482d12d952e96974b2427bd1afdcbcdb5f2d3e3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d9b438442c31ba2bfa9ffd9552dff34eef0b2f99","unresolved":false,"context_lines":[{"line_number":424,"context_line":"      notification_format \u003d both"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Configure Cinder Notifications"},{"line_number":428,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Watcher can also consume notifications generated by the Cinder services, in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"87c738d6_5ef45011","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":30},"in_reply_to":"2ff2cfcc_3e70a5cd","updated":"2025-09-01 11:49:05.000000000","message":"that\u0027s a fair comment we generally shoudl not have the nova section in detail either.\n\nthe watcher docs shoudl focus on teh wathcer service and just refence other services for there config.","commit_id":"5482d12d952e96974b2427bd1afdcbcdb5f2d3e3"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"5294800f182155feead69a4e89db2c3b55b5de47","unresolved":true,"context_lines":[{"line_number":424,"context_line":"      notification_format \u003d both"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Configure Cinder Notifications"},{"line_number":428,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Watcher can also consume notifications generated by the Cinder services, in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"065d8cb0_9c022de8","line":427,"range":{"start_line":427,"start_character":0,"end_line":427,"end_character":30},"in_reply_to":"fc98cdce_460ffec3","updated":"2025-09-01 09:27:59.000000000","message":"That\u0027s a good point, I\u0027ve changed the `Configure Cinder Notification` to mirror the Nova one to simply tell the user to ensure the notifications are enabled in Cinder, and moved the Watcher config instructions to a different section, I hope it\u0027s clearer now","commit_id":"5482d12d952e96974b2427bd1afdcbcdb5f2d3e3"}]}