)]}'
{"id":"openstack%2Fwatcher~957774","triplet_id":"openstack%2Fwatcher~stable%2F2024.1~Ic3b6bfd164e272d70fe86d7b182478dd962f8ac0","project":"openstack/watcher","branch":"stable/2024.1","topic":"bug/2112187","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2025-08-19 19:09:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic3b6bfd164e272d70fe86d7b182478dd962f8ac0","subject":"use cinder migrate for swap volume","status":"MERGED","created":"2025-08-18 16:09:48.000000000","updated":"2025-08-19 19:10:31.000000000","submitted":"2025-08-19 19:09:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"957774-bug/2112187","meta_rev_id":"bdea5a013446b8ceee80baa9920cefa4646600b4","_number":957774,"virtual_id_number":957774,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-08-19 19:09:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"all":[{"value":2,"date":"2025-08-18 16:45:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"all":[{"value":1,"date":"2025-08-19 16:32:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-18 16:45:39.000000000","updated_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"reviewer":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"state":"REVIEWER"},{"updated":"2025-08-18 19:37:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7769fc8dcd785e36515a05a94df33d05320ef958","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-08-18 16:09:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d081622977f12bb8a525f893ad87fff9c974aadc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-08-18 16:37:50.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d719f22f249f2427cfa02e5e514e89880f182a82","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-08-18 16:45:39.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"10d1e3355e4ed7c358e3cd952d6ed98949d329c3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-18 19:37:23.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/c0589360fd854bfaaf502920771b7e26\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a7aa82c5a9224fd1a24efedc193265a6 : SUCCESS in 6m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cad9fcc3de8b4a3da80e1e66df2a0bbb : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aaa5a829a8b34935b1b12091c3a61999 : SUCCESS in 2m 28s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/687ee3c4654a48f8b0b28ffd9183dea3 : SUCCESS in 4m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0554f206819c4cbdb0843207966f6ec1 : SUCCESS in 6m 19s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/12e48842241d4974bd2869b250bc673c : SUCCESS in 3m 32s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/b061d2901000413892cd29c9ff5fdf99 : SUCCESS in 13m 11s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/b65dac128cb342478c40d76ef2569fe8 : SUCCESS in 19m 57s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/ffb560b36daa4b658f703306518b0499 : FAILURE in 31m 33s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/c84950b2fbe94c1b9929317b37e627db : SUCCESS in 18m 44s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/667df629c9d44e89b5e532621465ba4f : SUCCESS in 12m 42s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/008720fc05274e9b9931bad83e1d95d0 : SUCCESS in 29m 07s","accounts_in_message":[],"_revision_number":2},{"id":"3c584f9a026807909f891d67f754537d77776206","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-08-19 13:19:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c5ba344545bc0547b9777bd041cdf887ae8c7a02","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-19 14:10:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/19ad5154e1984d7c8f48f977554d8637\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e16d5715a086486aa9f8258ad84f9e76 : SUCCESS in 5m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f9294bfef3b4451db55df2536cc9628c : SUCCESS in 2m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a860ebb8413746078aa5f763025e3b97 : SUCCESS in 5m 42s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/d5c2a7c758e54930b1b1213f7a2c498e : SUCCESS in 3m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/75c361b7236c4343ad8b13d0ecf1bd97 : SUCCESS in 3m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8589c307542a4fb5824604e1c404d4b8 : SUCCESS in 2m 29s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/2cab18427e894ca1b5a48d1aa908eacf : SUCCESS in 12m 53s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/0165c805423e40feb829ad1e73bd806b : SUCCESS in 20m 51s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/9cbf54a758a9492c8b1170affd527e15 : SUCCESS in 20m 00s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/c6a84ed4b4304c70ba7f875c421c8338 : SUCCESS in 19m 04s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/f91c1810e631496ea67265bb661270c9 : SUCCESS in 12m 43s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/9da7b825ff1e4a2d803ec41b0946ef24 : SUCCESS in 13m 22s","accounts_in_message":[],"_revision_number":2},{"id":"212da0d7dba8258417fe2e0b40968e8f40241468","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-08-19 16:32:11.000000000","message":"Patch Set 2: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a43b93e1582dccfec6ec68ef8107ca18bc524ca2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-19 16:32:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9f2c533d204fe55ac4301e6137423ae522beaec4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-19 19:09:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c3e0adc3080a4d1197083cd7ce3c5b9e\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8094be25a6b14f84884047b4b072aae5 : SUCCESS in 3m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cffdc418f2e34e61aba119182a0db69c : SUCCESS in 4m 48s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/a1d0e6b3e50f4ce788b8f5dfd65c7169 : SUCCESS in 2m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/14bc352948b546eca7af52b0ea9790e8 : SUCCESS in 8m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/40d2852abb41438d8423a3e2f248073b : SUCCESS in 5m 06s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/8d1ed0f98c3a4b3c876fb937a05300be : SUCCESS in 20m 07s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/f7579d0147fe4b499e084d3802661d5d : SUCCESS in 28m 37s","accounts_in_message":[],"_revision_number":2},{"id":"093b4b0b1aa26fbcbc982b7210ce73de46b208c9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-19 19:09:34.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"bdea5a013446b8ceee80baa9920cefa4646600b4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-19 19:10:31.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/85bca4b096894df1b391ada146d209f9\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/afc77ed3748647f0a86e3f72ad969db6 : SUCCESS in 42s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/12a7fe01405b409593042fc33f983c6e : SUCCESS in 48s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4fca7d246a64bd80d655c90ab3f68555ab7193e8","revisions":{"cbe542409b443d0c85d2e6cb362e42b36ff1da7c":{"kind":"REWORK","_number":1,"created":"2025-08-18 16:09:48.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/74/957774/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/74/957774/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/74/957774/1"}}},"commit":{"parents":[{"commit":"64ba589f809595d3563dd8874c9ea7c283c553f1","subject":"Further database refactoring","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/64ba589f809595d3563dd8874c9ea7c283c553f1"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-06-10 19:13:49.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-08-18 16:09:47.000000000","tz":60},"subject":"use cinder migrate for swap volume","message":"use cinder migrate for swap volume\n\nThis change removes watchers in tree functionality\nfor swaping instance volumes and defines swap as an alias\nof cinder volume migrate.\n\nThe watcher native implemetion was missng error handeling\nwhich could lead to irrirtivable data loss.\n\nThe removed code also forged project user credentils to\nperform admin request as if it was done by a member of a porject.\nthis was unsafe an posses a security risk due to how it was\nimplemnted. This code has been removed without replacement.\n\nWhile some effort has been made to allow existing\naudits that were defiend to work, any redcution of functionaltiy\nas a result of this security hardening is intentional.\n\nCloses-Bug: #2112187\nChange-Id: Ic3b6bfd164e272d70fe86d7b182478dd962f8ac0\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n(cherry picked from commit 5479b5b2a367cb2d7953365f281aebbb9feeb5f6)\n(cherry picked from commit 78b689151e8eee4ffaf673abcfd95c673d4c03ed)\n(cherry picked from commit 5ba7871099fd11bb812fe0786075c6398b4aaecc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/cbe542409b443d0c85d2e6cb362e42b36ff1da7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/cbe542409b443d0c85d2e6cb362e42b36ff1da7c"}]},"branch":"refs/heads/stable/2024.1"},"4fca7d246a64bd80d655c90ab3f68555ab7193e8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-18 16:37:50.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/74/957774/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/74/957774/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/957774/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/74/957774/2"}}},"commit":{"parents":[{"commit":"64ba589f809595d3563dd8874c9ea7c283c553f1","subject":"Further database refactoring","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/64ba589f809595d3563dd8874c9ea7c283c553f1"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-06-10 19:13:49.000000000","tz":60},"committer":{"name":"sean mooney","email":"work@seanmooney.info","date":"2025-08-18 16:37:50.000000000","tz":0},"subject":"use cinder migrate for swap volume","message":"use cinder migrate for swap volume\n\nThis change removes watchers in tree functionality\nfor swapping instance volumes and defines swap as an alias\nof cinder volume migrate.\n\nThe watcher native implementation was missing error handling\nwhich could lead to irretrievable data loss.\n\nThe removed code also forged project user credentials to\nperform admin request as if it was done by a member of a project.\nthis was unsafe an posses a security risk due to how it was\nimplemented. This code has been removed without replacement.\n\nWhile some effort has been made to allow existing\naudits that were defined to work, any reduction of functionality\nas a result of this security hardening is intentional.\n\nCloses-Bug: #2112187\nChange-Id: Ic3b6bfd164e272d70fe86d7b182478dd962f8ac0\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n(cherry picked from commit 3742e0a79cfcbd039cd396132a4188f376fcfeca)\n(cherry picked from commit ffec800f591bb56b4d718ed3a471c56b29edb187)\n(cherry picked from commit c049a533e342fc57e5b07eefcead1979e2ded926)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4fca7d246a64bd80d655c90ab3f68555ab7193e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4fca7d246a64bd80d655c90ab3f68555ab7193e8"}]},"branch":"refs/heads/stable/2024.1","description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}