)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2efe3c530f89bad14f5d90d25fdb97bdb3136747","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c070143d_c566ab40","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"updated":"2025-08-27 11:35:34.000000000","message":"sorry I\u0027ve lost this one, can you link it here?","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a9f3cf6977437e312f2f6eb9c712282e379a8d17","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c8ae1aab_7ea7bde9","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"34bc58ae_6225c947","updated":"2025-08-27 11:57:07.000000000","message":"no that was definitely merged train or before.","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e1210d40784566ade80cab4c24ebb419bc576353","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6ac61431_7967c810","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"44be25ad_0e5f8faa","updated":"2025-08-27 14:23:18.000000000","message":"Done","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6fca590880e4fdee25c7f7811f684f86e1683ae","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"34bc58ae_6225c947","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"c070143d_c566ab40","updated":"2025-08-27 11:41:18.000000000","message":"See https://review.opendev.org/c/openstack/watcher/+/661976 . This was merged during this cycle so the [watcher_datasources] query_timeout option is not available in any existing releases. (I kept the fallback to [gnocchi] query_timeout )","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"540f67e87ebfb112816470eafb56bba9a5714f17","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"333bda0c_1f55d0f5","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"c070143d_c566ab40","updated":"2025-08-27 11:40:18.000000000","message":"This option was added in 2019: https://github.com/openstack/watcher/commit/584eeefdc8311fc703e1b18877ec4723ca8dcb6d#diff-18d6cccba60becbe45743dc5f13bd128f9a7422ed24566c9729e93d065f15130R44","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"37753be1ef9c6c4cc8760f0050ffb26f32678195","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These do not actually define timeout but interval. Rename the options"},{"line_number":10,"context_line":"to reflect what they actually define."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The [watcher_datasources] query_timeout option is directly renamed,"},{"line_number":13,"context_line":"because this name was added during this cycle."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also fix inconsistent name (query vs call)."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"44be25ad_0e5f8faa","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":46},"in_reply_to":"c8ae1aab_7ea7bde9","updated":"2025-08-27 12:41:35.000000000","message":"Ohhh, wait. I was probably confused by a different change. Let me fix it.","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c597345c7a0cdf08fe51eed9e801a39e5734409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b93d250f_914e087c","updated":"2025-08-26 08:42:29.000000000","message":"recheck","commit_id":"854ca23085037a43f8b68e237c82fd665e062bdd"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6f94bd30ae54ee7afd8c0603777896334d9489a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b9ca558a_2aa53795","updated":"2025-08-26 15:56:33.000000000","message":"AFAIK the deprecation looks correct, using the oslo.config depcration options[1]. I have a comment about the release notes. If we should updated from them the deprecated options, we\u0027re missing some references to `api_call_retries` and `api_query_timeout` in [2].\n\n[1] https://docs.openstack.org/oslo.config/latest/reference/deprecating.html\n[2] https://github.com/openstack/watcher/blob/master/releasenotes/notes/api-call-retry-fef741ac684c58dd.yaml","commit_id":"bdd9e852d0496ac4919b8bc700f3d449535c570b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"427f2d29333a768620aeabbe44c06fb3bfb42439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"90cc62a1_ac26d394","updated":"2025-08-27 11:41:02.000000000","message":"-1: to raise the question about the query_timeout option","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4562164faa187b0ecfc691b65b0a50a1f140685","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ced6d6f_998e44f2","updated":"2025-08-26 20:06:39.000000000","message":"i agree with this change\nyou correctly deprecated teh old value and supproted them on upgrade\n\nalso agree with directly updating the newly intoduced value since we have not done a release yet with that although we were very close to one :)","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"546f89e33e659d1af4389ebd3edf37ab9dfa5260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9b1454d3_44550b8b","updated":"2025-08-27 05:22:33.000000000","message":"thanks for the changes, lgtm","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2efe3c530f89bad14f5d90d25fdb97bdb3136747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9675c73d_220a64e9","updated":"2025-08-27 11:35:34.000000000","message":"the rename looks ok, not sure if I am missing something about the direct rename","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"45b97061cc57fd1941bb254bc0802c303a97663b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f0102d26_50298249","updated":"2025-08-27 19:21:58.000000000","message":"LGTM, thanks Takashi!","commit_id":"7106a12251c1a18d362ff1cc7c59c8774389cda8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c4b3102bcf23c295b9fcbae8f0b12cb3757ff16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b49bfabc_8e2635f5","updated":"2025-08-27 19:47:51.000000000","message":"rechceck test_execute_workload_balance_strategy_ram failed in the ateos job \n\nbut that feels like a flaky test and not related to this change","commit_id":"7106a12251c1a18d362ff1cc7c59c8774389cda8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5365960af4af264c586d49a16afd2ef622cd23dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"29d24e66_562dd124","updated":"2025-08-28 07:14:34.000000000","message":"recheck","commit_id":"7106a12251c1a18d362ff1cc7c59c8774389cda8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e211109497e6247829d2a6569a25e362ddb036b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e8a0f21b_13b37644","updated":"2025-08-27 19:48:03.000000000","message":"recheck","commit_id":"7106a12251c1a18d362ff1cc7c59c8774389cda8"}],"releasenotes/notes/query-interval-not-query-timeout-ecb6f2c6b1a647e9.yaml":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6f94bd30ae54ee7afd8c0603777896334d9489a2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    the ``[collector] api_query_interval`` option."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``[collector] api_call_retries`` option was deprecatedi n favor of"},{"line_number":9,"context_line":"    the ``[collector] api_query_max_retries`` option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"975b3dea_5a670b1c","line":8,"updated":"2025-08-26 15:56:33.000000000","message":"typo\n```suggestion\n    The ``[collector] api_call_retries`` option was deprecated in favor of\n```","commit_id":"bdd9e852d0496ac4919b8bc700f3d449535c570b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"baf54eee61346a2f44d15638c0bff830e311b5e8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the ``[collector] api_query_interval`` option."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``[collector] api_call_retries`` option was deprecatedi n favor of"},{"line_number":9,"context_line":"    the ``[collector] api_query_max_retries`` option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"84eb4715_7fdf9f75","line":8,"in_reply_to":"975b3dea_5a670b1c","updated":"2025-08-26 16:01:20.000000000","message":"Done","commit_id":"bdd9e852d0496ac4919b8bc700f3d449535c570b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"45b97061cc57fd1941bb254bc0802c303a97663b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    The following deprecated options were removed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - ``[gnocchi_client] query_timeout`` (Use"},{"line_number":19,"context_line":"      ``[watcher_datsources] query_interval``)"},{"line_number":20,"context_line":"    - ``[gnocchi_client] query_max_retries`` (Use"},{"line_number":21,"context_line":"      ``[watcher_datasources] query_max_retires``)"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ec261b44_9fcc2830","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":50},"updated":"2025-08-27 19:21:58.000000000","message":"+1","commit_id":"7106a12251c1a18d362ff1cc7c59c8774389cda8"}],"watcher/conf/datasources.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a9f3cf6977437e312f2f6eb9c712282e379a8d17","unresolved":true,"context_lines":[{"line_number":53,"context_line":"               default\u003d1,"},{"line_number":54,"context_line":"               mutable\u003dTrue,"},{"line_number":55,"context_line":"               help\u003d\u0027How many seconds Watcher should wait to do query again\u0027,"},{"line_number":56,"context_line":"               deprecated_group\u003d\"gnocchi_client\","},{"line_number":57,"context_line":"               deprecated_name\u003d\"query_timeout\")"},{"line_number":58,"context_line":"    ]"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fe8a0695_88f4c0fa","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":47},"updated":"2025-08-27 11:57:07.000000000","message":"we shoudl change this to datasources.","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e1210d40784566ade80cab4c24ebb419bc576353","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               default\u003d1,"},{"line_number":54,"context_line":"               mutable\u003dTrue,"},{"line_number":55,"context_line":"               help\u003d\u0027How many seconds Watcher should wait to do query again\u0027,"},{"line_number":56,"context_line":"               deprecated_group\u003d\"gnocchi_client\","},{"line_number":57,"context_line":"               deprecated_name\u003d\"query_timeout\")"},{"line_number":58,"context_line":"    ]"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9cb5a767_621e972c","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":47},"in_reply_to":"fe8a0695_88f4c0fa","updated":"2025-08-27 14:23:18.000000000","message":"Done","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"}],"watcher/decision_engine/datasources/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4562164faa187b0ecfc691b65b0a50a1f140685","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                self.query_retry_reset(e)"},{"line_number":94,"context_line":"                LOG.warning(\"Retry %d of %d while retrieving metrics retry \""},{"line_number":95,"context_line":"                            \"in %d seconds\", i+1, num_retries, interval)"},{"line_number":96,"context_line":"                time.sleep(interval)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @abc.abstractmethod"},{"line_number":99,"context_line":"    def query_retry_reset(self, exception_instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f32deaae_675027a3","line":96,"updated":"2025-08-26 20:06:39.000000000","message":"so this is proably wehre the timeout name came form\n\nform the sleep paramter name.","commit_id":"923f89f85ffd0bdc4aa46582a71f5621a5f64f71"}]}