)]}'
{"id":"openstack%2Fwatcher~959174","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~I76e91ed99e7a814a43a6dd906b6bcc150d471624","project":"openstack/watcher","branch":"stable/2025.1","attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2025-10-07 15:34:13.000000000","reason":"\u003cGERRIT_ACCOUNT_16312\u003e replied on the change","reason_account":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I76e91ed99e7a814a43a6dd906b6bcc150d471624","subject":"Check result of retype action based on type and status","status":"NEW","created":"2025-09-02 13:02:24.000000000","updated":"2026-04-28 10:15:33.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"61ab84542e361c99375d0103adb115ea23340c2d","_number":959174,"virtual_id_number":959174,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"tag":"autogenerated:zuul:check","value":1,"date":"2025-09-02 14:28:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"all":[{"value":2,"date":"2026-04-28 10:15:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-02 13:02:24.000000000","updated_by":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"CC"},{"updated":"2025-09-02 14:28:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-10-07 15:34:13.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"}],"messages":[{"id":"61f446c5f22bb1fbb600b5ce1afe3775f6292db4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2025-09-02 13:02:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff2c7666d1bfab676ecb0359aa8090562526c437","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-02 14:28:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/65644b6a51ea4777aba7613555d89bb1\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bd406c8c7c6c4a83be179e875b26a979 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e03b13592b1140cabc328a1923734101 : SUCCESS in 2m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/80faa51fea9f4d3c88d923e3f17b9f47 : SUCCESS in 4m 41s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/aadd6518bf5f43e2b5666293dd6e4427 : SUCCESS in 4m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0d773878612b423aab5f1adf01384eb2 : SUCCESS in 8m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2b2f9f19fd554d57b3d5268f7e5a7bad : SUCCESS in 4m 08s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/4e251d67b64a4056937199ec9c57ecf9 : SUCCESS in 31m 34s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/83cac39291dc4eaa815ee21443e67757 : SUCCESS in 27m 38s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/16b82f97965e481bbaab665d1b8fbaed : SUCCESS in 44m 12s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/0e1b3723008d41d9888e0bb1f48425f3 : SUCCESS in 27m 51s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/05d28d387b334e49b737742b4ee6a5e4 : SUCCESS in 49m 36s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/98ab5e9d204d47acbba170dac4b5fb18 : SUCCESS in 34m 34s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/4fbe096c3e6045d9b71327e616b1c4fd : SUCCESS in 16m 58s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/9cdec6dcb48d48ad9f2c8265275d91ca : SUCCESS in 1h 06m 17s","accounts_in_message":[],"_revision_number":1},{"id":"8e49c871ee5ba7cd25be209c4d4ae0f8067e68c8","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2025-10-07 15:34:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"61ab84542e361c99375d0103adb115ea23340c2d","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-28 10:15:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d04a050bded1bddfa82128a02cc76d81c2384e1e","revisions":{"d04a050bded1bddfa82128a02cc76d81c2384e1e":{"kind":"REWORK","_number":1,"created":"2025-09-02 13:02:24.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/74/959174/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/74/959174/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/959174/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/959174/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/74/959174/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/74/959174/1"}}},"commit":{"parents":[{"commit":"024815af711553739b4627cb520f66886060db3f","subject":"Merge \"use cinder migrate for swap volume\" into stable/2025.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/024815af711553739b4627cb520f66886060db3f"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-05-30 11:24:36.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-09-02 13:02:19.000000000","tz":120},"subject":"Check result of retype action based on type and status","message":"Check result of retype action based on type and status\n\nCurrently, when there is a volume_migrate action and migration_type is\n`retype`, watcher assumes that the retype always triggers a migration\nand checks the result of the retype based on the fields related to\nthe migration action (actually, it uses the same function to check the\nresult when `migration_type` is `retype` or `migrate`. This creates\nproblem in different scenarios:\n\n- Actions keep in ONGOING status forever for volumes which have never\n  being migrated as the migration fields of the volume are empty.\n- Actions which were migrated anytime before, still have the old values\n  so it may report the status of te retype actions wrongly.\n\nThis patch is implementing an entirely new function to check the result\nof a retype action based on the final type and the status field of the\nvolume. This should be valid for any kind of retype action, with or\nwithout migration. The criteria for successfull retype is that the type\nfor the volume is the destination one in the action and the status is\navailable or in-use.\n\nCloses-Bug: #2112100\n\nChange-Id: I76e91ed99e7a814a43a6dd906b6bcc150d471624\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 90009aac84934232f81be1ba46607c1c4eb7f6eb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d04a050bded1bddfa82128a02cc76d81c2384e1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d04a050bded1bddfa82128a02cc76d81c2384e1e"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}