)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09d6c1a2ea32ffe2b63b8ac3d1ff211451626141","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note that the basic implementation is borrowed from octavia, which"},{"line_number":21,"context_line":"also uses pecan."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I6b47abe4f08dc257e9156b254fa60005b82898d7"},{"line_number":24,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6baaccf9_19902d4e","line":22,"updated":"2025-09-08 15:51:17.000000000","message":"+1 in general\nwe need to agree if this is to be treated as a backportabel security hardening bug-fix or as feature.\n\nbecause of the secuirty elemnt while not a vulnerbality im more incline to say we shoudl treat it as a hardening bug.","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88a2cdb48835be72431a91dbe740a908b90ca5f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note that the basic implementation is borrowed from octavia, which"},{"line_number":21,"context_line":"also uses pecan."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I6b47abe4f08dc257e9156b254fa60005b82898d7"},{"line_number":24,"context_line":"Signed-off-by: Takashi Kajinami \u003ckajinamit@oss.nttdata.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"95c190c1_634dec4b","line":22,"in_reply_to":"6baaccf9_19902d4e","updated":"2025-09-15 12:57:33.000000000","message":"Done","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09d6c1a2ea32ffe2b63b8ac3d1ff211451626141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"887043f7_2f99aed7","updated":"2025-09-08 15:51:17.000000000","message":"+1 while we wait for ci and dicsuss how to proceed but i agree with the overall direction fo the patch.","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6cc0dd8598c879ef356d76f0ccfa19f5058ad1aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91e18817_41189ea6","updated":"2025-09-08 16:02:55.000000000","message":"I\u0027ve updated the change to focus on CORS middleware. The other middlewares may be added sepatately.","commit_id":"7629ee544593b08c7da6b6946a741308a0744dea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a48ca6b3781cf643c5b4661edbd9f767abdc6ec9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2b5bb03f_cb2c8cb8","updated":"2025-09-09 13:19:45.000000000","message":"recheck","commit_id":"7629ee544593b08c7da6b6946a741308a0744dea"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0aa762c50f3d323c0d9e7f30136c8b1e27958786","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88e4848d_21c4e794","updated":"2025-09-11 13:10:41.000000000","message":"so we are still undecied if we shoudl backport this or not.\n\nwoudl you mind moving the cores supprot to the end and folding the requirement change to the request id patch or put it in its own commit\n\nwe generally agreec that the request id and froward headers supprot shoudl be backproted so we will see how others fell about the cors supprot sepreatly\n\nall 3 are valid for master\n\nim inclidne to backport all tree but want to see what others think.","commit_id":"7629ee544593b08c7da6b6946a741308a0744dea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"443c819dba2bc8dda50946fd56140d66832658d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"47d8eaf4_e0004822","updated":"2025-09-15 15:19:51.000000000","message":"lgtm, thanks for the fix takashi","commit_id":"e1c8961a7c7d2602ee3c28adc60b2d1f2f0a2a94"}],"requirements.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4cc68a1d791f7df4ca40008841ddbe1ee0e38a8a","unresolved":true,"context_lines":[{"line_number":19,"context_line":"oslo.i18n\u003e\u003d3.20.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.log\u003e\u003d3.37.0 # Apache-2.0"},{"line_number":21,"context_line":"oslo.messaging\u003e\u003d14.1.0 # Apache-2.0"},{"line_number":22,"context_line":"oslo.middleware\u003e\u003d4.0.1 # Apache-2.0"},{"line_number":23,"context_line":"oslo.policy\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.reports\u003e\u003d1.27.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.serialization\u003e\u003d2.25.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"dd5b4a5f_f209a7b9","line":22,"updated":"2025-09-08 15:52:40.000000000","message":"this is obviously packaged in rdo but we might need to tweak the rpm spec file to make the content provider job happy.","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6da0d5186c11ec20c72f29571ad5c12276c39177","unresolved":false,"context_lines":[{"line_number":19,"context_line":"oslo.i18n\u003e\u003d3.20.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.log\u003e\u003d3.37.0 # Apache-2.0"},{"line_number":21,"context_line":"oslo.messaging\u003e\u003d14.1.0 # Apache-2.0"},{"line_number":22,"context_line":"oslo.middleware\u003e\u003d4.0.1 # Apache-2.0"},{"line_number":23,"context_line":"oslo.policy\u003e\u003d4.5.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.reports\u003e\u003d1.27.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.serialization\u003e\u003d2.25.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"98094003_0ee96317","line":22,"in_reply_to":"dd5b4a5f_f209a7b9","updated":"2025-09-08 15:59:26.000000000","message":"I\u0027ve adjusted the lower bound according to the one used in a few other projects like ironic.","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"}],"setup.cfg":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88a2cdb48835be72431a91dbe740a908b90ca5f9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    watcher \u003d watcher.conf.opts:list_opts"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":39,"context_line":"    watcher \u003d watcher.common.config:set_lib_defaults"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"oslo.policy.policies \u003d"},{"line_number":42,"context_line":"    watcher \u003d watcher.common.policies:list_rules"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"dc17f50f_66635505","line":39,"updated":"2025-09-15 12:57:33.000000000","message":"ah right this is where its called ok.","commit_id":"e1c8961a7c7d2602ee3c28adc60b2d1f2f0a2a94"}],"watcher/api/app.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09d6c1a2ea32ffe2b63b8ac3d1ff211451626141","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                       \u0027DELETE\u0027,"},{"line_number":85,"context_line":"                       \u0027PATCH\u0027]"},{"line_number":86,"context_line":"    )"},{"line_number":87,"context_line":"    return app"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class VersionSelectorApplication(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"592bfde5_d73b8d49","line":87,"updated":"2025-09-08 15:51:17.000000000","message":"ah i see this is who we hardcore the middleware pipeline","commit_id":"97325d08fa7991ce8bfb574623a00bc3b709981f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9fe7179078efe48c9a7c545cbcc032f4dc25e7ba","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    # middleware - are annotated with CORS headers, and thus accessible"},{"line_number":67,"context_line":"    # by the browser."},{"line_number":68,"context_line":"    app \u003d cors.CORS(app, CONF)"},{"line_number":69,"context_line":"    cors.set_defaults("},{"line_number":70,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":71,"context_line":"                       \u0027X-Identity-Status\u0027,"},{"line_number":72,"context_line":"                       \u0027X-Roles\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"526a26d5_b0ee7f6a","line":69,"updated":"2025-09-11 18:12:15.000000000","message":"can we use set_lib_defaults here?","commit_id":"68cb9bec765278b9e5c32d56b7d16958563d56ea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0137f4b83c1d3c974b6ae0e7e5ad44c66aa7599","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # middleware - are annotated with CORS headers, and thus accessible"},{"line_number":67,"context_line":"    # by the browser."},{"line_number":68,"context_line":"    app \u003d cors.CORS(app, CONF)"},{"line_number":69,"context_line":"    cors.set_defaults("},{"line_number":70,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":71,"context_line":"                       \u0027X-Identity-Status\u0027,"},{"line_number":72,"context_line":"                       \u0027X-Roles\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4bf1c50f_93db82ed","line":69,"in_reply_to":"526a26d5_b0ee7f6a","updated":"2025-09-13 02:49:55.000000000","message":"Done. I also moved this to parse_args in case we want to add override logic for other repos in the future.","commit_id":"68cb9bec765278b9e5c32d56b7d16958563d56ea"}],"watcher/common/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9fe7179078efe48c9a7c545cbcc032f4dc25e7ba","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from watcher import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def set_lib_defaults():"},{"line_number":26,"context_line":"    cors.set_defaults("},{"line_number":27,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":28,"context_line":"                       \u0027X-Identity-Status\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"8b61c5a2_09380dad","line":25,"updated":"2025-09-11 18:12:15.000000000","message":"this is a slightly odd place to put this it snot really config.\n\ni also dont see this called anyhere, did i miss that?","commit_id":"68cb9bec765278b9e5c32d56b7d16958563d56ea"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"526cb434b788ed01cdfd92e32e2ef36f2e3c0f5d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from watcher import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def set_lib_defaults():"},{"line_number":26,"context_line":"    cors.set_defaults("},{"line_number":27,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":28,"context_line":"                       \u0027X-Identity-Status\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"96e3b8e7_3cde519c","line":25,"in_reply_to":"8b61c5a2_09380dad","updated":"2025-09-13 02:47:42.000000000","message":"This is called in https://review.opendev.org/c/openstack/watcher/+/960044/8/setup.cfg#38 to use these overridden default values in generated config files.\nThe same is done in other repos such as nova.","commit_id":"68cb9bec765278b9e5c32d56b7d16958563d56ea"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"88a2cdb48835be72431a91dbe740a908b90ca5f9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from watcher import version"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def set_lib_defaults():"},{"line_number":26,"context_line":"    cors.set_defaults("},{"line_number":27,"context_line":"        allow_headers\u003d[\u0027X-Auth-Token\u0027,"},{"line_number":28,"context_line":"                       \u0027X-Identity-Status\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4823d959_e97383fe","line":25,"in_reply_to":"96e3b8e7_3cde519c","updated":"2025-09-15 12:57:33.000000000","message":"ack, this is also a better place to store this +1","commit_id":"68cb9bec765278b9e5c32d56b7d16958563d56ea"}]}