)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"819e788a0ab292ccec28b44398bb11e44c19dc00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a41dbe53_08686e25","updated":"2025-09-11 13:52:41.000000000","message":"+1 but woudl you mind adding a unit test just to assert the request id header is present in the responce of any of the api respocnes.\n\nwhich one does nto matter.\n\nyou coudl also assert the middleware si applied as an alternitive but i think checking the response is more useful.","commit_id":"cdc2078542c209e73d189bd835d933bb53f2b149"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f61b35514a0d377b61af859c4ec96610db60ce45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27a544ec_8280ba31","in_reply_to":"a41dbe53_08686e25","updated":"2025-09-11 15:50:00.000000000","message":"Done. I\u0027ve added a unit test case to ensure presence of the header.","commit_id":"cdc2078542c209e73d189bd835d933bb53f2b149"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"98a8ee2e4b75a72a2392c4725b61b76bb0f0bf28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"385ce26b_c502200b","updated":"2025-09-11 15:18:56.000000000","message":"I\u0027ve fixed one wrong modification during re-ordering. Still looking into the way to add unit tests assertion.","commit_id":"71749508ca1b3f215a35e284e583b43a0900450b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"23cde9fefe7550450c2aba009b26091dcaea20f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"95e90d08_3c4ff2bf","updated":"2025-09-15 15:07:37.000000000","message":"lgtm","commit_id":"a562880b1cfe30b22ecdb41086428864b0f137f6"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2e276063650fba738c184e213a29ab4573bfc4bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"831845ec_fc66d3ca","updated":"2025-09-15 14:54:28.000000000","message":"lgtm, we can see in the tempest logs that the request header is returned:\n\n```\n2025-09-11 16:36:30.565 101678 DEBUG tempest.lib.common.rest_client [req-69889b26-58b7-44db-986f-76ed0a23a0b1 req-69889b26-58b7-44db-986f-76ed0a23a0b1 ] Request - Headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Accept\u0027: \u0027application/json\u0027, \u0027OpenStack-API-Version\u0027: \u0027infra-optim 1.3\u0027, \u0027X-Auth-Token\u0027: \u0027\u003comitted\u003e\u0027}\n        Body: None\n    Response - Headers: {\u0027date\u0027: \u0027Thu, 11 Sep 2025 16:36:28 GMT\u0027, \u0027server\u0027: \u0027Apache/2.4.58 (Ubuntu)\u0027, \u0027vary\u0027: \u0027OpenStack-API-Version\u0027,\n openstack-api-minimum-version\u0027: \u00271.0\u0027, \u0027openstack-api-maximum-version\u0027: \u00271.6\u0027, \u0027openstack-api-version\u0027: \u0027infra-optim 1.3\u0027, \u0027content-length\u0027: \u00271487\u0027, \u0027content-type\u0027: \u0027application/json\u0027,\n\u0027x-openstack-request-id\u0027: \u0027req-69889b26-58b7-44db-986f-76ed0a23a0b1\u0027, \u0027connection\u0027: \u0027close\u0027, \u0027status\u0027: \u0027200\u0027, \u0027content-location\u0027: \u0027https://10.209.128.55/infra-optim/v1/data_model?data_model_type\u003dcompute\u0027}\n```\n\nfrom https://50fba02399ceb50f60dc-e0eb26721fa5b6241fb190007d5273a9.ssl.cf2.rackcdn.com/openstack/af07ac1b54bf46ea847724175ff50d35/controller/logs/tempest_log.txt","commit_id":"a562880b1cfe30b22ecdb41086428864b0f137f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d95eb817866ac6b762fe6bd0a2c95556cd93396c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dbf5212f_daf054e2","in_reply_to":"831845ec_fc66d3ca","updated":"2025-09-15 14:59:24.000000000","message":"ah very good yes we can.","commit_id":"a562880b1cfe30b22ecdb41086428864b0f137f6"}],"watcher/tests/api/test_root.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"348e260cc29e9707de76b79143eda1e810b41f16","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    # it only at the root path."},{"line_number":29,"context_line":"    def test_request_id(self):"},{"line_number":30,"context_line":"        resp \u003d self.get_json(\u0027/\u0027, path_prefix\u003d\u0027\u0027, return_json\u003dFalse)"},{"line_number":31,"context_line":"        self.assertIn(\u0027X-OpenStack-Request-Id\u0027, resp.headers)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestV1Root(base.FunctionalTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d849a882_1c4f6951","line":31,"updated":"2025-09-11 17:24:16.000000000","message":"+1","commit_id":"a562880b1cfe30b22ecdb41086428864b0f137f6"}]}
