)]}'
{"id":"openstack%2Fwatcher~961448","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~Ie1894311b0e384ab52b1b3dfe0eb50618eef6c9f","project":"openstack/watcher","branch":"stable/2025.1","hashtags":[],"change_id":"Ie1894311b0e384ab52b1b3dfe0eb50618eef6c9f","subject":"Improve unit tests for zone migration strategy","status":"NEW","created":"2025-09-17 08:00:14.000000000","updated":"2026-03-11 08:26:20.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2590525f115914b2e70854adffdb94813cb8799c","_number":961448,"virtual_id_number":961448,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-11 08:26:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-17 08:58:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"02958b22c10d8c9d20b3842515e5bde0563ee8a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2025-09-17 08:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"414bd094258a8d3853575ccc6654e22feb1972f4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-17 08:58:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/293fbb03011f44ad976bf6ab29f2cc29\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c309cf56cc5748388bb14cda5d6aa9ed : SUCCESS in 5m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e4a1ec190bc14af499617cc88387b674 : SUCCESS in 3m 41s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ef1d1b4e32fa4fae926b07883c29856c : SUCCESS in 6m 02s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/beca15a31dce474287576efb2219ca5a : SUCCESS in 5m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80086de8b852484e97636be62b5b2117 : SUCCESS in 8m 30s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/254396d6521b43bc9e252a3cadbd324a : SUCCESS in 27m 41s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/40df86b8a48340fda94fd00b4cf738a7 : SUCCESS in 27m 34s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/7572f156023e4f2e92807ba9da123d1d : SUCCESS in 44m 40s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/4a16938645f54b3b917da77c25c11bdc : SUCCESS in 42m 32s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/c6cdf0ec7ad14ca5ad2e1d43490e7448 : SUCCESS in 25m 40s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/91a9840c955e480fa3782c33bd33ad1a : SUCCESS in 26m 00s","accounts_in_message":[],"_revision_number":1},{"id":"113a226bee6781436ca7a842fc57ecf34239d6dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-01-20 15:11:15.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"b05d8162fb521b6f938ee552e3805a20a666bf41","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-20 15:32:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f427a6ee020f4743a74ee842cce90624\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bdfaa0c40df5467d84d42319fa83b6d2 : SUCCESS in 4m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/094befb14c414475a5fe15159ab4cbff : SUCCESS in 6m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1e5314745ad04a48a25aad137611fa3e : SUCCESS in 4m 48s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4a59d349624142bfb96f6b194c1b3d52 : SUCCESS in 3m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a09ace14f89a489d9db3c9dbd2cecd1d : SUCCESS in 10m 44s","accounts_in_message":[],"_revision_number":2},{"id":"1a4a72e327e00da19e6d3f051c0c789591226c1c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-11 08:12:00.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"2590525f115914b2e70854adffdb94813cb8799c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-11 08:26:20.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e2f9b80177194fa0bf6d0015b6b449b6\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f4d3f38592824851a35e55004af101fa : SUCCESS in 5m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/881a9ba909cd4f44b1c43ea94700c19a : SUCCESS in 4m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/588034a552d340598059d924e7671b8a : SUCCESS in 5m 22s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c9f101726b79425d8f58bbea367cf48e : SUCCESS in 5m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aeb0007924a848d49358648559b6fe80 : SUCCESS in 7m 44s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0cd6d2b294d7fab88f0f07901be2baf6593e26fa","revisions":{"382c77ee30c861c3f981f11c62f982b3ffb8fa4a":{"kind":"REWORK","_number":1,"created":"2025-09-17 08:00:14.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/48/961448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/48/961448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/48/961448/1"}}},"commit":{"parents":[{"commit":"24240c7bb4f7a440f27f7ae109b84588b52b0da0","subject":"Support zone migration audit without compute_nodes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/24240c7bb4f7a440f27f7ae109b84588b52b0da0"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-07-08 14:59:25.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-09-17 08:00:02.000000000","tz":120},"subject":"Improve unit tests for zone migration strategy","message":"Improve unit tests for zone migration strategy\n\nThe unit tests were mocking part of the Zone Migration strategy class,\nwhich could hide possible bugs. This patch removes this mocking, leaving\nmocked only other classes that are used by the zone migration one.\n\nAdditionally, it includes improved suggestions as follow-up from the\nreview of previous patches, like more explicit comments and additional\nasserts of mocked functions.\n\nAssisted-By: Cursor (Claude-4-sonnet)\nChange-Id: Ie1894311b0e384ab52b1b3dfe0eb50618eef6c9f\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 821147547816888bf8e63ab8c03635792a0f564f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/382c77ee30c861c3f981f11c62f982b3ffb8fa4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/382c77ee30c861c3f981f11c62f982b3ffb8fa4a"}]},"branch":"refs/heads/stable/2025.1"},"11edb368147a00218643fbcf1b0cf086052ff8ca":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-01-20 15:11:15.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/48/961448/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/48/961448/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/48/961448/2"}}},"commit":{"parents":[{"commit":"8b6adeb0c491fa005a9df7cbcfaaecaf89348456","subject":"Support zone migration audit without compute_nodes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/8b6adeb0c491fa005a9df7cbcfaaecaf89348456"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-07-08 14:59:25.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-01-20 15:10:40.000000000","tz":60},"subject":"Improve unit tests for zone migration strategy","message":"Improve unit tests for zone migration strategy\n\nThe unit tests were mocking part of the Zone Migration strategy class,\nwhich could hide possible bugs. This patch removes this mocking, leaving\nmocked only other classes that are used by the zone migration one.\n\nAdditionally, it includes improved suggestions as follow-up from the\nreview of previous patches, like more explicit comments and additional\nasserts of mocked functions.\n\nAssisted-By: Cursor (Claude-4-sonnet)\nChange-Id: Ie1894311b0e384ab52b1b3dfe0eb50618eef6c9f\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 821147547816888bf8e63ab8c03635792a0f564f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/11edb368147a00218643fbcf1b0cf086052ff8ca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/11edb368147a00218643fbcf1b0cf086052ff8ca"}]},"branch":"refs/heads/stable/2025.1"},"0cd6d2b294d7fab88f0f07901be2baf6593e26fa":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-11 08:12:00.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/48/961448/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/48/961448/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/961448/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/48/961448/3"}}},"commit":{"parents":[{"commit":"e1cab89daa4d7e5def8c73373b84306f3d6a45b3","subject":"Support zone migration audit without compute_nodes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e1cab89daa4d7e5def8c73373b84306f3d6a45b3"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-07-08 14:59:25.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-11 08:11:51.000000000","tz":60},"subject":"Improve unit tests for zone migration strategy","message":"Improve unit tests for zone migration strategy\n\nThe unit tests were mocking part of the Zone Migration strategy class,\nwhich could hide possible bugs. This patch removes this mocking, leaving\nmocked only other classes that are used by the zone migration one.\n\nAdditionally, it includes improved suggestions as follow-up from the\nreview of previous patches, like more explicit comments and additional\nasserts of mocked functions.\n\nAssisted-By: Cursor (Claude-4-sonnet)\nChange-Id: Ie1894311b0e384ab52b1b3dfe0eb50618eef6c9f\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 821147547816888bf8e63ab8c03635792a0f564f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0cd6d2b294d7fab88f0f07901be2baf6593e26fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0cd6d2b294d7fab88f0f07901be2baf6593e26fa"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}