)]}'
{"id":"openstack%2Fwatcher~961457","triplet_id":"openstack%2Fwatcher~stable%2F2024.2~Ief7386ab448c2711d0d8a94a77fa9ba189c8b7d2","project":"openstack/watcher","branch":"stable/2024.2","hashtags":[],"change_id":"Ief7386ab448c2711d0d8a94a77fa9ba189c8b7d2","subject":"Allow volume and vm migrations in zone_migration","status":"ABANDONED","created":"2025-09-17 08:22:53.000000000","updated":"2026-04-30 09:34:25.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9cc2cb193b217ef246e736bd81abdd4091e9e42b","_number":961457,"virtual_id_number":961457,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-01-20 16:28:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-17 08:22:53.000000000","updated_by":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"CC"},{"updated":"2025-09-17 10:16:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-30 09:34:25.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"362f2daa6eac7acfce51ebf1e023391b0bc71745","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2025-09-17 08:22:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa72ae3cef84d938a755b5596da89c2a5318c6a9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-17 10:16:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d2de90d57ad048a19e874ad9736eaa62\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/073bded11c884ddda1f39868847a2b56 : SUCCESS in 7m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/36539c4a030f4f5a911261a0550ae88f : SUCCESS in 4m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a64f980e7ac845b3b146a0bd3056201b : SUCCESS in 3m 57s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/0d2dad17b23f4707b28eb39043a788e0 : SUCCESS in 5m 15s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b29cd388effa4fd2a941d3c7789f0d12 : SUCCESS in 5m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2e6c53077954b2ab969590f87e13e31 : SUCCESS in 5m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/20225ad6061b480eb08147d6b4075c6c : SUCCESS in 5m 15s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/8c3db42ee11143d48ecde87a4517ecc2 : SUCCESS in 19m 41s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/2dbc4096a4564206aae43fd42a5f403e : SUCCESS in 34m 21s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/73394dacbb4c431ebca59c3764a1fec0 : SUCCESS in 38m 23s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/d678168564cd49c18318371745dd7fb1 : SUCCESS in 33m 58s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/f7f1ba56af5e4e71b322728edb6c63f0 : SUCCESS in 21m 21s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/0c357ebee82d42a2b01375de42201a53 : SUCCESS in 20m 54s","accounts_in_message":[],"_revision_number":1},{"id":"dc117088a6a653e2c09aed1c1c6fed170e3bcc1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-01-20 15:14:48.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"2ad45607978e5945c92d00781c9b494a18914099","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-20 16:28:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a006120e818b4fcebed03b4b65798759\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2369f741422244fc82342f8183314c4d : SUCCESS in 7m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e7086835510546c2aa17e89b75db053e : SUCCESS in 3m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d7a95091cabc4f02a6ad249ea171dcb4 : SUCCESS in 4m 50s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/97e42f56b6a14befa5947b7d16afa03b : SUCCESS in 4m 43s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/231ea8cf9f06490d8a70af0d653a865b : SUCCESS in 5m 35s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/53c0e37b2dd740d6a3035251cf811f72 : SUCCESS in 6m 09s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6b7622d26c8646d0b79151dd934baeb6 : SUCCESS in 4m 53s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/be73908b24f24b64843cfc065e346d12 : SUCCESS in 39m 07s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/be872b0864a84e8e8b08a536daa400e4 : SUCCESS in 1h 06m 56s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/2231dc83ec0c48f1bf44dd5f75d0cc2d : SUCCESS in 37m 09s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/048c55cf9c4f40efa3608c4986bcc258 : SUCCESS in 23m 57s","accounts_in_message":[],"_revision_number":2},{"id":"9cc2cb193b217ef246e736bd81abdd4091e9e42b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2026-04-30 09:34:25.000000000","message":"Abandoned\n\nstable/2024.2 branch of openstack/watcher transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ee2c775018095487c5854e8265b09cd55946a622","revisions":{"c0360b27bd835e2778670817172628546d61d1fb":{"kind":"REWORK","_number":1,"created":"2025-09-17 08:22:53.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/57/961457/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/57/961457/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/57/961457/1"}}},"commit":{"parents":[{"commit":"1e7b75c2c25be633c1b6c47ee884a67bd586b68d","subject":"Add test for zone_migration with instances and volumes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/1e7b75c2c25be633c1b6c47ee884a67bd586b68d"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-06-06 10:47:27.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-09-17 08:22:44.000000000","tz":120},"subject":"Allow volume and vm migrations in zone_migration","message":"Allow volume and vm migrations in zone_migration\n\nCurrently, when an audit with strategy zone_migration has added at least\none volume_migration action, it will not process the instances\nmigrations according to the definition of the `compute_nodes` parameter.\nThis behavior is unexpected according to the documentation of the\nstrategy.\n\nThis patch is fixing that behavior and making sure that not duplicated\nactions are added to the solution, to handle the case where instances\nmigration actions are created when analyzing the volumes if the\n`with_attached_volume` parameter is enabled. The patch is also removing\nthe method `instances_no_attached` which is not longer used.\n\nFinally, it\u0027s adding some unit tests for the new method and fixing the\nones to cover the mixed instances and volumes migration situation.\n\nCloses-Bug: #2109722\nChange-Id: Ief7386ab448c2711d0d8a94a77fa9ba189c8b7d2\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 296856101f7cafe1b687119d9a88101e7c9e1af6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c0360b27bd835e2778670817172628546d61d1fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c0360b27bd835e2778670817172628546d61d1fb"}]},"branch":"refs/heads/stable/2024.2"},"ee2c775018095487c5854e8265b09cd55946a622":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-01-20 15:14:48.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/57/961457/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/57/961457/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/961457/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/57/961457/2"}}},"commit":{"parents":[{"commit":"740023cb8be5427ac4813ae28eda545800733013","subject":"Add test for zone_migration with instances and volumes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/740023cb8be5427ac4813ae28eda545800733013"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-06-06 10:47:27.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-01-20 15:13:33.000000000","tz":60},"subject":"Allow volume and vm migrations in zone_migration","message":"Allow volume and vm migrations in zone_migration\n\nCurrently, when an audit with strategy zone_migration has added at least\none volume_migration action, it will not process the instances\nmigrations according to the definition of the `compute_nodes` parameter.\nThis behavior is unexpected according to the documentation of the\nstrategy.\n\nThis patch is fixing that behavior and making sure that not duplicated\nactions are added to the solution, to handle the case where instances\nmigration actions are created when analyzing the volumes if the\n`with_attached_volume` parameter is enabled. The patch is also removing\nthe method `instances_no_attached` which is not longer used.\n\nFinally, it\u0027s adding some unit tests for the new method and fixing the\nones to cover the mixed instances and volumes migration situation.\n\nCloses-Bug: #2109722\nChange-Id: Ief7386ab448c2711d0d8a94a77fa9ba189c8b7d2\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 296856101f7cafe1b687119d9a88101e7c9e1af6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ee2c775018095487c5854e8265b09cd55946a622"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ee2c775018095487c5854e8265b09cd55946a622"}]},"branch":"refs/heads/stable/2024.2"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}