)]}'
{"id":"openstack%2Fwatcher~962010","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~Icf1e5d4c83862c848d11dae994842ad0ee62ba12","project":"openstack/watcher","branch":"stable/2025.1","topic":"bug/2098984","hashtags":[],"change_id":"Icf1e5d4c83862c848d11dae994842ad0ee62ba12","subject":"Add unit tests for instance and volume not found in model","status":"NEW","created":"2025-09-22 18:56:46.000000000","updated":"2026-03-11 08:30:27.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"026f90e4712a3202b39ae6532a0bc4d5ef2ed5d8","_number":962010,"virtual_id_number":962010,"owner":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-11 08:30:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-22 19:49:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"70c169e904c903becce407c65824d2fe01cf049f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-09-22 18:56:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a9c9733d059f16b75aea13ce43a1479b088905a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-22 19:49:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a84f962215bf45b39f70718fc480ca14\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/abbeb77bffd84a0d9872b7153c64cb1d : SUCCESS in 6m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b2ab614e27f44ac8879ebba6f6bd348f : SUCCESS in 3m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/320a6423afc6410589e02ed111f74a45 : SUCCESS in 4m 13s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b3ead3a6242143febc0a6949e5932395 : SUCCESS in 6m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee2d4408866b476888334a353740778a : SUCCESS in 4m 28s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/fb11010fc393412fb7afc4c5539afaef : SUCCESS in 14m 25s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/1442c908d5da44cfa43423eb99e147c4 : SUCCESS in 31m 00s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/d4276bbf161e4b96ba816c030d2308cb : SUCCESS in 43m 35s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/414407cd9d254f92bf22422ce05d06ad : SUCCESS in 49m 43s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/74151385d93e483091d83af9c01fe2ee : SUCCESS in 14m 16s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/3887168bacf946f5a3b40c44c1db11f0 : SUCCESS in 24m 12s","accounts_in_message":[],"_revision_number":1},{"id":"200a099bdf9937034334370b39983298ecd4e283","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-01-20 15:11:15.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"5631e8d8ab2c83988185b2780661d94bad55b28b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-20 15:24:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d59f39260a034f9a82169991c48410ca\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8479ae46c2914ad2a7a059716bf9a9cd : SUCCESS in 6m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/26b4a47d81a84b85ac69041e1c7df96e : SUCCESS in 6m 17s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/695419f6832b4306af1075038114647e : SUCCESS in 4m 49s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b0e8c25b1517431db948bcd296ca9db5 : SUCCESS in 5m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45d959a664a944bfb13e64d6a86de741 : SUCCESS in 9m 34s","accounts_in_message":[],"_revision_number":2},{"id":"251531ec2b8b5dd8465167343bf2921397740ad5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-11 08:12:00.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"026f90e4712a3202b39ae6532a0bc4d5ef2ed5d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-11 08:30:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/481de4c3850a48e8a5437affcd578d0e\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/15d68fb12832420fa65aa815e819e6a3 : SUCCESS in 7m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4bd70743280446798951ec6bf00e3e03 : SUCCESS in 4m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/54deb4416c3f4b4d8c65e80cc9531fe4 : SUCCESS in 5m 06s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/ca75512526304c35b3950b089b47e45d : SUCCESS in 5m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3c4149b6cfda460c8aad97791b5ff7b1 : SUCCESS in 9m 15s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"940b8bcd0bc3b6c7bfbfb9b29b6b06a1bb8d7be4","revisions":{"f29c3e4a61224e79bc6f40a4ab2d5f48a905a3c6":{"kind":"REWORK","_number":1,"created":"2025-09-22 18:56:46.000000000","uploader":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"ref":"refs/changes/10/962010/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/10/962010/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/10/962010/1"}}},"commit":{"parents":[{"commit":"382c77ee30c861c3f981f11c62f982b3ffb8fa4a","subject":"Improve unit tests for zone migration strategy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/382c77ee30c861c3f981f11c62f982b3ffb8fa4a"}]}],"author":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2025-07-30 20:02:03.000000000","tz":-180},"committer":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2025-09-22 18:00:29.000000000","tz":-180},"subject":"Add unit tests for instance and volume not found in model","message":"Add unit tests for instance and volume not found in model\n\nThe Zone Migration strategy was implemented to list all\ninstances and volumes from clients (nova and cinder) and\ncheck if they exist in the models. But the code is not\nproperly treating model exceptions, taking audit to a failure\nstate when the model doesn\u0027t have the requested element.\nThis patch adds unit tests to validate this scenario, which\nshould be fixed in a follow up change.\nThe additional check for volumes in the model was recently\nadded in [1]\n\n[1] https://github.com/openstack/watcher/commit/cb6fb1609706495a6187b973a55e270257be64e1\n\nRelated-Bug: #2098984\n\nAssisted-By: Cursor (claude-3.5-sonnet)\n\nChange-Id: Icf1e5d4c83862c848d11dae994842ad0ee62ba12\nSigned-off-by: Douglas Viroel \u003cviroel@gmail.com\u003e\n(cherry picked from commit cada9acced3f6f645d606504498e4fe1f4236386)\n(cherry picked from commit 15489fafb0a96d6fa3dbf7924f33014535121db0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f29c3e4a61224e79bc6f40a4ab2d5f48a905a3c6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f29c3e4a61224e79bc6f40a4ab2d5f48a905a3c6"}]},"branch":"refs/heads/stable/2025.1"},"0ff31a426786cd5ef3b70f1fddfa6c83d19351bb":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-01-20 15:11:15.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/10/962010/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/10/962010/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/10/962010/2"}}},"commit":{"parents":[{"commit":"11edb368147a00218643fbcf1b0cf086052ff8ca","subject":"Improve unit tests for zone migration strategy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/11edb368147a00218643fbcf1b0cf086052ff8ca"}]}],"author":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2025-07-30 20:02:03.000000000","tz":-180},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-01-20 15:10:40.000000000","tz":60},"subject":"Add unit tests for instance and volume not found in model","message":"Add unit tests for instance and volume not found in model\n\nThe Zone Migration strategy was implemented to list all\ninstances and volumes from clients (nova and cinder) and\ncheck if they exist in the models. But the code is not\nproperly treating model exceptions, taking audit to a failure\nstate when the model doesn\u0027t have the requested element.\nThis patch adds unit tests to validate this scenario, which\nshould be fixed in a follow up change.\nThe additional check for volumes in the model was recently\nadded in [1]\n\n[1] https://github.com/openstack/watcher/commit/cb6fb1609706495a6187b973a55e270257be64e1\n\nRelated-Bug: #2098984\n\nAssisted-By: Cursor (claude-3.5-sonnet)\n\nChange-Id: Icf1e5d4c83862c848d11dae994842ad0ee62ba12\nSigned-off-by: Douglas Viroel \u003cviroel@gmail.com\u003e\n(cherry picked from commit cada9acced3f6f645d606504498e4fe1f4236386)\n(cherry picked from commit 15489fafb0a96d6fa3dbf7924f33014535121db0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0ff31a426786cd5ef3b70f1fddfa6c83d19351bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0ff31a426786cd5ef3b70f1fddfa6c83d19351bb"}]},"branch":"refs/heads/stable/2025.1"},"940b8bcd0bc3b6c7bfbfb9b29b6b06a1bb8d7be4":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-11 08:12:00.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/10/962010/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/10/962010/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/10/962010/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/10/962010/3"}}},"commit":{"parents":[{"commit":"0cd6d2b294d7fab88f0f07901be2baf6593e26fa","subject":"Improve unit tests for zone migration strategy","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0cd6d2b294d7fab88f0f07901be2baf6593e26fa"}]}],"author":{"name":"Douglas Viroel","email":"viroel@gmail.com","date":"2025-07-30 20:02:03.000000000","tz":-180},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-11 08:11:51.000000000","tz":60},"subject":"Add unit tests for instance and volume not found in model","message":"Add unit tests for instance and volume not found in model\n\nThe Zone Migration strategy was implemented to list all\ninstances and volumes from clients (nova and cinder) and\ncheck if they exist in the models. But the code is not\nproperly treating model exceptions, taking audit to a failure\nstate when the model doesn\u0027t have the requested element.\nThis patch adds unit tests to validate this scenario, which\nshould be fixed in a follow up change.\nThe additional check for volumes in the model was recently\nadded in [1]\n\n[1] https://github.com/openstack/watcher/commit/cb6fb1609706495a6187b973a55e270257be64e1\n\nRelated-Bug: #2098984\n\nAssisted-By: Cursor (claude-3.5-sonnet)\n\nChange-Id: Icf1e5d4c83862c848d11dae994842ad0ee62ba12\nSigned-off-by: Douglas Viroel \u003cviroel@gmail.com\u003e\n(cherry picked from commit cada9acced3f6f645d606504498e4fe1f4236386)\n(cherry picked from commit 15489fafb0a96d6fa3dbf7924f33014535121db0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/940b8bcd0bc3b6c7bfbfb9b29b6b06a1bb8d7be4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/940b8bcd0bc3b6c7bfbfb9b29b6b06a1bb8d7be4"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}