)]}'
{"id":"openstack%2Fwatcher~963249","triplet_id":"openstack%2Fwatcher~master~Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461","project":"openstack/watcher","branch":"master","topic":"bug/2126969","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2025-10-23 14:45:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461","subject":"Remove dead NovaHelper methods","status":"MERGED","created":"2025-10-07 08:36:41.000000000","updated":"2025-10-23 14:46:02.000000000","submitted":"2025-10-23 14:45:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"963249-bug/2126969","meta_rev_id":"712b0ddaad6a60b59f25ee2498271272c4608548","_number":963249,"virtual_id_number":963249,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},{"value":0,"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-10-23 14:45:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"all":[{"value":2,"date":"2025-10-21 19:03:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":2,"date":"2025-10-23 13:55:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},{"value":1,"date":"2025-10-08 13:52:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"all":[{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":1,"date":"2025-10-23 13:55:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},{"value":0,"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"value":0,"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},{"value":0,"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-07 10:22:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-10-07 11:16:36.000000000","updated_by":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"reviewer":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"state":"REVIEWER"},{"updated":"2025-10-21 19:03:14.000000000","updated_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"reviewer":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"state":"REVIEWER"},{"updated":"2025-10-23 13:55:10.000000000","updated_by":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"reviewer":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"state":"REVIEWER"}],"messages":[{"id":"ede7cbb646d0f8a57963a65856f9cbfe21fd329d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-10-07 08:36:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6fc831fd720da99afe929bda61ee31391dbdf5e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-07 10:22:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/8a8554d8194647758ba09b7692af0f4a\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bb76dfffe6e24deea731a373928a3bff : SUCCESS in 7m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d47ed52e1aa946cbb97af3dccd030181 : FAILURE in 4m 51s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/ae5d1f596d414bb0b0018727d5a36e47 : SUCCESS in 4m 47s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/292f6f99316241a69052cd3c2fb1a0a7 : SUCCESS in 8m 00s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/c945a1441c984083ad56192979201624 : SUCCESS in 6m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/90db0c8e4f2246668e1e5de7609086c0 : SUCCESS in 5m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6aad3d84533f4a0ea16e067560a8f672 : SUCCESS in 3m 07s\n- openstack-tox-py312-threading https://zuul.opendev.org/t/openstack/build/e981e291337946599938ec683606cf51 : SUCCESS in 6m 42s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/f15de832b68541e5b1bafaa39af746b5 : SUCCESS in 20m 30s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/1834a5b172104b68b2c2c5615621cc5c : SUCCESS in 20m 11s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/3176729c041945d29159dd1495ede4d4 : SUCCESS in 1h 07m 40s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/6461c3f77eef4d2894d53783aab69e2b : SUCCESS in 48m 58s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/feb34c9c8a50400e9cb85eee9fe0a072 : SUCCESS in 20m 24s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/8ce838d5fa5842f3a966c91dbafb9f65 : SUCCESS in 1h 32m 26s\n- watcher-prometheus-integration-threading https://zuul.opendev.org/t/openstack/build/5c6477b9e873402b91438ef3a9aea152 : SUCCESS in 1h 39m 27s\n- watcher-aetos-integration https://zuul.opendev.org/t/openstack/build/6839f944ab4345b5b6ec8743a05d3306 : SUCCESS in 1h 10m 31s\n\nWarning:\n  Comments left for invalid file watcher/tests/decision_engine/model/faker_cluster_state.py\n  Comments left for invalid file watcher/tests/decision_engine/model/notification/test_cinder_notifications.py","accounts_in_message":[],"_revision_number":1},{"id":"cdcec4e8382baf429605b4876fe93aa25aa49dfd","author":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"date":"2025-10-07 11:16:36.000000000","message":"Patch Set 1: Code-Review+1\n\nBuild succeeded (check pipeline).\nhttps://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/74d0ecefc1b749db8df2bca0f4750d5c\n\n- openstack-meta-content-provider-master https://softwarefactory-project.io/zuul/t/rdoproject.org/build/3e0c8d546e7b44948414422f6ba662ba : SUCCESS in 2h 38m 41s\n- watcher-operator-validation-master https://softwarefactory-project.io/zuul/t/rdoproject.org/build/2f8c0f6091f14a0b98fda6272be2e1a9 : SUCCESS in 1h 53m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ee5fa96eb0e425671c56d83e332db4c5fafe3c7d","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-10-07 15:18:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1563e84bced82054591ffa30f9cf239fe0e77e9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-10-08 10:53:34.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"a6f833216b933614c5cd7dadca8f67f0ba0441f5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-08 12:33:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/be15a80e4251400183aa360f71ed9956\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a05bd9ba63ce44828d4e557709b70753 : SUCCESS in 3m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bdaae73b25a84401aee039edb99b3312 : SUCCESS in 6m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/13345bccaef74b6ba96bc63ea11d0fba : SUCCESS in 5m 17s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/f553f0af09fd461ba80c8ebb62a35097 : SUCCESS in 5m 38s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/aad7f01528c34a51b56f2c9fa880f7d3 : SUCCESS in 8m 36s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22bc1cbb6ae54d65acd0922c7d0e43cc : SUCCESS in 8m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bd801c5940314d77afe9352b73badab9 : SUCCESS in 4m 21s\n- openstack-tox-py312-threading https://zuul.opendev.org/t/openstack/build/8a2512ef621748dd9df3abb25ea7d652 : SUCCESS in 5m 27s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/9f8148e948aa4529b263ae7fb656b6fd : SUCCESS in 31m 58s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/d67f5ed005a54deb9c554117410ad46e : SUCCESS in 45m 52s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/ebeb2b4e504f4f74af9c798834fc95f9 : SUCCESS in 1h 11m 08s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/eb94461340f74872821843fc6520d8be : SUCCESS in 26m 27s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/6ca05dcfbab04c16a7a359958e0abfc2 : SUCCESS in 32m 38s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/98bba2ae8bd74b4e93817cf77d2cff9f : SUCCESS in 1h 27m 53s\n- watcher-prometheus-integration-threading https://zuul.opendev.org/t/openstack/build/7d2933867727448c85df7aaec530cff5 : SUCCESS in 1h 33m 40s\n- watcher-aetos-integration https://zuul.opendev.org/t/openstack/build/db47f3048af540bdb76d6de42968e741 : SUCCESS in 1h 14m 18s","accounts_in_message":[],"_revision_number":2},{"id":"32b861b2b008b63b7719759ae1ee51864d5dfd4a","author":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"date":"2025-10-08 13:52:35.000000000","message":"Patch Set 2: Code-Review+1\n\nBuild succeeded (check pipeline).\nhttps://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a6e7265a5e5b47479147ea32927104dc\n\n- openstack-meta-content-provider-master https://softwarefactory-project.io/zuul/t/rdoproject.org/build/bc522dc5fa4b489689fa5369f14f0b64 : SUCCESS in 2h 57m 23s\n- watcher-operator-validation-master https://softwarefactory-project.io/zuul/t/rdoproject.org/build/f0200f56e1dc4a1c8345d68bfdbbddcd : SUCCESS in 1h 49m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"58433f073ef75ed16cf81939f9af17c796c413d9","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-10-21 19:03:14.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"17866fc58c9936935ecaaf7be92f35849ae97027","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2025-10-23 13:55:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9d7e2aa75c07d07438cda0d22e6f2ef19bf014db","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-23 14:05:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"35196fd534254427201af61ca6cc0b8a81b42c9e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-23 14:45:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/afc9aea45ef44231a709beab9ee6599d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e8d127c50f04443ca2ff804c3cdfc6d0 : SUCCESS in 6m 04s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5f07a6c7a56d4da88866199a5251c271 : SUCCESS in 3m 18s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/2138ef13d23b4d259d385596a38f499e : SUCCESS in 10m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3228baff9ba41638843efafdc41f08e : SUCCESS in 9m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/29d236a760134579976a4a2cfff1f21d : SUCCESS in 3m 55s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/3158e2e233f648338e06f46e81f562d2 : SUCCESS in 35m 05s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/c5a9949dbc704271b7f46b2948ed3be5 : SUCCESS in 16m 37s","accounts_in_message":[],"_revision_number":2},{"id":"5bcb15fedd0e8a25037e3e60af899f817666d02c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-23 14:45:02.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"712b0ddaad6a60b59f25ee2498271272c4608548","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-10-23 14:46:02.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7da4edb50d2a465ca788b2b587a76b44\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3928f9e9e78b4290bfa7f6156c0bc34c : SUCCESS in 49s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3442af7775254cfaa9cc17fefd469ed7 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6bfbee1265f2cc39e19aa26ee85a74ce70e294ca","revisions":{"e624da7b490627f782153d162272d286ff583f91":{"kind":"REWORK","_number":1,"created":"2025-10-07 08:36:41.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/49/963249/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/49/963249/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/49/963249/1"}}},"commit":{"parents":[{"commit":"4d9df6044e675ff64f215a8cbb176928501acbe3","subject":"Remove unused glance client integration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4d9df6044e675ff64f215a8cbb176928501acbe3"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-10-07 08:32:26.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-10-07 08:35:57.000000000","tz":60},"subject":"Remove dead NovaHelper methods","message":"Remove dead NovaHelper methods\n\nRemove 7 unused methods from NovaHelper that have no production\nusage. These methods have been thoroughly verified against all 290\nproduction files and are only used in unit tests or not used at all.\n\nHigh-confidence removals:\n- delete_instance(): Remnant from old snapshot-based migration\n  workflow replaced in commit 4179c352 with Nova native migration API\n- get_availability_zone_list(): Added in 2016 for audit scope, never\n  used\n- get_instance_by_name(): Added in 2019 refactor, never integrated\n- get_instances_by_node(): Added in 2019 refactor, never integrated\n- get_service(): Added in 2017 for graph model, never integrated\n\nSecurity-related removals:\n- swap_volume(): Usage removed in commit 4fca7d24 due to data loss\n  risks and security concerns with credential forging\n- wait_for_instance_status(): Unused since 2015, redundant with\n  wait_for_instance_state()\n\nAll methods reverified against complete production file list.\nRemoving approximately 139 lines of code reduces maintenance burden\nand eliminates code with known security issues.\n\nGenerated-By: cursor\nAssisted-By: claude-code\nCloses-Bug: #2126969\nChange-Id: Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e624da7b490627f782153d162272d286ff583f91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e624da7b490627f782153d162272d286ff583f91"}]},"branch":"refs/heads/master"},"6bfbee1265f2cc39e19aa26ee85a74ce70e294ca":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-08 10:53:34.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/49/963249/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/49/963249/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/49/963249/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/49/963249/2"}}},"commit":{"parents":[{"commit":"13721b3804aa97c41e417339e03c9e848122a2c5","subject":"Remove unused glance client integration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/13721b3804aa97c41e417339e03c9e848122a2c5"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-10-07 08:32:26.000000000","tz":60},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2025-10-08 10:53:01.000000000","tz":60},"subject":"Remove dead NovaHelper methods","message":"Remove dead NovaHelper methods\n\nRemove 7 unused methods from NovaHelper that have no production\nusage. These methods have been thoroughly verified against all 290\nproduction files and are only used in unit tests or not used at all.\n\nHigh-confidence removals:\n- delete_instance(): Remnant from old snapshot-based migration\n  workflow replaced in commit 4179c352 with Nova native migration API\n- get_availability_zone_list(): Added in 2016 for audit scope, never\n  used\n- get_instance_by_name(): Added in 2019 refactor, never integrated\n- get_instances_by_node(): Added in 2019 refactor, never integrated\n- get_service(): Added in 2017 for graph model, never integrated\n\nSecurity-related removals:\n- swap_volume(): Usage removed in commit 4fca7d24 due to data loss\n  risks and security concerns with credential forging\n- wait_for_instance_status(): Unused since 2015, redundant with\n  wait_for_instance_state()\n\nAll methods reverified against complete production file list.\nRemoving approximately 139 lines of code reduces maintenance burden\nand eliminates code with known security issues.\n\nGenerated-By: cursor\nAssisted-By: claude-code\nCloses-Bug: #2126969\nChange-Id: Ic4a40a78fbb7c1bb9f659d8e801f25713c66c461\nSigned-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6bfbee1265f2cc39e19aa26ee85a74ce70e294ca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6bfbee1265f2cc39e19aa26ee85a74ce70e294ca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}