)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87e27e3db3558c4780fdbda5c885bc842c0bc459","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix term.py with 0.22.2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As per this Debian bug:"},{"line_number":10,"context_line":"https://bugs.debian.org/1118332"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"watcher fails to build from source with python3-docutils 0.22.2."},{"line_number":13,"context_line":"This patch fixes this."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"30de3f70_d4802209","line":10,"updated":"2025-10-24 11:59:21.000000000","message":"this should also have a launchpad bug bnut it sound valid.","commit_id":"c0d57a3cd578b194d76371d5f56ea35b6a0162ea"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87e27e3db3558c4780fdbda5c885bc842c0bc459","unresolved":true,"context_lines":[{"line_number":10,"context_line":"https://bugs.debian.org/1118332"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"watcher fails to build from source with python3-docutils 0.22.2."},{"line_number":13,"context_line":"This patch fixes this."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":16,"context_line":"Change-Id: I4ab81ff4a4374709961fbbf126482a8b746a0227"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a144f0d9_5e5214c4","line":13,"updated":"2025-10-24 11:59:21.000000000","message":"we probably shoudl add this to \n\nhttps://github.com/openstack/watcher/blob/master/doc/requirements.txt\n\nas its actually a direct dep since its used in the extension.\n\nwith that said upper cosntais is currently limited to 0.21.2 which is why that breaking change is not breakign our jobs.\n\nhttps://github.com/openstack/requirements/blob/master/upper-constraints.txt#L293\n\nwe can adapt to the new beahvior in 0.22.2 but they have intoduced a api breakage in that release.","commit_id":"c0d57a3cd578b194d76371d5f56ea35b6a0162ea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87e27e3db3558c4780fdbda5c885bc842c0bc459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f4b08f0_282a71a7","updated":"2025-10-24 11:59:21.000000000","message":"if you file a launachpad bug to track this for backports and add the fixme comment i think im ok with this","commit_id":"c0d57a3cd578b194d76371d5f56ea35b6a0162ea"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a445c92bb28c3389564a5137219cf0d571cba0a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"300d72a4_a1c57128","updated":"2026-02-11 18:56:50.000000000","message":"Agree, lets proceed with this fix.","commit_id":"d30da847e2cb95de9c69794378786e45cced48b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bec7fe246f1a2d3015c0a1d121fe4acc1f8e118","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"909225c4_e6223102","updated":"2026-02-09 18:03:03.000000000","message":"no your change is better i just wanted ot look at https://review.opendev.org/c/openstack/watcher/+/975231/1/doc/ext/term.py#40\nagain but your change is more defensive","commit_id":"d30da847e2cb95de9c69794378786e45cced48b3"}],"doc/ext/term.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87e27e3db3558c4780fdbda5c885bc842c0bc459","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \"\"\"Append one line of generated reST to the output.\"\"\""},{"line_number":40,"context_line":"        # Provide a proper source string to avoid issues with newer docutils"},{"line_number":41,"context_line":"        # Try to get the actual source file, fallback to class name"},{"line_number":42,"context_line":"        source \u003d getattr(self.state.document, \u0027current_source\u0027, None)"},{"line_number":43,"context_line":"        if source is None:"},{"line_number":44,"context_line":"            source \u003d f\u0027\u003cwatcher-{self.__class__.__name__.lower()}\u003e\u0027"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4cfba909_e17d3fbf","line":42,"updated":"2025-10-24 11:59:21.000000000","message":"getattr is generally a code smell\n\nhere its used corectly as wether this is avaible is depenend on the version fo docutils\n\nwith that said i woudl prefer if we added a `# FIXME(name):` comment to remvoe this when we rais the min version to 0.22 and then i woudl like to see a second patch on top that bumps our min doc utiles version and removes this usage and alwasy uses it. directly.\n\nwe can proceed with this version as is as i assume you will want to backport this to stable/2025.2 adn possible 2025.1?","commit_id":"c0d57a3cd578b194d76371d5f56ea35b6a0162ea"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87e27e3db3558c4780fdbda5c885bc842c0bc459","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    def add_textblock(self, textblock):"},{"line_number":53,"context_line":"        base_lineno \u003d getattr(self, \"lineno\", 0)"},{"line_number":54,"context_line":"        for i, line in enumerate(textblock.splitlines()):"},{"line_number":55,"context_line":"            self.add_line(line, base_lineno + i)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def add_object_docstring(self, obj):"},{"line_number":58,"context_line":"        obj_raw_docstring \u003d obj.__doc__ or \"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a9aeef4_a7dd12cb","line":55,"updated":"2025-10-24 11:59:21.000000000","message":"same general comment here.","commit_id":"c0d57a3cd578b194d76371d5f56ea35b6a0162ea"}]}