)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"611667bdac33d2a9bcecca496595727a186570c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9a00b3ad_57b3cfc8","updated":"2026-02-19 17:48:03.000000000","message":"recheck","commit_id":"4c5f2ed54497d0c391be9438698cff103fe1a1f3"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"945eac336e36fb77a8ce57e4ed96a3521037f2fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"456887b1_b38185de","updated":"2026-02-23 15:26:15.000000000","message":"It\u0027s not working as expected in my local tests. I\u0027m configuring:\n\n```\nnova.connect_retries \u003d 5\nnova.connect_retry_delay \u003d 2.0\n```\n\nBut I see it\u0027s only retrying once after 0.5s:\n\n2026-02-23 15:16:19.897 533 WARNING keystoneauth.session [None req-2f872d41-9d01-46ca-85e5-e35f0935c5d3 - - - - - -] Failure: Unable to establish connection to https://nova-internal.openstack.svc:8774/v2.1/os-services: HTTPSConnectionPool(host\u003d\u0027nova-internal.openstack.svc\u0027, port\u003d8774): Max retries exceeded with url: /v2.1/os-services?binary\u003dnova-compute\u0026host\u003dcompute2.ctlplane.localdomain (Caused by NewConnectionError(\u0027\u003curllib3.connection.HTTPSConnection object at 0x7fb167c4ae10\u003e: Failed to establish a new connection: [Errno 111] ECONNREFUSED\u0027)). **Retrying in 0.5s. 1 retries left**: keystoneauth1.exceptions.connection.ConnectFailure: Unable to establish connection to https://nova-internal.openstack.svc:8774/v2.1/os-services: HTTPSConnectionPool(host\u003d\u0027nova-internal.openstack.svc\u0027, port\u003d8774): Max retries exceeded with url: /v2.1/os-services?binary\u003dnova-compute\u0026host\u003dcompute2.ctlplane.localdomain (Caused by NewConnectionError(\u0027\u003curllib3.connection.HTTPSConnection object at 0x7fb167c4ae10\u003e: Failed to establish a new connection: [Errno 111] ECONNREFUSED\u0027))\n\nAlso I\u0027m getting a problem, not directly caused by this but hitting it because of the long exception message  reported and tried to add to the status_message:\n\n```\n2026-02-23 15:16:20.928 533 ERROR watcher.applier.action_plan.default oslo_db.exception.DBDataError: (pymysql.err.DataError) (1406, \"Data too long for column \u0027status_message\u0027 at row 1\")\n2026-02-23 15:16:20.928 533 ERROR watcher.applier.action_plan.default [SQL: UPDATE actions SET state\u003d%(state)s, status_message\u003d%(status_message)s, updated_at\u003d%(updated_at)s WHERE actions.id \u003d %(actions_id)s]\n2026-02-23 15:16:20.928 533 ERROR watcher.applier.action_plan.default [parameters: {\u0027state\u0027: \u0027FAILED\u0027, \u0027status_message\u0027: \"Action failed in execute: Unable to establish connection to https://nova-internal.openstack.svc:8774/v2.1/os-services: HTTPSConnectionPool(host\u003d\u0027nova ... (152 characters truncated) ...  NewConnectionError(\u0027\u003curllib3.connection.HTTPSConnection object at 0x7fb167c4b500\u003e: Failed to establish a new connection: [Errno 111] ECONNREFUSED\u0027))\", \u0027updated_at\u0027: datetime.datetime(2026, 2, 23, 15, 16, 20, 426674), \u0027actions_id\u0027: 66}]\n```\n\nWe probably need to fix that in separate fix","commit_id":"c684a9780dc2165bfa227695af9d05a27eaeb4cf"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d5be87103989a67299618545568b92c17d8c75a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b3496eba_e3a631b0","in_reply_to":"456887b1_b38185de","updated":"2026-02-23 15:45:29.000000000","message":"For the second issue https://bugs.launchpad.net/watcher/+bug/2142486","commit_id":"c684a9780dc2165bfa227695af9d05a27eaeb4cf"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"06d05b11f4b8c8f6b94ea406cdfa047c0cd5eaea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e56dcca0_2efb16cc","in_reply_to":"5afe0952_3cf591bb","updated":"2026-02-24 11:22:19.000000000","message":"thanks for testing Alfredo, indeed the delay option is being ignored. I did some testing in my local env and it seems that it\u0027s a bug in openstacksdk that does not parse that option. I\u0027ve reported a bug https://bugs.launchpad.net/openstacksdk/+bug/2142571 and proposed a fix which seems to fix the problem https://review.opendev.org/c/openstack/openstacksdk/+/977785. I\u0027ll -W the patch until we get some response from the openstacksdk maintainers","commit_id":"c684a9780dc2165bfa227695af9d05a27eaeb4cf"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"7a70505fd3e22581855451e2329f578d90920c6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5afe0952_3cf591bb","in_reply_to":"b3496eba_e3a631b0","updated":"2026-02-23 17:00:09.000000000","message":"One more note, openstacksdk is retrying on exceptions.RetriableConnectionFailure, while the nova_retries did it in exceptions.ConnectionError which covered SSLError and UnknownConnectionError in addition to ConnectTimeout and ConnectFailure.\n\nhttps://github.com/openstack/keystoneauth/blob/d534af707714644dc6ec6324de3e842c4b683d50/keystoneauth1/exceptions/connection.py\n\nI think that will covered most cases, but i still have doubts we should get rid of current implementation or at least we should test this carefully before changing to keystoneauth1 implementation.","commit_id":"c684a9780dc2165bfa227695af9d05a27eaeb4cf"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"94bfafdfc8e6ec5f37ec28866e54b39e8ede974a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4c15a414_d6a32892","in_reply_to":"e56dcca0_2efb16cc","updated":"2026-02-25 17:51:27.000000000","message":"I\u0027m ok with not retrying on SSLError, I don\u0027t think that retrying would solve SSL most of the SSL connection issues. I think that is fine to retry only on RetriableConnectionFailure failures.","commit_id":"c684a9780dc2165bfa227695af9d05a27eaeb4cf"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"06d05b11f4b8c8f6b94ea406cdfa047c0cd5eaea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"3593ab53_c243d1d7","updated":"2026-02-24 11:22:19.000000000","message":"We need a resolution for https://bugs.launchpad.net/openstacksdk/+bug/2142571 before proceeding","commit_id":"ad6c31c7be0f0f3097dadfff453b91e22c3b373c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4eef94ff90370b54e58de0143535bd93200cc4f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"a367b8a3_65fbe05a","updated":"2026-02-24 20:59:52.000000000","message":"you should fix the test bug form the previous patch in this one","commit_id":"6584fb2957e9faab17a055394d9fb43a862850f9"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c7ae82f3b10943a07229d9bd8534c8dfae299931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"8595fcea_65914985","in_reply_to":"a367b8a3_65fbe05a","updated":"2026-02-25 08:42:40.000000000","message":"I\u0027ve opened https://review.opendev.org/c/openstack/watcher/+/977919 insted, since we\u0027ll need to wait for a new openstacksdk release to proceed with this patch","commit_id":"6584fb2957e9faab17a055394d9fb43a862850f9"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"036e2b60b36913a812850dc007596bcf14c413d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"9f0182f9_17c7ce9c","updated":"2026-04-27 11:01:31.000000000","message":"Can\u0027t really proceed with this, the merged fix in openstacksdk was incomplete needs https://review.opendev.org/c/openstack/openstacksdk/+/986350 as well","commit_id":"f3e1ae18ef192915bec14c9779ba12cb22a9db12"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"54b4503330e594bdec981b102a46836e204c1b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0be9e06b_9a588e8a","updated":"2026-04-27 13:36:32.000000000","message":"I did a test in a devstack environment removing connectivity to the nova api and the parameters seem to work. With this configuration:\n```\n[nova]\nhttp_retries \u003d 3\nhttp_retry_interval \u003d 3.2\n```\nand with this one as well:\n\n```\n[nova]\nconnect_retries \u003d 3\nconnect_retry_delay \u003d 3.2\n```\n3 retries are attempted and the delay is reported corrrectly:\n\n```\n\nDEBUG keystoneauth.session [None req-a8126ac0-d85a-4fb9-929d-c10163a073a9 None None] REQ: curl -g -i --cacert \"/opt/stack/data/ca-bundle.pem\" -X GET http://192.168.70.37/compute/v2.1/servers/detail -H \"Accept: application/json\" -H \"OpenStack-API-Version: compute 2.100\" -H \"User-Agent: watcher-applier keystoneauth1/5.13.0 python-requests/2.32.5 CPython/3.12.3\" -H \"X-Auth-Token: {SHA256}d4261e3b45c36d484a23caa6c5b4e48a7288bf17711df44c32754679de3c5ce0\" -H \"X-OpenStack-Nova-API-Version: 2.100\" {{(pid\u003d9655) _http_log_request /opt/stack/data/venv/lib/python3.12/site-packages/keystoneauth1/session.py:575}}\nDEBUG urllib3.connectionpool [None req-a8126ac0-d85a-4fb9-929d-c10163a073a9 None None] Resetting dropped connection: 192.168.70.37 {{(pid\u003d9655) _get_conn /opt/stack/data/venv/lib/python3.12/site-packages/urllib3/connectionpool.py:291}}\nWARNING keystoneauth.session [None req-a8126ac0-d85a-4fb9-929d-c10163a073a9 None None] Failure: Request to http://192.168.70.37/compute/v2.1/servers/detail timed out. Retrying in 3.2s. 1 retries left: keystoneauth1.exceptions.connection.ConnectTimeout: Request to http://192.168.70.37/compute/v2.1/servers/detail timed out\nDEBUG urllib3.connectionpool [None req-a8126ac0-d85a-4fb9-929d-c10163a073a9 None None] Starting new HTTP connection (2): 192.168.70.37:80 {{(pid\u003d9655) _new_conn /opt/stack/data/venv/lib/python3.12/site-packages/urllib3/connectionpool.py:246}}\n*** keystoneauth1.exceptions.connection.ConnectTimeout: Request to http://192.168.70.37/compute/v2.1/servers/detail timed out\n```","commit_id":"f3e1ae18ef192915bec14c9779ba12cb22a9db12"}],"watcher/common/nova_helper.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"94bfafdfc8e6ec5f37ec28866e54b39e8ede974a","unresolved":true,"context_lines":[{"line_number":367,"context_line":"        # NOTE(jgilaber): use the values from the connection retries and"},{"line_number":368,"context_line":"        # interval from Watcher\u0027s specific options to set the values for the"},{"line_number":369,"context_line":"        # keystoneauth adapter options that openstacksdk uses"},{"line_number":370,"context_line":"        CONF.set_override(\u0027connect_retries\u0027, CONF.nova.http_retries, \u0027nova\u0027)"},{"line_number":371,"context_line":"        retry_interval \u003d CONF.nova.http_retry_interval"},{"line_number":372,"context_line":"        CONF.set_override(\u0027connect_retry_delay\u0027, retry_interval, \u0027nova\u0027)"},{"line_number":373,"context_line":"        if CONF.nova.valid_interfaces is None and CONF.nova.interface is None:"},{"line_number":374,"context_line":"            # NOTE(jgilaber): ensure the endpoint_type option from nova_client"},{"line_number":375,"context_line":"            # is processed and set with the right format in [nova]"}],"source_content_type":"text/x-python","patch_set":26,"id":"8dc3266e_f0d3a2f3","line":372,"range":{"start_line":370,"start_character":0,"end_line":372,"end_character":72},"updated":"2026-02-25 17:51:27.000000000","message":"I think that we should update options documentation to make this clear to users. We have both configurations, and one overrides the other.\nWe should also consider deprecating the http_* ones next cycle (when we added them?)","commit_id":"25b4356dcfb6a1b74ee61d26ec2c6e67c1ebe6fa"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"54543f665bd6a687a633795fa7031dfbd9af0abe","unresolved":true,"context_lines":[{"line_number":367,"context_line":"        # NOTE(jgilaber): use the values from the connection retries and"},{"line_number":368,"context_line":"        # interval from Watcher\u0027s specific options to set the values for the"},{"line_number":369,"context_line":"        # keystoneauth adapter options that openstacksdk uses"},{"line_number":370,"context_line":"        CONF.set_override(\u0027connect_retries\u0027, CONF.nova.http_retries, \u0027nova\u0027)"},{"line_number":371,"context_line":"        retry_interval \u003d CONF.nova.http_retry_interval"},{"line_number":372,"context_line":"        CONF.set_override(\u0027connect_retry_delay\u0027, retry_interval, \u0027nova\u0027)"},{"line_number":373,"context_line":"        if CONF.nova.valid_interfaces is None and CONF.nova.interface is None:"},{"line_number":374,"context_line":"            # NOTE(jgilaber): ensure the endpoint_type option from nova_client"},{"line_number":375,"context_line":"            # is processed and set with the right format in [nova]"}],"source_content_type":"text/x-python","patch_set":26,"id":"5ec54dbe_cb076384","line":372,"range":{"start_line":370,"start_character":0,"end_line":372,"end_character":72},"in_reply_to":"8dc3266e_f0d3a2f3","updated":"2026-04-27 10:33:25.000000000","message":"In patchset 27 I\u0027ve deprecated the `http_retries` and `http_retry_interval` options in favour of `connect_retries` and `connect_retry_delay`. I have some doubts about whether we should override the default values with the ones from the http_* options though","commit_id":"25b4356dcfb6a1b74ee61d26ec2c6e67c1ebe6fa"}]}