)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46915060dfbb6f7c3b89f455cc0ae47bf66da533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a301012_033885f7","updated":"2026-03-05 15:05:09.000000000","message":"+2 once you fix the test data to use unique uuids","commit_id":"40472f49b3299751090d6c42b474f1d98fb9afda"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c6a5349cd00f8ab3ddcf84353c0d62a26f8e904c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e595526e_c8b2b97f","updated":"2026-03-09 13:42:28.000000000","message":"lgtm, thanks for fixing Joan","commit_id":"40472f49b3299751090d6c42b474f1d98fb9afda"}],"watcher/applier/actions/resize.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"9c4cca2ec7b8764e5d5b623e6ce21e1f522a371d","unresolved":true,"context_lines":[{"line_number":91,"context_line":"            result \u003d nova.resize_instance("},{"line_number":92,"context_line":"                instance_id\u003dself.instance_uuid, flavor\u003dself.flavor)"},{"line_number":93,"context_line":"        except Exception as exc:"},{"line_number":94,"context_line":"            LOG.exception(exc)"},{"line_number":95,"context_line":"            LOG.critical("},{"line_number":96,"context_line":"                \"Unexpected error occurred. Resizing failed for \""},{"line_number":97,"context_line":"                \"instance %s.\", self.instance_uuid)"},{"line_number":98,"context_line":"        return result"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def execute(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf86167d_651bd606","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":51},"updated":"2026-02-27 07:27:57.000000000","message":"I think this is missing a `result \u003d False` or `return False` here?. This was another pre-existing bug but could be worthy to fix in this patch.","commit_id":"debc95071f8b315976cfc9d96f9b488b0004747f"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"96e333f92d2527f064fd02ada623cb4ae83af0f1","unresolved":true,"context_lines":[{"line_number":91,"context_line":"            result \u003d nova.resize_instance("},{"line_number":92,"context_line":"                instance_id\u003dself.instance_uuid, flavor\u003dself.flavor)"},{"line_number":93,"context_line":"        except Exception as exc:"},{"line_number":94,"context_line":"            LOG.exception(exc)"},{"line_number":95,"context_line":"            LOG.critical("},{"line_number":96,"context_line":"                \"Unexpected error occurred. Resizing failed for \""},{"line_number":97,"context_line":"                \"instance %s.\", self.instance_uuid)"},{"line_number":98,"context_line":"        return result"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def execute(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"edb9b9b4_17953f76","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":51},"in_reply_to":"bf86167d_651bd606","updated":"2026-02-27 08:38:31.000000000","message":"technically I don\u0027t think this would be a bug because only a return value of `True` is considered a success https://github.com/openstack/watcher/blob/5740bb98a5769ecdd342b2e7240ce76ac847dffa/watcher/applier/workflow_engine/default.py#L160-L170 so returning None is considered the same as `False`. With that said I agree that return False is preferable, it\u0027s clearer and simpler to understand imo","commit_id":"debc95071f8b315976cfc9d96f9b488b0004747f"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"191bd70fa950578e1a45dfe3983b0528b1dd05ce","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            result \u003d nova.resize_instance("},{"line_number":92,"context_line":"                instance_id\u003dself.instance_uuid, flavor\u003dself.flavor)"},{"line_number":93,"context_line":"        except Exception as exc:"},{"line_number":94,"context_line":"            LOG.exception(exc)"},{"line_number":95,"context_line":"            LOG.critical("},{"line_number":96,"context_line":"                \"Unexpected error occurred. Resizing failed for \""},{"line_number":97,"context_line":"                \"instance %s.\", self.instance_uuid)"},{"line_number":98,"context_line":"        return result"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def execute(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"66af542a_6f9e4368","line":97,"range":{"start_line":94,"start_character":0,"end_line":97,"end_character":51},"in_reply_to":"edb9b9b4_17953f76","updated":"2026-02-27 15:24:52.000000000","message":"Thanks for the explanation, and thanks for the change 😊","commit_id":"debc95071f8b315976cfc9d96f9b488b0004747f"}],"watcher/tests/unit/decision_engine/strategy/strategies/test_zone_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46915060dfbb6f7c3b89f455cc0ae47bf66da533","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"        server_info \u003d {"},{"line_number":1301,"context_line":"            \"compute_host\": \"src1\","},{"line_number":1302,"context_line":"            \"name\": \"INSTANCE_1\","},{"line_number":1303,"context_line":"            \"id\": \"d010ef1f-dc19-4982-9383-087498bfde03\","},{"line_number":1304,"context_line":"            \"vm_state\": \"active\""},{"line_number":1305,"context_line":"        }"},{"line_number":1306,"context_line":"        instance_on_src1_1 \u003d nova_helper.Server.from_openstacksdk("}],"source_content_type":"text/x-python","patch_set":3,"id":"e678c90d_cf492c35","line":1303,"range":{"start_line":1303,"start_character":19,"end_line":1303,"end_character":57},"updated":"2026-03-05 15:05:09.000000000","message":"the instnace uuid shoudl be uniwue between each fake instance\n\ni woudl recommend using teh uuid sententila moduel form oslo.\n\nfrom oslo_utils.fixture import uuidsentinel as uuids\n```\n...\n\"id\": uuids.instance_1\n...\n```\n\nthe way tha tworks is you jsut refenca any sub atirbute and the uuidsentinel isntance generate and returns a uuid for you that istabel so  \n\n uuids.instance_1 is the same every where you refence it","commit_id":"40472f49b3299751090d6c42b474f1d98fb9afda"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"fd77cc58c7e64a379b953587c2e6239b3d2a377a","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"        server_info \u003d {"},{"line_number":1301,"context_line":"            \"compute_host\": \"src1\","},{"line_number":1302,"context_line":"            \"name\": \"INSTANCE_1\","},{"line_number":1303,"context_line":"            \"id\": \"d010ef1f-dc19-4982-9383-087498bfde03\","},{"line_number":1304,"context_line":"            \"vm_state\": \"active\""},{"line_number":1305,"context_line":"        }"},{"line_number":1306,"context_line":"        instance_on_src1_1 \u003d nova_helper.Server.from_openstacksdk("}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe3c3e6_1b0f6528","line":1303,"range":{"start_line":1303,"start_character":19,"end_line":1303,"end_character":57},"in_reply_to":"e678c90d_cf492c35","updated":"2026-03-05 15:15:16.000000000","message":"note that the uuids for the different fake instances are very similar but not identical. The way the tests for the zone migration are written they use the `scenario_1.xml` file (https://github.com/openstack/watcher/blob/master/watcher/tests/unit/decision_engine/model/data/scenario_1.xml) where the uuids follow a predictable pattern so the uuids can be generated in a for loop in the tests that check them to test the model. I can\u0027t change the uuids here withouth changing that file and changine many other tests that also use them","commit_id":"40472f49b3299751090d6c42b474f1d98fb9afda"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7784af32c6737aee15a86968620f13cd3495ea14","unresolved":true,"context_lines":[{"line_number":1300,"context_line":"        server_info \u003d {"},{"line_number":1301,"context_line":"            \"compute_host\": \"src1\","},{"line_number":1302,"context_line":"            \"name\": \"INSTANCE_1\","},{"line_number":1303,"context_line":"            \"id\": \"d010ef1f-dc19-4982-9383-087498bfde03\","},{"line_number":1304,"context_line":"            \"vm_state\": \"active\""},{"line_number":1305,"context_line":"        }"},{"line_number":1306,"context_line":"        instance_on_src1_1 \u003d nova_helper.Server.from_openstacksdk("}],"source_content_type":"text/x-python","patch_set":3,"id":"776e9afc_722e8fa5","line":1303,"range":{"start_line":1303,"start_character":19,"end_line":1303,"end_character":57},"in_reply_to":"ffe3c3e6_1b0f6528","updated":"2026-03-05 15:19:07.000000000","message":"\"id\": \"d010ef1f-dc19-4982-9383-087498bfde03\",\n \"id\": \"d020ef1f-dc19-4982-9383-087498bfde03\",\n \n oh you change the 3rd digit instead of the forst or last...\n ok\n \n ok the forlop shoud just genereate random ones but fine.","commit_id":"40472f49b3299751090d6c42b474f1d98fb9afda"}]}