)]}'
{"id":"openstack%2Fwatcher~979123","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~I05f8d66c6a79e0cff356ac83b88b28942f14a9a9","project":"openstack/watcher","branch":"stable/2025.1","attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2026-03-06 10:21:34.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I05f8d66c6a79e0cff356ac83b88b28942f14a9a9","subject":"Fix zone migration dst pool and type selection","status":"NEW","created":"2026-03-06 09:08:38.000000000","updated":"2026-03-11 09:35:12.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c0ae0d15dd4682ccebec0483ba2861fcbac7e139","_number":979123,"virtual_id_number":979123,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-11 09:35:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-06 10:21:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3278318d6b1eaba8645f0a54d053a3d5984a1714","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-06 09:08:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4475274ec0b0494517342fd926fe0d437de2b68b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-06 10:21:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/561318de16a24dc3877f2971b933ba58\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3f6f0268840042e485cc9a61abed73df : FAILURE in 2m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77c3d729eacd425eb95fedd1333712e5 : FAILURE in 2m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fba0a32c060646e0a6b57d2e584ed1fd : SUCCESS in 3m 43s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/d08eb10ffe0f450aa8b4c1c358a175be : FAILURE in 5m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/53c59f08c22e4429849d033dad8ed118 : FAILURE in 7m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1dfd1ad669514570af9a4d7e9bddd233 : SUCCESS in 3m 43s\n- watcher-tempest-api-jammy https://zuul.opendev.org/t/openstack/build/c521b8f25bb74ef19b81cf728e58dfa0 : SUCCESS in 34m 35s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/d96de047c47149a688da5100f8f202c4 : SUCCESS in 24m 38s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/ae2c080c9f744932ba339500b947f05c : SUCCESS in 1h 04m 35s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/3d438b819f244637a1ce333b17c21e75 : SUCCESS in 40m 16s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/827efaa570a34bc689bd4cf6221c8cc8 : SUCCESS in 41m 35s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/1fa51b452e034cd88ee55dbdcb0d2ed4 : SUCCESS in 1h 10m 19s","accounts_in_message":[],"_revision_number":1},{"id":"48295f669d5602836c42624e1871ae387e4cd974","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-11 08:12:00.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"c0ae0d15dd4682ccebec0483ba2861fcbac7e139","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-11 09:35:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c1fbc68bb4b04ec497c8f05300a7f0e6\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3d085b33efbc407582f4c09cac7c7c2a : SUCCESS in 5m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c16484fb44a24a4db2aef97d894dbc12 : SUCCESS in 4m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/964eb22cbcec4654b1cb00b5ab8eaa3a : SUCCESS in 3m 21s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/bb72157a10d84f01a6dc65eab8cdb516 : SUCCESS in 5m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cfee4048ce974d709b127cd471fe0850 : SUCCESS in 8m 45s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/279cc3846eb344faa3307b1bb621aeb9 : SUCCESS in 4m 33s\n- watcher-tempest-api-jammy https://zuul.opendev.org/t/openstack/build/cd473515760e4951987a4423893774ed : SUCCESS in 32m 45s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/93382fbbbd2745299c2456a321d6f311 : SUCCESS in 47m 00s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/a6ffbb67fa1e437493987c87493420fd : SUCCESS in 1h 11m 57s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/1ff4d9446e9b4e18a53ce05f412eee3e : SUCCESS in 40m 34s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/23bdf52344854a96b698114cef3aefb7 : SUCCESS in 41m 20s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/f29da08b9e5143f9ac0664939ac85b05 : SUCCESS in 47m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4ac16bbfd7ab79a6c3bb457ee3fb5a5f29e988e2","revisions":{"5b2116245302ce2305bbafeb2e6c9d72fc4ac249":{"kind":"REWORK","_number":1,"created":"2026-03-06 09:08:38.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/23/979123/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/23/979123/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/23/979123/1"}}},"commit":{"parents":[{"commit":"9caa05de02d309f0708e551ffe2b0439f68bb8a1","subject":"Add tests for get_dst_pool_and_type method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/9caa05de02d309f0708e551ffe2b0439f68bb8a1"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-10-23 17:16:02.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-06 09:08:25.000000000","tz":60},"subject":"Fix zone migration dst pool and type selection","message":"Fix zone migration dst pool and type selection\n\nThe get_dst_pool_and_type method was always selecting the first\nmatching storage pool based only on src_pool, ignoring the\nsrc_type parameter. This caused incorrect volume migrations when\nthe user supplied multiple values for storage_pools with the same\nsource pool but different source types.\n\nThis change implements a two-pass matching approach:\n1. First pass attempts to match both src_pool and src_type for\n   exact matches\n2. Second pass falls back to matching just src_pool if no exact\n   match is found\n\nTests are updated to verify the correct behavior including the more\nrestrictive matching logic.\n\nGenerated-By: claude-code (clause-sonnet-4.5)\nCloses-Bug: 2129692\nChange-Id: I05f8d66c6a79e0cff356ac83b88b28942f14a9a9\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 16446385dd840b5cc072e3453e271e726aa38a72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/5b2116245302ce2305bbafeb2e6c9d72fc4ac249"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/5b2116245302ce2305bbafeb2e6c9d72fc4ac249"}]},"branch":"refs/heads/stable/2025.1"},"4ac16bbfd7ab79a6c3bb457ee3fb5a5f29e988e2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-11 08:12:00.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/23/979123/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/23/979123/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/979123/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/23/979123/2"}}},"commit":{"parents":[{"commit":"a074ae72e10de2208bb57a232d098a0ea3e87ea4","subject":"Add tests for get_dst_pool_and_type method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/a074ae72e10de2208bb57a232d098a0ea3e87ea4"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-10-23 17:16:02.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-11 08:11:51.000000000","tz":60},"subject":"Fix zone migration dst pool and type selection","message":"Fix zone migration dst pool and type selection\n\nThe get_dst_pool_and_type method was always selecting the first\nmatching storage pool based only on src_pool, ignoring the\nsrc_type parameter. This caused incorrect volume migrations when\nthe user supplied multiple values for storage_pools with the same\nsource pool but different source types.\n\nThis change implements a two-pass matching approach:\n1. First pass attempts to match both src_pool and src_type for\n   exact matches\n2. Second pass falls back to matching just src_pool if no exact\n   match is found\n\nTests are updated to verify the correct behavior including the more\nrestrictive matching logic.\n\nGenerated-By: claude-code (clause-sonnet-4.5)\nCloses-Bug: 2129692\nChange-Id: I05f8d66c6a79e0cff356ac83b88b28942f14a9a9\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit 16446385dd840b5cc072e3453e271e726aa38a72)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4ac16bbfd7ab79a6c3bb457ee3fb5a5f29e988e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4ac16bbfd7ab79a6c3bb457ee3fb5a5f29e988e2"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}