)]}'
{"id":"openstack%2Fwatcher~979128","triplet_id":"openstack%2Fwatcher~stable%2F2025.2~Ic401fe2e8c67df84581f236f344c1b4b52a334e3","project":"openstack/watcher","branch":"stable/2025.2","attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2026-03-06 11:05:36.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic401fe2e8c67df84581f236f344c1b4b52a334e3","subject":"Fix check for volume type in cinder helper migrate","status":"NEW","created":"2026-03-06 09:30:54.000000000","updated":"2026-04-30 08:55:54.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04c3af6848d735677cfe826234023f37f48cdedd","_number":979128,"virtual_id_number":979128,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-04-28 12:02:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-04-30 08:55:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-06 11:05:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-28 10:35:01.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"CC"},{"updated":"2026-04-30 08:55:54.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"}],"messages":[{"id":"3a423058515414d55b8ac517376cb9585013c736","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-06 09:30:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8db142701a608bf32712386d1211626147cdbe6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-06 11:05:36.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/0a59656ec5fb4f8dbfb66709ce8e7b48\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/54992436d1514c3ab9a71f0690dd19e4 : FAILURE in 5m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/49a12f4204ba4df89335e59af19d0889 : FAILURE in 2m 57s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/ff20171bfb4f4eb4985e38605da57df3 : FAILURE in 3m 42s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/d747d0b33a1841ec85eeff97048a8e56 : FAILURE in 4m 19s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/921f748b750c46f4a4470070f05f9f95 : FAILURE in 6m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ca1049be9908477a80d4cfff48cb5ee4 : FAILURE in 6m 36s\n- openstack-tox-py312-threading https://zuul.opendev.org/t/openstack/build/0c44124f72d245e38e289bcb790b3de2 : FAILURE in 4m 20s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/ff8f7b9f9d03413ba2f1e86c4274044f : SUCCESS in 36m 25s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/efff12d2d6bf4720805370c6aa2f7b72 : SUCCESS in 43m 47s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/4d3abdaf9b65455198ce176fbe0bcba3 : SUCCESS in 1h 13m 38s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/cbad93c52ef147ce9886f9a201332e1a : SUCCESS in 1h 16m 41s\n- watcher-tempest-prometheus-threading https://zuul.opendev.org/t/openstack/build/932b1e83e47641299f2629604122de7e : SUCCESS in 1h 24m 26s\n- watcher-tempest-aetos https://zuul.opendev.org/t/openstack/build/827b5964a7484db0992635244f828006 : SUCCESS in 1h 26m 55s","accounts_in_message":[],"_revision_number":1},{"id":"92caa2739aecb7272e7abe4da867bcdaac7d712d","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-28 10:35:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"166bd46edee0ba83145f486fcea43907d56fff45","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-28 12:02:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1d3f3a0230c945f79bfc92b02910b8d3\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8a89638a27d04fbc94a44da9c76f4f67 : SUCCESS in 6m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce445bef88964f39a87297a3441a0e33 : SUCCESS in 4m 11s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/52cdf4615ddf4163b3eba41929dc7175 : SUCCESS in 5m 02s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/82f6aacd17ca4970a3d0e1ad47ea909f : SUCCESS in 5m 20s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/690852ef23d24c5586455c700094dc52 : SUCCESS in 4m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e7f329ec6fac4e609abdca061217dbb7 : SUCCESS in 4m 50s\n- openstack-tox-py312-threading https://zuul.opendev.org/t/openstack/build/33242ec816e24dc1a157c1e0685fe3b6 : SUCCESS in 5m 18s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/63dffe4fbc7f44af840ecea89b5aea1e : SUCCESS in 51m 34s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/cf1ea87de47246adba4e90c9e837c379 : SUCCESS in 18m 45s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/e4551bca56f54ea1867e55eef2bdc75a : SUCCESS in 1h 10m 04s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/f1aee4cbc74248d9b10c99b12cec2723 : SUCCESS in 1h 00m 51s\n- watcher-tempest-prometheus-threading https://zuul.opendev.org/t/openstack/build/685f1361a6224c2daad03a74c6fb54ab : SUCCESS in 1h 12m 46s\n- watcher-tempest-aetos https://zuul.opendev.org/t/openstack/build/9b620a7ccd2747b086c1b63a8a9e0036 : SUCCESS in 1h 21m 33s","accounts_in_message":[],"_revision_number":1},{"id":"04c3af6848d735677cfe826234023f37f48cdedd","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-30 08:55:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8d34ff1da6b90a123a3ba9d76d8c13564ca39a91","revisions":{"8d34ff1da6b90a123a3ba9d76d8c13564ca39a91":{"kind":"REWORK","_number":1,"created":"2026-03-06 09:30:54.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/28/979128/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/28/979128/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/28/979128/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/28/979128/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/28/979128/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/28/979128/1"}}},"commit":{"parents":[{"commit":"c757d7f3324863f304ac22e986afce9cad109b1b","subject":"Merge \"Revert \"Update migration notification\"\" into stable/2025.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c757d7f3324863f304ac22e986afce9cad109b1b"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-10-13 09:03:47.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-06 09:30:33.000000000","tz":60},"subject":"Fix check for volume type in cinder helper migrate","message":"Fix check for volume type in cinder helper migrate\n\nUse all the extra_specs from the volume types when trying to determine\nwhether a volume can be migrated to a destination pool. Before this\npatch, it only checked if the \u0027volume_backend_name\u0027 of the volume type\nmatched the one from the pool\u0027s backend. With this change, volume types\nwith no extra_specs are considered a match for any pool, and all fields\nin the types extra_specs are checked against the pool capabilities.\n\nA pool with no capabilities reported is considered to match any volume\ntype, with the idea of being permissive and letting the migration\ncontinue and allowing cinder to do a proper evaluation of whether the\nmigration can be done, and fail the migration otherwise.\n\nThe test helper methods (fake_pool, fake_volume_type, fake_volume)\nwere enhanced to use proper mock specs and support the to_dict()\nmethod required by get_volume_types_for_pool. The migrate tests\nwere updated to use these improved helpers and properly mock the\nget_storage_pool_by_name method.\n\nThe backendname_from_poolname is removed since it\u0027s no longer used\nthrought the codebase.\n\nAssisted-By: claude-code (claude-sonnet-4.5)\n\nCloses-Bug: 2127485\nChange-Id: Ic401fe2e8c67df84581f236f344c1b4b52a334e3\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit b3595d77a755645d68332a9f153c5596b295e1d3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/8d34ff1da6b90a123a3ba9d76d8c13564ca39a91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/8d34ff1da6b90a123a3ba9d76d8c13564ca39a91"}]},"branch":"refs/heads/stable/2025.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}