)]}'
{"id":"openstack%2Fwatcher~979132","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~Ic401fe2e8c67df84581f236f344c1b4b52a334e3","project":"openstack/watcher","branch":"stable/2025.1","attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2026-03-06 11:11:56.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic401fe2e8c67df84581f236f344c1b4b52a334e3","subject":"Fix check for volume type in cinder helper migrate","status":"NEW","created":"2026-03-06 09:44:19.000000000","updated":"2026-04-30 11:27:34.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97e182645ae8f068c63564f64feedca3c9995a7f","_number":979132,"virtual_id_number":979132,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-04-30 10:14:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"all":[{"value":2,"date":"2026-04-30 11:27:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-06 11:11:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-28 10:15:46.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"CC"},{"updated":"2026-04-30 11:27:34.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"}],"messages":[{"id":"605d97721f631c749fa8e57611ae3957ef24b2a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-06 09:44:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"11ff5c14e461683866cce67eab67a83acd0c4cd2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-06 11:11:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/2e3f71c0e50f4a738a7fa977b0f9501d\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d00bbd47ac6b4969b9c27c95754f7f12 : FAILURE in 3m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/410c396300ae425c8ebb4b751213ccf3 : FAILURE in 2m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ba7a851302184903b469c8a7a3818fb4 : SUCCESS in 4m 48s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/41558cb708bb434dbfe4c7a0b26d04d7 : FAILURE in 3m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/625c34c276ce4bcd816e2a91d6ef1fb0 : FAILURE in 6m 07s\n- watcher-tempest-api-jammy https://zuul.opendev.org/t/openstack/build/cacc9135308447158bca58ef10bf9efe : FAILURE in 13m 19s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/d8fb301e0a264db998fd0c5582ae0600 : SUCCESS in 56m 15s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/d5edc9d2921a4b1f861ff510aadf5c02 : SUCCESS in 44m 27s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/6e85dec273ea40a2ad40157dbf297287 : SUCCESS in 20m 56s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/94cf12e818a743f096b7356f3be07ab0 : SUCCESS in 35m 05s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/cda13484a3474596bf2e9b7c58401b08 : SUCCESS in 1h 22m 36s","accounts_in_message":[],"_revision_number":1},{"id":"e18e87f2515865f8a38d6de0502fae44c83e01fb","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-28 10:15:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0b853413fa7181b1220c69aca39212766a73da4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-28 11:26:59.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/373a42a44c7e444b90b56ade6b63d119\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8c2ae6ac8dfc4dff9efc313f8b3f9829 : SUCCESS in 6m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fdbe954682d14addb466ff14d2a5af78 : SUCCESS in 3m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6b2c8d42065b4964ab341709fbaa93c4 : SUCCESS in 3m 34s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/a29f322857d84dc3a1e62f33d121703d : SUCCESS in 3m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ceb45a7696a645259b31eb9edb551a94 : SUCCESS in 8m 40s\n- watcher-tempest-api-jammy https://zuul.opendev.org/t/openstack/build/667fff31c6b14a6aae61eded0afd6c3e : FAILURE in 14m 00s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/a198c98a055c44039da4997284fdc3a2 : SUCCESS in 48m 05s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/27de9cd566b64d05b1133d408f8f9adc : SUCCESS in 58m 57s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/213569de21774e54b9629eee16e899e0 : SUCCESS in 15m 52s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/2446817d5bed4dfc8c2ff16d8cb0ec9d : SUCCESS in 38m 10s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/471488fd6a974c419916cb7ad3b8fbce : SUCCESS in 1h 07m 42s","accounts_in_message":[],"_revision_number":1},{"id":"67ed9d7fb412c309d3d9122b5addcbb40151056c","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-30 08:57:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"81b3c867f9308ceb145843442e52ab4e9386c017","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-30 10:14:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/eac0c984b76e4c978b1790f2faaee6d2\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/11cd0bb9ff5f4c23b8facfd7dbd2ace3 : SUCCESS in 3m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9050e9983c9a4cdf8dc69edaee23a95d : SUCCESS in 2m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5b246bd94ea94fd28e64181fee3ee449 : SUCCESS in 4m 52s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c5104fdc64dd40188505ba2b11359c4f : SUCCESS in 5m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d099f31c85a34fccada0722917d1962b : SUCCESS in 4m 58s\n- watcher-tempest-api-jammy https://zuul.opendev.org/t/openstack/build/9678dfbf5e984e3391662a2dbf6159d4 : SUCCESS in 33m 03s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/15e8f19ef1884b2288c4e77ce68e0fb8 : SUCCESS in 37m 37s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/673d4c03dde647b4a4001266c7d85f84 : SUCCESS in 1h 11m 39s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/b04ea395def14eb78ad62cd846f04dac : SUCCESS in 36m 42s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/0ec0d21811ef48fc995d81ebc760a56e : SUCCESS in 18m 50s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/de449786def0472781185a163b9217e6 : SUCCESS in 48m 15s","accounts_in_message":[],"_revision_number":1},{"id":"97e182645ae8f068c63564f64feedca3c9995a7f","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2026-04-30 11:27:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"25a44671d9f620d3b17499e3503df3ff42582d0e","revisions":{"25a44671d9f620d3b17499e3503df3ff42582d0e":{"kind":"REWORK","_number":1,"created":"2026-03-06 09:44:19.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/32/979132/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/32/979132/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/32/979132/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/32/979132/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/32/979132/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/32/979132/1"}}},"commit":{"parents":[{"commit":"d04a050bded1bddfa82128a02cc76d81c2384e1e","subject":"Check result of retype action based on type and status","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d04a050bded1bddfa82128a02cc76d81c2384e1e"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-10-13 09:03:47.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-06 09:44:02.000000000","tz":60},"subject":"Fix check for volume type in cinder helper migrate","message":"Fix check for volume type in cinder helper migrate\n\nUse all the extra_specs from the volume types when trying to determine\nwhether a volume can be migrated to a destination pool. Before this\npatch, it only checked if the \u0027volume_backend_name\u0027 of the volume type\nmatched the one from the pool\u0027s backend. With this change, volume types\nwith no extra_specs are considered a match for any pool, and all fields\nin the types extra_specs are checked against the pool capabilities.\n\nA pool with no capabilities reported is considered to match any volume\ntype, with the idea of being permissive and letting the migration\ncontinue and allowing cinder to do a proper evaluation of whether the\nmigration can be done, and fail the migration otherwise.\n\nThe test helper methods (fake_pool, fake_volume_type, fake_volume)\nwere enhanced to use proper mock specs and support the to_dict()\nmethod required by get_volume_types_for_pool. The migrate tests\nwere updated to use these improved helpers and properly mock the\nget_storage_pool_by_name method.\n\nThe backendname_from_poolname is removed since it\u0027s no longer used\nthrought the codebase.\n\nAssisted-By: claude-code (claude-sonnet-4.5)\n\nCloses-Bug: 2127485\nChange-Id: Ic401fe2e8c67df84581f236f344c1b4b52a334e3\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit b3595d77a755645d68332a9f153c5596b295e1d3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/25a44671d9f620d3b17499e3503df3ff42582d0e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/25a44671d9f620d3b17499e3503df3ff42582d0e"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}