)]}'
{"id":"openstack%2Fwatcher~979134","triplet_id":"openstack%2Fwatcher~stable%2F2024.2~Ic401fe2e8c67df84581f236f344c1b4b52a334e3","project":"openstack/watcher","branch":"stable/2024.2","attention_set":{},"removed_from_attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2026-04-30 09:32:30.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ic401fe2e8c67df84581f236f344c1b4b52a334e3","subject":"Fix check for volume type in cinder helper migrate","status":"ABANDONED","created":"2026-03-06 09:45:27.000000000","updated":"2026-04-30 09:32:30.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09cd77ba49e5b0525d6e521ad48320a103fe09a4","_number":979134,"virtual_id_number":979134,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-03-06 11:05:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-06 11:05:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-30 09:32:29.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"7dfbd0b6e25ca5f7bc1eebf8e8e45709450390d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-03-06 09:45:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7815d2fb58fac68997625cb757cbdf59289f02a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-06 11:05:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/c208af8463494f9e88f1fdc272047349\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9ef4624d616f4e97ab3e0fb7b9f551c5 : FAILURE in 3m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fddaf7ce8b4a4cf98e8bc52c7bf3b567 : FAILURE in 2m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6ab1b8d3d5f7441e854fb32cc0c8030d : FAILURE in 3m 13s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/33f55312ed014facae98c16b2cc682c8 : FAILURE in 4m 04s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/37bc6c284ba44c9f90e4936fc0141217 : FAILURE in 3m 46s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/73732b0ad11e4caeb5a329417ad20ef9 : FAILURE in 4m 04s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/1f85b69bada74353802ae75f21307c20 : SUCCESS in 45m 30s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/337f48fac8d343a69768e0c6d75382d6 : SUCCESS in 1h 09m 13s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/ff6c69aa599e4bc8a8123000732db6d4 : SUCCESS in 34m 24s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/a5457a86448748a09c7946520a6d581e : SUCCESS in 29m 44s","accounts_in_message":[],"_revision_number":1},{"id":"09cd77ba49e5b0525d6e521ad48320a103fe09a4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2026-04-30 09:32:30.000000000","message":"Abandoned\n\nstable/2024.2 branch of openstack/watcher transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"293e8366e3ef26f2e0980daadaa63258cd1ec21b","revisions":{"293e8366e3ef26f2e0980daadaa63258cd1ec21b":{"kind":"REWORK","_number":1,"created":"2026-03-06 09:45:27.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/34/979134/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/34/979134/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/979134/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/979134/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/979134/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/34/979134/1"}}},"commit":{"parents":[{"commit":"b604f9e4eafe1957de52640cd65ecaeacaa7b0f9","subject":"Check result of retype action based on type and status","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b604f9e4eafe1957de52640cd65ecaeacaa7b0f9"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2025-10-13 09:03:47.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-03-06 09:45:02.000000000","tz":60},"subject":"Fix check for volume type in cinder helper migrate","message":"Fix check for volume type in cinder helper migrate\n\nUse all the extra_specs from the volume types when trying to determine\nwhether a volume can be migrated to a destination pool. Before this\npatch, it only checked if the \u0027volume_backend_name\u0027 of the volume type\nmatched the one from the pool\u0027s backend. With this change, volume types\nwith no extra_specs are considered a match for any pool, and all fields\nin the types extra_specs are checked against the pool capabilities.\n\nA pool with no capabilities reported is considered to match any volume\ntype, with the idea of being permissive and letting the migration\ncontinue and allowing cinder to do a proper evaluation of whether the\nmigration can be done, and fail the migration otherwise.\n\nThe test helper methods (fake_pool, fake_volume_type, fake_volume)\nwere enhanced to use proper mock specs and support the to_dict()\nmethod required by get_volume_types_for_pool. The migrate tests\nwere updated to use these improved helpers and properly mock the\nget_storage_pool_by_name method.\n\nThe backendname_from_poolname is removed since it\u0027s no longer used\nthrought the codebase.\n\nAssisted-By: claude-code (claude-sonnet-4.5)\n\nCloses-Bug: 2127485\nChange-Id: Ic401fe2e8c67df84581f236f344c1b4b52a334e3\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n(cherry picked from commit b3595d77a755645d68332a9f153c5596b295e1d3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/293e8366e3ef26f2e0980daadaa63258cd1ec21b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/293e8366e3ef26f2e0980daadaa63258cd1ec21b"}]},"branch":"refs/heads/stable/2024.2"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
