)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"60752579f6521d00a0558d833b9c89b41a9e6e1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"875d463c_04bee2f1","updated":"2026-03-06 17:57:40.000000000","message":"recheck","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a0b96470448ab75872ee7dc364156ca418eac126","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa2d6b78_7a86f3cb","updated":"2026-03-09 11:07:02.000000000","message":"lgtm, thanks","commit_id":"64164197e0a8ae9e5016567724b13e7a66130ae7"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"5e1a24cd8005a7b4699c12ff35974768a7f27161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c5c26cf_691762a0","updated":"2026-03-10 15:34:43.000000000","message":"recheck","commit_id":"64164197e0a8ae9e5016567724b13e7a66130ae7"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b81e65ec2d59a56d1a6e6dc7ace15fb3d02a581b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4e5b415_ec8b2f9d","updated":"2026-03-10 12:48:43.000000000","message":"recheck ConnectionErrors","commit_id":"64164197e0a8ae9e5016567724b13e7a66130ae7"}],"watcher/decision_engine/strategy/strategies/zone_migration.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ceb533d16c14886edf3c4e75bd7f0994888b6eb2","unresolved":true,"context_lines":[{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d61b62f6_e249c3a4","line":437,"range":{"start_line":437,"start_character":45,"end_line":437,"end_character":53},"updated":"2026-03-06 17:57:18.000000000","message":"If both dst_type and dst_pool are None, will be this message valid? what about dst_type here?","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ed1ace8d938ae53f2aa837dffa984c3ff910395","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6cae92e2_982e40d6","line":437,"range":{"start_line":437,"start_character":45,"end_line":437,"end_character":53},"in_reply_to":"1893a927_bbfd6719","updated":"2026-03-10 11:02:47.000000000","message":"Done","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d94c0019cef633b1384ac11bbe145583cd74eae9","unresolved":true,"context_lines":[{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f93484e3_ec95a1e6","line":437,"range":{"start_line":437,"start_character":45,"end_line":437,"end_character":53},"in_reply_to":"d61b62f6_e249c3a4","updated":"2026-03-06 17:58:34.000000000","message":"it will log none\n\nbut since i would prefer this to be an info log im also ok with rewording this.","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"14846ec58d27f98ab1714a0d229053e9cf5dc242","unresolved":true,"context_lines":[{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1893a927_bbfd6719","line":437,"range":{"start_line":437,"start_character":45,"end_line":437,"end_character":53},"in_reply_to":"f93484e3_ec95a1e6","updated":"2026-03-06 18:09:11.000000000","message":"I\u0027ve updated the message so it\u0027s different if dst_type is None","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"60752579f6521d00a0558d833b9c89b41a9e6e1b","unresolved":true,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                if dst_pool is None:"},{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":441,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ede75fa_ce1bef43","line":438,"range":{"start_line":434,"start_character":20,"end_line":438,"end_character":37},"updated":"2026-03-06 17:57:40.000000000","message":"i think this shold likely be LOG.INFO there is nothign a openstack infra admin (the person who installed/confiugre the service) can do about an incorrectly defiend audit\n\nthat is the domain of the opesntack service admin/end user\n\nso we shoudl not add warning here jsut info logs.\n\nthis is a prexisting issue so we can adress this later","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"14846ec58d27f98ab1714a0d229053e9cf5dc242","unresolved":true,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                if dst_pool is None:"},{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":441,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"83859e67_550e2fdd","line":438,"range":{"start_line":434,"start_character":20,"end_line":438,"end_character":37},"in_reply_to":"1ede75fa_ce1bef43","updated":"2026-03-06 18:09:11.000000000","message":"I\u0027ll send a new patchset for the log content, so I can change it here","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"591ce33e29dcc674362cdaf627e14dda67013fd5","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                if dst_pool is None:"},{"line_number":434,"context_line":"                    LOG.warning(\"volume %s will not be migrated because \""},{"line_number":435,"context_line":"                                \"it already has type %s and \u0027dst_pool\u0027\""},{"line_number":436,"context_line":"                                \" was not specified for src_pool %s\","},{"line_number":437,"context_line":"                                volume.name, dst_type,"},{"line_number":438,"context_line":"                                pool)"},{"line_number":439,"context_line":"                    continue"},{"line_number":440,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":441,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d470f98f_b3d221eb","line":438,"range":{"start_line":434,"start_character":20,"end_line":438,"end_character":37},"in_reply_to":"83859e67_550e2fdd","updated":"2026-03-06 18:38:12.000000000","message":"Acknowledged","commit_id":"c18234548bf70c62e0d12c2f034fb81704235018"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"591ce33e29dcc674362cdaf627e14dda67013fd5","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            LOG.debug(\"%s %s\", dst_pool, dst_type)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                type_msg \u003d \"\""},{"line_number":434,"context_line":"                if dst_type is not None:"},{"line_number":435,"context_line":"                    type_msg \u003d f\"it already has type {dst_type} and \""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"                if dst_pool is None:"},{"line_number":438,"context_line":"                    LOG.info("},{"line_number":439,"context_line":"                        \"volume %s will not be migrated because %s\u0027dst_pool\u0027 \""},{"line_number":440,"context_line":"                        \"was not specified for src_pool %s\","},{"line_number":441,"context_line":"                        volume.name, type_msg, pool"},{"line_number":442,"context_line":"                    )"},{"line_number":443,"context_line":"                    continue"},{"line_number":444,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":445,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"704564cd_b150cd5e","line":442,"range":{"start_line":433,"start_character":16,"end_line":442,"end_character":21},"updated":"2026-03-06 18:38:12.000000000","message":"This is hard to follow how about this instead \n```suggestion\n               \n                if dst_pool is None:\n                    type_msg \u003d (\n                        \"\" if dst_type is None else\n                        f\"it already has type {dst_type} and \")\n                    LOG.info(\n                        \"volume %s will not be migrated because %s\u0027dst_pool\u0027 \"\n                        \"was not specified for src_pool %s\",\n                        volume.name, type_msg, pool\n                    )\n```","commit_id":"c81a4b5cb2957ee850ab019b4984e5c993cd8e6e"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"20d4a37169b29877f30ccccaf5aadf1693defd5e","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            LOG.debug(\"%s %s\", dst_pool, dst_type)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                type_msg \u003d \"\""},{"line_number":434,"context_line":"                if dst_type is not None:"},{"line_number":435,"context_line":"                    type_msg \u003d f\"it already has type {dst_type} and \""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"                if dst_pool is None:"},{"line_number":438,"context_line":"                    LOG.info("},{"line_number":439,"context_line":"                        \"volume %s will not be migrated because %s\u0027dst_pool\u0027 \""},{"line_number":440,"context_line":"                        \"was not specified for src_pool %s\","},{"line_number":441,"context_line":"                        volume.name, type_msg, pool"},{"line_number":442,"context_line":"                    )"},{"line_number":443,"context_line":"                    continue"},{"line_number":444,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":445,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c39f71d9_44a855bc","line":442,"range":{"start_line":433,"start_character":16,"end_line":442,"end_character":21},"in_reply_to":"704564cd_b150cd5e","updated":"2026-03-09 09:07:12.000000000","message":"that looks a bit simpler, thanks!","commit_id":"c81a4b5cb2957ee850ab019b4984e5c993cd8e6e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ed1ace8d938ae53f2aa837dffa984c3ff910395","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            LOG.debug(\"%s %s\", dst_pool, dst_type)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"            if dst_type is None or src_type \u003d\u003d dst_type:"},{"line_number":433,"context_line":"                type_msg \u003d \"\""},{"line_number":434,"context_line":"                if dst_type is not None:"},{"line_number":435,"context_line":"                    type_msg \u003d f\"it already has type {dst_type} and \""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"                if dst_pool is None:"},{"line_number":438,"context_line":"                    LOG.info("},{"line_number":439,"context_line":"                        \"volume %s will not be migrated because %s\u0027dst_pool\u0027 \""},{"line_number":440,"context_line":"                        \"was not specified for src_pool %s\","},{"line_number":441,"context_line":"                        volume.name, type_msg, pool"},{"line_number":442,"context_line":"                    )"},{"line_number":443,"context_line":"                    continue"},{"line_number":444,"context_line":"                self._volume_migrate(volume, dst_pool)"},{"line_number":445,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"921882ae_1a7c8b30","line":442,"range":{"start_line":433,"start_character":16,"end_line":442,"end_character":21},"in_reply_to":"c39f71d9_44a855bc","updated":"2026-03-10 11:02:47.000000000","message":"Done","commit_id":"c81a4b5cb2957ee850ab019b4984e5c993cd8e6e"}]}