)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e309dff3fd69084c720b54345dd08a6318457c55","unresolved":true,"context_lines":[{"line_number":16,"context_line":"- Migrate [codespell] to [tool.codespell]"},{"line_number":17,"context_line":"- Add [tool.setuptools.packages.find] for auto-discovery"},{"line_number":18,"context_line":"- Reduce setup.cfg to a minimal [metadata] name stub"},{"line_number":19,"context_line":"- Remove setup.py (no longer needed with pbr build backend)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Generated-By: claude-code sonnet 4.6"},{"line_number":22,"context_line":"Change-Id: I9259fd7168d5df3188dc6242fcff16405cfaf793"},{"line_number":23,"context_line":"Signed-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"91d61418_8215025c","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":1},"updated":"2026-03-20 21:53:07.000000000","message":"oh i forgot to revmoet this before pushing.\nwe  can remove setup.py now but i didnt in this change\n\ni might propsoe that in a followup\nin most other project where we have done this we did not","commit_id":"d98737660b4c36763fd8af34146eb403c021b8f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e3390cdb23e7feb7fb37d46a50235a52d90c69d","unresolved":true,"context_lines":[{"line_number":16,"context_line":"- Migrate [codespell] to [tool.codespell]"},{"line_number":17,"context_line":"- Add [tool.setuptools.packages.find] for auto-discovery"},{"line_number":18,"context_line":"- Reduce setup.cfg to a minimal [metadata] name stub"},{"line_number":19,"context_line":"- Remove setup.py (no longer needed with pbr build backend)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Generated-By: claude-code sonnet 4.6"},{"line_number":22,"context_line":"Change-Id: I9259fd7168d5df3188dc6242fcff16405cfaf793"},{"line_number":23,"context_line":"Signed-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b6a10200_a8bf0d56","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"1917cbe3_d19284d6","updated":"2026-03-23 12:37:25.000000000","message":"im going to check what oslo and some of the other proejct that have alreday done this have done and do the same.\nif they have started removeing setup.py since the PTI was updated to remove using it ill do the same.\nif they have not ill update the commit message","commit_id":"d98737660b4c36763fd8af34146eb403c021b8f2"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"455c6a60def13cb20e3b36a5901e24d931bc5ac3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"- Migrate [codespell] to [tool.codespell]"},{"line_number":17,"context_line":"- Add [tool.setuptools.packages.find] for auto-discovery"},{"line_number":18,"context_line":"- Reduce setup.cfg to a minimal [metadata] name stub"},{"line_number":19,"context_line":"- Remove setup.py (no longer needed with pbr build backend)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Generated-By: claude-code sonnet 4.6"},{"line_number":22,"context_line":"Change-Id: I9259fd7168d5df3188dc6242fcff16405cfaf793"},{"line_number":23,"context_line":"Signed-off-by: Sean Mooney \u003cwork@seanmooney.info\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1917cbe3_d19284d6","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"91d61418_8215025c","updated":"2026-03-23 11:59:20.000000000","message":"I\u0027m ok either way, we just need to make sure the commit msg and change are in sync","commit_id":"d98737660b4c36763fd8af34146eb403c021b8f2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7cbe2a2b67ad7d475989fd6b464051f670ebaa37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d349183f_2ca7b724","updated":"2026-09-01 22:15:22.000000000","message":"LGTM","commit_id":"8599261212fa5eab6444a1b2ea9d55af6e6d3207"}],"pyproject.toml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4cf7c5dada3f24c87da35305da5b91f88aad9913","unresolved":true,"context_lines":[{"line_number":118,"context_line":"storage \u003d \"watcher.decision_engine.model.collector.cinder:CinderClusterDataModelCollector\""},{"line_number":119,"context_line":"baremetal \u003d \"watcher.decision_engine.model.collector.ironic:BaremetalClusterDataModelCollector\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[tool.setuptools.packages.find]"},{"line_number":122,"context_line":"where \u003d [\".\"]"},{"line_number":123,"context_line":"include \u003d [\"watcher*\"]"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-toml","patch_set":2,"id":"73592c67_46dbc9af","line":121,"in_reply_to":"c78bdfa7_03cc4e6b","updated":"2026-03-23 21:01:25.000000000","message":"hum\n\nso yes this is ture\n\nim conflicted because thsi fucntionatliy is deprecated for removal in setuptool\nso we should not rely on it long term\n\n\nbut we can port it for now via something like \n```\n[tool.setuptools.data-files]\n\"etc/nova\" \u003d [\n    \"etc/nova/api-paste.ini\",\n    \"etc/nova/rootwrap.conf\",\n]\n\"etc/nova/rootwrap.d\" \u003d [\n    \"etc/nova/rootwrap.d/*\",\n]\n```\nhttps://github.com/openstack/nova/blob/master/pyproject.toml#L99C1-L106C2\nso we proably shoudl do that for now.\n\nthe lack of the wsgi script however is sort of intentional\n\n\nthis clean up shoudl likly be defert to a diffnt commit so ill restore the prvious behviro for now.","commit_id":"c5aa1f0d778f5f482a18dc557a3f87d22870670b"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"6dca6509d5b0adde4542d848294719b733e98e89","unresolved":false,"context_lines":[{"line_number":118,"context_line":"storage \u003d \"watcher.decision_engine.model.collector.cinder:CinderClusterDataModelCollector\""},{"line_number":119,"context_line":"baremetal \u003d \"watcher.decision_engine.model.collector.ironic:BaremetalClusterDataModelCollector\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[tool.setuptools.packages.find]"},{"line_number":122,"context_line":"where \u003d [\".\"]"},{"line_number":123,"context_line":"include \u003d [\"watcher*\"]"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-toml","patch_set":3,"id":"1471fab8_a13dd939","line":121,"updated":"2026-09-01 18:00:40.000000000","message":"The removed setup.cfg [files] section declared `data_files \u003d etc/ \u003d etc/*`, which installed the sample Apache vhost (etc/apache2/watcher) and the oslo-config-generator/oslo-policy-generator templates (etc/watcher/oslo-config-generator/watcher.conf, etc/watcher/oslo-policy-generator/watcher-policy-generator.conf, etc/watcher/README-watcher.conf.txt) under \u003csys.prefix\u003e/etc/. The migration adds no replacement (pyproject.toml only configures [tool.setuptools.packages.find]) and the commit message, which claims to \u0027move all package metadata, entry points, console scripts, and tool config\u0027, never mentions a removal. This is a functional regression in the built artifact, not just a metadata move.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Distro packagers and pip installs of python-watcher no longer receive the sample apache2 vhost or the config/policy generator templates under \u003csys.prefix\u003e/etc/. Workflows that reference the installed template path (for example `oslo-config-generator --config-file \u003cprefix\u003e/etc/watcher/oslo-config-generator/watcher.conf`) or downstream packaging that ships these files will silently break after this change lands.\n\n**Suggestion**:\nEither restore the files (for example a [tool.setuptools.data-files] section mapping the etc/ entries, or retain the data_files stanza in setup.cfg alongside the name stub), or, if dropping them is intentional since wheels discourage data-files, state the removal explicitly in the commit message and add a release note so operators and downstream packagers are warned before upgrade.","commit_id":"d56bba5e17dddee5be9121e4699ac8aec0dbc8a3"}]}