)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f90e14a94eaecd9cf68277161ac2d1e537f7fd37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6807801_25e1a352","updated":"2026-04-21 10:36:44.000000000","message":"+1 on not having the alsisas but -1 on rexporing them a diffent way and directly imorting the classes","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"62b9cfe2e44ead41474792a984f1894b1ad5f959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86028dbc_9ab7e84d","updated":"2026-04-28 10:01:57.000000000","message":"Thanks for the fix!","commit_id":"f420c168ad0d80b54ca9ef0ea4394e9750025e14"}],"watcher/objects/fields.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f90e14a94eaecd9cf68277161ac2d1e537f7fd37","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_versionedobjects import fields"},{"line_number":21,"context_line":"from oslo_versionedobjects.fields import BaseEnumField"},{"line_number":22,"context_line":"from oslo_versionedobjects.fields import BooleanField"},{"line_number":23,"context_line":"from oslo_versionedobjects.fields import DateTimeField"},{"line_number":24,"context_line":"from oslo_versionedobjects.fields import Enum"},{"line_number":25,"context_line":"from oslo_versionedobjects.fields import FloatField"},{"line_number":26,"context_line":"from oslo_versionedobjects.fields import IntegerField"},{"line_number":27,"context_line":"from oslo_versionedobjects.fields import ListOfStringsField"},{"line_number":28,"context_line":"from oslo_versionedobjects.fields import NonNegativeFloatField"},{"line_number":29,"context_line":"from oslo_versionedobjects.fields import NonNegativeIntegerField"},{"line_number":30,"context_line":"from oslo_versionedobjects.fields import ObjectField"},{"line_number":31,"context_line":"from oslo_versionedobjects.fields import StringField"},{"line_number":32,"context_line":"from oslo_versionedobjects.fields import UnspecifiedDefault"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"aae02ef5_397ba1b3","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":59},"updated":"2026-04-21 10:36:44.000000000","message":"the correct thing to do is import from oslo_versionedobjects import fields\nwhen required and use  fields.* as needed","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7db4268ee1ce826eded90fd86a4e96bcbdbb18d6","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_versionedobjects import fields"},{"line_number":21,"context_line":"from oslo_versionedobjects.fields import BaseEnumField"},{"line_number":22,"context_line":"from oslo_versionedobjects.fields import BooleanField"},{"line_number":23,"context_line":"from oslo_versionedobjects.fields import DateTimeField"},{"line_number":24,"context_line":"from oslo_versionedobjects.fields import Enum"},{"line_number":25,"context_line":"from oslo_versionedobjects.fields import FloatField"},{"line_number":26,"context_line":"from oslo_versionedobjects.fields import IntegerField"},{"line_number":27,"context_line":"from oslo_versionedobjects.fields import ListOfStringsField"},{"line_number":28,"context_line":"from oslo_versionedobjects.fields import NonNegativeFloatField"},{"line_number":29,"context_line":"from oslo_versionedobjects.fields import NonNegativeIntegerField"},{"line_number":30,"context_line":"from oslo_versionedobjects.fields import ObjectField"},{"line_number":31,"context_line":"from oslo_versionedobjects.fields import StringField"},{"line_number":32,"context_line":"from oslo_versionedobjects.fields import UnspecifiedDefault"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5d917315_518b4470","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":59},"in_reply_to":"0de39b7f_af364199","updated":"2026-04-21 14:58:07.000000000","message":"Done","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"537f897feb7808787604feb2062bd0aa3f265582","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_versionedobjects import fields"},{"line_number":21,"context_line":"from oslo_versionedobjects.fields import BaseEnumField"},{"line_number":22,"context_line":"from oslo_versionedobjects.fields import BooleanField"},{"line_number":23,"context_line":"from oslo_versionedobjects.fields import DateTimeField"},{"line_number":24,"context_line":"from oslo_versionedobjects.fields import Enum"},{"line_number":25,"context_line":"from oslo_versionedobjects.fields import FloatField"},{"line_number":26,"context_line":"from oslo_versionedobjects.fields import IntegerField"},{"line_number":27,"context_line":"from oslo_versionedobjects.fields import ListOfStringsField"},{"line_number":28,"context_line":"from oslo_versionedobjects.fields import NonNegativeFloatField"},{"line_number":29,"context_line":"from oslo_versionedobjects.fields import NonNegativeIntegerField"},{"line_number":30,"context_line":"from oslo_versionedobjects.fields import ObjectField"},{"line_number":31,"context_line":"from oslo_versionedobjects.fields import StringField"},{"line_number":32,"context_line":"from oslo_versionedobjects.fields import UnspecifiedDefault"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"0de39b7f_af364199","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":59},"in_reply_to":"3336bf2d_ffb847dd","updated":"2026-04-21 11:19:51.000000000","message":"well in this file you dont need to alias it\n\nwe only use as when it would be a conflict\n\nwe do `from watcher.objects import fields as wfields` to avoid confilcty with the fileds value in the clases so ovo_fields woudl be fine\n\n\nwe coudl also wait for the new ovo release that suprpot the new way of declaring field with the data class style aprpoch and just port directly to that.\n\nif your busy we can just do that for you once that is aviable in uc.\nbut if you do respine im ok with either approch","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c1b7a3d555b1fbd1351b24bb7c474681aeb392a7","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_serialization import jsonutils"},{"line_number":20,"context_line":"from oslo_versionedobjects import fields"},{"line_number":21,"context_line":"from oslo_versionedobjects.fields import BaseEnumField"},{"line_number":22,"context_line":"from oslo_versionedobjects.fields import BooleanField"},{"line_number":23,"context_line":"from oslo_versionedobjects.fields import DateTimeField"},{"line_number":24,"context_line":"from oslo_versionedobjects.fields import Enum"},{"line_number":25,"context_line":"from oslo_versionedobjects.fields import FloatField"},{"line_number":26,"context_line":"from oslo_versionedobjects.fields import IntegerField"},{"line_number":27,"context_line":"from oslo_versionedobjects.fields import ListOfStringsField"},{"line_number":28,"context_line":"from oslo_versionedobjects.fields import NonNegativeFloatField"},{"line_number":29,"context_line":"from oslo_versionedobjects.fields import NonNegativeIntegerField"},{"line_number":30,"context_line":"from oslo_versionedobjects.fields import ObjectField"},{"line_number":31,"context_line":"from oslo_versionedobjects.fields import StringField"},{"line_number":32,"context_line":"from oslo_versionedobjects.fields import UnspecifiedDefault"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__all__ \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3336bf2d_ffb847dd","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":59},"in_reply_to":"aae02ef5_397ba1b3","updated":"2026-04-21 11:05:09.000000000","message":"Yeah, either works for me. Do you want this reworked so every object instance uses fields from an e.g. `ovo_fields` import alias so?","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"512cfd1fd9c3c982e1220a193a06b6ab0be6af58","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from oslo_versionedobjects.fields import UnspecifiedDefault"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"__all__ \u003d ["},{"line_number":36,"context_line":"    \"BaseEnumField\","},{"line_number":37,"context_line":"    \"BooleanField\","},{"line_number":38,"context_line":"    \"DateTimeField\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ecf1240e_2f2cc164","line":35,"updated":"2026-04-21 10:03:31.000000000","message":"This is a (better, IMO) alternative to `# noqa` on all the above imports.","commit_id":"0b51bcae8ba9d3f3b2752be53e3b07759b520df2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fcebe5ee6c48692086fccec6e0cec8a369ff0f5e","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from oslo_versionedobjects import fields"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"__all__ \u003d ["},{"line_number":24,"context_line":"    \"DictField\","},{"line_number":25,"context_line":"    \"FlexibleDictField\","},{"line_number":26,"context_line":"    \"FlexibleListOfDictField\","}],"source_content_type":"text/x-python","patch_set":2,"id":"f9dd00b7_b12719a5","line":23,"updated":"2026-04-21 12:05:28.000000000","message":"ideally we woudl also not have this.","commit_id":"f420c168ad0d80b54ca9ef0ea4394e9750025e14"}]}
