)]}'
{"releasenotes/notes/keystoneclient-openstacksdk-migration-23fe0611b0052209.yaml":[{"robot_id":"zuul","robot_run_id":"080f737bd38f4606b54bae0c592c95f4","url":"https://zuul.teim.app/t/main/buildset/080f737bd38f4606b54bae0c592c95f4","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"acc42e11c92250402a71baf649941d65a5c8913b","patch_set":1,"id":"4630255b_fbce63d9","line":13,"updated":"2026-05-04 09:15:22.000000000","message":"The release note in keystoneclient-openstacksdk-migration-23fe0611b0052209.yaml wraps the added line at column 80 but the preceding lines wrap differently, making the paragraph formatting inconsistent.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Consistent wrapping in release notes improves readability for operators reviewing upgrade documentation.\n\n**Recommendation**:\nConsider reformatting the \u0027other\u0027 section to be a single unwrapped line or consistently wrap all lines at the same column for a cleaner diff.","commit_id":"03933bbb650c51d1c1b9f27db4a0b1ffebb9c932"},{"robot_id":"zuul","robot_run_id":"673264abd3a84498829ed69f0b5daa37","url":"https://zuul.teim.app/t/main/buildset/673264abd3a84498829ed69f0b5daa37","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b947461ea47360540b46d8ad046408bdc8f39511","patch_set":3,"id":"134f5d9f_031ea88b","line":15,"updated":"2026-05-04 12:11:55.000000000","message":"Release note says \u0027Usage of keystoneclient has been removed\u0027 but the keystone_client config group help strings in watcher/conf/keystone_client.py and watcher/conf/aetos_client.py still reference \u0027keystoneclient\u0027 as a descriptive noun, which could confuse operators reading the config.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Operators reading config help strings will see references to \u0027keystoneclient\u0027 and may think the package is still required or that the migration is incomplete.\n\n**Suggestion**:\nConsider updating the help strings in watcher/conf/keystone_client.py and watcher/conf/aetos_client.py to reference \u0027openstacksdk\u0027 or \u0027keystoneauth1\u0027 instead of \u0027keystoneclient\u0027. This is not strictly required for this patch but would improve consistency as a follow-up.","commit_id":"aa4eae7e44651e44e204682f8f7f55e1fc3de7b3"},{"robot_id":"zuul","robot_run_id":"673264abd3a84498829ed69f0b5daa37","url":"https://zuul.teim.app/t/main/buildset/673264abd3a84498829ed69f0b5daa37","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b947461ea47360540b46d8ad046408bdc8f39511","patch_set":3,"id":"fcb817a4_2418159d","line":15,"updated":"2026-05-04 12:11:55.000000000","message":"The release note other section combines two statements on one line after the edit. Consider splitting into a separate bullet point for better readability in rendered release notes.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Improved readability of release notes for operators tracking the migration timeline.\n\n**Recommendation**:\nSplit the combined statement into two separate bullet points under \u0027other:\u0027 -- one for the openstacksdk support addition and one for the keystoneclient removal.","commit_id":"aa4eae7e44651e44e204682f8f7f55e1fc3de7b3"}],"watcher/common/exception.py":[{"robot_id":"zuul","robot_run_id":"673264abd3a84498829ed69f0b5daa37","url":"https://zuul.teim.app/t/main/buildset/673264abd3a84498829ed69f0b5daa37","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b947461ea47360540b46d8ad046408bdc8f39511","patch_set":3,"id":"9f9d58a0_d847e103","line":29,"updated":"2026-05-04 12:11:55.000000000","message":"The exception import change from keystoneclient.exceptions to keystoneauth1.exceptions is correct and safe. Both libraries expose AuthorizationFailure and ClientException with compatible interfaces.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Validates that the exception handling path remains functionally equivalent after the migration.\n\n**Recommendation**:\nNo action needed. This is a confirmation that the change is correct. The keystoneauth1 library is already a dependency and provides the same exception hierarchy.","commit_id":"aa4eae7e44651e44e204682f8f7f55e1fc3de7b3"}],"watcher/tests/unit/decision_engine/cluster/test_cinder_cdmc.py":[{"robot_id":"zuul","robot_run_id":"080f737bd38f4606b54bae0c592c95f4","url":"https://zuul.teim.app/t/main/buildset/080f737bd38f4606b54bae0c592c95f4","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"acc42e11c92250402a71baf649941d65a5c8913b","patch_set":1,"id":"50384241_26a07e18","line":28,"updated":"2026-05-04 09:15:22.000000000","message":"The test files test_cinder_cdmc.py and test_nova_cdmc.py previously had @mock.patch decorators targeting keystoneclient.v3.client.Client that were never actually consumed by the test methods (no corresponding mock parameter), confirming these were vestigial and safe to remove.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Acknowledging that the removed mock patches were already dead code validates the correctness of the removal and provides confidence in the change.\n\n**Recommendation**:\nNo action needed. This is an observation confirming the removal was correct -- the @mock.patch decorators had no corresponding positional argument in the test method signatures, meaning they were silently creating unused mocks.","commit_id":"03933bbb650c51d1c1b9f27db4a0b1ffebb9c932"},{"robot_id":"zuul","robot_run_id":"673264abd3a84498829ed69f0b5daa37","url":"https://zuul.teim.app/t/main/buildset/673264abd3a84498829ed69f0b5daa37","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b947461ea47360540b46d8ad046408bdc8f39511","patch_set":3,"id":"ca83a2b8_33ba2ae2","line":28,"updated":"2026-05-04 12:11:55.000000000","message":"The removal of the @mock.patch(\u0027keystoneclient.v3.client.Client\u0027) decorators from test_cinder_cdmc.py and test_nova_cdmc.py is correct since those mocks were no longer exercising any real code path. Verify these tests still pass without the mocks.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Confirms the test suite is not silently losing coverage of keystone-related functionality.\n\n**Recommendation**:\nRun the specific test files to confirm all tests pass: tox -e py3 -- watcher.tests.unit.decision_engine.cluster.test_cinder_cdmc watcher.tests.unit.decision_engine.cluster.test_nova_cdmc","commit_id":"aa4eae7e44651e44e204682f8f7f55e1fc3de7b3"}]}