)]}'
{"watcher/decision_engine/strategy/strategies/workload_stabilization.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"dd09c07e8b9a8bc9163a7e6413343be47613de8d","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            )"},{"line_number":753,"context_line":"            self.periods[\u0027compute_node\u0027] \u003d self.periods[\u0027node\u0027]"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @track_time(\u0027time_do_execute\u0027)"},{"line_number":756,"context_line":"    def do_execute(self, audit\u003dNone):"},{"line_number":757,"context_line":"        overall_start \u003d time.time()"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"316a891e_2e46dc6e","line":755,"updated":"2026-08-26 20:04:14.000000000","message":"do_execute is wrapped with @track_time(\u0027time_do_execute\u0027), but that accumulated stat is never reported anywhere. Instead, do_execute re-implements the same measurement manually with overall_start/total_time. Two parallel timing mechanisms for one method can drift when edited and the decorator stat is dead instrumentation.\n\n**Severity**: SUGGESTION | **Confidence**: 0.85\n\n**Impact**: Dead state (\u0027time_do_execute\u0027) invites confusion about which timing is authoritative, and future edits to one mechanism (e.g., switching to a monotonic clock or reporting total time from stats) can silently diverge from the other.\n\n**Recommendation**:\nEither report the decorator-collected stat in the summary (e.g., add a \u0027  - Total execution time (tracked): %.2f\u0027 line using self.stats[\u0027time_do_execute\u0027]) and drop the manual overall_start, or remove the \u0027time_do_execute\u0027 stat and the decorator on do_execute.","commit_id":"d7c652d364294eba98004d969d59011d6e0f951f"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"dd09c07e8b9a8bc9163a7e6413343be47613de8d","unresolved":false,"context_lines":[{"line_number":874,"context_line":"                self.sd_before_audit,"},{"line_number":875,"context_line":"                self.sd_after_audit,"},{"line_number":876,"context_line":"                ("},{"line_number":877,"context_line":"                    (self.sd_before_audit - self.sd_after_audit)"},{"line_number":878,"context_line":"                    / self.sd_before_audit"},{"line_number":879,"context_line":"                    * 100"},{"line_number":880,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba46ef41_dab00207","line":877,"updated":"2026-08-26 20:04:14.000000000","message":"The new performance summary computes improvement as (sd_before_audit - sd_after_audit) / sd_before_audit * 100. sd_after_audit is initialized to 0 in __init__ and is only updated inside the apply-loop branch that actually performs a migration. If check_threshold returns candidates but none are applied, the summary reports a 100.00% improvement that never happened.\n\n**Severity**: WARNING | **Confidence**: 0.85\n\n**Impact**: Operators reading the summary get a clearly wrong result (100% improvement with 0 migrations applied). Since the patch\u0027s stated purpose is to print accurate statistics, this directly defeats that purpose for a reachable edge case (all candidates rejected by the destination-disk check).\n\n**Suggestion**:\nCompute the improvement only when a migration was applied and sd_after_audit was set, e.g. guard with migrations_applied \u003e 0 (or a sentinel like sd_after_audit \u003d sd_before_audit initially); otherwise print 0.0 or \u0027n/a\u0027.","commit_id":"d7c652d364294eba98004d969d59011d6e0f951f"}]}