)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2145736214ba4c42dc318bb1a40d1ef59be85ba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c07e4f7f_20db0a4c","updated":"2026-05-21 13:17:15.000000000","message":"check-rdo","commit_id":"84cb9de58af7b124ce19b37ec13741e25120d3cc"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"3cdfdfca92a1228c5cf63366b68fa619683c1d7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7b764d0_7aabe21f","updated":"2026-05-20 09:17:51.000000000","message":"recheck","commit_id":"84cb9de58af7b124ce19b37ec13741e25120d3cc"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"56da6eb4dbcc62ee827f9121180bb49b16043fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8c5a88d_6de5629c","updated":"2026-05-29 18:03:41.000000000","message":"thanks for the updates, this lgtm","commit_id":"dcc44fe724df7917dd33525def6cd61bc415fd33"}],"watcher/common/base_helper.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8c8465a3c555cc5f260f193470492ee0d42d8bf0","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d conf.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class BaseHelper:"},{"line_number":29,"context_line":"    \"\"\"Base class for OpenStack service helpers."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Provides common functionality for creating OpenStackSDK"}],"source_content_type":"text/x-python","patch_set":3,"id":"07e0ee88_21459d8e","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":16},"updated":"2026-05-28 18:56:45.000000000","message":"Not sure what is expected to be added in here in the future, but it could be named BaseConnectionHelper perhaps. It could be also a mixin class and the service name would be a parameter for the create connection function.","commit_id":"e31b5c596e8c139daaa89f5110d2ed9a3263dfe8"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b8b57f9fa744bef1c91e02312ce0942d681b69e3","unresolved":true,"context_lines":[{"line_number":25,"context_line":"CONF \u003d conf.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class BaseHelper:"},{"line_number":29,"context_line":"    \"\"\"Base class for OpenStack service helpers."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Provides common functionality for creating OpenStackSDK"}],"source_content_type":"text/x-python","patch_set":3,"id":"787c0c8a_5af2c9f8","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":16},"in_reply_to":"07e0ee88_21459d8e","updated":"2026-05-29 08:46:01.000000000","message":"I don\u0027t expect to add much more for now to this class. I like the idea of making it a Mixin, it reflects better the intention, I\u0027ve changed it","commit_id":"e31b5c596e8c139daaa89f5110d2ed9a3263dfe8"}],"watcher/tests/unit/common/test_keystone_helper.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8c8465a3c555cc5f260f193470492ee0d42d8bf0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class TestKeystoneHelperConnection(test.TestCase):"},{"line_number":75,"context_line":"    @mock.patch.object(clients, \u0027get_sdk_connection\u0027, autospec\u003dTrue)"},{"line_number":76,"context_line":"    @mock.patch.object("},{"line_number":77,"context_line":"        ks_loading, \u0027load_auth_from_conf_options\u0027, autospec\u003dTrue"}],"source_content_type":"text/x-python","patch_set":3,"id":"0761b6f8_6ea9ce7f","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":50},"updated":"2026-05-28 18:56:45.000000000","message":"This is not actually testing the keystone_helper anymore, but testing the internals of the BaseHelper, which is already covered in the other test file.","commit_id":"e31b5c596e8c139daaa89f5110d2ed9a3263dfe8"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b8b57f9fa744bef1c91e02312ce0942d681b69e3","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        )"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class TestKeystoneHelperConnection(test.TestCase):"},{"line_number":75,"context_line":"    @mock.patch.object(clients, \u0027get_sdk_connection\u0027, autospec\u003dTrue)"},{"line_number":76,"context_line":"    @mock.patch.object("},{"line_number":77,"context_line":"        ks_loading, \u0027load_auth_from_conf_options\u0027, autospec\u003dTrue"}],"source_content_type":"text/x-python","patch_set":3,"id":"b4029def_6f470e0c","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":50},"in_reply_to":"0761b6f8_6ea9ce7f","updated":"2026-05-29 08:46:01.000000000","message":"yes, it\u0027s duplicating a bit the testing I\u0027ve removed the new tests from keystone_heper and nova_helper test suites","commit_id":"e31b5c596e8c139daaa89f5110d2ed9a3263dfe8"}]}