)]}'
{"devstack/lib/watcher":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"937ceee3a9f7c068ea06a6dd7b277e53118f002f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# configure_watcher() - Set config files, create data dirs, etc"},{"line_number":92,"context_line":"function configure_watcher {"},{"line_number":93,"context_line":"    # Put config files in ``/etc/watcher`` for everyone to find"},{"line_number":94,"context_line":"    sudo install -d -o $STACK_USER $WATCHER_CONF_DIR"},{"line_number":95,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f37880d0_01b918e8","line":92,"updated":"2026-06-20 15:07:37.000000000","message":"Neither change 994178 nor its dependency 961486 adds a release note documenting the devstack policy file handling changes.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: A release note would help developers and operators understand that devstack no longer generates or installs a sample policy file, and that the oslo_policy default (policy.yaml) is now used.\n\n**Recommendation**:\nConsider adding a brief release note under releasenotes/notes/ explaining that the devstack plugin no longer generates or installs a sample policy file and relies on oslo_policy registered defaults.","commit_id":"5a583f780da2039fc73cf528b7fb5044803e7b98"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"937ceee3a9f7c068ea06a6dd7b277e53118f002f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    iniset_rpc_backend watcher $WATCHER_CONF"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    iniset $WATCHER_CONF database connection $(database_connection_url watcher)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    iniset $WATCHER_CONF oslo_messaging_notifications driver \"messagingv2\""},{"line_number":130,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"04af09d6_baaf3509","line":127,"updated":"2026-06-20 15:07:37.000000000","message":"The commit message body for change 994178 is terse and does not explain what the oslo_policy default value actually is (policy.yaml) or why the override was originally needed.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: A more descriptive commit body would help future developers understand the rationale and avoid reintroducing the redundant override.\n\n**Recommendation**:\nIn future changes, consider expanding the commit body to explain what the default value is and briefly why the previous override became unnecessary (e.g., oslo_policy defaults to policy.yaml, and watcher uses registered defaults rather than a static file).","commit_id":"5a583f780da2039fc73cf528b7fb5044803e7b98"}]}