)]}'
{".zuul.yaml":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bad744cfcb5978dbf6dc5e8c76af51b63757baa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- nodeset:"},{"line_number":2,"context_line":"    name: openstack-three-node-noble"},{"line_number":3,"context_line":"    nodes:"},{"line_number":4,"context_line":"      - name: controller"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"28ba13da_76cc0fac","line":1,"updated":"2026-06-22 16:19:44.000000000","message":"Commit message body contains three spelling errors: \u0027enabeld\u0027 (enabled), \u0027addtionally\u0027 (additionally), and \u0027souce\u0027 (source). Commit messages are permanent history and are surfaced in release notes and search.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Reduces professionalism of the project history and makes the change harder to find via search for correct terms (enabled, additionally, source).\n\n**Suggestion**:\nAmend the commit message before merge to fix the three typos: \u0027enabled\u0027, \u0027additionally\u0027, \u0027source\u0027. A codespell pre-commit hook is configured for this repo; running it on the message would catch these.","commit_id":"81a101d07b853973366de47ec5fa4881dfc6024e"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bad744cfcb5978dbf6dc5e8c76af51b63757baa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- nodeset:"},{"line_number":2,"context_line":"    name: openstack-three-node-noble"},{"line_number":3,"context_line":"    nodes:"},{"line_number":4,"context_line":"      - name: controller"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a2c2bcb2_976377f6","line":1,"updated":"2026-06-22 16:19:44.000000000","message":"The commit subject uses a \u0027[ci]\u0027 bracket prefix, which is not an established OpenStack commit-message convention. OpenStack subjects use an imperative verb phrase with no bracket tags (e.g. \u0027Make live migration faster in CI\u0027).\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: Aligning with the documented OpenStack commit-message style keeps git history consistent across the project and avoids implying a tag/namespace that tooling does not recognize.\n\n**Recommendation**:\nDrop the \u0027[ci]\u0027 prefix in favor of a plain imperative subject such as \u0027Make live migration faster in tempest jobs\u0027. Keep it under 50 characters and end without a period.","commit_id":"81a101d07b853973366de47ec5fa4881dfc6024e"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bad744cfcb5978dbf6dc5e8c76af51b63757baa5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          $CINDER_CONF:"},{"line_number":108,"context_line":"            oslo_messaging_notifications:"},{"line_number":109,"context_line":"              driver: messagingv2"},{"line_number":110,"context_line":"          $NOVA_CPU_CONF: \u0026nova_cpu_conf_base"},{"line_number":111,"context_line":"            DEFAULT:"},{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8dec264c_7ff87ee4","line":110,"updated":"2026-06-22 16:19:44.000000000","message":"The aggressive migration timeout (30s with force_complete) and the postcopy switch are presented in the commit body without explaining the expected speedup or the stability tradeoff. Reviewers cannot tell whether 30s was measured or guessed.\n\n**Severity**: SUGGESTION | **Confidence**: 0.7\n\n**Benefit**: A one-line note on the measured migration-time reduction (or a pointer to a periodic-weekly result) lets future contributors reproduce or safely re-tune the values without re-deriving the rationale.\n\n**Recommendation**:\nAdd a short comment in the $NOVA_CPU_CONF block (or a sentence in the commit body) stating the typical migration time observed before/after and that postcopy is intentional for CI speed. An in-file comment is preferable since commit messages are easily overlooked when editing config.","commit_id":"81a101d07b853973366de47ec5fa4881dfc6024e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"631ddc8a207d65cad360b5deb824b10759ff6dc9","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            DEFAULT:"},{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # Use lower TB cache than default(1GiB), only applicable with"},{"line_number":115,"context_line":"              # libvirt\u003e\u003d8.0.0"},{"line_number":116,"context_line":"              tb_cache_size: 128"},{"line_number":117,"context_line":"              live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"},{"line_number":119,"context_line":"              live_migration_timeout_action: \"force_complete\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1105b768_1753b9b5","line":116,"range":{"start_line":114,"start_character":1,"end_line":116,"end_character":32},"updated":"2026-06-22 16:05:44.000000000","message":"this is the defautl in devstack actully so we dont need this","commit_id":"81a101d07b853973366de47ec5fa4881dfc6024e"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"bad744cfcb5978dbf6dc5e8c76af51b63757baa5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"              live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"},{"line_number":119,"context_line":"              live_migration_timeout_action: \"force_complete\""},{"line_number":120,"context_line":"              live_migration_completion_timeout: 30"},{"line_number":121,"context_line":"            compute:"},{"line_number":122,"context_line":"              # Switch off the provider association refresh, which should"},{"line_number":123,"context_line":"              # reduce the number of placement calls in steady state. Added in"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"27e60962_96180fa1","line":120,"updated":"2026-06-22 16:19:44.000000000","message":"live_migration_completion_timeout: 30 is far below Nova\u0027s 800s default. With force_complete and postcopy, each still-running migration is force-switched to postcopy after 30s. At 4 concurrent migrations on 2-core / 2GB CI nodes this risks migration storms and intermittent failures under memory load.\n\n**Severity**: HIGH | **Confidence**: 0.7\n\n**Risk**: Tempest jobs may become flaky: migrations that legitimately need more than 30s to converge get force-completed to postcopy, and four of them running concurrently on a tiny node can starve CPU and RAM, producing sporadic timeouts or libvirt errors that are hard to attribute.\n\n**Priority**: Before merge\n**Why This Matters**: Aggressive CI tuning that buys speed at the cost of reliability can turn a green gate into a flaky one, eroding trust in the watcher tempest results that block merges.\n\n**Recommendation**:\nEither raise live_migration_completion_timeout to a safer value (e.g. 150-300s) for initial validation, or land it at 30 only after one or two full periodic-weekly runs confirm the two-node jobs stay green. Consider documenting the chosen value in the comment block so future tuners understand the tradeoff was deliberate.","commit_id":"81a101d07b853973366de47ec5fa4881dfc6024e"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"52d9a4aad2a978e7175f911b14f6710bc8f36e72","unresolved":false,"context_lines":[{"line_number":109,"context_line":"              driver: messagingv2"},{"line_number":110,"context_line":"          $NOVA_CPU_CONF: \u0026nova_cpu_conf_base"},{"line_number":111,"context_line":"            DEFAULT:"},{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # This need qemu 10.1.0 to use with post-copy"},{"line_number":115,"context_line":"              # we can evaluate that later as it requires changing"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"26804c7c_e4ff5b51","line":112,"updated":"2026-06-22 17:30:53.000000000","message":"max_concurrent_live_migrations: 4 is defined at the base level but the three-node nodeset (openstack-three-node-noble) runs two compute subnodes plus the controller-as-compute, so up to 4 concurrent migrations could contend on a single host\u0027s network/disk.\n\n**Severity**: SUGGESTION | **Confidence**: 0.6\n\n**Benefit**: Documenting why 4 is safe for these tempest jobs (small instance counts, post-copy) prevents a future reader from assuming the value is tunable upward without consequence.\n\n**Recommendation**:\nConsider a one-line comment noting that 4 concurrent migrations is appropriate because tempest test instances are small and post-copy bounds memory transfer, so contention is acceptable. No code change required.","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"52d9a4aad2a978e7175f911b14f6710bc8f36e72","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            DEFAULT:"},{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # This need qemu 10.1.0 to use with post-copy"},{"line_number":115,"context_line":"              # we can evaluate that later as it requires changing"},{"line_number":116,"context_line":"              # the job to ubuntu 26.04 so prefer post-copy for now."},{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0bfbcfaf_d71a687b","line":114,"updated":"2026-06-22 17:30:53.000000000","message":"The inline comment is contradictory. It says \u0027prefer post-copy for now\u0027 yet the next line enables live_migration_permit_post_copy: true, while the actually-deferred setting (live_migration_parallel_connections) is the one commented out. As written, post-copy reads as the deferred option.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Future maintainers will misread which behaviour is enabled versus deferred, risking accidental enabling of parallel connections before the qemu 10.1.0 dependency is satisfied, or confusion about the post-copy intent.\n\n**Suggestion**:\nReword to separate the two decisions, e.g.: \u0027live_migration_permit_post_copy is enabled to allow source-node cleanup sooner. live_migration_parallel_connections is commented out because it requires qemu 10.1.0 (ubuntu 26.04); revisit once the nodeset is upgraded.\u0027","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9c5befe75e3bdd39078f82a6ce4c219286b353f","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            DEFAULT:"},{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # This need qemu 10.1.0 to use with post-copy"},{"line_number":115,"context_line":"              # we can evaluate that later as it requires changing"},{"line_number":116,"context_line":"              # the job to ubuntu 26.04 so prefer post-copy for now."},{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"735872c9_0c0445fb","line":114,"in_reply_to":"0bfbcfaf_d71a687b","updated":"2026-06-22 17:39:42.000000000","message":"the concern is not really correct but i can reword this\n\nthe this is refering to live_migration_parallel_connections","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"52d9a4aad2a978e7175f911b14f6710bc8f36e72","unresolved":false,"context_lines":[{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # This need qemu 10.1.0 to use with post-copy"},{"line_number":115,"context_line":"              # we can evaluate that later as it requires changing"},{"line_number":116,"context_line":"              # the job to ubuntu 26.04 so prefer post-copy for now."},{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b719efbf_50107db2","line":115,"updated":"2026-06-22 17:30:53.000000000","message":"Spelling error in the added comment: \u0027This need qemu 10.1.0\u0027 should be \u0027This needs qemu 10.1.0\u0027.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Minor, but the comment is part of a newly-added explanatory block that other contributors will read; typos in guidance comments reduce clarity.\n\n**Suggestion**:\nChange \u0027This need qemu 10.1.0\u0027 to \u0027This needs qemu 10.1.0\u0027.","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9c5befe75e3bdd39078f82a6ce4c219286b353f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"              max_concurrent_live_migrations: 4"},{"line_number":113,"context_line":"            libvirt:"},{"line_number":114,"context_line":"              # This need qemu 10.1.0 to use with post-copy"},{"line_number":115,"context_line":"              # we can evaluate that later as it requires changing"},{"line_number":116,"context_line":"              # the job to ubuntu 26.04 so prefer post-copy for now."},{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fd90552e_45524f84","line":115,"in_reply_to":"b719efbf_50107db2","updated":"2026-06-22 17:39:42.000000000","message":"ture","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"52d9a4aad2a978e7175f911b14f6710bc8f36e72","unresolved":false,"context_lines":[{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"},{"line_number":119,"context_line":"              live_migration_timeout_action: \"force_complete\""},{"line_number":120,"context_line":"              live_migration_completion_timeout: 30"},{"line_number":121,"context_line":"        test-config:"},{"line_number":122,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":123,"context_line":"            compute:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dc226783_9a3c3e2c","line":120,"updated":"2026-06-22 17:30:53.000000000","message":"live_migration_completion_timeout is set to 30 seconds. With live_migration_timeout_action: force_complete, Nova forcibly cuts over any migration not done within 30s. For memory-write-intensive tempest workloads this is very tight and can cause migration failures or premature post-copy fallback.\n\n**Severity**: WARNING | **Confidence**: 0.7\n\n**Impact**: Intermittent CI failures if a migration cannot complete or reach a post-copy-safe state within 30s, particularly on the heavier two/three-node jobs (prometheus-realdata, aetos-realdata) that inherit this base.\n\n**Suggestion**:\nConfirm this value holds across the periodic-weekly realdata jobs under load. If failures appear, raise to 60-120s; with post-copy enabled the completion timeout mainly governs the forced-cutover window and can be relaxed without losing the speed benefit.","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9c5befe75e3bdd39078f82a6ce4c219286b353f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"              # live_migration_parallel_connections: 2"},{"line_number":118,"context_line":"              live_migration_permit_post_copy: true"},{"line_number":119,"context_line":"              live_migration_timeout_action: \"force_complete\""},{"line_number":120,"context_line":"              live_migration_completion_timeout: 30"},{"line_number":121,"context_line":"        test-config:"},{"line_number":122,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":123,"context_line":"            compute:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a2a8dca5_610d01aa","line":120,"in_reply_to":"dc226783_9a3c3e2c","updated":"2026-06-22 17:39:42.000000000","message":"so i could actully add a comemnt to explain that for ci i want to force the migration to complete if its is still runnign after 30 even if it causes a guest visabel pause because in ci we dont care.","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"14083c1396f6dab5f7339e2357de0b335952e716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f3ebdce_aef1e57d","updated":"2026-06-22 23:11:57.000000000","message":"i need to configure Userfaultfd\nhttps://github.com/openstack-k8s-operators/edpm-ansible/blob/main/roles/edpm_kernel/vars/main.yml#L105-L106\n\ni will do that in devstack","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9c5befe75e3bdd39078f82a6ce4c219286b353f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13cc4292_1e7d4bfd","updated":"2026-06-22 17:39:42.000000000","message":"im going to end up flipping the order as we need to add a falback for the extended atirbutes when we are updatign the model based on notifictions. ore rethink that test","commit_id":"c19e8f7280a8dbe93508e7627cc9b739034e3515"}]}