)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"a0bcb5d8822af169e3dde1cbc0b7a90336e0b19a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a61a7b4a_d090ae40","updated":"2026-06-26 15:25:22.000000000","message":"create and delete volumes comes from the old swap implementation iirc, no need to maintain that.","commit_id":"22a8b50b5ce18af7c6a1136660367aea3c54774d"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6cb5edccd12633a439cf51d9fa2f3c39692dc598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e44b4ec_92ca177c","updated":"2026-07-02 08:02:43.000000000","message":"recheck","commit_id":"22a8b50b5ce18af7c6a1136660367aea3c54774d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ef9c32e16dffa647b9c3b7b2c31de002ca7da159","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de181d04_f128d6c6","updated":"2026-07-20 18:45:58.000000000","message":"Looks good to me, just remove unused code","commit_id":"075c421f8b25f47b1b736baf1fe5bdd8b8901d2b"}],"watcher/tests/unit/common/test_cinder_helper.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"fe123c28e82bb76a858bbd59e43c5e7bd3022a6b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        volume.name \u003d kwargs.get(\u0027name\u0027, \u0027fakename\u0027)"},{"line_number":159,"context_line":"        volume.size \u003d kwargs.get(\u0027size\u0027, \u00271\u0027)"},{"line_number":160,"context_line":"        volume.status \u003d kwargs.get(\u0027status\u0027, \u0027available\u0027)"},{"line_number":161,"context_line":"        volume.snapshot_id \u003d kwargs.get(\u0027snapshot_id\u0027, None)"},{"line_number":162,"context_line":"        volume.availability_zone \u003d kwargs.get(\u0027availability_zone\u0027, \u0027nova\u0027)"},{"line_number":163,"context_line":"        volume.volume_type \u003d kwargs.get(\u0027volume_type\u0027, \u0027fake_type\u0027)"},{"line_number":164,"context_line":"        volume.migration_status \u003d kwargs.get(\u0027migration_status\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"714cad3e_ac84c5a6","line":161,"updated":"2026-06-25 06:29:57.000000000","message":"The fake_volume() test helper still sets volume.snapshot_id, but the only tests that exercised snapshot_id (test_has_snapshot_success/fail) were removed in this change, leaving that attribute assignment without any consumer.\n\n**Severity**: SUGGESTION | **Confidence**: 0.8\n\n**Benefit**: Removing the now-unused snapshot_id kwarg keeps the test helper accurate and signals intent — the field is no longer relevant to any CinderHelper test path.\n\n**Recommendation**:\nIn the fake_volume() static helper (around line 161), drop the line `volume.snapshot_id \u003d kwargs.get(\u0027snapshot_id\u0027, None)` and the corresponding \u0027snapshot_id\u0027 kwarg handling, since no remaining test reads it. This is optional and non-blocking for merge.","commit_id":"22a8b50b5ce18af7c6a1136660367aea3c54774d"}]}