)]}'
{"id":"openstack%2Fwatcher~994841","triplet_id":"openstack%2Fwatcher~master~Ib44e3a6220d2a4b8581c7cf2e702705a5224be19","project":"openstack/watcher","branch":"master","topic":"use-openstacksdk","attention_set":{"34452":{"account":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"last_update":"2026-06-25 09:16:24.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ib44e3a6220d2a4b8581c7cf2e702705a5224be19","subject":"Remove unused CinderHelper methods","status":"NEW","created":"2026-06-25 06:15:15.000000000","updated":"2026-06-25 09:16:24.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bdf38b33e093dcc9bd126d4badbec333be8af196","_number":994841,"virtual_id_number":994841,"owner":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-06-25 08:27:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"all":[{"value":1,"date":"2026-06-25 09:16:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-25 06:15:27.000000000","updated_by":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"reviewer":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"state":"CC"},{"updated":"2026-06-25 08:27:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-25 09:16:24.000000000","updated_by":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"reviewer":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"state":"REVIEWER"}],"messages":[{"id":"a3c8b9760f3926ac705547840114bc91ef1a1f97","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"date":"2026-06-25 06:15:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d478fb3aed9b901ebf89c434923d9f27a20af46","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2026-06-25 06:15:27.000000000","message":"Patch Set 1:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fe123c28e82bb76a858bbd59e43c5e7bd3022a6b","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2026-06-25 06:29:57.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nBuild succeeded (automatic-ci pipeline).\nhttps://zuul.teim.app/t/main/buildset/f269edae854c48068b9df120e414e78d\n\n- teim-code-review https://zuul.teim.app/t/main/build/c824fe22d88a4262923ad0abd85d1463 : SUCCESS in 14m 21s\n\nWarning:\n  A full-repo search confirms that _has_snapshot, create_volume, and delete_volume on CinderHelper have zero call sites in production code. The other create_volume/delete_volume references in the repo belong to unrelated classes (model_root.ModelRoot, notification cinder.VolumeMapper). Impact: The deletion is safe. No downstream code path in watcher references the removed methods, so there is no regression risk. Recommendation: No action needed. The dead-code removal is correctly scoped and the commit message accurately describes the rationale.","accounts_in_message":[],"_revision_number":1},{"id":"45e6da963102e590eb7235bf4ef275e0644f2ff7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-25 08:27:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/16f5ff2df5ca456183dc78b4da101162\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/667885dac40546a18af81e84d902a4ef : SUCCESS in 8m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35696716e61c42bfa5d417162ebc8876 : SUCCESS in 2m 18s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ce08e5ed147c49b1bc0e65097e4dc0cf : SUCCESS in 5m 22s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/754f7904bebc448085a60d5da2f4b036 : SUCCESS in 3m 39s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/6e52e77fee2e4bd589dc734935004ffc : SUCCESS in 8m 15s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa4edc75cef84a828457784c704c8037 : SUCCESS in 9m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/32d0a36215204fcebe2a198bf5fdc6c0 : SUCCESS in 6m 12s\n- openstack-tox-py313-eventlet https://zuul.opendev.org/t/openstack/build/b9d6cdb04bd94988885d475018dc4a1d : SUCCESS in 2m 59s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/b7cf67a2d23a45ecac1a9e0e16f630bf : SUCCESS in 54m 27s\n- watcher-grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/14ed39914fe8472b8a65f0cfc01dcb83 : SUCCESS in 52m 29s\n- watcher-tempest-api-ipv6-only https://zuul.opendev.org/t/openstack/build/12fcacce556f486c94dd7457589098e0 : SUCCESS in 36m 29s\n- watcher-tempest-gnocchi https://zuul.opendev.org/t/openstack/build/0f148a64eec84835939d4483141b7157 : TIMED_OUT in 2h 05m 52s\n- watcher-tempest-prometheus https://zuul.opendev.org/t/openstack/build/d6223821b7724a80b396e533905a19dc : SUCCESS in 2h 02m 54s\n- watcher-tempest-prometheus-eventlet https://zuul.opendev.org/t/openstack/build/409fccb14fdd4c51af5cc5a5586cf2a4 : SUCCESS in 2h 01m 13s\n- watcher-tempest-aetos https://zuul.opendev.org/t/openstack/build/1fa3f70f6f934eb399803c93c9f6cde7 : SUCCESS in 1h 13m 51s","accounts_in_message":[],"_revision_number":1},{"id":"bdf38b33e093dcc9bd126d4badbec333be8af196","author":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"},"date":"2026-06-25 09:16:24.000000000","message":"Patch Set 1: Code-Review+1\n\nBuild succeeded (check pipeline).\nhttps://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/bec8c0508b9c49d9a8991e814634f5d6\n\n- openstack-meta-content-provider-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/54b91f7c01ae4a0f9b4151e4222c5f3f : SUCCESS in 2h 59m 19s\n- watcher-operator-validation-master https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/build/cf1d2b39848642b5aecee80a12aae04d : SUCCESS in 2h 17m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"22a8b50b5ce18af7c6a1136660367aea3c54774d","revisions":{"22a8b50b5ce18af7c6a1136660367aea3c54774d":{"kind":"REWORK","_number":1,"created":"2026-06-25 06:15:15.000000000","uploader":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"ref":"refs/changes/41/994841/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/41/994841/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/41/994841/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/41/994841/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/41/994841/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/41/994841/1"}}},"commit":{"parents":[{"commit":"50af94dcabcb6c958c9fb6d69fa7cebe6c85476b","subject":"Merge \"Remove unused placement from OpenStackClients\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/50af94dcabcb6c958c9fb6d69fa7cebe6c85476b"}]}],"author":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-06-16 09:57:17.000000000","tz":120},"committer":{"name":"jgilaber","email":"jgilaber@redhat.com","date":"2026-06-25 06:10:37.000000000","tz":120},"subject":"Remove unused CinderHelper methods","message":"Remove unused CinderHelper methods\n\nRemove _has_snapshot, create_volume, and delete_volume methods\nfrom CinderHelper as they are not called anywhere in the\ncodebase. Remove their corresponding unit tests.\n\nGenerated-By: claude-code (claude-opus-4-6)\nChange-Id: Ib44e3a6220d2a4b8581c7cf2e702705a5224be19\nSigned-off-by: jgilaber \u003cjgilaber@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/22a8b50b5ce18af7c6a1136660367aea3c54774d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/22a8b50b5ce18af7c6a1136660367aea3c54774d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":26471,"name":"Software Factory CI","email":"softwarefactory-operations-team@redhat.com","username":"sf-project-io"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}