)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"2d7e21ff17afa855b9ea2b18a932f884b858324a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c99f54d_565b6f73","updated":"2026-06-25 15:33:53.000000000","message":"recheck","commit_id":"193ffcaf8a9ac9f5cc23d610f6ea92ea012420a6"}],"releasenotes/notes/cinderclient-openstacksdk-migration-05ec7aaef6795584.yaml":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b6660214a3975afcd290758724db85f720e798f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Replaced python-cinderclient with the openstacksdk block-storage proxy"},{"line_number":16,"context_line":"    in CinderHelper. Usage of cinderclient has been removed and"},{"line_number":17,"context_line":"    python-novaclient has been removed as a dependency."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"919337c7_607fb37d","line":17,"updated":"2026-06-25 07:50:38.000000000","message":"The \u0027other\u0027 section of the release note incorrectly claims \u0027python-novaclient has been removed as a dependency.\u0027 This is factually wrong for this change set: python-novaclient was already removed in the earlier novaclient-to-openstacksdk migration (see releasenotes/notes/prepare-openstacksdk-migration-73cc43ab26ed47e6.yaml:14). This patch only removes python-cinderclient. The novaclient claim is misleading and should be removed.\n\n**Severity**: WARNING | **Confidence**: 0.9\n\n**Impact**: Operators reading the release notes will be confused about which dependency was removed in which release. The duplicate claim about novaclient makes the cinder migration note inaccurate and undermines trust in the release notes documentation.\n\n**Suggestion**:\nRemove the phrase \u0027and python-novaclient has been removed as a dependency\u0027 from line 17. The sentence should end after \u0027Usage of cinderclient has been removed.\u0027 The novaclient removal is already documented in the prepare-openstacksdk-migration release note.","commit_id":"d8c343f8a4f34480bd2c5a55c29e968c728b7b03"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"80acd320ca348d1abe85544b009b89b466d8bc7b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Replaced python-cinderclient with the openstacksdk block-storage proxy"},{"line_number":16,"context_line":"    in CinderHelper. Usage of cinderclient has been removed and"},{"line_number":17,"context_line":"    python-novaclient has been removed as a dependency."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5e9e031_692f2de1","line":17,"updated":"2026-06-25 12:17:03.000000000","message":"Release note incorrectly states \u0027python-novaclient has been removed as a dependency.\u0027 This commit removes python-cinderclient (see requirements.txt diff), not python-novaclient. python-novaclient is not present in requirements.txt and is not touched by this change.\n\n**Severity**: HIGH | **Confidence**: 1.0\n\n**Risk**: Operators reading the release note are told the wrong dependency was removed. This causes confusion during upgrade/migration planning and misleads anyone auditing the dependency footprint. The note is the authoritative operator-facing record of this change.\n\n**Priority**: Before merge\n**Why This Matters**: Release notes are consumed directly by operators for upgrade decisions. A factually incorrect statement about which dependency was removed undermines trust in the migration guidance and could lead to incorrect packaging or dependency audits downstream.\n\n**Recommendation**:\nReplace \u0027python-novaclient has been removed as a dependency\u0027 with \u0027python-cinderclient has been removed as a dependency.\u0027 The preceding sentence already describes cinderclient, so the sentence can simply read \u0027and python-cinderclient has been removed as a dependency.\u0027","commit_id":"65b8b20fe11ae254d9800feafe28681add50dc14"},{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"020d82bdadf5bf6123f0ba5f241c893b9a826a90","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Replaced python-cinderclient with the openstacksdk block-storage proxy"},{"line_number":16,"context_line":"    in CinderHelper. Usage of cinderclient has been removed and"},{"line_number":17,"context_line":"    python-cinderclient has been removed as a dependency."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c31ef0f1_4c8111b8","line":17,"updated":"2026-06-25 16:24:59.000000000","message":"The dependency-removal release note is placed under the \u0027other\u0027 section. Removing python-cinderclient from requirements.txt is an upgrade change operators would more readily find under \u0027upgrade\u0027. The upgrade section only mentions the [cinder] config migration, not the package removal.\n\n**Severity**: WARNING | **Confidence**: 0.8\n\n**Impact**: Downstream packagers and operators scanning reno \u0027upgrade\u0027 notes may miss that python-cinderclient is no longer an install requirement, since the dependency removal is only documented under \u0027other\u0027.\n\n**Suggestion**:\nConsider moving (or duplicating) the python-cinderclient removal statement into the \u0027upgrade\u0027 section of this reno note so the dependency change is surfaced alongside the config migration guidance.","commit_id":"de59ad43cb45b0324145ba515928c6058ef76a89"}],"watcher/decision_engine/model/collector/cinder.py":[{"author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"tag":"autogenerated:zuul:automatic-ci","change_message_id":"b6660214a3975afcd290758724db85f720e798f2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def __init__(self, osc):"},{"line_number":159,"context_line":"        self.osc \u003d osc"},{"line_number":160,"context_line":"        self.model \u003d model_root.StorageModelRoot()"},{"line_number":161,"context_line":"        self.cinder_helper \u003d cinder_helper.CinderHelper()"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0ddf12f0_c118c888","line":159,"updated":"2026-06-25 07:50:38.000000000","message":"CinderModelBuilder.__init__ stores self.osc \u003d osc (line 159) but never reads self.osc afterward since the CinderHelper() constructor no longer takes the osc parameter. The osc parameter is still passed from CinderClusterDataModelCollector.execute() at line 140 (builder \u003d CinderModelBuilder(self.osc)). This is now dead stored state within the builder.\n\n**Severity**: SUGGESTION | **Confidence**: 0.9\n\n**Benefit**: Removing the unused self.osc assignment and the osc parameter from CinderModelBuilder.__init__ would make the code cleaner and avoid implying that the OpenStackClients instance is used for cinder operations when it is not. This also simplifies future maintenance by making it clear the builder does not depend on osc.\n\n**Recommendation**:\nConsider removing the osc parameter from CinderModelBuilder.__init__ and the self.osc assignment. Update the caller at line 140 (CinderClusterDataModelCollector.execute) to call CinderModelBuilder() without arguments. Note: the same osc parameter pattern exists in NovaModelBuilder, so this could be a follow-up cleanup if consistency is preferred.","commit_id":"d8c343f8a4f34480bd2c5a55c29e968c728b7b03"}]}