)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"11bc0e9a66e7db56d68a7144d020a987abce48bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45776af9_3d40c37c","updated":"2026-06-30 08:34:46.000000000","message":"Shouldn\u0027t the shebang be also added to devstack/plugin.sh ? . Also, this is also changing the file to executable, what I\u0027d say it\u0027s not needed?.","commit_id":"34b0630f6406619d37f74f46a2c71a4db055a4c9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5156362afb76e1d5bca4de026c9f6e6662ad1494","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d395c864_dc869c10","updated":"2026-10-07 12:27:07.000000000","message":"as noted on the other version of this in outter proejct this is incorrect\n\nif we want to make highight work (we have conventison advising agisnt making change just for editror by the way) the correct way is to change the extion to have .bash or .sh\n\nthis is not an executabel file and should not have a shibang or the exeuctable bit set\n\nif we have merge this on any of our repos already we shoudl revert it","commit_id":"34b0630f6406619d37f74f46a2c71a4db055a4c9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ccdc771db2823a3e90bd57a5cbdfc2a91e325085","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"42159b31_61385803","in_reply_to":"060069bb_f591a111","updated":"2026-10-07 13:06:12.000000000","message":"you realised i asksed for this to be revert in nova and placement right.\n\nthis is weaking the security of the script by provideing permition and executable line they shoudl nto have.","commit_id":"34b0630f6406619d37f74f46a2c71a4db055a4c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7e255f9fb477db21306ef43f0a01f230e8d51166","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d0f796a_7179dbbd","in_reply_to":"42159b31_61385803","updated":"2026-10-07 13:50:39.000000000","message":"I remember your comment in cyborg change (iiru) but these shebangs in tempest were added in quite old days https://review.opendev.org/c/openstack/devstack/+/139715.\n\nThese are dev scripts and not codes, you can technically execute these to load functions in bash. (contrarily to the other files line release note files which I fixed in a few repos afair).","commit_id":"34b0630f6406619d37f74f46a2c71a4db055a4c9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"62fefdcb8274e9ee0ae35a7d62a54ca79ec75656","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"060069bb_f591a111","in_reply_to":"d395c864_dc869c10","updated":"2026-10-07 13:04:02.000000000","message":"Although I understand your point, this is the common pattern even used within tempest (see lib/placement or lib/nova for example).\n\nRenaming it may also work though that\u0027s not the standard naming used in all devstack plugins yet so there are trade-offs here.\n\nI find it annoying that editors can\u0027t detect its file type but I\u0027m ok to leave this to project\u0027s own decision.","commit_id":"34b0630f6406619d37f74f46a2c71a4db055a4c9"}]}