)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~746222","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I3abff34b84d14c854131e2631ad21911419fd20b","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"resort_numa","hashtags":[],"change_id":"I3abff34b84d14c854131e2631ad21911419fd20b","subject":"Normalize list of single dict for equality tests","status":"MERGED","created":"2020-08-13 20:04:21.000000000","updated":"2020-08-13 22:56:15.000000000","submitted":"2020-08-13 22:56:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"746222-1597359375140-62d8eb97","meta_rev_id":"3d51a7f4d1487ac808a3db08a632af9a59acff30","_number":746222,"virtual_id_number":746222,"owner":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"date":"2020-08-13 21:42:44.000000000","_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-13 22:56:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2020-08-13 21:19:25.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2020-08-13 21:19:25.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-13 20:05:16.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-08-13 20:05:23.000000000","updated_by":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"reviewer":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"state":"REVIEWER"},{"updated":"2020-08-13 20:05:31.000000000","updated_by":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"reviewer":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"state":"REVIEWER"},{"updated":"2020-08-13 21:19:25.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2020-08-13 22:56:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1faaea3559d4dc0fb42328ada61ba6544f79c238","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-13 20:04:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38c0563139bf20c3c4c0a8bff0f3c149166caffb","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-13 20:18:34.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)\n\nAwesome work.","accounts_in_message":[],"_revision_number":1},{"id":"8bb40cf0b354bc6ce580917006d3678a9f01b9d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 21:11:33.000000000","message":"Patch Set 1: Verified-1\n\n(12 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/66a636228b73416399528639b154d860 : FAILURE in 3m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6598bf0dbe7b4abc9651efc775e566e8 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/508a7d6f1dbb4eab903cd5945e6a454c : SUCCESS in 3m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0e940efbe17d4f68863f5c9699eb2979 : SUCCESS in 3m 46s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/abd209575a634b4cbef42d700405130c : SUCCESS in 1h 05m 42s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/e543913d5bc04182bd10047f3f21b499 : RETRY_LIMIT in 8m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7b731784059e69f1a620f5be9430658914c9d1c0","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-13 21:15:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3b1695b840a11e51e78b01bc5f6b7bc616d21f3e","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-13 21:19:25.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nStill yep.\n\n`tox -e pep8` locally in the future (not that I\u0027m not guilty of doing the same thing) :)","accounts_in_message":[],"_revision_number":2},{"id":"7d103e14f9caa77fe9a7cf1424b82d0bf04f3793","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-13 21:42:44.000000000","message":"Patch Set 2:\n\nYea sorry I have a special container env for doing the final pep8 checks before I push it for review. I normally do the checks but forgot this time :(.","accounts_in_message":[],"_revision_number":2},{"id":"8f7c41aa09689389f71399c98ed0dcb75bff08d7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 22:01:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4e1841c051c048778055615d036f54e7 : SUCCESS in 3m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8d0877b1d59e40a4bd365d3b8a281335 : SUCCESS in 6m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7f493451bfb0450c9ffc5cb69eac5341 : SUCCESS in 4m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/82c347a30dea44e1adf70eb42fe66287 : SUCCESS in 4m 17s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/b105f02bc0234de98ee0e09bb32e9c81 : SUCCESS in 42m 48s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/988d214984534c35be07462ebefb7278 : RETRY_LIMIT in 8m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4f16c45ced99f678f7ea3bbb436ebb93b161e956","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 22:01:59.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"82a6ae35e3e6ab97207f3eff9059a21f51dc0f66","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 22:56:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a1d840d8bf742ea9a1ce5b99f7dbbf1 : SUCCESS in 2m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4d4456d10c6d46cab5ab5a1c4e25b088 : SUCCESS in 3m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fcbe40f3c5e448b9b317b2e1f49ae897 : SUCCESS in 3m 31s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/28b7dfe176d04dcd83af10769b388b98 : SUCCESS in 3m 51s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/f317e385aaa64c1ea2517456843feaf1 : SUCCESS in 50m 23s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/da518a44d6364908a63b088803d6a354 : RETRY_LIMIT in 8m 19s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"671d4d2695c3f7608f8868514f7de7bb752ef739","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-13 22:56:15.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6869d270e87a60f3a18749688388a29da3274dbe","revisions":{"a148d6a9fb751385c7fbeb6d02ab3404f4364002":{"kind":"REWORK","_number":1,"created":"2020-08-13 20:04:21.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/22/746222/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/22/746222/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/1"}}},"commit":{"parents":[{"commit":"97713d8bf73a33faea3a2f629b44764773e8656c","subject":"New [whitebox-hardware]/cpu_topology option","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/97713d8bf73a33faea3a2f629b44764773e8656c"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-13 19:55:32.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-13 19:55:36.000000000","tz":-240},"subject":"Normalize list of single dict for equality tests","message":"Normalize list of single dict for equality tests\n\nCommit [1] normalized the json data for numa_topology to allow for\naccurate comparison checks. Original logic would end the recursion when\na list was found. If the list had a dictionary, it\u0027s list values would\nnot be sorted. This adds a check for dict objects in the list and\nrecurses on the object(s). It should be noted that when executing\nv.sort(), there is a list of dictionaries greater than one, it results\nin a TypeError exception since sorting against multiple dictionaries is\nnot supported by list method sort().\n\n[1] https://review.opendev.org/#/c/705999/\n\nChange-Id: I3abff34b84d14c854131e2631ad21911419fd20b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/a148d6a9fb751385c7fbeb6d02ab3404f4364002"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/a148d6a9fb751385c7fbeb6d02ab3404f4364002"}]},"branch":"refs/heads/master"},"6869d270e87a60f3a18749688388a29da3274dbe":{"kind":"REWORK","_number":2,"created":"2020-08-13 21:15:41.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/22/746222/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/22/746222/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/22/746222/2"}}},"commit":{"parents":[{"commit":"97713d8bf73a33faea3a2f629b44764773e8656c","subject":"New [whitebox-hardware]/cpu_topology option","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/97713d8bf73a33faea3a2f629b44764773e8656c"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-13 19:55:32.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-13 21:15:03.000000000","tz":-240},"subject":"Normalize list of single dict for equality tests","message":"Normalize list of single dict for equality tests\n\nCommit [1] normalized the json data for numa_topology to allow for\naccurate comparison checks. Original logic would end the recursion when\na list was found. If the list had a dictionary, its list values would\nnot be sorted. This adds a check for dict objects in the list and\nrecurses on the object(s). It should be noted that when executing\nv.sort(), there is a list of dictionaries greater than one, it results\nin a TypeError exception since sorting against multiple dictionaries is\nnot supported by list method sort().\n\n[1] https://review.opendev.org/#/c/705999/\n\nChange-Id: I3abff34b84d14c854131e2631ad21911419fd20b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/6869d270e87a60f3a18749688388a29da3274dbe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/6869d270e87a60f3a18749688388a29da3274dbe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}