)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~746605","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I4d9330cf8abcb6ba3c0852e6ce3db732e468c6a5","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"nova_sm_dns","hashtags":[],"change_id":"I4d9330cf8abcb6ba3c0852e6ce3db732e468c6a5","subject":"Pass hostname to NovaServiceManager","status":"MERGED","created":"2020-08-17 21:23:43.000000000","updated":"2020-08-20 18:13:05.000000000","submitted":"2020-08-20 18:13:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":16,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"746605-1597947185202-0b925b31","meta_rev_id":"ed155282168ea5e02c11a29ed8689b2b80d72ea7","_number":746605,"virtual_id_number":746605,"owner":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"date":"2020-08-20 15:35:43.000000000","_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-20 18:13:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2020-08-20 17:22:32.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2020-08-20 17:22:32.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-18 17:45:44.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-08-18 17:45:50.000000000","updated_by":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"reviewer":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"state":"REVIEWER"},{"updated":"2020-08-18 17:45:55.000000000","updated_by":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"reviewer":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"state":"REVIEWER"},{"updated":"2020-08-20 17:22:32.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2020-08-20 18:13:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a4e9ceea5ccdc4fb4e370ac003fa58eef30375a0","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-17 21:23:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5bd150864ac461db1f55c077516ef03fc35bec6e","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-17 21:25:06.000000000","message":"Patch Set 1:\n\nRelevant Downstream results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_cpu_pinning\n{0} whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_cpu_pinning [476.435258s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 476.4353 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 476.4353 sec.\n\n\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_emulator_threads\n{0} whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_emulator_threads [317.504290s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 317.5043 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 317.5043 sec.","accounts_in_message":[],"_revision_number":1},{"id":"f7cad51d1060bd254d4f190e71f0c15b08316bcf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-17 22:34:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/41185532c8e142bfbfe175bdf54f9c2b : SUCCESS in 3m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a2b4de3e1a5f498188685635279a3d41 : FAILURE in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/52bf818eafb04fa992db8bca2c4f91bf : FAILURE in 4m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/947164755ed84ed4a7d43a1682dbe751 : FAILURE in 4m 52s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/5376f696ce70480eb8e5b34d64b6a8ba : FAILURE in 1h 09m 01s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/bd42ba456bcb4e15863f515daa10c954 : RETRY_LIMIT in 8m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c2d97d5b7306f0af2b7d351b8dde8404aa28fc5d","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-18 16:38:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a4ca9fb15101fdc61a5692af5b2a0a66948498ad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 17:42:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe99fa514a5a4f97b7560ea004303f5b : SUCCESS in 4m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1794fd7a817a48b5993a8820f523f515 : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/68c6e5b2669641e887fa504b81dc3ae7 : SUCCESS in 4m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/446b045869c64bfea24075ebb737199c : SUCCESS in 5m 34s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/6f3ecb3071fc4eebb8f2d773b23e9d38 : SUCCESS in 1h 02m 30s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/640dd47d543b431ba6d55d89384068d6 : RETRY_LIMIT in 12m 53s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b2b15515e4000a4d08d685fb524d073ae6ed35a9","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-19 17:49:54.000000000","message":"Patch Set 2: Code-Review-1\n\n(8 comments)\n\nLooking good, just a bunch of nits that I think collectively warrant a respin.","accounts_in_message":[],"_revision_number":2},{"id":"fda2a94d777b98528184cc2390bf70b4ed97e67f","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-19 18:16:37.000000000","message":"Patch Set 2:\n\n(7 comments)","accounts_in_message":[],"_revision_number":2},{"id":"22b8a7db01367d3694af0bbbbbcac474e90793fb","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-19 20:12:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1a81956a809bb746033ae352039feedf54e30cd6","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-19 21:00:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3f0a45653c1beed01d3b25f3bae37a5d8293b1df","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-19 22:05:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e477d321dcfb4a9294df51005f177582 : SUCCESS in 4m 17s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/766121be893b4a759b4391ace140d8f9 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2906b31e7f9d44949b3666cfc43b9b27 : SUCCESS in 4m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/350e07ecdec54bc9a704ae3b118bfd93 : SUCCESS in 9m 57s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/d5edb28db592456eaca99303a035a5de : SUCCESS in 1h 02m 15s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/ec45f5fa04ce41c9a9dba39e83532fe9 : RETRY_LIMIT in 10m 02s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"66d3628dd46101b3ad45f599336c09819ec96afb","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-08-20 15:35:43.000000000","message":"Patch Set 3:\n\nDownstream results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_cpu_pinning\n{0} whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_cpu_pinning [414.012222s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 414.0122 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 414.0122 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (1 tests) \u003d\u003e 0:06:54.012222\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_emulator_threads\n{0} whitebox_tempest_plugin.api.compute.test_cpu_pinning.NUMALiveMigrationTest.test_emulator_threads [327.078896s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 327.0789 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 327.0789 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (1 tests) \u003d\u003e 0:05:27.078896","accounts_in_message":[],"_revision_number":3},{"id":"6cc21ab88b5c9563c7af2f8fee0cb6a3f2eae30c","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-20 17:22:32.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"dceb15bdaf610ec4a59f0682e4d97455f82b1339","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-20 17:22:52.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"baba9ef59bb28f4517eedcb3d7460fe9f44f5c48","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-20 18:13:04.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/18c7be28997e47508068352639fb2cc1 : SUCCESS in 4m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2b385c7bffef4e3e839091992707c3d3 : SUCCESS in 4m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/297a1cbc27cf4324a669a1785dfcbe4c : SUCCESS in 3m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/597e2eb5035b4a94a9a5dade2b803050 : SUCCESS in 4m 39s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/87c3ed6316c340a081c2645e3731030e : SUCCESS in 43m 04s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/2ac5e1532fcc40e78b8e92c2f0539d64 : RETRY_LIMIT in 12m 35s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b9754cb00eb33a32eaa4a41ec24c9fb89753acdb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-20 18:13:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"17185972008937fd45bc0fe3755a8e69f991a524","revisions":{"ce7633aaebc3608741746b3c81de138c26009a55":{"kind":"REWORK","_number":1,"created":"2020-08-17 21:23:43.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/05/746605/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/05/746605/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/1"}}},"commit":{"parents":[{"commit":"6869d270e87a60f3a18749688388a29da3274dbe","subject":"Normalize list of single dict for equality tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/6869d270e87a60f3a18749688388a29da3274dbe"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-17 21:10:08.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-17 21:10:13.000000000","tz":-240},"subject":"Pass hostname to NovaServiceManager","message":"Pass hostname to NovaServiceManager\n\nTripleO deployments do not have the capacity to look up nova service\nbinaries based on the respetive compute\u0027s IP address. To allow the\nrecent change [1] to run downstream, this commit updates how parameters\nare passed to NovaServiceManager. The hostname is passed to\nNovaServiceManager instead of the IP address, and during the init the IP\naddress is determined from the hostname and passed to the SSHClient.\nWhen NovaServiceManager attempts to access nova services, it uses the\nprovided hostname now instead of the IP address.\n\nThe get_ctlplane_address() function was moved from api.compute.base to\nutils, since services.clients now needs to leverage this functionality as\nwell. All original calls have been updated to use the new module path.\n\nSince downstream deployments still map the internal API subnet to the\ncompute domain names, several tests are storing both the compute\nhostname as well as the compute control plane IP address and passing\nthem to the respective service managers.\n\n[1] https://review.opendev.org/#/c/736820/\n\nChange-Id: I4d9330cf8abcb6ba3c0852e6ce3db732e468c6a5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/ce7633aaebc3608741746b3c81de138c26009a55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/ce7633aaebc3608741746b3c81de138c26009a55"}]},"branch":"refs/heads/master"},"14363afff6a3455c922dfdeebe72cb84929ac01a":{"kind":"REWORK","_number":2,"created":"2020-08-18 16:38:00.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/05/746605/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/05/746605/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/2"}}},"commit":{"parents":[{"commit":"6869d270e87a60f3a18749688388a29da3274dbe","subject":"Normalize list of single dict for equality tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/6869d270e87a60f3a18749688388a29da3274dbe"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-17 21:10:08.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-18 16:23:16.000000000","tz":-240},"subject":"Pass hostname to NovaServiceManager","message":"Pass hostname to NovaServiceManager\n\nDefault TripleO deployments utilize compute domain names when looking up\nnova service binaries, this lookup does not work when using a compute\u0027s\nIP address though. To allow the recent change [1] to run downstream,\nthis commit updates how parameters are passed to the init of\nNovaServiceManager. The hostname is passed to NovaServiceManager instead\nof the IP address.  During the init the compute\u0027s control plane IP\naddress is determined and passed to its SSHClient. When\nNovaServiceManager attempts to access nova services, it uses the\ncompute\u0027s provided hostname now instead of the IP address.\n\nThe get_ctlplane_address() function was moved from api.compute.base to\nutils, since services.clients now needs to leverage this functionality\nas well. All test case calls of get_ctlplane_address() have been updated\nto use the new module path. Unit test modules test_base and test_utils\nwere updated to reflect these changes.\n\nLastly test cases interfacing with NovaServiceManager have been updated\nto store both the compute\u0027s hostname as well as it\u0027s associated control\nplane IP address. Originally these tests only stored the compute\u0027s\ncontrol plane address.\n\n[1] https://review.opendev.org/#/c/736820/\n\nChange-Id: I4d9330cf8abcb6ba3c0852e6ce3db732e468c6a5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/14363afff6a3455c922dfdeebe72cb84929ac01a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/14363afff6a3455c922dfdeebe72cb84929ac01a"}]},"branch":"refs/heads/master"},"17185972008937fd45bc0fe3755a8e69f991a524":{"kind":"REWORK","_number":3,"created":"2020-08-19 21:00:13.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/05/746605/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/05/746605/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/05/746605/3"}}},"commit":{"parents":[{"commit":"6869d270e87a60f3a18749688388a29da3274dbe","subject":"Normalize list of single dict for equality tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/6869d270e87a60f3a18749688388a29da3274dbe"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-17 21:10:08.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-08-19 20:59:16.000000000","tz":-240},"subject":"Pass hostname to NovaServiceManager","message":"Pass hostname to NovaServiceManager\n\nDefault TripleO deployments utilize compute domain names when looking up\nnova service binaries, this lookup does not work when using a compute\u0027s\ncontrol plane IP address though. To allow the recent change [1] to run\ndownstream, this commit updates how parameters are passed to the init of\nNovaServiceManager. The hostname is passed to NovaServiceManager instead\nof the IP address.  During the init the compute\u0027s control plane IP\naddress is determined and passed to its SSHClient. When\nNovaServiceManager attempts to access nova services, it uses the\ncompute\u0027s provided hostname now instead of the IP address.\n\nThe get_ctlplane_address() function was moved from api.compute.base to\nutils, since services.clients now needs to leverage this functionality\nas well. All test case calls of get_ctlplane_address() have been updated\nto use the new module path. Unit test modules test_base and test_utils\nwere updated to reflect these changes.\n\nLastly test cases interfacing with NovaServiceManager have been updated\nto store both the compute\u0027s hostname as well as it\u0027s associated control\nplane IP address. Originally these tests only stored the compute\u0027s\ncontrol plane address.\n\n[1] https://review.opendev.org/#/c/736820/\n\nChange-Id: I4d9330cf8abcb6ba3c0852e6ce3db732e468c6a5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/17185972008937fd45bc0fe3755a8e69f991a524"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/17185972008937fd45bc0fe3755a8e69f991a524"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}