)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~749987","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I0271894acd0689b947974c86910b3d8c41aa9d72","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"live_mig_reboot","hashtags":[],"change_id":"I0271894acd0689b947974c86910b3d8c41aa9d72","subject":"Test soft reboot after live-migration","status":"MERGED","created":"2020-09-04 15:20:49.000000000","updated":"2020-10-05 21:48:01.000000000","submitted":"2020-10-05 21:48:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":37,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"749987-1601934481922-8f1aa1ae","meta_rev_id":"b07d6b2682150301e8773806f6cea03c4d2d0359","_number":749987,"virtual_id_number":749987,"owner":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-05 21:48:01.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2020-10-05 18:43:59.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2020-10-05 18:43:59.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-04 16:16:26.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-09-10 11:45:25.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-10-05 18:43:59.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2020-10-05 21:48:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"40fe03a9d317cff6f22cb288b7de43c81bb7e2dc","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-04 15:20:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6bce1b6945bed2253c6abdbf0b59510366b4a58a","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-04 15:30:29.000000000","message":"Patch Set 1:\n\nNot a full review, but I think there\u0027s be value in running this against an older Nova to make sure this consistently fails. This seems like the kind of thing that could easily pass even without the fix because devices names be funky, yo.","accounts_in_message":[],"_revision_number":1},{"id":"3e6137c42b2f56366b91f080187a2a4b6fcadc95","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-04 15:33:54.000000000","message":"Patch Set 1:\n\nThat\u0027s a good point, after completing the official cve validation I will follow up with some report logs against different releases prior to the fix.  I was also wondering if I should implement a skip check for this that validates the deployment is using iSCSI?","accounts_in_message":[],"_revision_number":1},{"id":"9b986f239e145154024e4ac54fba7805392fbee9","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-04 15:44:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"63183f5b601d22f53a84b86a42333506099b12df","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-04 16:14:57.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2404957ebaa6e9d2d7f7113254aef0720b69d78c","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-04 16:16:26.000000000","message":"Patch Set 1:\n\n\u003e Not a full review, but I think there\u0027s be value in running this\n \u003e against an older Nova to make sure this consistently fails. This\n \u003e seems like the kind of thing that could easily pass even without\n \u003e the fix because devices names be funky, yo.\n\nDevice names inside the instance sure but this is about ensuring the host block devices we are mapping through from the destination host aren\u0027t reverting after a soft reboot to the block devices used prior to a migration on the source host.","accounts_in_message":[],"_revision_number":1},{"id":"774fa02e7b08d864f56a4b54d44c91ad2e695f46","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-04 16:34:28.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"445df59e08c582fbf915a9355dba28b872988a10","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 16:49:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/baa85489158a4f7ca863d048cbb886ff : SUCCESS in 3m 20s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7992b56d23544efa9308e94ced29166b : SUCCESS in 7m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/adb379a4e81a4162823d8c53af8425cb : SUCCESS in 5m 08s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/15cea880c7214a63bc3e4ddc55175666 : SUCCESS in 4m 54s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/5d3e4bd33e1d4d7294419a6aa2c0a0f7 : SUCCESS in 1h 24m 57s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/d77cfa8111c0410495e9365a814fbac1 : RETRY_LIMIT in 11m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"40be59caab62a83a95b254bd29c77a34c0eb0486","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-04 17:05:18.000000000","message":"Patch Set 1:\n\n\u003e \u003e Not a full review, but I think there\u0027s be value in running this\n \u003e \u003e against an older Nova to make sure this consistently fails. This\n \u003e \u003e seems like the kind of thing that could easily pass even without\n \u003e \u003e the fix because devices names be funky, yo.\n \u003e \n \u003e Device names inside the instance sure but this is about ensuring\n \u003e the host block devices we are mapping through from the destination\n \u003e host aren\u0027t reverting after a soft reboot to the block devices used\n \u003e prior to a migration on the source host.\n\nAh I see. If you\u0027re happy with the test logic I\u0027ll happily defer to you on that :)","accounts_in_message":[],"_revision_number":1},{"id":"b72df4723059e8563b5097f957c15a8cb4a883e4","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-09-04 22:21:40.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"178ba7925f367181448ffbb55b02b7984a95b45c","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-08 20:15:33.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0f2d64e975d4d23b1c0f8ceeab67c5ea6f354f4f","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-10 00:34:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9d5405838dcc827f8634967d8d88569ad6dcaaff","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-09-10 01:12:43.000000000","message":"Patch Set 2: Code-Review+2\n\n(5 comments)\n\ni am pretty happy with this but i would like lee to also have another look\nsome commens inline that could be addressed in a separate patch but nothing that looks like a blocker.","accounts_in_message":[],"_revision_number":2},{"id":"7dd2221176e01db906345d94bc62f260f70c1c8f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-10 01:47:56.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a54d52957faa48848153a845bf875835 : SUCCESS in 3m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5fd0ff70168a47cd8aa69679bcbe10ee : SUCCESS in 4m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/85c96beb50f74f52858ebb97def1d7ba : SUCCESS in 4m 09s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b6cb2f98f4e442518ba761246d6e1a74 : SUCCESS in 4m 49s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/a80209b02bb74d9fba57479e0ba26b15 : FAILURE in 1h 08m 17s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/27b3c041169b4bf9934edb6cb50d5f2f : RETRY_LIMIT in 8m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"27f096530fe848e5349c5db721d2614928a9a382","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-10 01:53:25.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nNot a full review, but it looks like what you\u0027ve basically done is re-written the CPU pinning NUMA live migration to not need multi-NUMA, and to test both old (vcpu_pin_set) and new (cpu_dedicated_set) configurations. You\u0027ve just happened to tack on the soft reboot CVE thing.\n\nThat is all excellent work, but it means we need to remove the old test before merging, and then maybe we don\u0027t need to reorganize stuff so much?","accounts_in_message":[],"_revision_number":2},{"id":"5ca5e8a32969e8c5ad0fab4d388fb3235c1fc000","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-09-10 11:27:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3d1af2292d1176b8fb0c0f169fa85cd6769326f4","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-10 11:33:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f56ddc024fc5e3d33cb97b6fb5eb3cd7951c496d","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-09-10 11:45:25.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"eb2a1cd6992e9237058c2287b8ff7223b981a7cc","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-10 13:33:10.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dfd47ec64ec6f8b32905d543a06ab79d840f0498","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-10 13:43:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d7488b8968c95e0f8f38329aa79af03f0674cee3","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-09-11 15:06:55.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"96519c4bb93b1ac9ab57b26400d88c48886ce724","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-15 21:17:45.000000000","message":"Patch Set 2: -Code-Review\n\n(1 comment)\n\nI\u0027ve removed my -1 (see inline), need to do a full review","accounts_in_message":[],"_revision_number":2},{"id":"1b3a70396125199b7a18a3a5bcce100a15d08113","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-10-01 13:54:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ba4a1a0bb8501e11a613c6c81585e431695c1f59","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-01 15:25:20.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8d7e778aedfb43b7a2c853d761520ac0 : SUCCESS in 3m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cd3f27edcd21475b9f9b7d74665c1bb2 : SUCCESS in 3m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3330cf1fcb674b14a85bd8b045eb7272 : SUCCESS in 3m 20s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/65ab363439cf4e7db7ba3e0d6cb66e98 : SUCCESS in 1h 23m 22s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d8cbe39a52e1d93d75e4cc47b82be387cd38802b","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-10-02 15:51:08.000000000","message":"Patch Set 3: Code-Review-1\n\nAll new child classes inheriting from LiveMigrationTest in test_live_migration  attempt to execute test method LiveMigrationTest.test_volume_backed_live_migration().  Need to refactor test structure to avoid unnecessary repetition of the same test.","accounts_in_message":[],"_revision_number":3},{"id":"ad571d29e00ef169aeeeb4340c1c00849f25f5b5","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2020-10-02 18:32:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f83ee9d34fe672699abee603ac93826356dd0abf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-02 20:04:07.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04d74d9aaace49b49967d369c4a18ba5 : SUCCESS in 4m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/37e61309113542c4981651e9ef2fddd1 : SUCCESS in 3m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d532ef3dc69148148bb65977d10b573a : SUCCESS in 3m 19s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/7ff40e0e153345e7a66359652b2c97e1 : SUCCESS in 1h 29m 21s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/baa2c0125e8a401cb91c73bc11d676b7 : RETRY_LIMIT in 8m 56s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"7b6b7b356d4d6ac72a10e79cce28c9b4123b3ca7","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-10-05 18:43:33.000000000","message":"Patch Set 4: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"342c41bc1226cb14ee3ad8d23431e3954d37f968","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-10-05 18:43:41.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5307cc4127f071f1cbce72eb0ae850004ca6d4f0","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-10-05 18:43:59.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nThis is gone on for long enough, fixed my own nits, lgtm","accounts_in_message":[],"_revision_number":5},{"id":"da4484b47bf9c6a5294ef72f47b022f78d26d7d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-05 20:21:02.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6571857e3cc84982b70ff4ab8f39fda9 : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7751db93cc674b6c956fb65f843e0cd8 : SUCCESS in 4m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c50820d202dd43db8c0b7452067dec12 : SUCCESS in 4m 28s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/36f8e6d4c9924c4ca36b80f3ff18c6ef : SUCCESS in 1h 27m 41s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/d53b51c63807474bb9179f126afb756c : RETRY_LIMIT in 9m 11s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"3d1f6e28351c0e87b42262f3327bd456757c93e4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-05 20:21:14.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"9bcc8a69cdcec62c30dabdae855e16b8f23ef884","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-05 21:48:01.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f47d2fb5de1e41949fcc837bd56b2a5d : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8aee5da88454466c9836bbba14e781ef : SUCCESS in 4m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5b2379310d3c4eeca9e4287b3f8e5d44 : SUCCESS in 4m 24s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/f925e9fea89c4de7b9a567fbb0b17662 : SUCCESS in 1h 23m 43s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/4cc773da87324739a26894a8bdca4090 : RETRY_LIMIT in 8m 33s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"c1bdc03f923700810380031c99e7d5c05c088cd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-05 21:48:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"30c8018731e8c5099757e5ea46af9f635c0747ba","revisions":{"f2bceabcb5837306704120a976ed806ddf740090":{"kind":"REWORK","_number":1,"created":"2020-09-04 15:20:49.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/87/749987/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/87/749987/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/1"}}},"commit":{"parents":[{"commit":"720f25ab11c39b325ff99181d11fccc72c11aaab","subject":"Merge \"Update exception message for nova service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/720f25ab11c39b325ff99181d11fccc72c11aaab"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 14:56:35.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 15:20:25.000000000","tz":-240},"subject":"Test soft reboot after live-migration","message":"Test soft reboot after live-migration\n\nCommit looks to add regression coverage for [1]. Test creates two\ninstances with iSCSI volumes and puts them on their own respective\nhosts. Instance two is then live-migrated to the host containing\ninstance one. Since an instance is already on the host, server two\u0027s\nsource disks should be enumerated to different values. After\nlive-migration, instance two is soft-rebooted.  After the reboot the\ntest validates that server two\u0027s source disk devices are different than\nwhat they were pre-migration. It validates the disk enumeration for the\nserver remains the same after the soft-reboot. Finally it confirms\nserver one\u0027s disk enumeration is different from server two.\n\nTest creates a new class ,test_live_migration.LiveMigrationReboot, which\ninherits from the previously established class LiveMigrationTest.\nTestcase method added is called test_reboot_after_live_migration, which\nhas its own helper method, get_source_disk_devs. This method parses a\ndomain\u0027s XML and creates a list of all source disk devices.\n\n[1] https://bugs.launchpad.net/nova/+bug/1890501\n\nChange-Id: I0271894acd0689b947974c86910b3d8c41aa9d72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/f2bceabcb5837306704120a976ed806ddf740090"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/f2bceabcb5837306704120a976ed806ddf740090"}]},"branch":"refs/heads/master"},"9bd678475f1989ba8c57cb2f4a0fe188ce1f2a2f":{"kind":"REWORK","_number":2,"created":"2020-09-10 00:34:15.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/87/749987/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/87/749987/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/2"}}},"commit":{"parents":[{"commit":"720f25ab11c39b325ff99181d11fccc72c11aaab","subject":"Merge \"Update exception message for nova service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/720f25ab11c39b325ff99181d11fccc72c11aaab"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 14:56:35.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-09 23:56:34.000000000","tz":-240},"subject":"Test soft reboot after live-migration","message":"Test soft reboot after live-migration\n\nCommit looks to add regression coverage for [1]. It introduces two tests\nthat follow the same procedure with the only differing feature being the\nparameter utilized to define the available pinned CPUs on the compute\nhost. The test updates two compute hosts with two different cpu ranges,\ne.g. host0 [0-3] and host1 [4-7]. An instance is created and its\nassociated pinned CPUs are recorded. It is then migrated to the other\nhost and the updated pinned CPUs are compared against the CPUs prior to\nmigration, asserting they are no longer the same. Finally it soft\nreboots the instance and asserts that its pinned CPUs remain the same.\n\nTest introduces three classes to test_live_migration.py. First is\nLiveMigrationAndReboot which handles all of the test logic. It\u0027s two\nchildren, VCPUPinSetMigrateAndReboot and CPUDedicatedMigrateAndReboot,\nprovide test parameters necessary to execute the test logic with either\nvcpu_pin_set or cpu_dedicated_set.\n\nThe tests needs to leverage a lot of the helper functions found in\ntest_cpu_pinning.NUMALiveMigrationBase. To prevent duplication and since\nthese tests does not work with anything NUMA specific, the necessary\nhelper functions were moved to base.BaseWhiteboxComputeTest. This\nincludes parse_cpu_spec, get_all_cpus, get_pinning_as_set, and\n_get_cpu_set.\n\n[1] https://bugs.launchpad.net/nova/+bug/1890501\n\nChange-Id: I0271894acd0689b947974c86910b3d8c41aa9d72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9bd678475f1989ba8c57cb2f4a0fe188ce1f2a2f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9bd678475f1989ba8c57cb2f4a0fe188ce1f2a2f"}]},"branch":"refs/heads/master"},"b697fb686e5b2c57cb799365c76579290544ddb2":{"kind":"REWORK","_number":3,"created":"2020-10-01 13:54:27.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/87/749987/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/87/749987/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/3"}}},"commit":{"parents":[{"commit":"720f25ab11c39b325ff99181d11fccc72c11aaab","subject":"Merge \"Update exception message for nova service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/720f25ab11c39b325ff99181d11fccc72c11aaab"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 14:56:35.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-10-01 13:49:29.000000000","tz":-240},"subject":"Test soft reboot after live-migration","message":"Test soft reboot after live-migration\n\nCommit looks to add regression coverage for [1]. It introduces two tests\nthat follow the same procedure with the only differing feature being the\nparameter utilized to define the available pinned CPUs on the compute\nhost. The test updates two compute hosts to use different cpu ranges for\ncpu_dedicated_set, e.g. host0 uses [0-1] and host1 [2-3]. An instance is\ncreated and its associated pinned CPUs are recorded. It is then migrated\nto the other host and the updated pinned CPUs are compared against the\nCPUs prior to migration, asserting they are no longer the same. Finally\nthe test soft reboots the instance and asserts that its pinned CPUs\nremain the same.\n\nTest introduces three classes to test_live_migration.py. First is\nLiveMigrationAndReboot which handles all of the test logic. It\u0027s two\nchildren, VCPUPinSetMigrateAndReboot and CPUDedicatedMigrateAndReboot,\nprovide test parameters necessary to execute the test logic with either\nvcpu_pin_set or cpu_dedicated_set.\n\nThe tests needs to leverage a lot of the helper functions found in\ntest_cpu_pinning.NUMALiveMigrationBase. To prevent duplication and since\nthese tests does not work with anything NUMA specific, the necessary\nhelper functions were moved to base.BaseWhiteboxComputeTest. This\nincludes get_all_cpus, get_pinning_as_set, and _get_cpu_set.\n\nLastly it moves parse_cpu_spec from compute.test_cpu_pinning to the\nutils module.\n\n[1] https://bugs.launchpad.net/nova/+bug/1890501\n\nChange-Id: I0271894acd0689b947974c86910b3d8c41aa9d72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/b697fb686e5b2c57cb799365c76579290544ddb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/b697fb686e5b2c57cb799365c76579290544ddb2"}]},"branch":"refs/heads/master"},"04ecf196873a60f5ec90e555e44ec5b3eb43cc14":{"kind":"REWORK","_number":4,"created":"2020-10-02 18:32:50.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/87/749987/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/87/749987/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/4"}}},"commit":{"parents":[{"commit":"720f25ab11c39b325ff99181d11fccc72c11aaab","subject":"Merge \"Update exception message for nova service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/720f25ab11c39b325ff99181d11fccc72c11aaab"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 14:56:35.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-10-02 18:31:07.000000000","tz":-240},"subject":"Test soft reboot after live-migration","message":"Test soft reboot after live-migration\n\nCommit looks to add regression coverage for [1]. It introduces two tests\nthat follow the same procedure with the only differing feature being the\nparameter utilized to define the available pinned CPUs on the compute\nhost. The test updates two compute hosts to use different cpu ranges for\ncpu_dedicated_set, e.g. host0 uses [0-1] and host1 [2-3]. An instance is\ncreated and its associated pinned CPUs are recorded. It is then migrated\nto the other host and the updated pinned CPUs are compared against the\nCPUs prior to migration, asserting they are no longer the same. Finally\nthe test soft reboots the instance and asserts that its pinned CPUs\nremain the same.\n\nTest introduces four classes to test_live_migration.py. First is\nLiveMigrationAndReboot which handles all of the test logic. It\u0027s two\nchildren, VCPUPinSetMigrateAndReboot and CPUDedicatedMigrateAndReboot,\nprovide test parameters necessary to execute the test logic with either\nvcpu_pin_set or cpu_dedicated_set. Lastly it creates a new base class\nfor all tests, LiveMigrationBase, that allows for LiveMigrationTest and\nLiveMigrationAndReboot to both inherit from.\n\nThe tests needs to leverage a lot of the helper functions found in\ntest_cpu_pinning.NUMALiveMigrationBase. To prevent duplication and since\nthese tests does not work with anything NUMA specific, the necessary\nhelper functions were moved to base.BaseWhiteboxComputeTest. This\nincludes get_all_cpus, get_pinning_as_set, and _get_cpu_set.\n\nLastly it moves parse_cpu_spec from compute.test_cpu_pinning to the\nutils module.\n\n[1] https://bugs.launchpad.net/nova/+bug/1890501\n\nChange-Id: I0271894acd0689b947974c86910b3d8c41aa9d72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/04ecf196873a60f5ec90e555e44ec5b3eb43cc14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/04ecf196873a60f5ec90e555e44ec5b3eb43cc14"}]},"branch":"refs/heads/master"},"30c8018731e8c5099757e5ea46af9f635c0747ba":{"kind":"REWORK","_number":5,"created":"2020-10-05 18:43:41.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/87/749987/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/87/749987/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/87/749987/5"}}},"commit":{"parents":[{"commit":"720f25ab11c39b325ff99181d11fccc72c11aaab","subject":"Merge \"Update exception message for nova service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/720f25ab11c39b325ff99181d11fccc72c11aaab"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2020-09-04 14:56:35.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-10-05 18:43:26.000000000","tz":-240},"subject":"Test soft reboot after live-migration","message":"Test soft reboot after live-migration\n\nCommit looks to add regression coverage for [1]. It introduces two tests\nthat follow the same procedure with the only differing feature being the\nparameter utilized to define the available pinned CPUs on the compute\nhost. The test updates two compute hosts to use different cpu ranges for\ncpu_dedicated_set, e.g. host0 uses [0-1] and host1 [2-3]. An instance is\ncreated and its associated pinned CPUs are recorded. It is then migrated\nto the other host and the updated pinned CPUs are compared against the\nCPUs prior to migration, asserting they are no longer the same. Finally\nthe test soft reboots the instance and asserts that its pinned CPUs\nremain the same.\n\nTest introduces four classes to test_live_migration.py. First is\nLiveMigrationAndReboot which handles all of the test logic. It\u0027s two\nchildren, VCPUPinSetMigrateAndReboot and CPUDedicatedMigrateAndReboot,\nprovide test parameters necessary to execute the test logic with either\nvcpu_pin_set or cpu_dedicated_set. Lastly it creates a new base class\nfor all tests, LiveMigrationBase, that allows for LiveMigrationTest and\nLiveMigrationAndReboot to both inherit from.\n\nThe tests needs to leverage a lot of the helper functions found in\ntest_cpu_pinning.NUMALiveMigrationBase. To prevent duplication and since\nthese tests does not work with anything NUMA specific, the necessary\nhelper functions were moved to base.BaseWhiteboxComputeTest. This\nincludes get_all_cpus, get_pinning_as_set, and _get_cpu_set.\n\nLastly it moves parse_cpu_spec from compute.test_cpu_pinning to the\nutils module.\n\n[1] https://bugs.launchpad.net/nova/+bug/1890501\n\nChange-Id: I0271894acd0689b947974c86910b3d8c41aa9d72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/30c8018731e8c5099757e5ea46af9f635c0747ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/30c8018731e8c5099757e5ea46af9f635c0747ba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
