)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~750011","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I6964475cca973a305d982b31d660858c81929772","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"use-ubuntu-focal","hashtags":[],"change_id":"I6964475cca973a305d982b31d660858c81929772","subject":"Clean up service management","status":"MERGED","created":"2020-09-04 18:35:57.000000000","updated":"2020-10-30 00:42:44.000000000","submitted":"2020-10-30 00:42:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"750011-1604018564681-cb4ec074","meta_rev_id":"8bc84fd0711b2bc3a284ce354bebd316c91106ed","_number":750011,"virtual_id_number":750011,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-30 00:42:44.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":2,"date":"2020-10-29 23:05:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2020-10-29 23:55:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"value":2,"date":"2020-10-28 14:20:58.000000000","_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":1,"date":"2020-10-29 23:05:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"value":0,"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-28 14:20:58.000000000","updated_by":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"reviewer":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"state":"REVIEWER"},{"updated":"2020-10-29 23:05:44.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-10-29 23:55:06.000000000","updated_by":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"reviewer":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"state":"REVIEWER"},{"updated":"2020-10-30 00:42:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"79d2492a211d650d7ab41be8f7507b170b466f6e","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-04 18:35:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e1c8f2d3320b6f35af8a879f391168fbba6b500","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 20:18:57.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d48fdc4a02f1416b9399c1666527ba44 : FAILURE in 3m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5b2ddb1497c142ecb484ef26de16ac11 : FAILURE in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4b968f0ad30e496f8e87e52619494d0c : FAILURE in 3m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/024e909843b04a249975a55e3a6d82ab : FAILURE in 4m 42s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/32a03c7b220d48abaa706e0998678335 : FAILURE in 1h 41m 08s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/1548f0b7d3ac446e93108e1017ddd279 : RETRY_LIMIT in 8m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"da879be1adac0900337f147dc424a9c0a0ee9cc3","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-09-14 17:41:34.000000000","message":"Patch Set 1: Code-Review-1\n\nthe test failures are real you still have tests that try to call restart","accounts_in_message":[],"_revision_number":1},{"id":"6c6d09fed33a7a8d74bd75b1919d22940d2c5447","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-15 15:05:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"846f8eacdc8ef2f71080f5f22512d6a472eb6f00","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-15 15:05:48.000000000","message":"Patch Set 2:\n\n\u003e the test failures are real you still have tests that try to call\n \u003e restart\n\nYep, fixed.","accounts_in_message":[],"_revision_number":2},{"id":"03b7b369fadba751376088691866bb125e601ff5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-15 16:26:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/255efcaa928a4acb893f500fdf561ab0 : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1d62babf1337489b864a9f1e61469a32 : SUCCESS in 4m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/772b3aa6feaf4e0a97d6b6383af931f5 : SUCCESS in 3m 32s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/f8a261f1122d480cac134b2f14d90a57 : FAILURE in 1h 18m 16s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/c67afa543192426da79d7ca6e531624c : RETRY_LIMIT in 8m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"afbc2de37931524cbdaca71298cb212c00e1ac65","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-15 17:13:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6f0879b5aa7b9c16370de36ec9333b09b4feda30","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-15 18:35:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9fde259618414a15a16e2825c5a8b452 : SUCCESS in 3m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/50bcfb09ee2e41198e817bf28ccadfd2 : SUCCESS in 3m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6dfcfe72915c41c5ba5dd1bf56d879dd : SUCCESS in 3m 23s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/602f572185e543aab552357cc2b0c244 : SUCCESS in 1h 20m 12s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/0d11bbc0a5764bf6b8630fc10ae3319b : RETRY_LIMIT in 8m 37s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"72efdec657037362a999cdbb5678d22fc4a02036","author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"date":"2020-10-19 14:34:47.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"a8bbca9b4b96f2b8f55d59ab2f811259fe0455e3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-19 16:30:08.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7834ac23594347479fecb07c295f204b : SUCCESS in 7m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5824865b0b64adda8583f4aa86502de : SUCCESS in 5m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3dd40aca918a4c85b8cf2f8cf3e84205 : SUCCESS in 6m 05s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/a85ad8c14f3e40f08440e6612df72ee0 : SUCCESS in 1h 31m 13s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/7dafd9f118f5405eaa2efce6f0fbe8d6 : RETRY_LIMIT in 10m 33s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"1ac4c6268e47d1aefd31904d745dc308baade86a","author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"date":"2020-10-28 14:20:58.000000000","message":"Patch Set 3: Code-Review+2\n\nthis patch looks good to me as we currently not using restart command and it can be used as stop/start execution anyways if needed so separate conf option for restart is not needed here .\n\nI will wait for other reviewer to have a final check before merging it but looks good to me overall.","accounts_in_message":[],"_revision_number":3},{"id":"c2d4c6014e79c24853d710a13d78706bc2dfe367","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-10-29 23:02:05.000000000","message":"Patch Set 3:\n\nseans-nfv-ci: recheck","accounts_in_message":[],"_revision_number":3},{"id":"2a542ef8d189b2e0ecd6aa27b0462c9b67d1f65a","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-10-29 23:02:21.000000000","message":"Patch Set 3:\n\nStarting seans-nfv-ci jobs.","accounts_in_message":[],"_revision_number":3},{"id":"412da47975a3e99473edcb0cce11354c1687804c","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-10-29 23:05:44.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"059bfa2d2a69f17fa859f95f69663754ae896945","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-29 23:05:57.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"f3ad7e9bac8c66d6a0d9dc837d28c597aca4de7c","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-10-29 23:55:06.000000000","message":"Patch Set 3: Code-Review+1\n\nBuild succeeded (seans-nfv-ci pipeline).\n\n- whitebox-multinode-multinuma-devstack https://zuul.seanmooney.info/build/db08fcac2a6c4c8f85ee59017fd989b5 : SUCCESS in 51m 29s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"dd38ab96d7041b61065e98d278e33e95bcf84229","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-30 00:42:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"567714ed16f377c48e64d9c29bcbf87dc81043c3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-30 00:42:44.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/953bb47f66874931ab912eaafc99a1d2 : SUCCESS in 2m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/17271bd4a16e47c498b446c0a78060f9 : SUCCESS in 3m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d93717bea38c428cbcdee54eab74ed9e : SUCCESS in 3m 21s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/0a849d7a728d4499a7409524bd786811 : SUCCESS in 1h 32m 21s\n- whitebox-multinode-multinuma-devstack https://zuul.opendev.org/t/openstack/build/None : NODE_FAILURE in 0s (non-voting)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1de36b326815a6325b07c5e8f1e56517825c1e77","revisions":{"37aba1952525d08a996b72b54f37bef43a5c096b":{"kind":"REWORK","_number":1,"created":"2020-09-04 18:35:57.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/750011/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/750011/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/1"}}},"commit":{"parents":[{"commit":"afb8f1df1bfd01493f01ad1f6d42597716e036fc","subject":"Get rid of service start/stop sleep","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/afb8f1df1bfd01493f01ad1f6d42597716e036fc"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-04 18:30:15.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-04 18:30:15.000000000","tz":-240},"subject":"Clean up service management","message":"Clean up service management\n\nTo ensure consistency and have our code better reflect reality, this\npatch includes the following cleanups:\n\n* The base ServiceManager class gets a start() method, thus giving all\n  services the basic start/stop/restart methods/\n\n* The libvirt service manager loses its restart() method in favor of\n  start(). restart() was never actually used to restart libvirt, but\n  rather to starts it from scratch after having previously stopped it.\n\n* The return values of start/stop/restart were never used. Don\u0027t\n  returning anything.\n\nChange-Id: I6964475cca973a305d982b31d660858c81929772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/37aba1952525d08a996b72b54f37bef43a5c096b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/37aba1952525d08a996b72b54f37bef43a5c096b"}]},"branch":"refs/heads/master"},"662b530278961e7f46afd1ac580c06997e63dc34":{"kind":"REWORK","_number":2,"created":"2020-09-15 15:05:24.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/750011/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/750011/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/2"}}},"commit":{"parents":[{"commit":"875aa46cea23ceb7e575660197c4b3214c3b961a","subject":"Get rid of service start/stop sleep","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/875aa46cea23ceb7e575660197c4b3214c3b961a"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-04 18:30:15.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-15 15:04:18.000000000","tz":-240},"subject":"Clean up service management","message":"Clean up service management\n\nTo ensure consistency and have our code better reflect reality, this\npatch includes the following cleanups:\n\n* The base ServiceManager class gets a start() method, thus giving all\n  services the basic start/stop/restart methods.\n\n* The libvirt service manager loses its restart() method in favor of\n  start(). restart() was never actually used to restart libvirt, but\n  rather to starts it from scratch after having previously stopped it.\n\n* The return values of start/stop/restart were never used. Don\u0027t\n  returning anything.\n\nChange-Id: I6964475cca973a305d982b31d660858c81929772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/662b530278961e7f46afd1ac580c06997e63dc34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/662b530278961e7f46afd1ac580c06997e63dc34"}]},"branch":"refs/heads/master"},"1de36b326815a6325b07c5e8f1e56517825c1e77":{"kind":"REWORK","_number":3,"created":"2020-09-15 17:13:46.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/750011/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/750011/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/750011/3"}}},"commit":{"parents":[{"commit":"875aa46cea23ceb7e575660197c4b3214c3b961a","subject":"Get rid of service start/stop sleep","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/875aa46cea23ceb7e575660197c4b3214c3b961a"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-04 18:30:15.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-15 17:12:41.000000000","tz":-240},"subject":"Clean up service management","message":"Clean up service management\n\nTo ensure consistency and have our code better reflect reality, this\npatch includes the following cleanups:\n\n* The base ServiceManager class gets a start() method, thus giving all\n  services the basic start/stop/restart methods.\n\n* The libvirt service manager loses its restart() method in favor of\n  start(). restart() was never actually used to restart libvirt, but\n  rather to starts it from scratch after having previously stopped it.\n\n* The return values of start/stop/restart were never used. Don\u0027t\n  returning anything.\n\nChange-Id: I6964475cca973a305d982b31d660858c81929772\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/1de36b326815a6325b07c5e8f1e56517825c1e77"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/1de36b326815a6325b07c5e8f1e56517825c1e77"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}