)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"839eb4ad4c83166eb12769d6e84129cefad995cd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This will be providing qe_test_coverage for the following"},{"line_number":16,"context_line":"BZ[1]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://bugzillia.redhat.com/show_bug.cgi?id\u003d1849488"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id57fdcb7b6188cbda01da135f39b54c17f7a4cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_b0032ebe","line":18,"updated":"2020-09-21 17:16:29.000000000","message":"Since this is upstream would probably be better to reference https://bugs.launchpad.net/nova/+bug/1867075 instead.","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This will be providing qe_test_coverage for the following"},{"line_number":16,"context_line":"BZ[1]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://bugzillia.redhat.com/show_bug.cgi?id\u003d1849488"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id57fdcb7b6188cbda01da135f39b54c17f7a4cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_a0f45788","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":22},"updated":"2020-09-23 13:19:30.000000000","message":"also, \u0027bugzilla\u0027","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"93c870f1086bba8766f2845e0f572190fb726399","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This will be providing qe_test_coverage for the following"},{"line_number":16,"context_line":"BZ[1]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://bugzillia.redhat.com/show_bug.cgi?id\u003d1849488"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id57fdcb7b6188cbda01da135f39b54c17f7a4cf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_0d953c3d","line":18,"in_reply_to":"9f560f44_b0032ebe","updated":"2020-09-25 18:47:17.000000000","message":"\u003e Since this is upstream would probably be better to reference\n \u003e https://bugs.launchpad.net/nova/+bug/1867075 instead.\n\nYes just the nova launchpad bug can be enough","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"11d6f20fabfb2d0c10885703a14f93ee3fdabe3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"has hw_cdrom_bus: scsi, hw_disk_bus: scsi, hw_scsi_model:"},{"line_number":13,"context_line":"virtio-scsi."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This will be providing qe_test_coverage for the following"},{"line_number":16,"context_line":"BZ:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: #1867075"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_589507e3","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":3},"updated":"2020-09-29 15:07:28.000000000","message":"Remove","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"}],"whitebox_tempest_plugin/api/compute/test_virtio_scsi_attach.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.flavor \u003d self.create_flavor()"},{"line_number":43,"context_line":"        self.img_id \u003d self.copy_default_image(hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":44,"context_line":"                                              hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":45,"context_line":"                                              hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_attached_disks(self, server_id):"},{"line_number":48,"context_line":"        \"\"\"Returns all disk devices attached to the server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9ba9c2de","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":65},"updated":"2020-09-23 13:19:30.000000000","message":"what\u0027s the impact of this on other non-change related tests in here?","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d2d6ddede910e82d14bb3c060fbf29af7efef54f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.flavor \u003d self.create_flavor()"},{"line_number":43,"context_line":"        self.img_id \u003d self.copy_default_image(hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":44,"context_line":"                                              hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":45,"context_line":"                                              hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_attached_disks(self, server_id):"},{"line_number":48,"context_line":"        \"\"\"Returns all disk devices attached to the server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_25cf7e7f","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":65},"in_reply_to":"9f560f44_2354bf21","updated":"2020-09-25 15:10:53.000000000","message":"\u003e I don\u0027t see any impact on the other tests, it will be an add on\n \u003e scsi property for cdrom and also as per the date job all tests\n \u003e looks happy\n\nCan u post the test run result for all tests?","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"757e792a1ae389c963a5068c0a329b1a9ad2b1f6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.flavor \u003d self.create_flavor()"},{"line_number":43,"context_line":"        self.img_id \u003d self.copy_default_image(hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":44,"context_line":"                                              hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":45,"context_line":"                                              hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_attached_disks(self, server_id):"},{"line_number":48,"context_line":"        \"\"\"Returns all disk devices attached to the server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c0b4b0f3","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":65},"in_reply_to":"9f560f44_25cf7e7f","updated":"2020-09-25 15:38:19.000000000","message":"that will be in gate job as well, this is the link:\nhttps://api.us-east.open-edge.io:8080/swift/v1/AUTH_e02c11e4e2c24efc98022353c88ab506/zuul_opendev_logs_699/752947/2/check/whitebox-multinode-devstack/6992524/testr_results.html","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8680758e1ac79854e464a1e36fbd6571068c7861","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.flavor \u003d self.create_flavor()"},{"line_number":43,"context_line":"        self.img_id \u003d self.copy_default_image(hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":44,"context_line":"                                              hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":45,"context_line":"                                              hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_attached_disks(self, server_id):"},{"line_number":48,"context_line":"        \"\"\"Returns all disk devices attached to the server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2354bf21","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":65},"in_reply_to":"9f560f44_9ba9c2de","updated":"2020-09-25 15:02:20.000000000","message":"I don\u0027t see any impact on the other tests, it will be an add on scsi property for cdrom and also as per the date job all tests looks happy","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"93c870f1086bba8766f2845e0f572190fb726399","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.flavor \u003d self.create_flavor()"},{"line_number":43,"context_line":"        self.img_id \u003d self.copy_default_image(hw_scsi_model\u003d\u0027virtio-scsi\u0027,"},{"line_number":44,"context_line":"                                              hw_disk_bus\u003d\u0027scsi\u0027,"},{"line_number":45,"context_line":"                                              hw_cdrom_bus\u003d\u0027scsi\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_attached_disks(self, server_id):"},{"line_number":48,"context_line":"        \"\"\"Returns all disk devices attached to the server"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2d9ac06d","line":45,"range":{"start_line":45,"start_character":46,"end_line":45,"end_character":65},"in_reply_to":"9f560f44_c0b4b0f3","updated":"2020-09-25 18:47:17.000000000","message":"\u003e that will be in gate job as well, this is the link:\n \u003e https://api.us-east.open-edge.io:8080/swift/v1/AUTH_e02c11e4e2c24efc98022353c88ab506/zuul_opendev_logs_699/752947/2/check/whitebox-multinode-devstack/6992524/testr_results.html\n\nThanks, looks good","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                              \"Created vol ids do not align with serial ids \""},{"line_number":201,"context_line":"                              \"found on the domain\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":204,"context_line":"        host1, host2 \u003d self.list_compute_hosts()"},{"line_number":205,"context_line":"        host1_sm \u003d clients.NovaServiceManager(host1, \u0027nova-compute\u0027,"},{"line_number":206,"context_line":"                                              self.os_admin.services_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fb71de46","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":42},"updated":"2020-09-23 13:19:30.000000000","message":"since we\u0027re detaching also using iso9660 config-drive can we have both in the test name, possible add a skip check if needed too?\njust an example- test_attach_detach_scsi_config_drive_iso9660_disk\n\nAlso, missing: description of the test","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d2d6ddede910e82d14bb3c060fbf29af7efef54f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                              \"Created vol ids do not align with serial ids \""},{"line_number":201,"context_line":"                              \"found on the domain\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":204,"context_line":"        host1, host2 \u003d self.list_compute_hosts()"},{"line_number":205,"context_line":"        host1_sm \u003d clients.NovaServiceManager(host1, \u0027nova-compute\u0027,"},{"line_number":206,"context_line":"                                              self.os_admin.services_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_85a3eab0","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":42},"in_reply_to":"9f560f44_25dc9e72","updated":"2020-09-25 15:10:53.000000000","message":"\u003e yeah I can add the config drive name as well, Umm but this give me\n \u003e an idea of adding config_Drive format as whitebox config option so\n \u003e that it gives flexibility to use any of the supported format\n\nEven better :) fine with either","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8680758e1ac79854e464a1e36fbd6571068c7861","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                              \"Created vol ids do not align with serial ids \""},{"line_number":201,"context_line":"                              \"found on the domain\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":204,"context_line":"        host1, host2 \u003d self.list_compute_hosts()"},{"line_number":205,"context_line":"        host1_sm \u003d clients.NovaServiceManager(host1, \u0027nova-compute\u0027,"},{"line_number":206,"context_line":"                                              self.os_admin.services_client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_25dc9e72","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":42},"in_reply_to":"9f560f44_fb71de46","updated":"2020-09-25 15:02:20.000000000","message":"yeah I can add the config drive name as well, Umm but this give me an idea of adding config_Drive format as whitebox config option so that it gives flexibility to use any of the supported format","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                              \"found on the domain\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":204,"context_line":"        host1, host2 \u003d self.list_compute_hosts()"},{"line_number":205,"context_line":"        host1_sm \u003d clients.NovaServiceManager(host1, \u0027nova-compute\u0027,"},{"line_number":206,"context_line":"                                              self.os_admin.services_client)"},{"line_number":207,"context_line":"        host2_sm \u003d clients.NovaServiceManager(host2, \u0027nova-compute\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fb443e4a","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":48},"updated":"2020-09-23 13:19:30.000000000","message":"Don\u0027t you need a min(or max)_compute_node set to 2 here in the skip checks","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8680758e1ac79854e464a1e36fbd6571068c7861","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                              \"found on the domain\")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":204,"context_line":"        host1, host2 \u003d self.list_compute_hosts()"},{"line_number":205,"context_line":"        host1_sm \u003d clients.NovaServiceManager(host1, \u0027nova-compute\u0027,"},{"line_number":206,"context_line":"                                              self.os_admin.services_client)"},{"line_number":207,"context_line":"        host2_sm \u003d clients.NovaServiceManager(host2, \u0027nova-compute\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_65e21632","line":204,"range":{"start_line":204,"start_character":8,"end_line":204,"end_character":48},"in_reply_to":"9f560f44_fb443e4a","updated":"2020-09-25 15:02:20.000000000","message":"yup, good point","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            host1_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":211,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":212,"context_line":"                                    (\u0027DEFAULT\u0027,"},{"line_number":213,"context_line":"                                        \u0027config_drive_format\u0027, \u0027iso9660\u0027)),"},{"line_number":214,"context_line":"            host2_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":215,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":216,"context_line":"                                    (\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c074ebd2","line":213,"range":{"start_line":213,"start_character":38,"end_line":213,"end_character":40},"updated":"2020-09-23 13:19:30.000000000","message":"extra space","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8680758e1ac79854e464a1e36fbd6571068c7861","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            host1_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":211,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":212,"context_line":"                                    (\u0027DEFAULT\u0027,"},{"line_number":213,"context_line":"                                        \u0027config_drive_format\u0027, \u0027iso9660\u0027)),"},{"line_number":214,"context_line":"            host2_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":215,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":216,"context_line":"                                    (\u0027DEFAULT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_45dd526b","line":213,"range":{"start_line":213,"start_character":38,"end_line":213,"end_character":40},"in_reply_to":"9f560f44_c074ebd2","updated":"2020-09-25 15:02:20.000000000","message":"done","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"d522d9b2de442e3540ec5f120383e9589adb8d13","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            host2_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":215,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":216,"context_line":"                                    (\u0027DEFAULT\u0027,"},{"line_number":217,"context_line":"                                        \u0027config_drive_format\u0027, \u0027iso9660\u0027))"},{"line_number":218,"context_line":"        ):"},{"line_number":219,"context_line":"            server \u003d self.create_test_server(flavor\u003dself.flavor[\u0027id\u0027],"},{"line_number":220,"context_line":"                                             image_id\u003dself.img_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_007b83be","line":217,"range":{"start_line":217,"start_character":38,"end_line":217,"end_character":40},"updated":"2020-09-23 13:19:30.000000000","message":"extra space","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8680758e1ac79854e464a1e36fbd6571068c7861","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            host2_sm.config_options((\u0027DEFAULT\u0027,"},{"line_number":215,"context_line":"                                     \u0027force_config_drive\u0027, True),"},{"line_number":216,"context_line":"                                    (\u0027DEFAULT\u0027,"},{"line_number":217,"context_line":"                                        \u0027config_drive_format\u0027, \u0027iso9660\u0027))"},{"line_number":218,"context_line":"        ):"},{"line_number":219,"context_line":"            server \u003d self.create_test_server(flavor\u003dself.flavor[\u0027id\u0027],"},{"line_number":220,"context_line":"                                             image_id\u003dself.img_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a5d1ce59","line":217,"range":{"start_line":217,"start_character":38,"end_line":217,"end_character":40},"in_reply_to":"9f560f44_007b83be","updated":"2020-09-25 15:02:20.000000000","message":"done","commit_id":"12b26489b4b1ad8b557aec251c7c6c7785b3a9dc"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"7c43eaecf8c14f61d321d121f225f96bc1f65393","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    @testtools.skipIf(CONF.compute.min_compute_nodes \u003c 2 or"},{"line_number":204,"context_line":"                      CONF.whitebox.max_compute_nodes \u003e 2,"},{"line_number":205,"context_line":"                      \"Need exactly 2 compute nodes,\""},{"line_number":206,"context_line":"                      \"skipping attach/detach scsi config drive disk test\")"},{"line_number":207,"context_line":"    def test_attach_scsi_config_drive_disk(self):"},{"line_number":208,"context_line":"        \"\"\"Enable the config drive, add the config_drive format in"},{"line_number":209,"context_line":"        nova.conf, followed by booting an instance from an image with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d8fbd745","line":206,"range":{"start_line":206,"start_character":23,"end_line":206,"end_character":24},"updated":"2020-09-29 15:06:58.000000000","message":"nit: S","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f632b72d3df9af3a6369790678bc31380f1efddf","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                              self.os_admin.services_client)"},{"line_number":218,"context_line":"        with whitebox_utils.multicontext("},{"line_number":219,"context_line":"            host1_sm.config_options("},{"line_number":220,"context_line":"                (\u0027DEFAULT\u0027, \u0027force_config_drive\u0027, True),"},{"line_number":221,"context_line":"                (\u0027DEFAULT\u0027, \u0027config_drive_format\u0027,"},{"line_number":222,"context_line":"                 CONF.compute_feature_enabled.config_drive_format)),"},{"line_number":223,"context_line":"            host2_sm.config_options("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a414af42","line":220,"updated":"2020-10-05 19:26:51.000000000","message":"We don\u0027t need the host-level config option IIRC, we can use the config_drive request param when booting a server, like in [1]\n\n[1] https://github.com/openstack/tempest/blob/da58be008e00f3ba4139804aa272535e712c36aa/tempest/api/compute/servers/test_device_tagging.py#L214","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"6d12d8966c75842d65b95400437952086887b24f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                                              self.os_admin.services_client)"},{"line_number":218,"context_line":"        with whitebox_utils.multicontext("},{"line_number":219,"context_line":"            host1_sm.config_options("},{"line_number":220,"context_line":"                (\u0027DEFAULT\u0027, \u0027force_config_drive\u0027, True),"},{"line_number":221,"context_line":"                (\u0027DEFAULT\u0027, \u0027config_drive_format\u0027,"},{"line_number":222,"context_line":"                 CONF.compute_feature_enabled.config_drive_format)),"},{"line_number":223,"context_line":"            host2_sm.config_options("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_676e19ff","line":220,"in_reply_to":"9f560f44_a414af42","updated":"2020-10-05 21:53:08.000000000","message":"Umm yeah you are right we can pass it through api also, I totally forget that.","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f632b72d3df9af3a6369790678bc31380f1efddf","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            server \u003d self.create_test_server(flavor\u003dself.flavor[\u0027id\u0027],"},{"line_number":229,"context_line":"                                             image_id\u003dself.img_id)"},{"line_number":230,"context_line":"            volume \u003d self.create_volume()"},{"line_number":231,"context_line":"            self.addCleanup(self.delete_volume, volume[\u0027id\u0027])"},{"line_number":232,"context_line":"            attachment \u003d self.attach_volume(server, volume)"},{"line_number":233,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":234,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f04ca2c9","line":231,"updated":"2020-10-05 19:26:51.000000000","message":"nit: if this is using create_volume() from tempest/api/compute/base.py as a I think it is, addCleanup() is done for you.","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"6d12d8966c75842d65b95400437952086887b24f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            server \u003d self.create_test_server(flavor\u003dself.flavor[\u0027id\u0027],"},{"line_number":229,"context_line":"                                             image_id\u003dself.img_id)"},{"line_number":230,"context_line":"            volume \u003d self.create_volume()"},{"line_number":231,"context_line":"            self.addCleanup(self.delete_volume, volume[\u0027id\u0027])"},{"line_number":232,"context_line":"            attachment \u003d self.attach_volume(server, volume)"},{"line_number":233,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":234,"context_line":"                self.volumes_client, attachment[\u0027volumeId\u0027], \u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_07491d8d","line":231,"in_reply_to":"9f560f44_f04ca2c9","updated":"2020-10-05 21:53:08.000000000","message":"I don\u0027t know but i was observing some issue if I don\u0027t add this as it seems other tests in the same class started failing\nas it seems to have some sequence difference might be some race condition among the tests in same class.\n\nhttps://api.us-east.open-edge.io:8080/swift/v1/AUTH_e02c11e4e2c24efc98022353c88ab506/zuul_opendev_logs_dd0/752947/1/check/whitebox-multinode-devstack/dd06977/testr_results.html","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"8201f37cd91fc979e131e239b9f738e19a9002c2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      None]"},{"line_number":105,"context_line":"        return serial_ids"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e 8,"},{"line_number":108,"context_line":"                          \u0027Need at least 8GB of storage to execute\u0027)"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"},{"line_number":110,"context_line":"        \"\"\"Using block device mapping, boot an instance with more than six"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_6650bb2d","line":107,"updated":"2020-10-07 17:25:11.000000000","message":"Since the flavor_volume size can have varying values we can\u0027t use the hardcoded 8GB as an acceptable value.  It would need to be the size of the flavor_volume_size plus the 7GB disks been attach. e.g:\nskipUnless(CONF.whitebox.available_cinder_storage \u003e (CONF.whitebox.flavor_volume_size + 7), \u0027Need at least %sGB of storage to execute\u0027 % (CONF.whitebox.flavor_volume_size + 7)","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"e5aa5a325c412576ac076f93ff8c45df691edb96","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                      None]"},{"line_number":105,"context_line":"        return serial_ids"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e 8,"},{"line_number":108,"context_line":"                          \u0027Need at least 8GB of storage to execute\u0027)"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"},{"line_number":110,"context_line":"        \"\"\"Using block device mapping, boot an instance with more than six"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_89e08029","line":107,"in_reply_to":"9f560f44_6650bb2d","updated":"2020-10-09 18:23:54.000000000","message":"correct, yeah good catch. I missed this","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"8201f37cd91fc979e131e239b9f738e19a9002c2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            self.volumes_client, attachment[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":214,"context_line":"        volume_after_attach \u003d self.servers_client.list_volume_attachments("},{"line_number":215,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":216,"context_line":"        self.assertEqual(1, len(volume_after_attach))"},{"line_number":217,"context_line":"        self.servers_client.detach_volume("},{"line_number":218,"context_line":"            server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":219,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a61c9377","line":216,"updated":"2020-10-07 17:25:11.000000000","message":"An additional error message if/when this fails can be useful for debugging.","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"e5aa5a325c412576ac076f93ff8c45df691edb96","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            self.volumes_client, attachment[\u0027volumeId\u0027], \u0027in-use\u0027)"},{"line_number":214,"context_line":"        volume_after_attach \u003d self.servers_client.list_volume_attachments("},{"line_number":215,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":216,"context_line":"        self.assertEqual(1, len(volume_after_attach))"},{"line_number":217,"context_line":"        self.servers_client.detach_volume("},{"line_number":218,"context_line":"            server[\u0027id\u0027], attachment[\u0027volumeId\u0027])"},{"line_number":219,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_c9cf18b1","line":216,"in_reply_to":"9f560f44_a61c9377","updated":"2020-10-09 18:23:54.000000000","message":"done","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"8201f37cd91fc979e131e239b9f738e19a9002c2","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":221,"context_line":"        volume_after_detach \u003d self.servers_client.list_volume_attachments("},{"line_number":222,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":223,"context_line":"        self.assertEqual(0, len(volume_after_detach))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e6120b61","line":223,"updated":"2020-10-07 17:25:11.000000000","message":"Ditto L#216","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"e5aa5a325c412576ac076f93ff8c45df691edb96","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            self.volumes_client, attachment[\u0027volumeId\u0027], \u0027available\u0027)"},{"line_number":221,"context_line":"        volume_after_detach \u003d self.servers_client.list_volume_attachments("},{"line_number":222,"context_line":"            server[\u0027id\u0027])[\u0027volumeAttachments\u0027]"},{"line_number":223,"context_line":"        self.assertEqual(0, len(volume_after_detach))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a9d46448","line":223,"in_reply_to":"9f560f44_e6120b61","updated":"2020-10-09 18:23:54.000000000","message":"done","commit_id":"b9dc5855e78b46be374a97c13a4d0eb371a02fe7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"783e3be322ae15603f1e41fc09e5cb8cd833b85f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_2303bf44","side":"PARENT","line":23,"updated":"2020-10-22 13:33:16.000000000","message":"Oy.","commit_id":"bfde546191a660f570d54d6c22bca104444d1b09"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"5234a47a15d0e5a71643aa16d28506ee066b7552","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_a6d23d33","side":"PARENT","line":23,"in_reply_to":"3f65232a_2303bf44","updated":"2020-10-22 13:51:26.000000000","message":"oops I will remove it","commit_id":"bfde546191a660f570d54d6c22bca104444d1b09"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"783e3be322ae15603f1e41fc09e5cb8cd833b85f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return serial_ids"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e"},{"line_number":106,"context_line":"                          (CONF.whitebox.flavor_volume_size + 7),"},{"line_number":107,"context_line":"                          \u0027Need more than %sGB of storage to execute\u0027"},{"line_number":108,"context_line":"                          % (CONF.whitebox.flavor_volume_size + 7))"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_03004334","line":106,"range":{"start_line":106,"start_character":62,"end_line":106,"end_character":63},"updated":"2020-10-22 13:33:16.000000000","message":"Err, magic number?","commit_id":"45086063e9af9af1bf03b57cdb33c06d1bb2cddf"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"5234a47a15d0e5a71643aa16d28506ee066b7552","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return serial_ids"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e"},{"line_number":106,"context_line":"                          (CONF.whitebox.flavor_volume_size + 7),"},{"line_number":107,"context_line":"                          \u0027Need more than %sGB of storage to execute\u0027"},{"line_number":108,"context_line":"                          % (CONF.whitebox.flavor_volume_size + 7))"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_061e910b","line":106,"range":{"start_line":106,"start_character":62,"end_line":106,"end_character":63},"in_reply_to":"3f65232a_03004334","updated":"2020-10-22 13:51:26.000000000","message":"In this CONF.whitebox.flavor_volume_size will be the boot disk and the other 7 will be the disks to create as per #L32","commit_id":"45086063e9af9af1bf03b57cdb33c06d1bb2cddf"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"63b53138826fdb4ef31766552174fd8bd2bab6ee","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return serial_ids"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e"},{"line_number":106,"context_line":"                          (CONF.whitebox.flavor_volume_size + 7),"},{"line_number":107,"context_line":"                          \u0027Need more than %sGB of storage to execute\u0027"},{"line_number":108,"context_line":"                          % (CONF.whitebox.flavor_volume_size + 7))"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_46ed29ee","line":106,"range":{"start_line":106,"start_character":62,"end_line":106,"end_character":63},"in_reply_to":"3f65232a_03004334","updated":"2020-10-22 13:54:28.000000000","message":"The note for the class kind of covers this, but the test creates 7x 1GB disks to test Nova bug 1686116, so the original check was ensuring the deployment had at least 7GB plus a 1GB \u0027buffer\u0027.  This resulted in a skip check of the system volume capacity having 8GB or more to run.  With this update one of the disks can now have a varying size, so the check now is the size of the volume plus 7GB.  Maybe the hardcoded 7 could be replaced by the class variable disks_to_create + a 1GB buffer versus just the number?","commit_id":"45086063e9af9af1bf03b57cdb33c06d1bb2cddf"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"8e4da27760464f00a35ad5f015beea2baa9d0c90","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return serial_ids"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @testtools.skipUnless(CONF.whitebox.available_cinder_storage \u003e"},{"line_number":106,"context_line":"                          (CONF.whitebox.flavor_volume_size + 7),"},{"line_number":107,"context_line":"                          \u0027Need more than %sGB of storage to execute\u0027"},{"line_number":108,"context_line":"                          % (CONF.whitebox.flavor_volume_size + 7))"},{"line_number":109,"context_line":"    def test_boot_with_multiple_disks(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f65232a_61e64f47","line":106,"range":{"start_line":106,"start_character":62,"end_line":106,"end_character":63},"in_reply_to":"3f65232a_46ed29ee","updated":"2020-10-22 14:31:30.000000000","message":"yeah that can be replace with disks_to_create. I will do that","commit_id":"45086063e9af9af1bf03b57cdb33c06d1bb2cddf"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e2a713b81aa41af7b01496c4389eb1b2fda8edf3","unresolved":true,"context_lines":[{"line_number":123,"context_line":"                boot_dict[\u0027volume_size\u0027] \u003d CONF.whitebox.flavor_volume_size"},{"line_number":124,"context_line":"            else:"},{"line_number":125,"context_line":"                boot_dict[\u0027source_type\u0027] \u003d \u0027blank\u0027"},{"line_number":126,"context_line":"                boot_dict[\u0027volume_size\u0027] \u003d 1"},{"line_number":127,"context_line":"            boot_dict.update({\u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":128,"context_line":"                              \u0027boot_index\u0027: i,"},{"line_number":129,"context_line":"                              \u0027disk_bus\u0027: \u0027scsi\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9821cc37_f7bbe67d","line":126,"updated":"2021-01-15 14:48:06.000000000","message":"Ah, this is just setting non-root volume size, which can be 1 for all images, since it\u0027s not actually affected by the image.","commit_id":"1dd0c63df6a744393b01fa8159c45efd8277965f"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f632b72d3df9af3a6369790678bc31380f1efddf","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"compute_features_group_opts \u003d ["},{"line_number":182,"context_line":"    cfg.StrOpt("},{"line_number":183,"context_line":"        \u0027config_drive_format\u0027,"},{"line_number":184,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":185,"context_line":"        help\u003d\u0027config drive format iso9660/vfat used for storing\u0027"},{"line_number":186,"context_line":"             \u0027instance meta data\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_503bcee8","line":183,"updated":"2020-10-05 19:26:51.000000000","message":"Is the config drive format relevant at all? IIUC we just need to have a non-disk SCSI device on the guest before attaching our scsi volume...","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"7677c71e477e5292c217ef17f09fa2d74505aae3","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"compute_features_group_opts \u003d ["},{"line_number":182,"context_line":"    cfg.StrOpt("},{"line_number":183,"context_line":"        \u0027config_drive_format\u0027,"},{"line_number":184,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":185,"context_line":"        help\u003d\u0027config drive format iso9660/vfat used for storing\u0027"},{"line_number":186,"context_line":"             \u0027instance meta data\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dadc1819","line":183,"in_reply_to":"9f560f44_503bcee8","updated":"2020-10-05 23:49:02.000000000","message":"I mean this can give an additional flexibility to pick the format needed. So we can use two jobs even downstream to cover both the config drives format.","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":31239,"name":"Paras Babbar","email":"pbabbar@redhat.com","username":"pbabbar"},"change_message_id":"25c2bde3f162f1c385a7352156cf47dd856adaa5","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"compute_features_group_opts \u003d ["},{"line_number":182,"context_line":"    cfg.StrOpt("},{"line_number":183,"context_line":"        \u0027config_drive_format\u0027,"},{"line_number":184,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":185,"context_line":"        help\u003d\u0027config drive format iso9660/vfat used for storing\u0027"},{"line_number":186,"context_line":"             \u0027instance meta data\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2608832b","line":183,"in_reply_to":"9f560f44_867a2fb8","updated":"2020-10-07 17:21:31.000000000","message":"nops that\u0027s why I have removed and let the tripleo set it at the time of deployment otherwise it will use iso9660 which is the default one","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"02e17f992c2cba8dd9620a59155c08c25ce681df","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"compute_features_group_opts \u003d ["},{"line_number":182,"context_line":"    cfg.StrOpt("},{"line_number":183,"context_line":"        \u0027config_drive_format\u0027,"},{"line_number":184,"context_line":"        default\u003d\u0027iso9660\u0027,"},{"line_number":185,"context_line":"        help\u003d\u0027config drive format iso9660/vfat used for storing\u0027"},{"line_number":186,"context_line":"             \u0027instance meta data\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_867a2fb8","line":183,"in_reply_to":"9f560f44_dadc1819","updated":"2020-10-07 17:16:32.000000000","message":"I thought the test doesn\u0027t actually care about config drive format... does it? As in, it just needs a SCSI CDROM - whether it\u0027s formatted as iso9660 or vfat is irrelevant...","commit_id":"e0e5e14ae24412175df2370d1909293b29583f45"}]}