)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~765211","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I14dddb5846b2330811c496aa7c134d020781edb8","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"selinux_labels","hashtags":[],"change_id":"I14dddb5846b2330811c496aa7c134d020781edb8","subject":"Remove restart_command config option","status":"MERGED","created":"2020-12-02 21:58:07.000000000","updated":"2020-12-03 06:38:12.000000000","submitted":"2020-12-03 06:38:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"765211-selinux_labels","meta_rev_id":"53f93af2099f3903fdba29482b6a1a52675d797e","_number":765211,"virtual_id_number":765211,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-03 06:37:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2020-12-03 01:13:07.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:automatic-ci","value":1,"date":"2020-12-03 02:34:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2020-12-03 01:13:07.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-02 21:58:25.000000000","updated_by":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"reviewer":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"state":"CC"},{"updated":"2020-12-02 21:58:29.000000000","updated_by":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"reviewer":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"state":"REVIEWER"},{"updated":"2020-12-02 22:18:27.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-12-02 23:59:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"924a3ee83b92b7c5e45ab3df51676c1277617118","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-12-02 21:58:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9999b44416271c31745b29caef5fc3f48e7aa17d","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-02 21:58:25.000000000","message":"Patch Set 1:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dc4f11d72276af223ac2e67be9f41744612517fd","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-02 21:58:29.000000000","message":"Patch Set 1: Code-Review-1\n\nBuild failed (automatic-ci pipeline). To rerun just this ci comment\n\"seans-automatic-ci: recheck\". To rerun other ci jobs comment \"recheck\".\nNote this ci does run on \"recheck\".\n\n\n- whitebox-multinode-multinuma-devstack https://zuul.seanmooney.info/t/openstack/build/None : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"aa01c6092f1c0537181dca4fd99788f588c81e1a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-12-02 22:18:27.000000000","message":"Patch Set 1: Code-Review+1\n\nprovisional +1 until ci runs","accounts_in_message":[],"_revision_number":1},{"id":"12b4b71b23dc40ee1bb2a84c9d21df17d88f927a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-12-02 22:53:59.000000000","message":"Patch Set 1:\n\nseans-automatic-ci: recheck","accounts_in_message":[],"_revision_number":1},{"id":"5a82596bf3d98ca3f12e7f437380057ea8103070","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-02 22:54:13.000000000","message":"Patch Set 1: -Code-Review\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c598ca8c3dad89d41a770256f05cce3373fa4446","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-02 23:59:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5d4087c09cf44710a76c323d5bdea7e0 : SUCCESS in 3m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/79e3e229daf847fbb97013bd465bfb1a : SUCCESS in 4m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/66934440a24c4f39ab19fa80eca6e96f : SUCCESS in 4m 01s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/218c4aa3456d4f8b84dc88c322412a5c : SUCCESS in 1h 43m 38s","accounts_in_message":[],"_revision_number":1},{"id":"1213d0b8e69b0a3f24e04e9d692bcc600c515228","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-03 00:13:26.000000000","message":"Patch Set 1: Code-Review+1\n\nBuild succeeded (automatic-ci pipeline).\n\n- whitebox-multinode-multinuma-devstack https://zuul.seanmooney.info/t/openstack/build/049c2bcb6f214bee9d60223c619feb7d : SUCCESS in 1h 18m 40s","accounts_in_message":[],"_revision_number":1},{"id":"6b30bbcfe4f440b5f5fcad0f7fb774bf843a58fe","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-12-03 00:58:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nnit aside this passing both the first-party and third-party ci so upgrading to a +2","accounts_in_message":[],"_revision_number":1},{"id":"0150ccdae8656a12807ee8ef025949147217b2a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-12-03 01:11:40.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1705cea67a586cc27fb764d1d5a5d3e1939cce4a","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-03 01:11:55.000000000","message":"Patch Set 2:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a649327ac93abd837ccd7bedcdaeeebd05a76255","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-12-03 01:12:50.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"ad5f72703546918ced2c6169e7cd788a0f8912bb","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-03 01:13:05.000000000","message":"Patch Set 3:\n\nStarting automatic-ci jobs.","accounts_in_message":[],"_revision_number":3},{"id":"7b4b99310e03aaff98930b84cae5d300d8e1d7cb","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-12-03 01:13:07.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nSean was happy on PS1, fixed the commit message nits.","accounts_in_message":[],"_revision_number":3},{"id":"dfd55fe1648693f98883a5c5b266210a25c88ff4","tag":"autogenerated:zuul:automatic-ci","author":{"_account_id":28006,"name":"teim-ci","display_name":"teim-ci","email":"ci@seanmooney.info","username":"ci-sean-mooney","status":"this is a third-party ci account run by sean-k-mooney on irc\nhosted at zuul.teim.app"},"date":"2020-12-03 02:34:49.000000000","message":"Patch Set 3: Code-Review+1\n\nBuild succeeded (automatic-ci pipeline).\n\n- whitebox-multinode-multinuma-devstack https://zuul.seanmooney.info/t/openstack/build/5791da03c64346f09e6779bef59023f5 : SUCCESS in 1h 18m 20s","accounts_in_message":[],"_revision_number":3},{"id":"12eccaca347afec461437e2a1170995ebfebe992","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 03:08:55.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a3bdabfca63e4a0c8d369193610ab902 : SUCCESS in 2m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d4401321ba9943cea3f893211cf277a2 : SUCCESS in 3m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9a0a8c4cc6ca4570bc07ceded481e0ca : SUCCESS in 5m 01s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/51bf4e2b0d3c4129902b231de4591419 : FAILURE in 1h 37m 48s","accounts_in_message":[],"_revision_number":3},{"id":"e4ed2bcca642e17d7c0646b183a9651c29e55f1d","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-12-03 03:29:57.000000000","message":"Patch Set 3:\n\n*Now* this triggers:\n\nDec 03 02:13:57.396833 nested-virt-ubuntu-focal-ovh-gra1-0022024470 nova-compute[52777]: ERROR oslo_messaging.rpc.server nova.exception.CPUUnpinningInvalid: CPU set to unpin [2, 6] must be a subset of pinned CPU set []\n\nI\u0027ve rechecked https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/763411","accounts_in_message":[],"_revision_number":3},{"id":"c05b45b42eca8d14e9c21f0ff7912e39b6cc1a81","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 05:03:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/210a07c4bf364f35989877f88069c569 : SUCCESS in 3m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4afb36beec0b41529d07e9baae46f60e : SUCCESS in 2m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/62170dd9cc0b4f44abfe9e762a794591 : SUCCESS in 7m 17s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/b97029ea6d9344d18e5f88c8e68e5a70 : SUCCESS in 1h 26m 00s","accounts_in_message":[],"_revision_number":3},{"id":"1f2aecc956d2d9c8bbdf29324cc6ee2a3cc84a4b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 05:03:57.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"01edc57d38246476176c4422d046e8c79f348feb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 06:37:48.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/603bb2c1777742759ad523d167a91514 : SUCCESS in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5b5d64edec8a48d3addc9d29bba6b358 : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e066480bca4642ada8bea3f0eb2ba94c : SUCCESS in 3m 00s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/35133f5bbd0d439589fe2d85c8d10575 : SUCCESS in 1h 29m 54s","accounts_in_message":[],"_revision_number":3},{"id":"53f93af2099f3903fdba29482b6a1a52675d797e","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 06:38:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4a4d0c6d639681c8224dbed3508acad1748f4d26","revisions":{"d4657d70a8aa1420309f82347436100671cea0a0":{"kind":"REWORK","_number":1,"created":"2020-12-02 21:58:07.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/765211/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/765211/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/1"}}},"commit":{"parents":[{"commit":"c74bb93b6d20246e6f9ee086ca5b32fba0131494","subject":"Merge \"move whitebox-multinode-multinuma-devstack to third party ci\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/c74bb93b6d20246e6f9ee086ca5b32fba0131494"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-02 21:54:17.000000000","tz":-300},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-02 21:57:30.000000000","tz":-300},"subject":"Remove restart_command config option","message":"Remove restart_command config option\n\nIn real life, nothin actually uses that config option. We currently\nsupport nova-compute and libvirt as services, and both only use\nstart_command and stop_command. Libvirt only uses those because it\nneeds to be a stopped for a destructive test, and nova-compute only\nuses those because it implements restart() as a sequence of stop/start\noperations and waits for the service to appear down/up in the services\nAPI at each step.\n\nThis patch removes the restart_command config option entirely, and\nmoves the stop()/start() implementation of restart() into the base\nServiceManager class.\n\nIf we ever actually need to restart a service, we can re-add this\nconfig option in the future.\n\nChange-Id: I14dddb5846b2330811c496aa7c134d020781edb8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/d4657d70a8aa1420309f82347436100671cea0a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/d4657d70a8aa1420309f82347436100671cea0a0"}]},"branch":"refs/heads/master"},"9110076605eafc0f85c1f0feda2159b11d339a94":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-12-03 01:11:40.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/765211/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/765211/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/2"}}},"commit":{"parents":[{"commit":"c74bb93b6d20246e6f9ee086ca5b32fba0131494","subject":"Merge \"move whitebox-multinode-multinuma-devstack to third party ci\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/c74bb93b6d20246e6f9ee086ca5b32fba0131494"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-02 21:54:17.000000000","tz":-300},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-03 01:06:59.000000000","tz":-300},"subject":"Remove restart_command config option","message":"Remove restart_command config option\n\nIn real life, nothing actually uses that config option. We currently\nsupport nova-compute and libvirt as services, and both only use\nstart_command and stop_command. Libvirt only uses those because it\nneeds to be a stopped for a destructive test, and nova-compute only\nuses those because it implements restart() as a sequence of stop/start\noperations and waits for the service to appear down/up in the services\nAPI at each step.\n\nThis patch removes the restart_command config option entirely, and\nmoves the stop()/start() implementation of restart() into the base\nServiceManager class.\n\nIf we ever actually need to restart a service, we can re-add this\nconfig option in the future.\n\nChange-Id: I14dddb5846b2330811c496aa7c134d020781edb8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9110076605eafc0f85c1f0feda2159b11d339a94"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9110076605eafc0f85c1f0feda2159b11d339a94"}]},"branch":"refs/heads/master"},"4a4d0c6d639681c8224dbed3508acad1748f4d26":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-12-03 01:12:50.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/11/765211/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/11/765211/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/11/765211/3"}}},"commit":{"parents":[{"commit":"c74bb93b6d20246e6f9ee086ca5b32fba0131494","subject":"Merge \"move whitebox-multinode-multinuma-devstack to third party ci\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/c74bb93b6d20246e6f9ee086ca5b32fba0131494"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-02 21:54:17.000000000","tz":-300},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-12-03 01:12:25.000000000","tz":-300},"subject":"Remove restart_command config option","message":"Remove restart_command config option\n\nIn real life, nothing actually uses that config option. We currently\nsupport nova-compute and libvirt as services, and both only use\nstart_command and stop_command. Libvirt only uses those because it\nneeds to be stopped for a destructive test, and nova-compute only\nuses those because it implements restart() as a sequence of stop/start\noperations and waits for the service to appear down/up in the services\nAPI at each step.\n\nThis patch removes the restart_command config option entirely, and\nmoves the stop()/start() implementation of restart() into the base\nServiceManager class.\n\nIf we ever actually need to restart a service, we can re-add this\nconfig option in the future.\n\nChange-Id: I14dddb5846b2330811c496aa7c134d020781edb8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/4a4d0c6d639681c8224dbed3508acad1748f4d26"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/4a4d0c6d639681c8224dbed3508acad1748f4d26"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}