)]}'
{".zuul.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"67b7b73aef0773b5346295f72da4b969394bfd0a","unresolved":true,"context_lines":[{"line_number":86,"context_line":"              libvirt:"},{"line_number":87,"context_line":"                cpu_mode: custom"},{"line_number":88,"context_line":"                cpu_models: kvm64"},{"line_number":89,"context_line":"                cpu_model_extra_flags: ssse3"},{"line_number":90,"context_line":"                virt_type: kvm"},{"line_number":91,"context_line":"                rx_queue_size: 1024"},{"line_number":92,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ac7cc935_682f9b47","line":89,"updated":"2021-04-09 22:00:09.000000000","message":"You also need the flags here I think the allinone \"main node\" functions as a compute as well.","commit_id":"66abdd75a44b42c99c6fbbd0af8e35e14df19b34"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"e1f782a8b9519e310ed169cc7c4d8db086bca0a9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"              libvirt:"},{"line_number":87,"context_line":"                cpu_mode: custom"},{"line_number":88,"context_line":"                cpu_models: kvm64"},{"line_number":89,"context_line":"                cpu_model_extra_flags: ssse3"},{"line_number":90,"context_line":"                virt_type: kvm"},{"line_number":91,"context_line":"                rx_queue_size: 1024"},{"line_number":92,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"457bd6a7_1204a300","line":89,"in_reply_to":"ac7cc935_682f9b47","updated":"2021-04-12 13:36:12.000000000","message":"Ack","commit_id":"66abdd75a44b42c99c6fbbd0af8e35e14df19b34"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"16a8c4e7d6348b1ca98c78ee35bf3bb42d5b8554","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            MAX_COMPUTE_NODES: 2"},{"line_number":80,"context_line":"            LIBVIRT_TYPE: kvm"},{"line_number":81,"context_line":"            TEMPEST_PLUGINS: /opt/stack/whitebox-tempest-plugin"},{"line_number":82,"context_line":"            WHITEBOX_PRIVKEY_PATH: /home/tempest/.ssh/id_rsa"},{"line_number":83,"context_line":"        devstack_local_conf:"},{"line_number":84,"context_line":"          post-config:"},{"line_number":85,"context_line":"            $NOVA_CONF:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ca02d78e_09ba184c","line":82,"updated":"2021-04-22 15:41:26.000000000","message":"You need to add your environment vars here I believe...","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"dd8fbd3b96c7affd1d9037fa2f52c3ec05e22acd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            MAX_COMPUTE_NODES: 2"},{"line_number":80,"context_line":"            LIBVIRT_TYPE: kvm"},{"line_number":81,"context_line":"            TEMPEST_PLUGINS: /opt/stack/whitebox-tempest-plugin"},{"line_number":82,"context_line":"            WHITEBOX_PRIVKEY_PATH: /home/tempest/.ssh/id_rsa"},{"line_number":83,"context_line":"        devstack_local_conf:"},{"line_number":84,"context_line":"          post-config:"},{"line_number":85,"context_line":"            $NOVA_CONF:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ac04620a_ee1007e5","line":82,"in_reply_to":"ca02d78e_09ba184c","updated":"2021-04-22 17:11:52.000000000","message":"Ack","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"16a8c4e7d6348b1ca98c78ee35bf3bb42d5b8554","unresolved":true,"context_lines":[{"line_number":86,"context_line":"              libvirt:"},{"line_number":87,"context_line":"                cpu_mode: custom"},{"line_number":88,"context_line":"                cpu_models: qemu64"},{"line_number":89,"context_line":"                cpu_model_extra_flags: vme,+sse3,-mmx"},{"line_number":90,"context_line":"                virt_type: kvm"},{"line_number":91,"context_line":"                rx_queue_size: 1024"},{"line_number":92,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ac201201_3a41ecec","line":89,"updated":"2021-04-22 15:41:26.000000000","message":"You\u0027re missing an \u0027s\u0027 in \u0027ssse3\u0027: https://zuul.opendev.org/t/openstack/build/96eb677b407d4f39b7202964f438d2b1/log/controller/logs/screen-n-cpu.txt?severity\u003d4#3503","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"dd8fbd3b96c7affd1d9037fa2f52c3ec05e22acd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"              libvirt:"},{"line_number":87,"context_line":"                cpu_mode: custom"},{"line_number":88,"context_line":"                cpu_models: qemu64"},{"line_number":89,"context_line":"                cpu_model_extra_flags: vme,+sse3,-mmx"},{"line_number":90,"context_line":"                virt_type: kvm"},{"line_number":91,"context_line":"                rx_queue_size: 1024"},{"line_number":92,"context_line":"    group-vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9b03e2e1_17500187","line":89,"in_reply_to":"ac201201_3a41ecec","updated":"2021-04-22 17:11:52.000000000","message":"Ack","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"}],"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1b49493498ca54ccb9ad05a42ae5dd36f258eaf5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Implements test for disabling cpu flags within the guest. Since this is"},{"line_number":10,"context_line":"building on the already established test_cpu_extra_flags testcase, a"},{"line_number":11,"context_line":"skipcheck was added to allow this test to run downstream on older"},{"line_number":12,"context_line":"releases of Openstack that do not support disabling the flags."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related blueprint allow-disabling-cpu-flags"},{"line_number":15,"context_line":"Depends-on: https://review.opendev.org/c/openstack/nova/+/774240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d3f47429_b19cd11a","line":12,"updated":"2021-04-13 14:52:47.000000000","message":"Well it\u0027s more because we backported this stuff downstream, but not upstream, so we can\u0027t do a pure microversion check - OSP16 will have this, but not upstream stable/train.","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"179c488058f0bdfa922c63f1d3b4fa652c25ef3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implements test for disabling cpu flags within the guest. Since this is"},{"line_number":10,"context_line":"building on the already established test_cpu_extra_flags testcase, a"},{"line_number":11,"context_line":"skipcheck was added to allow this test to run downstream on older"},{"line_number":12,"context_line":"releases of Openstack that do not support disabling the flags."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related blueprint allow-disabling-cpu-flags"},{"line_number":15,"context_line":"Depends-on: https://review.opendev.org/c/openstack/nova/+/774240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"49370638_377464c0","line":12,"in_reply_to":"d3f47429_b19cd11a","updated":"2021-04-13 14:55:08.000000000","message":"Will update the commit message accordingly, thanks for clarifying.","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"}],"devstack/plugin.sh":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"71e63bf8b759dc2a65e912f9ba7394208670c459","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    iniset $TEMPEST_CONFIG whitebox file_backed_memory_size $WHITEBOX_FILE_BACKED_MEMORY_SIZE"},{"line_number":16,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model $WHITEBOX_CPU_MODEL"},{"line_number":17,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model_extra_flags $WHITEBOX_CPU_MODEL_EXTRA_FLAGS"},{"line_number":18,"context_line":"    iniset $TEMPEST_CONFIG whitebox allow_disabling_of_cpu_model_extra_flags $WHITEBOX_ALLOW_DISABLING_CPU_EXTRA_FLAGS"},{"line_number":19,"context_line":"    iniset $TEMPEST_CONFIG whitebox rx_queue_size $WHITEBOX_RX_QUEUE_SIZE"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    iniset $TEMPEST_CONFIG whitebox-nova-compute config_path \"$WHITEBOX_NOVA_COMPUTE_CONFIG_PATH\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"8c38b3a0_0a064e02","line":18,"updated":"2021-04-14 14:11:33.000000000","message":"I think this can get dropped...","commit_id":"619ba79f8cd878b7760832ff8e17ec6f96fd96d7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"71e63bf8b759dc2a65e912f9ba7394208670c459","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    iniset $TEMPEST_CONFIG whitebox-hardware cpu_topology \"$WHITEBOX_CPU_TOPOLOGY\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled virtio_rng \"$COMPUTE_FEATURE_VIRTIO_RNG\""},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1ef9a592_bb3257d1","line":36,"updated":"2021-04-14 14:11:33.000000000","message":"And replaced with a line here","commit_id":"619ba79f8cd878b7760832ff8e17ec6f96fd96d7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"16a8c4e7d6348b1ca98c78ee35bf3bb42d5b8554","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        iniset $TEMPEST_CONFIG whitebox-hardware smt_hosts \"$SMT_HOSTS\""},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"    iniset $TEMPEST_CONFIG whitebox file_backed_memory_size $WHITEBOX_FILE_BACKED_MEMORY_SIZE"},{"line_number":16,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model $cpu_models"},{"line_number":17,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model_extra_flags $cpu_model_extra_flags"},{"line_number":18,"context_line":"    iniset $TEMPEST_CONFIG whitebox rx_queue_size $WHITEBOX_RX_QUEUE_SIZE"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"82dee568_f1042e15","line":16,"updated":"2021-04-22 15:41:26.000000000","message":"I don\u0027t think this is going to work - $cpu_models isn\u0027t an environment variable. The way zuul does those is in the devstack_localrc section.","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"dd8fbd3b96c7affd1d9037fa2f52c3ec05e22acd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        iniset $TEMPEST_CONFIG whitebox-hardware smt_hosts \"$SMT_HOSTS\""},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"    iniset $TEMPEST_CONFIG whitebox file_backed_memory_size $WHITEBOX_FILE_BACKED_MEMORY_SIZE"},{"line_number":16,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model $cpu_models"},{"line_number":17,"context_line":"    iniset $TEMPEST_CONFIG whitebox cpu_model_extra_flags $cpu_model_extra_flags"},{"line_number":18,"context_line":"    iniset $TEMPEST_CONFIG whitebox rx_queue_size $WHITEBOX_RX_QUEUE_SIZE"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"f5b6ea8c_563d6f9b","line":16,"in_reply_to":"82dee568_f1042e15","updated":"2021-04-22 17:11:52.000000000","message":"Ah gotcha, makes a lot more sense now.","commit_id":"a47d437757b4a85a40642a15e19e3ab8a1975d4f"}],"devstack/settings":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"71e63bf8b759dc2a65e912f9ba7394208670c459","unresolved":true,"context_lines":[{"line_number":5,"context_line":"WHITEBOX_FILE_BACKED_MEMORY_SIZE\u003d${WHITEBOX_FILE_BACKED_MEMORY_SIZE:-8192}"},{"line_number":6,"context_line":"WHITEBOX_CPU_MODEL\u003d${WHITEBOX_CPU_MODEL:-kvm64}"},{"line_number":7,"context_line":"WHITEBOX_CPU_MODEL_EXTRA_FLAGS\u003d${WHITEBOX_CPU_MODEL_EXTRA_FLAGS:-\u0027+ssse3,-hle,-rtm,md-clear\u0027}"},{"line_number":8,"context_line":"WHITEBOX_ALLOW_DISABLING_CPU_EXTRA_FLAGS\u003d${WHITEBOX_ALLOW_DISABLING_CPU_EXTRA_FLAGS:-True}"},{"line_number":9,"context_line":"WHITEBOX_RX_QUEUE_SIZE\u003d${WHITEBOX_RX_QUEUE_SIZE:-1024}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"WHITEBOX_NOVA_COMPUTE_CONFIG_PATH\u003d${WHITEBOX_NOVA_COMPUTE_CONFIG_PATH:-/etc/nova/nova-cpu.conf}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"d7c5697a_90e4f1b2","line":8,"updated":"2021-04-14 14:11:33.000000000","message":"Drop this too","commit_id":"619ba79f8cd878b7760832ff8e17ec6f96fd96d7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b2ddc4d2130b14effbe2274116a2bea6a4f05de7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"SMT_HOSTS\u003d${SMT_HOSTS:-\u0027\u0027}"},{"line_number":5,"context_line":"WHITEBOX_FILE_BACKED_MEMORY_SIZE\u003d${WHITEBOX_FILE_BACKED_MEMORY_SIZE:-8192}"},{"line_number":6,"context_line":"WHITEBOX_CPU_MODEL\u003d${WHITEBOX_CPU_MODEL:-kvm64}"},{"line_number":7,"context_line":"WHITEBOX_CPU_MODEL_EXTRA_FLAGS\u003d${WHITEBOX_CPU_MODEL_EXTRA_FLAGS:-\u0027+ssse3,-hle,-rtm,md-clear\u0027}"},{"line_number":8,"context_line":"WHITEBOX_RX_QUEUE_SIZE\u003d${WHITEBOX_RX_QUEUE_SIZE:-1024}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"WHITEBOX_NOVA_COMPUTE_CONFIG_PATH\u003d${WHITEBOX_NOVA_COMPUTE_CONFIG_PATH:-/etc/nova/nova-cpu.conf}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"17ad352a_a45777f9","line":7,"updated":"2021-04-14 21:32:53.000000000","message":"Doh, we\u0027re setting the flags twice - here in devstack, and also via Zuul. Oh well, no harm, it\u0027s just redundant.","commit_id":"dbce222b8ef7e1d3b097595e139503ef01e5e7ca"}],"whitebox_tempest_plugin/api/compute/test_cpu_model_extra_flags.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"44f480f76b25bed1e03bfb5eb60a097a356d85f3","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                        \u0027cpu[@mode\u003d\"custom\"]/\u0027"},{"line_number":48,"context_line":"                        \u0027feature[@name\u003d\"%s\"][@policy\u003d\"require\"]\u0027 % flag),"},{"line_number":49,"context_line":"                    \"Required feature \u0027%s\u0027 not found in the XML\" % flag)"},{"line_number":50,"context_line":"            elif flag.startswith(\u0027-\u0027):"},{"line_number":51,"context_line":"                self.assertNotEmpty("},{"line_number":52,"context_line":"                    root.findall("},{"line_number":53,"context_line":"                        \u0027cpu[@mode\u003d\"custom\"]/\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5965c595_a8384e8e","line":50,"updated":"2021-03-22 17:46:32.000000000","message":"Since its assumed \u0027+\u0027 if \u0027-\u0027 is not present, would it make more sense to confirm disabled if \u0027-\u0027 and everything else assumed enabled i.e.\nif flag.startswith(\u0027-\u0027)\n  #Confirm disabled\nelse:\n  flag_to_check \u003d flag.split(\u0027+\u0027)[-1]\n  #Confirm enabled","commit_id":"e5e9234ef21620ead9cb9b30a2ce1c0e2612c896"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12691b65d24368e5b414aa1aabe5b778612c7f46","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                        \u0027cpu[@mode\u003d\"custom\"]/\u0027"},{"line_number":48,"context_line":"                        \u0027feature[@name\u003d\"%s\"][@policy\u003d\"require\"]\u0027 % flag),"},{"line_number":49,"context_line":"                    \"Required feature \u0027%s\u0027 not found in the XML\" % flag)"},{"line_number":50,"context_line":"            elif flag.startswith(\u0027-\u0027):"},{"line_number":51,"context_line":"                self.assertNotEmpty("},{"line_number":52,"context_line":"                    root.findall("},{"line_number":53,"context_line":"                        \u0027cpu[@mode\u003d\"custom\"]/\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b82848a4_4c88d0df","line":50,"in_reply_to":"5965c595_a8384e8e","updated":"2021-03-22 17:48:59.000000000","message":"Yeah, that\u0027d make sense.","commit_id":"e5e9234ef21620ead9cb9b30a2ce1c0e2612c896"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7e14be2b1eb8f46cdb8d0c0fe0499c558a5449c2","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @testtools.skipUnless(CONF.whitebox.cpu_model_extra_flags,"},{"line_number":32,"context_line":"                          \"\u0027cpu_model_extra_flags must be set\")"},{"line_number":33,"context_line":"    def test_cpu_model_extra_flags(self):"},{"line_number":34,"context_line":"        if not CONF.whitebox.allow_disabling_of_cpu_model_extra_flags:"},{"line_number":35,"context_line":"            for flag in CONF.whitebox.cpu_model_extra_flags:"},{"line_number":36,"context_line":"                if flag.startswith(\u0027-\u0027):"},{"line_number":37,"context_line":"                    raise self.skipException("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa5130fe_0d4190ff","line":34,"updated":"2021-04-09 19:37:09.000000000","message":"Is this to allow the test to run and skip against OSP13?","commit_id":"d39f2963a549281d5f3d4a390c8260eaecb7bb3d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d9e1fa39baf9a84b1ee16b2488f11f46d686a819","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @testtools.skipUnless(CONF.whitebox.cpu_model_extra_flags,"},{"line_number":32,"context_line":"                          \"\u0027cpu_model_extra_flags must be set\")"},{"line_number":33,"context_line":"    def test_cpu_model_extra_flags(self):"},{"line_number":34,"context_line":"        if not CONF.whitebox.allow_disabling_of_cpu_model_extra_flags:"},{"line_number":35,"context_line":"            for flag in CONF.whitebox.cpu_model_extra_flags:"},{"line_number":36,"context_line":"                if flag.startswith(\u0027-\u0027):"},{"line_number":37,"context_line":"                    raise self.skipException("}],"source_content_type":"text/x-python","patch_set":4,"id":"f00ee8ce_e79fd0a3","line":34,"in_reply_to":"fa5130fe_0d4190ff","updated":"2021-04-09 19:48:16.000000000","message":"Yea, this feature isn\u0027t tied to a specific microversion, so using the flag to skip the test if it is ever incorrectly present.  As we\u0027ve started discussing more, it might be time to branch whitebox to a 13 only version to avoid more instances like this.","commit_id":"d39f2963a549281d5f3d4a390c8260eaecb7bb3d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9519f9dec8b1548f10812076a911d6c5d1b1a7fa","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @testtools.skipUnless(CONF.whitebox.cpu_model_extra_flags,"},{"line_number":32,"context_line":"                          \"\u0027cpu_model_extra_flags must be set\")"},{"line_number":33,"context_line":"    def test_cpu_model_extra_flags(self):"},{"line_number":34,"context_line":"        disable_cpu_extra_flags_supported \u003d \\"},{"line_number":35,"context_line":"            CONF.compute_feature_enabled.allow_disabling_of_cpu_extra_flags"},{"line_number":36,"context_line":"        if not disable_cpu_extra_flags_supported:"},{"line_number":37,"context_line":"            for flag in CONF.whitebox.cpu_model_extra_flags:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ba3a39e_ec212e68","line":34,"updated":"2021-04-21 21:39:57.000000000","message":"So I\u0027m thinking we can drop this entirely, and rely solely on...","commit_id":"b528de49f173aa8564682ca41d5b07153992fbb0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9519f9dec8b1548f10812076a911d6c5d1b1a7fa","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            root.find(\"cpu[@mode\u003d\u0027custom\u0027]/model\").text,"},{"line_number":51,"context_line":"            \u0027Wrong CPU model defined in instance xml\u0027)"},{"line_number":52,"context_line":"        for flag in CONF.whitebox.cpu_model_extra_flags:"},{"line_number":53,"context_line":"            if flag.startswith(\u0027-\u0027):"},{"line_number":54,"context_line":"                self.assertNotEmpty("},{"line_number":55,"context_line":"                    root.findall("},{"line_number":56,"context_line":"                        \u0027cpu[@mode\u003d\"custom\"]/\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"39647fe2_20c58360","line":53,"updated":"2021-04-21 21:39:57.000000000","message":"On this \u0027-\u0027. The idea being, if whatever deployed us has set a \u0027-flag\u0027 in [whitebox]cpu_model_extra_flahs, then it knows that the deployment supports it.","commit_id":"b528de49f173aa8564682ca41d5b07153992fbb0"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1b49493498ca54ccb9ad05a42ae5dd36f258eaf5","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        \u0027cpu_model_extra_flags\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Extra flags set in the [libvirt]/cpu_model_extra_flags config \u0027"},{"line_number":99,"context_line":"             \u0027option on the compute hosts.\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt("},{"line_number":101,"context_line":"        \u0027allow_disabling_of_cpu_model_extra_flags\u0027,"},{"line_number":102,"context_line":"        default\u003dFalse,"},{"line_number":103,"context_line":"        help\u003d\u0027Deployment supports the disabling of cpu model extra flags in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"e522d936_0fd3ae05","line":100,"updated":"2021-04-13 14:52:47.000000000","message":"We should be consistent and use the compute-features-enabled section, like what we did for Virtio RNG.","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"179c488058f0bdfa922c63f1d3b4fa652c25ef3d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        \u0027cpu_model_extra_flags\u0027,"},{"line_number":98,"context_line":"        help\u003d\u0027Extra flags set in the [libvirt]/cpu_model_extra_flags config \u0027"},{"line_number":99,"context_line":"             \u0027option on the compute hosts.\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt("},{"line_number":101,"context_line":"        \u0027allow_disabling_of_cpu_model_extra_flags\u0027,"},{"line_number":102,"context_line":"        default\u003dFalse,"},{"line_number":103,"context_line":"        help\u003d\u0027Deployment supports the disabling of cpu model extra flags in \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"e73bce66_50b107f6","line":100,"in_reply_to":"e522d936_0fd3ae05","updated":"2021-04-13 14:55:08.000000000","message":"Ack","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1b49493498ca54ccb9ad05a42ae5dd36f258eaf5","unresolved":true,"context_lines":[{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"compute_features_group_opts \u003d ["},{"line_number":238,"context_line":"    cfg.BoolOpt(\u0027virtio_rng\u0027,"},{"line_number":239,"context_line":"                default\u003dFalse,"},{"line_number":240,"context_line":"                help\u003d\"If false, skip virtio rng tests\")"},{"line_number":241,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b99b1db_0e3d8488","line":238,"updated":"2021-04-13 14:52:47.000000000","message":"Down here...","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"179c488058f0bdfa922c63f1d3b4fa652c25ef3d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"compute_features_group_opts \u003d ["},{"line_number":238,"context_line":"    cfg.BoolOpt(\u0027virtio_rng\u0027,"},{"line_number":239,"context_line":"                default\u003dFalse,"},{"line_number":240,"context_line":"                help\u003d\"If false, skip virtio rng tests\")"},{"line_number":241,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"ab4ed4b4_6db7fe09","line":238,"in_reply_to":"3b99b1db_0e3d8488","updated":"2021-04-13 14:55:08.000000000","message":"Ack","commit_id":"77533155240e69269b30c2634d3699b47b42c0c7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"71e63bf8b759dc2a65e912f9ba7394208670c459","unresolved":true,"context_lines":[{"line_number":235,"context_line":"                help\u003d\"If false, skip virtio rng tests\"),"},{"line_number":236,"context_line":"    cfg.BoolOpt("},{"line_number":237,"context_line":"        \u0027allow_disabling_of_cpu_extra_flags\u0027,"},{"line_number":238,"context_line":"        default\u003dFalse,"},{"line_number":239,"context_line":"        help\u003d\u0027Deployment supports the disabling of cpu model extra flags in \u0027"},{"line_number":240,"context_line":"             \u0027the guest\u0027)"},{"line_number":241,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"0dbb8a85_0e9dbcd9","line":238,"updated":"2021-04-14 14:11:33.000000000","message":"Since the default is false you\u0027ll need to set this to True in zuul.yaml, or just change the default to True here.","commit_id":"619ba79f8cd878b7760832ff8e17ec6f96fd96d7"}]}