)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"78e6e17ec0f4d01da22410e7057aad3c33169d19","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    iniset $TEMPEST_CONFIG whitebox-database host $DATABASE_HOST"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    iniset $TEMPEST_CONFIG whitebox-hardware cpu_topology \"$WHITEBOX_CPU_TOPOLOGY\""},{"line_number":34,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume True"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"4a36491e_93e84b08","line":34,"updated":"2021-03-04 14:20:51.000000000","message":"Wait, why is this set to True by default? Is it because devstack deploys Nova that way?","commit_id":"0b2f477e3fe92b2de79e50131f9852f0384555ef"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"8b4acfd56150c633c3e81cbafbcba6af2bc975d8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    iniset $TEMPEST_CONFIG whitebox-database host $DATABASE_HOST"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    iniset $TEMPEST_CONFIG whitebox-hardware cpu_topology \"$WHITEBOX_CPU_TOPOLOGY\""},{"line_number":34,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume True"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"284a2984_dd89b56d","line":34,"in_reply_to":"4a36491e_93e84b08","updated":"2021-03-04 14:35:17.000000000","message":"oh, apologies, its again a diff between upstream and downstream where in my deployed env, this was set to False by default, i\u0027ll remove this now","commit_id":"0b2f477e3fe92b2de79e50131f9852f0384555ef"}],"whitebox_tempest_plugin/api/compute/test_volume_encryption.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"1309168cf8375ac3f56f49b5c3d73d70fd9b0308","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def skip_checks(cls):"},{"line_number":47,"context_line":"        super(TestQEMUVolumeEncrption, cls).skip_checks()"},{"line_number":48,"context_line":"        if not CONF.service_available.barbican:"},{"line_number":49,"context_line":"            skip_msg \u003d (\"%s skipped as barbican is not enabled\" % cls.__name__)"},{"line_number":50,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"45583201_0cc0acf1","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":47},"updated":"2021-03-02 17:46:36.000000000","message":"After the tempest change gets added, this should be:\n    if not CONF.service_available.barbican or \n        not CONF.compute_feature_enabled.fixed_key:","commit_id":"b51b45ac1813e4ab444b15132b7c511bdac9bb42"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"31f9b9e3e374126c3d902e7b3769c7ce2fec0eae","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from oslo_config import types"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"service_option \u003d cfg.BoolOpt(\"barbican\","},{"line_number":21,"context_line":"                             default\u003dTrue,"},{"line_number":22,"context_line":"                             help\u003d\"Whether or not barbican is expected to be \""},{"line_number":23,"context_line":"                                  \"available\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"general_group \u003d cfg.OptGroup("},{"line_number":26,"context_line":"    name\u003d\u0027whitebox\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b322c265_2f9f5e77","line":23,"range":{"start_line":19,"start_character":0,"end_line":23,"end_character":46},"updated":"2021-03-03 10:03:16.000000000","message":"Do you need this? Shouldn\u0027t it be available via Tempest itself already?","commit_id":"bb0c4fd91b8a56701d658100735406f9446c565c"}],"whitebox_tempest_plugin/plugin.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"31f9b9e3e374126c3d902e7b3769c7ce2fec0eae","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        return full_test_dir, base_path"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def register_opts(self, conf):"},{"line_number":35,"context_line":"        config.register_opt(conf, whitebox_config.service_option,"},{"line_number":36,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":37,"context_line":"        config.register_opt_group(conf, whitebox_config.general_group,"},{"line_number":38,"context_line":"                                  whitebox_config.general_opts)"},{"line_number":39,"context_line":"        config.register_opt_group(conf, whitebox_config.nova_compute_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c24aa0d5_6b45fb59","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":54},"updated":"2021-03-03 10:03:16.000000000","message":"Yeah I wouldn\u0027t think you would need this to pass through the tempest config option?","commit_id":"bb0c4fd91b8a56701d658100735406f9446c565c"}]}
