)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~781090","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~Ibe64ef9c3e96456c93e00ce1e87214a2717103d2","project":"openstack/whitebox-tempest-plugin","branch":"master","hashtags":[],"change_id":"Ibe64ef9c3e96456c93e00ce1e87214a2717103d2","subject":"zuul: Ensure subnode n-cpu is correctly configured","status":"MERGED","created":"2021-03-17 12:44:15.000000000","updated":"2021-03-22 19:44:56.000000000","submitted":"2021-03-22 19:44:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"781090","meta_rev_id":"345ee277c92b841c1363bda84fd20ed76c8b176b","_number":781090,"virtual_id_number":781090,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-22 19:44:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-03-18 15:54:17.000000000","_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":2,"date":"2021-03-22 17:53:10.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2021-03-18 15:54:17.000000000","_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},{"value":1,"date":"2021-03-22 17:53:10.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-17 12:44:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-18 14:15:26.000000000","updated_by":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"reviewer":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"state":"REVIEWER"},{"updated":"2021-03-19 18:35:17.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"}],"messages":[{"id":"4f7e120329aee75946a4eaefb2949c4d01716a01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-17 12:44:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3de41944dc164bbed8ae2de5335b405bd9fa3087","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 12:44:56.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nZuul encountered a syntax error while parsing its configuration in the\nrepo openstack/whitebox-tempest-plugin on branch master.  The error\nwas:\n\n  Invalid Ansible variable name \u0027post-config\u0027 for dictionary value @ data[\u0027group-vars\u0027][\u0027subnode\u0027]\n\nThe error appears in the following job stanza:\n\n  job:\n      name: whitebox-multinode-devstack-base\n      abstract: true\n      parent: tempest-multinode-full-py3\n      description: |\n          Base devstack multinode job.\n      required-projects:\n          openstack/whitebox-tempest-plugin\n      pre-run: playbooks/whitebox/pre.yaml\n      irrelevant-files:\n        - ^test-requirements.txt$\n      vars:\n          tox_envlist: all\n          tempest_concurrency: 1\n          tempest_test_regex: ^whitebox_tempest_plugin\\.\n          devstack_plugins:\n              whitebox-tempest-plugin: https://opendev.org/openstack/whitebox-tempest-plugin.git\n          devstack_localrc:\n              MAX_COMPUTE_NODES: 2\n              LIBVIRT_TYPE: kvm\n              TEMPEST_PLUGINS: /opt/stack/whitebox-tempest-plugin\n              WHITEBOX_PRIVKEY_PATH: /home/tempest/.ssh/id_rsa\n          devstack_local_conf:\n            post-config:\n              $NOVA_CONF:\n                libvirt:\n                  cpu_mode: custom\n                  cpu_models: kvm64\n                  cpu_model_extra_flags: ssse3\n                  virt_type: kvm\n                  rx_queue_size: 1024\n      group-vars:\n          subnode:\n              num_hugepages: 2048\n              devstack_localrc:\n                  LIBVIRT_TYPE: kvm\n              post-config:\n                $NOVA_CONF:\n                  libvirt:\n                    cpu_mode: custom\n                    cpu_models: kvm64\n                    cpu_model_extra_flags: ssse3\n                    virt_type: kvm\n                    rx_queue_size: 1024\n          tempest:\n              num_hugepages: 512\n\n  in \"openstack/whitebox-tempest-plugin/.zuul.yaml@master\", line 61, column 3","accounts_in_message":[],"_revision_number":1},{"id":"280b2baec8dfbf9f44e7e6566d7deeeac66828ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-17 12:45:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e779510c7c63bc53639e4cddb7fea495762baf80","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 15:04:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1b2fe0e379fc438b91d10d6565985ec0 : SUCCESS in 3m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9a0aa583fafb42de9c033ae07e2581ed : SUCCESS in 4m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d17d6a5d8aed4c8fb010f25d69210317 : SUCCESS in 4m 13s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/e5a6b8a5ec8e4e9490c60aefa1a533eb : SUCCESS in 2h 13m 07s","accounts_in_message":[],"_revision_number":2},{"id":"7eddedb1adb2797ad01d59cfab1c53d666a411b0","author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"date":"2021-03-18 14:15:26.000000000","message":"Patch Set 2: Code-Review+1\n\nlooks good","accounts_in_message":[],"_revision_number":2},{"id":"dd95e6210484a1f8f394e348b260f2e760429a73","author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"date":"2021-03-18 15:37:52.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1d9fd78b72db1f8f7f4220aca078db16ff082ad5","author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"date":"2021-03-18 15:54:17.000000000","message":"Patch Set 2: Code-Review+2 -Workflow","accounts_in_message":[],"_revision_number":2},{"id":"076f05b479ceb8234d4ae00d30405523ca0fddbf","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-03-19 18:35:17.000000000","message":"Patch Set 2: Code-Review-1\n\nAre we sure this is necessary? Looking at an early PS (PS3) of the WIP Barbican patch, this is what I have on the controller and compute node [1] [2]:\n\n\n  [libvirt]\n  cpu_model_extra_flags \u003d ssse3\n  cpu_models \u003d kvm64\n  rx_queue_size \u003d 1024\n  live_migration_uri \u003d qemu+ssh://stack@%s/system\n  cpu_mode \u003d custom\n  virt_type \u003d kvm\n\n  [libvirt]\n  cpu_model_extra_flags \u003d ssse3\n  cpu_models \u003d kvm64\n  rx_queue_size \u003d 1024\n  live_migration_uri \u003d qemu+ssh://stack@%s/system\n  cpu_mode \u003d custom\n  virt_type \u003d kvm\n\n[1] https://zuul.opendev.org/t/openstack/build/b81ef269f2df4c95af63084db36afd40/log/controller/logs/etc/nova/nova-cpu_conf.txt#106-112\n[2] https://zuul.opendev.org/t/openstack/build/b81ef269f2df4c95af63084db36afd40/log/compute/logs/etc/nova/nova-cpu_conf.txt#84-90","accounts_in_message":[],"_revision_number":2},{"id":"3de548da10da230994f05b24e7e7f48f3911f190","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-03-19 20:04:08.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e Are we sure this is necessary? Looking at an early PS (PS3) of the WIP Barbican patch, this is what I have on the controller and compute node [1] [2]:\n\u003e \n\u003e \n\u003e   [libvirt]\n\u003e   cpu_model_extra_flags \u003d ssse3\n\u003e   cpu_models \u003d kvm64\n\u003e   rx_queue_size \u003d 1024\n\u003e   live_migration_uri \u003d qemu+ssh://stack@%s/system\n\u003e   cpu_mode \u003d custom\n\u003e   virt_type \u003d kvm\n\u003e \n\u003e   [libvirt]\n\u003e   cpu_model_extra_flags \u003d ssse3\n\u003e   cpu_models \u003d kvm64\n\u003e   rx_queue_size \u003d 1024\n\u003e   live_migration_uri \u003d qemu+ssh://stack@%s/system\n\u003e   cpu_mode \u003d custom\n\u003e   virt_type \u003d kvm\n\u003e \n\u003e [1] https://zuul.opendev.org/t/openstack/build/b81ef269f2df4c95af63084db36afd40/log/controller/logs/etc/nova/nova-cpu_conf.txt#106-112\n\u003e [2] https://zuul.opendev.org/t/openstack/build/b81ef269f2df4c95af63084db36afd40/log/compute/logs/etc/nova/nova-cpu_conf.txt#84-90\n\nI guess something has changed since then because it was failing pretty consistently for me in Id91887bb5d75c36c9a3c6fa4ea297c20b442fd4a [1][2][3] without nova-cpu.conf being updated correctly [4][5][6] and this change has resolved these failures.\n\n[1] https://zuul.opendev.org/t/openstack/build/fe81fd2c8f7341f6a01badaccaea6386/logs\n[2] https://zuul.opendev.org/t/openstack/build/400a9c580fad49e5bc79223ec1d4ed0e/logs\n[3] https://zuul.opendev.org/t/openstack/build/ef4a356cc8024dcabbb3fb9eaea7af46/logs\n[4] https://zuul.opendev.org/t/openstack/build/fe81fd2c8f7341f6a01badaccaea6386/log/compute/logs/etc/nova/nova-cpu_conf.txt#84\n[5] https://zuul.opendev.org/t/openstack/build/400a9c580fad49e5bc79223ec1d4ed0e/log/compute/logs/etc/nova/nova-cpu_conf.txt#84\n[6] https://zuul.opendev.org/t/openstack/build/ef4a356cc8024dcabbb3fb9eaea7af46/log/compute/logs/etc/nova/nova-cpu_conf.txt#84","accounts_in_message":[],"_revision_number":2},{"id":"ecaf5da8e42ebe49d2e55d9ded7866f69d65afd3","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-03-22 17:53:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nI wonder if we can remove the\n\n              devstack_localrc:\n                LIBVIRT_TYPE: kvm\n\nbits...","accounts_in_message":[],"_revision_number":2},{"id":"c07dc3f1bdade39ce6f918f8c432536ef57384d9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-22 17:53:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e24fdf2b7b2b20a88734a5a6e9a9b8a5a219eaa0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-22 19:44:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b6ec0b16206947e48a2faf35e8faaec4 : SUCCESS in 4m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a7bf66aeb77a4221959816dc3bc9e55c : SUCCESS in 4m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1ef5354062584c9995166b4bf7c6a6c4 : SUCCESS in 4m 43s\n- whitebox-multinode-devstack https://zuul.opendev.org/t/openstack/build/9f10845c20c245fcb4ccfe7faf265a60 : SUCCESS in 1h 48m 20s","accounts_in_message":[],"_revision_number":2},{"id":"345ee277c92b841c1363bda84fd20ed76c8b176b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-22 19:44:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9f90797c39d52129d917cb28bbe009e2765a0da5","revisions":{"5ce1a5619d6e81f34d3233a82a72fd433468541c":{"kind":"REWORK","_number":1,"created":"2021-03-17 12:44:15.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/90/781090/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/90/781090/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/1"}}},"commit":{"parents":[{"commit":"befaafc1c24a8e9f68f75850865e5ae4a8a93cd1","subject":"Add skip check to volume encryption tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/befaafc1c24a8e9f68f75850865e5ae4a8a93cd1"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-17 12:41:56.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-17 12:43:30.000000000","tz":0},"subject":"zuul: Ensure subnode n-cpu is correctly configured","message":"zuul: Ensure subnode n-cpu is correctly configured\n\nWithout this instances spawned on the compute subnode will use\nthe qemu64 CPU model.\n\nStory: #2008726\nChange-Id: Ibe64ef9c3e96456c93e00ce1e87214a2717103d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/5ce1a5619d6e81f34d3233a82a72fd433468541c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/5ce1a5619d6e81f34d3233a82a72fd433468541c"}]},"branch":"refs/heads/master"},"9f90797c39d52129d917cb28bbe009e2765a0da5":{"kind":"REWORK","_number":2,"created":"2021-03-17 12:45:41.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/90/781090/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/90/781090/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/90/781090/2"}}},"commit":{"parents":[{"commit":"befaafc1c24a8e9f68f75850865e5ae4a8a93cd1","subject":"Add skip check to volume encryption tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/befaafc1c24a8e9f68f75850865e5ae4a8a93cd1"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-17 12:41:56.000000000","tz":0},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-03-17 12:45:24.000000000","tz":0},"subject":"zuul: Ensure subnode n-cpu is correctly configured","message":"zuul: Ensure subnode n-cpu is correctly configured\n\nWithout this instances spawned on the compute subnode will use\nthe qemu64 CPU model.\n\nStory: #2008726\nChange-Id: Ibe64ef9c3e96456c93e00ce1e87214a2717103d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9f90797c39d52129d917cb28bbe009e2765a0da5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9f90797c39d52129d917cb28bbe009e2765a0da5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}