)]}'
{"devstack/settings":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cdb2cd040c0b4f42d11bffc1a7302b2a16821d74","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"WHITEBOX_CPU_TOPOLOGY\u003d${WHITEBOX_CPU_TOPOLOGY:-\u0027\u0027}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"VIRTIO_RNG\u003d${VIRTIO_RNG:-\u0027True\u0027}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9d11ba9d_5622a84a","line":21,"updated":"2021-03-31 17:36:17.000000000","message":"nit: Could we rename this to something more descriptive? Like COMPUTE_FEATURE_VIRTIO_RNG?","commit_id":"b4c567851059fba6c3fd1a14e8fb577e466abc73"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"b4ca2f28841048766012b508d3b3748422e95e2a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"WHITEBOX_CPU_TOPOLOGY\u003d${WHITEBOX_CPU_TOPOLOGY:-\u0027\u0027}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"VIRTIO_RNG\u003d${VIRTIO_RNG:-\u0027True\u0027}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"cd86ad08_a52db8c3","line":21,"in_reply_to":"9d11ba9d_5622a84a","updated":"2021-03-31 21:30:28.000000000","message":"Done","commit_id":"b4c567851059fba6c3fd1a14e8fb577e466abc73"}],"whitebox_tempest_plugin/api/compute/test_server_xml.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"3ec21b7f68cedab7b5ccc3fd858fc338a38341a1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    \"\"\"Checks various instance metadata from the"},{"line_number":27,"context_line":"       generated server XML"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_virtio_rng_model(self):"},{"line_number":31,"context_line":"        server \u003d self.create_test_server()"},{"line_number":32,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"319a7ea3_e36ad5f1","line":29,"updated":"2021-03-25 21:48:48.000000000","message":"And this needs skip checks or a min_microversion as this feature is supported from Train onwards","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"901e3db24a80de8389ce15be1ade5e4b27c96d04","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"},{"line_number":34,"context_line":"        self.assertEqual("},{"line_number":35,"context_line":"            rng_device.attrib[\u0027model\u0027], \u0027virtio\u0027,"},{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_set_rng_device_false(self):"},{"line_number":39,"context_line":"        meta \u003d {\u0027hw_rng:allowed\u0027: \u0027False\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f0e044e_9bfe5dac","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":44},"updated":"2021-03-26 11:55:28.000000000","message":"Shouldn\u0027t this message be other way round?","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"3f072825f546a6803e0514ed68d0d938737468ea","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"},{"line_number":34,"context_line":"        self.assertEqual("},{"line_number":35,"context_line":"            rng_device.attrib[\u0027model\u0027], \u0027virtio\u0027,"},{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_set_rng_device_false(self):"},{"line_number":39,"context_line":"        meta \u003d {\u0027hw_rng:allowed\u0027: \u0027False\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3519db25_e478464c","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":44},"in_reply_to":"8f0e044e_9bfe5dac","updated":"2021-03-26 15:19:05.000000000","message":"This is the error message when the model is NOT \u0027virtio\u0027","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"901e3db24a80de8389ce15be1ade5e4b27c96d04","unresolved":true,"context_lines":[{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_set_rng_device_false(self):"},{"line_number":39,"context_line":"        meta \u003d {\u0027hw_rng:allowed\u0027: \u0027False\u0027}"},{"line_number":40,"context_line":"        server \u003d self.create_test_server(metadata\u003dmeta, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":42,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f379dc0_1ace17c5","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":42},"updated":"2021-03-26 11:55:28.000000000","message":"Hm, this should work — once you boot a server (as you do below) w/ it, you should _not_ see it in the guest XML.\n\nFor reference, here\u0027s the Nova method that handles the RNG device addition\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5665,#L5682","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"0cbb50ddfa64a54df14faef39ab41b467f9d9cb5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_set_rng_device_false(self):"},{"line_number":39,"context_line":"        meta \u003d {\u0027hw_rng:allowed\u0027: \u0027False\u0027}"},{"line_number":40,"context_line":"        server \u003d self.create_test_server(metadata\u003dmeta, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":42,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1910d962_4c684975","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":42},"in_reply_to":"0f379dc0_1ace17c5","updated":"2021-03-26 12:29:01.000000000","message":"Oh, I\u0027m wrong: so in the above Nova code only the *extra_spec* is taken into consideration.  The image metadata property has no effect; it is ignored. \n\n\nSo please test the True/False with \u0027extra_spec\u0027","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"3f072825f546a6803e0514ed68d0d938737468ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_set_rng_device_false(self):"},{"line_number":39,"context_line":"        meta \u003d {\u0027hw_rng:allowed\u0027: \u0027False\u0027}"},{"line_number":40,"context_line":"        server \u003d self.create_test_server(metadata\u003dmeta, wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":41,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":42,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"e70c68d8_59eca348","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":42},"in_reply_to":"1910d962_4c684975","updated":"2021-03-26 15:19:05.000000000","message":"Ack","commit_id":"037b278ef07b66d0dd76070c25f57c3e1ae54ae4"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"5fa2555a1eb733677f293230b08f1432e093aa74","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        server \u003d self.create_test_server()"},{"line_number":32,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":33,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"},{"line_number":34,"context_line":"        self.assertEqual("},{"line_number":35,"context_line":"            rng_device.attrib[\u0027model\u0027], \u0027virtio\u0027,"},{"line_number":36,"context_line":"            \"VirtIO-RNG device not present\")"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f4286fe0_d53dc1d8","line":34,"updated":"2021-03-26 15:21:54.000000000","message":"can probably add a self.assertIsNotNone(rng_device) check before checking the latter","commit_id":"c457cc7f6e2002ef7705e848240fb23598699732"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"5975b1d4d7cac8b02f545ad15aa686f912961083","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            extra_specs\u003dextra_specs)[\u0027id\u0027]"},{"line_number":42,"context_line":"        server \u003d self.create_test_server(flavor\u003dflavor_id)"},{"line_number":43,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":44,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"},{"line_number":45,"context_line":"        self.assertIsNone(rng_device)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbfd1d80_5af01522","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":37},"updated":"2021-03-30 09:05:22.000000000","message":"self.assertIsNone(domain.find(\"devices/rng\"))","commit_id":"c457cc7f6e2002ef7705e848240fb23598699732"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"1b501eda5c394599d8b8fdad350960dbacc97f5a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            extra_specs\u003dextra_specs)[\u0027id\u0027]"},{"line_number":42,"context_line":"        server \u003d self.create_test_server(flavor\u003dflavor_id)"},{"line_number":43,"context_line":"        domain \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":44,"context_line":"        rng_device \u003d domain.find(\"devices/rng\")"},{"line_number":45,"context_line":"        self.assertIsNone(rng_device)"}],"source_content_type":"text/x-python","patch_set":2,"id":"089f23ff_aa650279","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":37},"in_reply_to":"cbfd1d80_5af01522","updated":"2021-03-30 13:38:49.000000000","message":"Done","commit_id":"c457cc7f6e2002ef7705e848240fb23598699732"}]}