)]}'
{"whitebox_tempest_plugin/api/compute/base.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"38013689524d3944140f0777538ed3b8a7f181d0","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                                                      block_migration\u003d\u0027auto\u0027,"},{"line_number":133,"context_line":"                                                      host\u003dtarget_host)"},{"line_number":134,"context_line":"        waiters.wait_for_server_status(self.servers_client, server_id, state)"},{"line_number":135,"context_line":"        self.assertNotEqual("},{"line_number":136,"context_line":"            orig_host, self.get_host_for_server(server_id),"},{"line_number":137,"context_line":"            \u0027Live migration failed, \u0027"},{"line_number":138,"context_line":"            \u0027instance %s has not changed hosts\u0027 % server_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"89e83256_a78660af","line":135,"updated":"2021-08-27 16:57:03.000000000","message":"Might be beneficial to have a conditional based on target_host that way you are confirming the target host functionality is working when it is utilized.\n\nif target_host:\n    self.assertEqual(target_host, self.get_host_for_server(server_id), \u0027fail msg\u0027)\nelse:\n    self.assertNotEqual(orig_host, self.get_host_for_server(server_id), \u0027fail msg\u0027)","commit_id":"b04cb187fabb594348fe591015a42b7bd1c27444"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"bbc2271afb8a27deb968f04d1d78c5709ee6b3c5","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                                                      block_migration\u003d\u0027auto\u0027,"},{"line_number":133,"context_line":"                                                      host\u003dtarget_host)"},{"line_number":134,"context_line":"        waiters.wait_for_server_status(self.servers_client, server_id, state)"},{"line_number":135,"context_line":"        self.assertNotEqual("},{"line_number":136,"context_line":"            orig_host, self.get_host_for_server(server_id),"},{"line_number":137,"context_line":"            \u0027Live migration failed, \u0027"},{"line_number":138,"context_line":"            \u0027instance %s has not changed hosts\u0027 % server_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfcd5e21_b2326a7a","line":135,"in_reply_to":"89e83256_a78660af","updated":"2021-08-27 20:00:02.000000000","message":"Good point, done.","commit_id":"b04cb187fabb594348fe591015a42b7bd1c27444"}],"whitebox_tempest_plugin/api/compute/test_live_migration.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"38013689524d3944140f0777538ed3b8a7f181d0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        # Assert cache-mode has not changed during live migration"},{"line_number":72,"context_line":"        self.assertEqual(cache_type, root_disk_cache())"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_live_migrate_and_reboot(self):"},{"line_number":75,"context_line":"        flavor \u003d self.create_flavor("},{"line_number":76,"context_line":"            extra_specs\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027})"},{"line_number":77,"context_line":"        server \u003d self.create_test_server(flavor\u003dflavor[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"d368130a_5c5ef8d4","line":74,"updated":"2021-08-27 16:57:03.000000000","message":"Does it make sense to add a note mentioning https://bugs.launchpad.net/nova/+bug/1890501 here?  Just to highlight the importance that:\n1) The cpu sets have to be different between computes\n2) It is assumed they will be different and the test will no be responsible for getting it in that state.","commit_id":"b04cb187fabb594348fe591015a42b7bd1c27444"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"bbc2271afb8a27deb968f04d1d78c5709ee6b3c5","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        # Assert cache-mode has not changed during live migration"},{"line_number":72,"context_line":"        self.assertEqual(cache_type, root_disk_cache())"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def test_live_migrate_and_reboot(self):"},{"line_number":75,"context_line":"        flavor \u003d self.create_flavor("},{"line_number":76,"context_line":"            extra_specs\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027})"},{"line_number":77,"context_line":"        server \u003d self.create_test_server(flavor\u003dflavor[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"afdf7d35_70c6a0c9","line":74,"in_reply_to":"d368130a_5c5ef8d4","updated":"2021-08-27 20:00:02.000000000","message":"Yep, a docstring here stating the assumptions is needed.","commit_id":"b04cb187fabb594348fe591015a42b7bd1c27444"}]}