)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12002b63fb81af233d72460509af99938b327a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"62345a09_9e9a2dcb","updated":"2021-10-28 18:47:01.000000000","message":"Last 2 nits, thanks in advance for your patience :)","commit_id":"e0aa7930f1fea32d5901b94c7d04b6063b20df0f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"8a56ad49be0005376597bce8a2d776cbe8de2094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5e287e09_76ac7ff6","updated":"2021-11-01 14:39:28.000000000","message":"recheck","commit_id":"0276f52886397a6557b5cb8d8477b313e14291de"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7798975ef67113f45f7462fbaffda33e78574447","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f06fe4ba_faacbd81","updated":"2021-10-30 00:51:48.000000000","message":"recheck","commit_id":"0276f52886397a6557b5cb8d8477b313e14291de"}],"whitebox_tempest_plugin/api/compute/test_cpu_pinning.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"76f1f81a93b068ce963323ad55c18c45b5071542","unresolved":true,"context_lines":[{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def _get_cpu_set_by_core(self, server_id, instance_cpu_id):"},{"line_number":1346,"context_line":"        \"\"\"Search the xml vcpu element of the provided server for its cpuset."},{"line_number":1347,"context_line":"        Convert cpuset found into a set of integers."},{"line_number":1348,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"b66e49c3_5bda2f68","line":1345,"updated":"2021-09-01 18:57:51.000000000","message":"I\u0027m not sold on the name here... maybe something like get_host_cpus_for_guest_cpu?\n\nand this would belong in the numa helper mixin as well, no? if that\u0027s where were trying to centralize all the various numa-like helpers that need a test class to run (so they need self to be passed in, as opposed to the stuff in hardware.py)","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b0232095fd17981fe11d1427ab73379d77e4bbcf","unresolved":true,"context_lines":[{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def _get_cpu_set_by_core(self, server_id, instance_cpu_id):"},{"line_number":1346,"context_line":"        \"\"\"Search the xml vcpu element of the provided server for its cpuset."},{"line_number":1347,"context_line":"        Convert cpuset found into a set of integers."},{"line_number":1348,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a48a61d_186a2e7a","line":1345,"in_reply_to":"b66e49c3_5bda2f68","updated":"2021-09-01 19:10:13.000000000","message":"Agreed with both the name change and placement, maybe get_host_pcpus_for_guest_vcpu?","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12002b63fb81af233d72460509af99938b327a84","unresolved":true,"context_lines":[{"line_number":1337,"context_line":"                         \"NUMA topology doesn\u0027t match\")"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"class SharedPinnedAndUnpinned(BasePinningTest, numa_helper.NUMAHelperMixin):"},{"line_number":1341,"context_line":"    vcpus \u003d 2"},{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"}],"source_content_type":"text/x-python","patch_set":12,"id":"17b7131b_8c2058d0","line":1340,"range":{"start_line":1340,"start_character":6,"end_line":1340,"end_character":29},"updated":"2021-10-28 18:47:01.000000000","message":"It\u0027s a nit, but I\u0027d rather get it right the first time: the test name. In this context, \u0027shared\u0027 normally refers to the cpu_shared_set, can we rename the test to something else, like MixedPolicyTest or something?","commit_id":"e0aa7930f1fea32d5901b94c7d04b6063b20df0f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"361dc3fbb17b15924317ee3f9fe28d742c10dd00","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"                         \"NUMA topology doesn\u0027t match\")"},{"line_number":1338,"context_line":""},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"class SharedPinnedAndUnpinned(BasePinningTest, numa_helper.NUMAHelperMixin):"},{"line_number":1341,"context_line":"    vcpus \u003d 2"},{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"}],"source_content_type":"text/x-python","patch_set":12,"id":"1b0d4485_533f31f4","line":1340,"range":{"start_line":1340,"start_character":6,"end_line":1340,"end_character":29},"in_reply_to":"17b7131b_8c2058d0","updated":"2021-10-28 19:38:27.000000000","message":"Yes that\u0027s a better overall name","commit_id":"e0aa7930f1fea32d5901b94c7d04b6063b20df0f"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"12002b63fb81af233d72460509af99938b327a84","unresolved":true,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"class SharedPinnedAndUnpinned(BasePinningTest, numa_helper.NUMAHelperMixin):"},{"line_number":1341,"context_line":"    vcpus \u003d 2"},{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_shared_pinned_and_unpinned_guest(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"b6bf26d5_c8b1b42c","line":1342,"range":{"start_line":1342,"start_character":4,"end_line":1342,"end_character":24},"updated":"2021-10-28 18:47:01.000000000","message":"Err, it\u0027s not \u0027dedicated\u0027 :)","commit_id":"e0aa7930f1fea32d5901b94c7d04b6063b20df0f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"361dc3fbb17b15924317ee3f9fe28d742c10dd00","unresolved":false,"context_lines":[{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"class SharedPinnedAndUnpinned(BasePinningTest, numa_helper.NUMAHelperMixin):"},{"line_number":1341,"context_line":"    vcpus \u003d 2"},{"line_number":1342,"context_line":"    dedicated_cpu_policy \u003d {\u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1343,"context_line":"                            \u0027hw:cpu_dedicated_mask\u0027: \u0027^0\u0027}"},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"    def test_shared_pinned_and_unpinned_guest(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ace55095_89a10836","line":1342,"range":{"start_line":1342,"start_character":4,"end_line":1342,"end_character":24},"in_reply_to":"b6bf26d5_c8b1b42c","updated":"2021-10-28 19:38:27.000000000","message":"Ack","commit_id":"e0aa7930f1fea32d5901b94c7d04b6063b20df0f"}],"whitebox_tempest_plugin/services/clients.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"76f1f81a93b068ce963323ad55c18c45b5071542","unresolved":true,"context_lines":[{"line_number":218,"context_line":"                                            \u0027down\u0027)"},{"line_number":219,"context_line":"        return result"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_cpu_shared_set(self):"},{"line_number":222,"context_line":"        shared_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_shared_set\u0027)"},{"line_number":223,"context_line":"        return hardware.parse_cpu_spec(shared_set)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ac5c7832_b572d608","line":221,"updated":"2021-09-01 18:57:51.000000000","message":"This should probably live in the numa helper mixin...","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b0232095fd17981fe11d1427ab73379d77e4bbcf","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                                            \u0027down\u0027)"},{"line_number":219,"context_line":"        return result"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_cpu_shared_set(self):"},{"line_number":222,"context_line":"        shared_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_shared_set\u0027)"},{"line_number":223,"context_line":"        return hardware.parse_cpu_spec(shared_set)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8e2b955f_df82eb67","line":221,"in_reply_to":"ac5c7832_b572d608","updated":"2021-09-01 19:10:13.000000000","message":"Ack","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"76f1f81a93b068ce963323ad55c18c45b5071542","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        shared_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_shared_set\u0027)"},{"line_number":223,"context_line":"        return hardware.parse_cpu_spec(shared_set)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def get_cpu_dedicated_set(self):"},{"line_number":226,"context_line":"        dedicated_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_dedicated_set\u0027)"},{"line_number":227,"context_line":"        dedicated_set \u003d (dedicated_set if dedicated_set is not None else"},{"line_number":228,"context_line":"                         self.get_conf_opt(\u0027DEFAULT\u0027, \u0027vcpu_pin_set\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"cb871fab_dcd1ce39","line":225,"updated":"2021-09-01 18:57:51.000000000","message":"This too","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b0232095fd17981fe11d1427ab73379d77e4bbcf","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        shared_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_shared_set\u0027)"},{"line_number":223,"context_line":"        return hardware.parse_cpu_spec(shared_set)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def get_cpu_dedicated_set(self):"},{"line_number":226,"context_line":"        dedicated_set \u003d self.get_conf_opt(\u0027compute\u0027, \u0027cpu_dedicated_set\u0027)"},{"line_number":227,"context_line":"        dedicated_set \u003d (dedicated_set if dedicated_set is not None else"},{"line_number":228,"context_line":"                         self.get_conf_opt(\u0027DEFAULT\u0027, \u0027vcpu_pin_set\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"95cddd9e_5ec75b61","line":225,"in_reply_to":"cb871fab_dcd1ce39","updated":"2021-09-01 19:10:13.000000000","message":"Ack","commit_id":"c900a7d6c551e922a332279b7cbf942e12d94738"}]}