)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"adad121c7dfde7311e49c09d953b53604e565cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c3f84aaf_7ef28f60","updated":"2021-12-03 15:01:10.000000000","message":"Looks good, awaiting Zuul results.","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"406946b75403808facc31195f236b4127e3ba439","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3983cbe_4dc45509","updated":"2021-12-03 18:34:27.000000000","message":"So CI failed because we\u0027re running test_resize_unpinned_server_to_pinned on the \"base\" deployment with no cpu_dedicated_set configured. Specifically, the delete failed. What I think is happening is a race with the update resources periodic task, which ends up giving the now infamous \"CPU set to unpin [2, 6] must be a subset of pinned CPU set []\" - which kinda makes sense, as the host doesn\u0027t have any CPU pinning configuration, but we booted a pinned instance.\n\nI\u0027ve proposed https://review.opendev.org/c/openstack/nova/+/820401 to Nova to track *something* that has to do with fixing that, though I think on the whitebox side we can merge back the jobs and run everything with the CPU pinning configuration in place.","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b51a1dfe2d2c4032e5981793270db1ba83286d83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3027fabe_f7f94743","updated":"2021-12-03 15:04:26.000000000","message":"nit based on recent changes we\u0027ve been doing.","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7b32171649facb23ca3464c2d11edbbe597835a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"63784ec0_b664d9b7","updated":"2021-12-03 15:38:50.000000000","message":"recheck","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9b7bc3f1704f3466277fe8ca6048ce12d6fe2628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e45695a0_5937794a","updated":"2021-12-03 18:14:41.000000000","message":"recheck","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"}],"whitebox_tempest_plugin/api/compute/base.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b51a1dfe2d2c4032e5981793270db1ba83286d83","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_server_xml(self, server_id):"},{"line_number":95,"context_line":"        server \u003d self.os_admin.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":96,"context_line":"        host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":97,"context_line":"        cntrlplane_addr \u003d whitebox_utils.get_ctlplane_address(host)"},{"line_number":98,"context_line":"        server_instance_name \u003d server[\u0027OS-EXT-SRV-ATTR:instance_name\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d6fe5856_3f76523a","line":96,"updated":"2021-12-03 15:04:26.000000000","message":"nit:\nWe\u0027ve been moving a lot of these to the function, self.get_host_for_server() should we do it here as well?","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"1634cbf46923622972a3e558a98993dc7248c743","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_server_xml(self, server_id):"},{"line_number":95,"context_line":"        server \u003d self.os_admin.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":96,"context_line":"        host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":97,"context_line":"        cntrlplane_addr \u003d whitebox_utils.get_ctlplane_address(host)"},{"line_number":98,"context_line":"        server_instance_name \u003d server[\u0027OS-EXT-SRV-ATTR:instance_name\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d4a2e1d6_055a952b","line":96,"in_reply_to":"32132f37_e7fbdf8f","updated":"2021-12-03 15:17:18.000000000","message":"Ah right sorry that makes sense thanks for clarifying.","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ea3ca6f9a4ce03d15b4791439206de1bb9ff508e","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_server_xml(self, server_id):"},{"line_number":95,"context_line":"        server \u003d self.os_admin.servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":96,"context_line":"        host \u003d server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":97,"context_line":"        cntrlplane_addr \u003d whitebox_utils.get_ctlplane_address(host)"},{"line_number":98,"context_line":"        server_instance_name \u003d server[\u0027OS-EXT-SRV-ATTR:instance_name\u0027]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"32132f37_e7fbdf8f","line":96,"in_reply_to":"d6fe5856_3f76523a","updated":"2021-12-03 15:07:59.000000000","message":"So here I did it differently because we need both the host and the instance_name. get_host_for_sever fetches the server with the admin client and returns only the host. We\u0027d then have to fetch it again wastefully to get the instance name. So we just fetch it once manually, and pick both the host and the instance name.","commit_id":"f5b84645348dd28b968768d1720f6b78634ab40c"}]}