)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8ca7e4cb48dc8d8b3b006e3b7c0f104a57a5d301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58c11248_57f5e8de","updated":"2022-12-13 20:07:49.000000000","message":"Couple of nits, and a question.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"58ee7a5a1e135e095f9366f2b0f79b1a39e2ceec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e81f4f48_eabee32e","updated":"2023-01-23 15:26:38.000000000","message":"vDPA Downstream Results:\n(.tempest) (overcloud) [stack@undercloud-0 tempest_workspace]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_vdpa.VDPASmokeTests.test_guest_creation_with_vdpa_port\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPASmokeTests.test_guest_creation_with_vdpa_port [22.781992s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 1 tests in 22.7820 sec.\n - Passed: 1\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 22.7820 sec.\n","commit_id":"75bbfeb2575e6ebe94340c2f01a7d695b39be12e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"749a3505727950b62b753eba35b40c559f0d75b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d6801858_28842320","updated":"2023-04-03 16:07:40.000000000","message":"looking at the changes since i last reivew patchset 6 this still looks good to me ","commit_id":"f7104a681d2e808642ea65132a2a3ad6997a614f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"acde1940d0be5db62d95cbd73968f90c5a8ae6e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"06efc82d_de6583c3","updated":"2023-03-14 13:28:10.000000000","message":"recheck","commit_id":"f7104a681d2e808642ea65132a2a3ad6997a614f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"adeb167e09d26aac5bd3972f24ae88b0eecbd427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2ad9aec7_38794aa3","updated":"2023-03-21 16:23:16.000000000","message":"recheck","commit_id":"f7104a681d2e808642ea65132a2a3ad6997a614f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"7851bf34625c9b7a237a849d03ccae4429380aca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ecd2c8ac_dc57b56a","updated":"2023-02-01 19:09:46.000000000","message":"recheck","commit_id":"f7104a681d2e808642ea65132a2a3ad6997a614f"}],"whitebox_tempest_plugin/api/compute/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b294a29cb45011b39e9364ccca6efb1995f285ed","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        \"\"\"Returns xml interface element that matches provided port mac"},{"line_number":287,"context_line":"        and interface type. It is technically possible to have multiple ports"},{"line_number":288,"context_line":"        with the same MAC address in an instance, so method functionality may"},{"line_number":289,"context_line":"        break in the future."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        :param server_id: str, id of the instance to analyze"},{"line_number":292,"context_line":"        :param port_id: str, port id to request from the ports client"}],"source_content_type":"text/x-python","patch_set":6,"id":"4c1fed0e_713c7372","line":289,"updated":"2022-12-12 18:22:09.000000000","message":"ack not that its relevent for this test but it also will not work for vnic_type\u003ddirect-physical since it does not have the mac in the xml\n\nfor our usage here however  it should be fine.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ce061f0787109a5401421c16756a35823cc5e268","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        \"\"\"Returns xml interface element that matches provided port mac"},{"line_number":287,"context_line":"        and interface type. It is technically possible to have multiple ports"},{"line_number":288,"context_line":"        with the same MAC address in an instance, so method functionality may"},{"line_number":289,"context_line":"        break in the future."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        :param server_id: str, id of the instance to analyze"},{"line_number":292,"context_line":"        :param port_id: str, port id to request from the ports client"}],"source_content_type":"text/x-python","patch_set":6,"id":"5e4238b1_5e0fca2b","line":289,"in_reply_to":"4c1fed0e_713c7372","updated":"2022-12-12 18:33:54.000000000","message":"Ack","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b294a29cb45011b39e9364ccca6efb1995f285ed","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        db \u003d CONF.whitebox_database.nova_cell1_db_name"},{"line_number":392,"context_line":"        with db_client.cursor(db) as cursor:"},{"line_number":393,"context_line":"            cursor.execute("},{"line_number":394,"context_line":"                \u0027SELECT address,status,dev_type FROM \u0027"},{"line_number":395,"context_line":"                \u0027pci_devices WHERE %s \u003d \"%s\"\u0027 % (column, value))"},{"line_number":396,"context_line":"            data \u003d cursor.fetchall()"},{"line_number":397,"context_line":"        return data"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"13535a6b_4613d5e4","line":395,"range":{"start_line":394,"start_character":16,"end_line":395,"end_character":64},"updated":"2022-12-12 18:22:09.000000000","message":"this works but its proably cleaner to use f string in the future.\nboth fstrings and interperaltion are valid so this is just a nit.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ce061f0787109a5401421c16756a35823cc5e268","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        db \u003d CONF.whitebox_database.nova_cell1_db_name"},{"line_number":392,"context_line":"        with db_client.cursor(db) as cursor:"},{"line_number":393,"context_line":"            cursor.execute("},{"line_number":394,"context_line":"                \u0027SELECT address,status,dev_type FROM \u0027"},{"line_number":395,"context_line":"                \u0027pci_devices WHERE %s \u003d \"%s\"\u0027 % (column, value))"},{"line_number":396,"context_line":"            data \u003d cursor.fetchall()"},{"line_number":397,"context_line":"        return data"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85eb7a_df531413","line":395,"range":{"start_line":394,"start_character":16,"end_line":395,"end_character":64},"in_reply_to":"13535a6b_4613d5e4","updated":"2022-12-12 18:33:54.000000000","message":"I\u0027ll be sure to update this when I put up the movement based tests for vDPA.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"}],"whitebox_tempest_plugin/api/compute/test_sriov.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"39cb66c7ea940aafecb1e268bcfb27cfcf45146f","unresolved":true,"context_lines":[{"line_number":679,"context_line":"        super(SRIOVAttachAndDetach, self).setUp()"},{"line_number":680,"context_line":"        self.vlan_id \u003d \\"},{"line_number":681,"context_line":"            CONF.whitebox_hardware.sriov_vlan_id"},{"line_number":682,"context_line":"        self.network \u003d self._create_net_from_physical_network(self.vlan_id)"},{"line_number":683,"context_line":"        self.__create_subnet(self.sriov_network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"d455c4aa_fc0184f7","line":682,"updated":"2023-01-09 18:20:22.000000000","message":"Need to address this as it will fail due to missing parameter.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6905b6a3570ea46cab6ace8333c3bebcf0c34812","unresolved":true,"context_lines":[{"line_number":771,"context_line":"            pci_device_status_regex \u003d \u0027allocated|claimed\u0027"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        net_vlan \u003d \\"},{"line_number":774,"context_line":"            CONF.network_feature_enabled.provider_net_base_segmentation_id"},{"line_number":775,"context_line":"        flavor \u003d self.create_flavor()"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        port \u003d self._create_sriov_port("}],"source_content_type":"text/x-python","patch_set":8,"id":"96ed38ea_5590e4ed","side":"PARENT","line":774,"updated":"2023-04-03 18:22:47.000000000","message":"Oh OK, this is from network features, so nothing to remove in whitebox config proper.","commit_id":"37f8dd83e66e39be282fa3aab869a9a872c8d01f"}],"whitebox_tempest_plugin/api/compute/test_vdpa.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8ca7e4cb48dc8d8b3b006e3b7c0f104a57a5d301","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        super(VDPASmokeTests, cls).skip_checks()"},{"line_number":31,"context_line":"        if getattr(CONF.whitebox_hardware,"},{"line_number":32,"context_line":"                   \u0027vdpa_physnet\u0027, None) is None:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Requires sriov_physnet parameter \u0027"},{"line_number":34,"context_line":"                                    \u0027to be set in order to execute test \u0027"},{"line_number":35,"context_line":"                                    \u0027cases.\u0027)"},{"line_number":36,"context_line":"        if getattr(CONF.whitebox_hardware,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4a32bd22_9f5b269e","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":59},"updated":"2022-12-13 20:07:49.000000000","message":"nit: you forgot to un-copy-paste sriov_physnet to vdpa_physnet ;)","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9f7fa0096ab6e34e58d7591eaaf6060a0b0cae5d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        super(VDPASmokeTests, cls).skip_checks()"},{"line_number":31,"context_line":"        if getattr(CONF.whitebox_hardware,"},{"line_number":32,"context_line":"                   \u0027vdpa_physnet\u0027, None) is None:"},{"line_number":33,"context_line":"            raise cls.skipException(\u0027Requires sriov_physnet parameter \u0027"},{"line_number":34,"context_line":"                                    \u0027to be set in order to execute test \u0027"},{"line_number":35,"context_line":"                                    \u0027cases.\u0027)"},{"line_number":36,"context_line":"        if getattr(CONF.whitebox_hardware,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c32e07ea_d592d21b","line":33,"range":{"start_line":33,"start_character":46,"end_line":33,"end_character":59},"in_reply_to":"4a32bd22_9f5b269e","updated":"2022-12-13 20:20:43.000000000","message":"Ack","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b294a29cb45011b39e9364ccca6efb1995f285ed","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                   \u0027vdpa_vlan_id\u0027, None) is None:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Requires \u0027"},{"line_number":39,"context_line":"                                    \u0027vdpa_vlan_id parameter to be set in \u0027"},{"line_number":40,"context_line":"                                    \u0027order to execute test cases.\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(VDPASmokeTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"676115e0_aa41272c","line":40,"updated":"2022-12-12 18:22:09.000000000","message":"as an intiall set of testcase i think im fine with this.\n\nin the future it would also be good to test with geneve networks\nim not sure if we can do both in ci so we can chat about this later but for an inital set of smoke tests vlan netorking sound good to me.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ce061f0787109a5401421c16756a35823cc5e268","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                   \u0027vdpa_vlan_id\u0027, None) is None:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Requires \u0027"},{"line_number":39,"context_line":"                                    \u0027vdpa_vlan_id parameter to be set in \u0027"},{"line_number":40,"context_line":"                                    \u0027order to execute test cases.\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(VDPASmokeTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"11505550_76dbc04a","line":40,"in_reply_to":"676115e0_aa41272c","updated":"2022-12-12 18:33:54.000000000","message":"Ack","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8ca7e4cb48dc8d8b3b006e3b7c0f104a57a5d301","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self._create_subnet(self.network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_guest_creation_with_vdpa_port(self):"},{"line_number":54,"context_line":"        \"\"\"Parent test class that perform sr-iov live migration"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param vnic_type: str, vnic_type to use when creating sr-iov port"},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"956f2aeb_afce3990","line":54,"updated":"2022-12-13 20:07:49.000000000","message":"I don\u0027t think this is the correct doctext ;)","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9f7fa0096ab6e34e58d7591eaaf6060a0b0cae5d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self._create_subnet(self.network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_guest_creation_with_vdpa_port(self):"},{"line_number":54,"context_line":"        \"\"\"Parent test class that perform sr-iov live migration"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        :param vnic_type: str, vnic_type to use when creating sr-iov port"},{"line_number":57,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"62332cb8_297c930f","line":54,"in_reply_to":"956f2aeb_afce3990","updated":"2022-12-13 20:20:43.000000000","message":"Ack","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"8ca7e4cb48dc8d8b3b006e3b7c0f104a57a5d301","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            server[\u0027id\u0027],"},{"line_number":73,"context_line":"            port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        if CONF.whitebox.rx_queue_size:"},{"line_number":76,"context_line":"            driver \u003d interface_xml_element.find(\"./driver[@name\u003d\u0027vhost\u0027]\")"},{"line_number":77,"context_line":"            self.assertEqual("},{"line_number":78,"context_line":"                str(CONF.whitebox.rx_queue_size),"}],"source_content_type":"text/x-python","patch_set":6,"id":"1269f69f_d7249aa3","line":75,"updated":"2022-12-13 20:07:49.000000000","message":"Is this left over from a copy-paste? Or is this a legit part of the vDPA feature and I\u0027m just ignorant? Feels weirdly out of scope to check for queue size here...","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9f7fa0096ab6e34e58d7591eaaf6060a0b0cae5d","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            server[\u0027id\u0027],"},{"line_number":73,"context_line":"            port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        if CONF.whitebox.rx_queue_size:"},{"line_number":76,"context_line":"            driver \u003d interface_xml_element.find(\"./driver[@name\u003d\u0027vhost\u0027]\")"},{"line_number":77,"context_line":"            self.assertEqual("},{"line_number":78,"context_line":"                str(CONF.whitebox.rx_queue_size),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7cd68d8a_5b2b36b8","line":75,"in_reply_to":"1269f69f_d7249aa3","updated":"2022-12-13 20:20:43.000000000","message":"Both hybrid beds are inaccessible currently :/, but let me confirm, I remember specifically seeing this specific to vDPA but I could be mistaken.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4a823a7a56b425da1cb05a7c19183f55df98981","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            server[\u0027id\u0027],"},{"line_number":73,"context_line":"            port[\u0027port\u0027][\u0027id\u0027],"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        if CONF.whitebox.rx_queue_size:"},{"line_number":76,"context_line":"            driver \u003d interface_xml_element.find(\"./driver[@name\u003d\u0027vhost\u0027]\")"},{"line_number":77,"context_line":"            self.assertEqual("},{"line_number":78,"context_line":"                str(CONF.whitebox.rx_queue_size),"}],"source_content_type":"text/x-python","patch_set":6,"id":"53ae3c35_6c407535","line":75,"in_reply_to":"7cd68d8a_5b2b36b8","updated":"2022-12-13 20:29:13.000000000","message":"this should be configurable with vdpa but honestly not sure.\ni didnt actully try to configure it myself btu i think this shoudl work for any virtio-net-pci device from a qemu perspective.","commit_id":"68eafb7ff8e69a5c8f2771085f47ec59b2783000"}]}