)]}'
{".zuul.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7c613cfdb9898301edda97cc2eadc42941d090c8","unresolved":true,"context_lines":[{"line_number":67,"context_line":"              rx_queue_size: 1024"},{"line_number":68,"context_line":"    group-vars:"},{"line_number":69,"context_line":"      subnode:"},{"line_number":70,"context_line":"        num_hugepages: 2048"},{"line_number":71,"context_line":"        devstack_localrc:"},{"line_number":72,"context_line":"          LIBVIRT_TYPE: kvm"},{"line_number":73,"context_line":"        devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fb6a734c_ccbd4630","line":70,"updated":"2022-01-18 02:54:58.000000000","message":"Why not lose the num_hugepages here...","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"06f8a394cb1683ed55972334c907f9cc9bdc885d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"              rx_queue_size: 1024"},{"line_number":68,"context_line":"    group-vars:"},{"line_number":69,"context_line":"      subnode:"},{"line_number":70,"context_line":"        num_hugepages: 2048"},{"line_number":71,"context_line":"        devstack_localrc:"},{"line_number":72,"context_line":"          LIBVIRT_TYPE: kvm"},{"line_number":73,"context_line":"        devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d5db0dab_9670f592","line":70,"in_reply_to":"fb6a734c_ccbd4630","updated":"2022-01-18 03:00:17.000000000","message":"Ack","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7c613cfdb9898301edda97cc2eadc42941d090c8","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                virt_type: kvm"},{"line_number":142,"context_line":"                rx_queue_size: 1024"},{"line_number":143,"context_line":"      tempest:"},{"line_number":144,"context_line":"        num_hugepages: 512"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"- job:"},{"line_number":147,"context_line":"    name: whitebox-devstack-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3318cdd9_cbbfb221","line":144,"updated":"2022-01-18 02:54:58.000000000","message":"... and here, and have the new job inherit from whitebox-devstack-multinode, and just add the hugepages variable to it?","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"06f8a394cb1683ed55972334c907f9cc9bdc885d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                virt_type: kvm"},{"line_number":142,"context_line":"                rx_queue_size: 1024"},{"line_number":143,"context_line":"      tempest:"},{"line_number":144,"context_line":"        num_hugepages: 512"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"- job:"},{"line_number":147,"context_line":"    name: whitebox-devstack-ceph-compute-local-ephemeral"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ce8597d_07e0d884","line":144,"in_reply_to":"3318cdd9_cbbfb221","updated":"2022-01-18 03:00:17.000000000","message":"Ack","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"fc978bf7426930bd93e7cf14c1a7c108754dcbe6","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    description: |"},{"line_number":89,"context_line":"      Runs the entire test suite on single-NUMA, non-SMT, nested virt VMs, and hugepages."},{"line_number":90,"context_line":"    vars:"},{"line_number":91,"context_line":"      tempest_exclude_regex: test_file_backed_memory.FileBackedMemory"},{"line_number":92,"context_line":"    group-vars:"},{"line_number":93,"context_line":"      subnode:"},{"line_number":94,"context_line":"        num_hugepages: 512"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bf83bbfc_08570713","line":91,"updated":"2022-02-08 12:39:38.000000000","message":"I think it makes more sense to just run the hugepages tests in this job, no? (So tempest_test_regex: \u003chugepages\u003e\n\nThat would also mean that you\u0027d have to squash the new tests into this patch (or vice versa), and have just one patch with the new code and the new job.","commit_id":"29e7f7ae10e61d21717ea55156f53f707b2994eb"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9272a4bc997d192eb5bfb54fd684a160e9bb8bb5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    description: |"},{"line_number":89,"context_line":"      Runs the entire test suite on single-NUMA, non-SMT, nested virt VMs, and hugepages."},{"line_number":90,"context_line":"    vars:"},{"line_number":91,"context_line":"      tempest_exclude_regex: test_file_backed_memory.FileBackedMemory"},{"line_number":92,"context_line":"    group-vars:"},{"line_number":93,"context_line":"      subnode:"},{"line_number":94,"context_line":"        num_hugepages: 512"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"58985902_cf9e0c5b","line":91,"in_reply_to":"bf83bbfc_08570713","updated":"2022-02-08 14:19:42.000000000","message":"Ack","commit_id":"29e7f7ae10e61d21717ea55156f53f707b2994eb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28279f65d348a637ee065d6da602d452b02f70a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"876cea84_154925b8","updated":"2022-01-18 17:02:33.000000000","message":"https://zuul.opendev.org/t/openstack/build/117561150f504acd92cd11d0093e84b5/log/job-output.txt#1810\n\nI know Zuul doens\u0027t have access to all the ansible modules, I wonder if this is one of them...","commit_id":"e6427c85b130b95bcf7ead431c0980f5a878c4a9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"59dc595955a68efab2089edb5a416a7383e3db7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2341197a_12033faa","in_reply_to":"876cea84_154925b8","updated":"2022-01-18 17:11:06.000000000","message":"No, I got it wrong - has to do with namespaces apparently. Try just \u0027mount\u0027","commit_id":"e6427c85b130b95bcf7ead431c0980f5a878c4a9"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9ad7ea71d82c0df9352cc79d38728809570c82cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fea8052_6fc97c90","in_reply_to":"876cea84_154925b8","updated":"2022-01-18 17:04:45.000000000","message":"Yea I think you are right, let me revert back to shell.","commit_id":"e6427c85b130b95bcf7ead431c0980f5a878c4a9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"0fa5248ff83fe5643b4bf838a30be1dc41b775cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"352c58c6_cea70eb3","updated":"2022-02-09 20:35:41.000000000","message":"I\u0027d like to see the new tests stacked on top of this one and ran, but other than that LGTM.","commit_id":"32e16049f47debd2bff84b01c206273940d5940c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3d6a32f88d89d9de110af1be9ea504bea9cd757d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2f9ace62_ab9584ce","updated":"2022-03-04 21:56:30.000000000","message":"I think we\u0027re overcomplicating things by splitting this into 2 patches. Just squash https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/824772 into this one (or vice versa I guess) and have everything in one patch:\n\n- the new Ansible tasks to set up huge pages\n- a new job that just runs the huge pages tests\n- exclude the huge pages tests from our current job\n- the actual test code and the config that it needs\n\n","commit_id":"1a1d6ae4ce3345d5064d5b98f10f8c5b29246a70"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a1970f25e4f85749d08be592b7bd6ef58ef3361c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"40a4209f_428f26ee","updated":"2022-02-11 19:48:23.000000000","message":"If the dependant test patches, we can go ahead with this.","commit_id":"1a1d6ae4ce3345d5064d5b98f10f8c5b29246a70"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c8b345863a43745db188d57fe3c80874b5a5da94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"fc4c804d_c4420ea7","updated":"2022-02-14 16:13:22.000000000","message":"recheck","commit_id":"1a1d6ae4ce3345d5064d5b98f10f8c5b29246a70"}],"playbooks/whitebox/pre.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"fc978bf7426930bd93e7cf14c1a7c108754dcbe6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"          ansible_become: yes"},{"line_number":22,"context_line":"          copy_sshkey_target_user: \u0027tempest\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Install numactl"},{"line_number":25,"context_line":"      package:"},{"line_number":26,"context_line":"          name: numactl"},{"line_number":27,"context_line":"          state: present"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"230e8534_759832fb","line":24,"updated":"2022-02-08 12:39:38.000000000","message":"I don\u0027t think we actually need this anymore, but removing it is out of scope here.\n\n\u003cedit\u003e OK, I think I\u0027ve wrapped my head around what my beef with this PS is:\n\nIt\u0027s doing too many things at once (probably my fault, since I asked to move stuff to just a list of tasks in the pre playbook).\n\nI think we need a patch under this one, that moves the roles in here as a list of tasks (and removes the roles entirely) and removes numactl since we don\u0027t need it anymore.\n\nThen we need another patch on top that adds a different playbook, called hugepages.yaml or something, that just sets up hugepages. The reason for this is while the pre.yaml playbook is common to all whitebox jobs (we need the tempest SSH key everywhere, as well as crudini), the hugepages setup will only get used in the hugepages job.\n\nIn that second patch we can add the job as well, and the new test code, so everything gets tested at once and comes in as a unit.","commit_id":"29e7f7ae10e61d21717ea55156f53f707b2994eb"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9272a4bc997d192eb5bfb54fd684a160e9bb8bb5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"          ansible_become: yes"},{"line_number":22,"context_line":"          copy_sshkey_target_user: \u0027tempest\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Install numactl"},{"line_number":25,"context_line":"      package:"},{"line_number":26,"context_line":"          name: numactl"},{"line_number":27,"context_line":"          state: present"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"43bffe4c_46b7d1dc","line":24,"in_reply_to":"230e8534_759832fb","updated":"2022-02-08 14:19:42.000000000","message":"Yup this is all sounds like a good approach.","commit_id":"29e7f7ae10e61d21717ea55156f53f707b2994eb"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"18775c1ae2a4f42cb86667a033b58088eefcdb0c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"          ansible_become: yes"},{"line_number":22,"context_line":"          copy_sshkey_target_user: \u0027tempest\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Install numactl"},{"line_number":25,"context_line":"      package:"},{"line_number":26,"context_line":"          name: numactl"},{"line_number":27,"context_line":"          state: present"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ab41e7c6_52022b70","line":24,"in_reply_to":"43bffe4c_46b7d1dc","updated":"2022-02-09 16:49:31.000000000","message":"Let me know if this hits what you had in mind.  The follow up commit in the series will have the new job along with the testcases.","commit_id":"29e7f7ae10e61d21717ea55156f53f707b2994eb"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"0fa5248ff83fe5643b4bf838a30be1dc41b775cd","unresolved":true,"context_lines":[{"line_number":37,"context_line":"              mkdir /dev/hugepages2M"},{"line_number":38,"context_line":"              mount -t hugetlbfs -o pagesize\u003d2M none /dev/hugepages2M"},{"line_number":39,"context_line":"          become: yes"},{"line_number":40,"context_line":"      when: num_hugepages is defined"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f1b1091f_982f84a1","line":40,"updated":"2022-02-09 20:35:41.000000000","message":"Oh I see how you did it. Rather than add a separate playbook, just add the two hugepages tasks into the existing one as a block with a condition. Yep, I like that.","commit_id":"32e16049f47debd2bff84b01c206273940d5940c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a1970f25e4f85749d08be592b7bd6ef58ef3361c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"          ansible_become: yes"},{"line_number":21,"context_line":"          copy_sshkey_target_user: \u0027tempest\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- hosts: compute"},{"line_number":24,"context_line":"  tasks:"},{"line_number":25,"context_line":"    - name: Create hugepages for computes"},{"line_number":26,"context_line":"      block:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"c91d85cc_2a187ab6","line":23,"updated":"2022-02-11 19:48:23.000000000","message":"OK, we have a group called \u0027compute\u0027 that contains both the controller and the... compute :P Duplicate group/node name is confusing, but OK, should work.","commit_id":"1a1d6ae4ce3345d5064d5b98f10f8c5b29246a70"}],"roles/whitebox-nova-compute/tasks/main.yml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7c613cfdb9898301edda97cc2eadc42941d090c8","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create mounts for hugepages"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"      mkdir /dev/hugepages1M"},{"line_number":10,"context_line":"      mount -t hugetlbfs -o pagesize\u003d1G none /dev/hugepages1M"},{"line_number":11,"context_line":"      mkdir /dev/hugepages2M"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"811d4b70_e52d3467","line":8,"updated":"2022-01-18 02:54:58.000000000","message":"I wonder if you can use ansible mounts for this [1]\n\n[1] https://docs.ansible.com/ansible/latest/collections/ansible/posix/mount_module.html","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"06f8a394cb1683ed55972334c907f9cc9bdc885d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create mounts for hugepages"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"      mkdir /dev/hugepages1M"},{"line_number":10,"context_line":"      mount -t hugetlbfs -o pagesize\u003d1G none /dev/hugepages1M"},{"line_number":11,"context_line":"      mkdir /dev/hugepages2M"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dcd5e8f8_cbaea452","line":8,"in_reply_to":"811d4b70_e52d3467","updated":"2022-01-18 03:00:17.000000000","message":"The service builtin \u0027worked\u0027, see response on L#16, so I think this could work as well.  I will switch it out with the mount module.","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"7c613cfdb9898301edda97cc2eadc42941d090c8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  become: yes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Restart libvirtd"},{"line_number":16,"context_line":"  shell: systemctl restart libvirtd"},{"line_number":17,"context_line":"  become: yes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Allocate hugepages"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"382b3adc_690453e5","line":16,"updated":"2022-01-18 02:54:58.000000000","message":"And the ansible service module here.\n\n[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/service_module.html","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"06f8a394cb1683ed55972334c907f9cc9bdc885d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  become: yes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Restart libvirtd"},{"line_number":16,"context_line":"  shell: systemctl restart libvirtd"},{"line_number":17,"context_line":"  become: yes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Allocate hugepages"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fded0bce_109280a2","line":16,"in_reply_to":"382b3adc_690453e5","updated":"2022-01-18 03:00:17.000000000","message":"I think we can, I tried it in the previous patchset but when it failed I wanted to try shell.  Both attempts failed for the same reason (unable to find the libvirtd service).  I\u0027ll revert it back to the builtin though.","commit_id":"eccf1c2887035ece7355880cc09a96d6b8205904"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"0d9d1a90e5ac7d4120e9d41bf726562e60b8f29e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create 1M mount for hugepages"},{"line_number":8,"context_line":"  path: /dev/hugepages1M"},{"line_number":9,"context_line":"  src: none"},{"line_number":10,"context_line":"  opts: pagesize\u003d1M"},{"line_number":11,"context_line":"  state: mounted"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"db8abbb9_b3d4f506","line":8,"updated":"2022-01-18 16:04:10.000000000","message":"The indents are off, I\u0027m not sure why Zuul hasn\u0027t complained about syntax yet.","commit_id":"5b47dc3fe45e571422a4cfc1206ec4d68b9823ad"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"a0079b627b4acc4266d281df4b8c2773a750ceec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create 1M mount for hugepages"},{"line_number":8,"context_line":"  path: /dev/hugepages1M"},{"line_number":9,"context_line":"  src: none"},{"line_number":10,"context_line":"  opts: pagesize\u003d1M"},{"line_number":11,"context_line":"  state: mounted"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f2b3c85c_eba500d4","line":8,"in_reply_to":"db8abbb9_b3d4f506","updated":"2022-01-18 16:06:20.000000000","message":"Ack","commit_id":"5b47dc3fe45e571422a4cfc1206ec4d68b9823ad"}]}