)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"4932a5ad2a0c19c4e063e8b51496d956b0a6122f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e56ae11d_8542da3e","updated":"2022-03-02 20:34:13.000000000","message":"Downstream results:\n(.tempest) (overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [31.175584s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [30.433436s] ... ok\n","commit_id":"107c94a01c2851bcdf1a1426a8e7aeea27627fb0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"529773de64fe16022ca537dc3672abf0c6df84aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4a8f1e6_48bde22c","updated":"2022-03-04 21:58:23.000000000","message":"I think I\u0027d like just more explanations as to why we need this?","commit_id":"107c94a01c2851bcdf1a1426a8e7aeea27627fb0"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"bdeff4c1a8fc0818398515c07bd93f6f57b81ccd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f009742d_598691fe","in_reply_to":"011ceac2_486a1873","updated":"2022-03-07 14:05:47.000000000","message":"Didn\u0027t mean to resolve the comment thread, unresolving it with this comment until I get feedback.","commit_id":"107c94a01c2851bcdf1a1426a8e7aeea27627fb0"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"5778189dc4be08a0e4ed196583af6a2dd35cc7ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"011ceac2_486a1873","in_reply_to":"d4a8f1e6_48bde22c","updated":"2022-03-07 14:05:10.000000000","message":"I believe for 17+ it\u0027s not needed but for 16 to 16.2 due to the periodic update of the status of the pci device there is a very small chance that when I check the status in the DB it will be claimed rather than allocated. An alternative approach  could be to loop and check a couple of times and restrict the check to just allocated.","commit_id":"107c94a01c2851bcdf1a1426a8e7aeea27627fb0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f028580302f873a366df37c56168c55212a7cd4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94daadc4_0cad33af","in_reply_to":"f009742d_598691fe","updated":"2022-03-21 15:51:38.000000000","message":"the context is that on stable train we do not have sriov hot plug support\n\nhttps://github.com/openstack/nova/commit/1361ea5ad128e7048430612e01d97281fd094f05\n\nso on osp 16 we rely on the periodic task to move the device form claimed to allocated. on master/17 \n\nhttps://github.com/openstack/nova/blob/de10013328895c0a2c29d833c3c26209a258bc8f/nova/compute/manager.py#L7962\nwill atomicaly as part of the attach.\n\nso this code needs to cater for both states claimed or allocated since that is not backported to 16.x and this test needs to work on both.","commit_id":"107c94a01c2851bcdf1a1426a8e7aeea27627fb0"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d326e13ae435cd4fe11ace5e4c5f273aaebc2ab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6214f5f_84204e1b","updated":"2022-03-21 17:50:42.000000000","message":"Downstream Results:\n(overcloud) (.tempest) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [43.920170s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [30.459501s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 74.3878 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 74.3797 sec.\n","commit_id":"883c3d8c89f25db1b6d60efb70e23f9580638942"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"7f3e47de16a6da3ae0dffd656462c7c7f17394f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9bd58bb2_678602a4","updated":"2022-03-21 18:10:35.000000000","message":"Downstream Results for PS3:\n(overcloud) (.tempest) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [33.070227s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [27.517123s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 60.5933 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 60.5874 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (2 tests) \u003d\u003e 0:01:00.593261\n","commit_id":"d8dde5e6d1dfcbd8228e514fb12c32f34ed6a0b7"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c85f3a853104cf0f130f50763b32a20e39e74fb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc1a90aa_6bde3d90","updated":"2022-03-21 18:50:14.000000000","message":"Thanks!","commit_id":"d8dde5e6d1dfcbd8228e514fb12c32f34ed6a0b7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5766bb308b04aec97c4831d4677e2304f31f345c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4582409d_c9c6d655","updated":"2022-03-21 18:14:37.000000000","message":"ill leave the final desision to artom since he asked for the config option but i think this should work for our usecases.","commit_id":"d8dde5e6d1dfcbd8228e514fb12c32f34ed6a0b7"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5766bb308b04aec97c4831d4677e2304f31f345c","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                default\u003dFalse,"},{"line_number":262,"context_line":"                help\u003d\"If false, skip rbd direct download tests\"),"},{"line_number":263,"context_line":"    cfg.BoolOpt(\u0027sriov_hotplug\u0027,"},{"line_number":264,"context_line":"                default\u003dTrue,"},{"line_number":265,"context_line":"                help\u003d\"Sriov hotplugging is supported in the deployment\")"},{"line_number":266,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"424b809a_77111ead","line":264,"range":{"start_line":264,"start_character":24,"end_line":264,"end_character":28},"updated":"2022-03-21 18:14:37.000000000","message":"ack this is the correct default for master and it can be overriden downstream or on stable banches in the job config so i think this works for me +1","commit_id":"d8dde5e6d1dfcbd8228e514fb12c32f34ed6a0b7"}]}