)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28afbd7c382211a098a0287ae318d351c1c933ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee303ded_1013e857","updated":"2022-10-28 22:12:51.000000000","message":"With the nova fix from [1] applied, there is a new failure:\n\nTraceback (most recent call last):\n  File \"/home/stack/plugins/whitebox-tempest-plugin/whitebox_tempest_plugin/api/compute/test_sriov.py\", line 837, in test_sriov_affinity_socket_policy_precedence_flavor\n    self._socket_test_procedure(\n  File \"/home/stack/plugins/whitebox-tempest-plugin/whitebox_tempest_plugin/api/compute/test_sriov.py\", line 798, in _socket_test_procedure\n    pcpus_on_socket \u003d self._get_cpu_ids_with_socket_affinity(\n  File \"/home/stack/plugins/whitebox-tempest-plugin/whitebox_tempest_plugin/api/compute/test_sriov.py\", line 748, in _get_cpu_ids_with_socket_affinity\n    for socket, numa in CONF.whitebox_hardware.socket_affinity:\nTypeError: \u0027int\u0027 object is not iterable\n\n[1] https://review.opendev.org/c/openstack/nova/+/862964","commit_id":"f5504c89359e28fea01879b3181e734e14e8985b"}],"whitebox_tempest_plugin/api/compute/test_sriov.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"59f8a4eea5c33f5fd0b772475917491a5a6cd2f8","unresolved":true,"context_lines":[{"line_number":810,"context_line":"        # Validate servers A and B have correct sr-iov interface"},{"line_number":811,"context_line":"        # information in the xml. Its type and vlan should be accurate."},{"line_number":812,"context_line":"        net_vlan \u003d \\"},{"line_number":813,"context_line":"            CONF.network_feature_enabled.provider_net_base_segmentation_id"},{"line_number":814,"context_line":"        for server, port in zip([server_a, server_b],"},{"line_number":815,"context_line":"                                [port_a, port_b]):"},{"line_number":816,"context_line":"            interface_xml_element \u003d self._get_xml_interface_device("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa26431f_8b537992","line":813,"updated":"2022-12-13 20:26:42.000000000","message":"With the VDPA patch landing soon-ish, this should be sriov_vlan_id no? I guess whether or not your change this here will depend on what lands first.","commit_id":"5aecf722211f45dfad2903327f808121947d1306"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"f21611b2ada8c354c0c47b8f1db2c3be0abb5071","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        # Validate servers A and B have correct sr-iov interface"},{"line_number":811,"context_line":"        # information in the xml. Its type and vlan should be accurate."},{"line_number":812,"context_line":"        net_vlan \u003d \\"},{"line_number":813,"context_line":"            CONF.network_feature_enabled.provider_net_base_segmentation_id"},{"line_number":814,"context_line":"        for server, port in zip([server_a, server_b],"},{"line_number":815,"context_line":"                                [port_a, port_b]):"},{"line_number":816,"context_line":"            interface_xml_element \u003d self._get_xml_interface_device("}],"source_content_type":"text/x-python","patch_set":5,"id":"df3cca43_48cf7398","line":813,"in_reply_to":"9a3aa9d9_f336314c","updated":"2023-06-06 13:42:37.000000000","message":"Done","commit_id":"5aecf722211f45dfad2903327f808121947d1306"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b263f1ad5fade4f7761e8c25537a55872fedb077","unresolved":true,"context_lines":[{"line_number":810,"context_line":"        # Validate servers A and B have correct sr-iov interface"},{"line_number":811,"context_line":"        # information in the xml. Its type and vlan should be accurate."},{"line_number":812,"context_line":"        net_vlan \u003d \\"},{"line_number":813,"context_line":"            CONF.network_feature_enabled.provider_net_base_segmentation_id"},{"line_number":814,"context_line":"        for server, port in zip([server_a, server_b],"},{"line_number":815,"context_line":"                                [port_a, port_b]):"},{"line_number":816,"context_line":"            interface_xml_element \u003d self._get_xml_interface_device("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a3aa9d9_f336314c","line":813,"in_reply_to":"fa26431f_8b537992","updated":"2022-12-13 20:31:19.000000000","message":"Yes this will need to change, and most likely vDPA will land first so I will update this based on that.","commit_id":"5aecf722211f45dfad2903327f808121947d1306"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"59f8a4eea5c33f5fd0b772475917491a5a6cd2f8","unresolved":true,"context_lines":[{"line_number":283,"context_line":"        \u0027socket_topology\u0027,"},{"line_number":284,"context_line":"        default\u003dNone,"},{"line_number":285,"context_line":"        type\u003dtypes.Dict(types.List(types.Integer(), bounds\u003dTrue)),"},{"line_number":286,"context_line":"        help\u003d\u0027Host CPU topology, as a dictionary of \u003cNUMA node ID\u003e:\u0027"},{"line_number":287,"context_line":"             \u0027\u003cList of CPUs in that node\u003e. For example, if NUMA node 0 has \u0027"},{"line_number":288,"context_line":"             \u0027CPUs 0 and 1, and NUMA node 1 has CPUs 2 and 3, the value to \u0027"},{"line_number":289,"context_line":"             \u0027set would be `0: [0,1], 1: [2, 3]`.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"8269bbfc_c5176966","line":286,"updated":"2022-12-13 20:26:42.000000000","message":"Based on the code, I\u0027m assuming this is a mapping of what NUMA nodes are in what sockets (so if socket 0 has NUMA nodes 0 and 1, it would be 0: [0, 1]). Please update the helptext accordingly, and explain that it\u0027s really different from cpu_topology above :)","commit_id":"5aecf722211f45dfad2903327f808121947d1306"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"b263f1ad5fade4f7761e8c25537a55872fedb077","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        \u0027socket_topology\u0027,"},{"line_number":284,"context_line":"        default\u003dNone,"},{"line_number":285,"context_line":"        type\u003dtypes.Dict(types.List(types.Integer(), bounds\u003dTrue)),"},{"line_number":286,"context_line":"        help\u003d\u0027Host CPU topology, as a dictionary of \u003cNUMA node ID\u003e:\u0027"},{"line_number":287,"context_line":"             \u0027\u003cList of CPUs in that node\u003e. For example, if NUMA node 0 has \u0027"},{"line_number":288,"context_line":"             \u0027CPUs 0 and 1, and NUMA node 1 has CPUs 2 and 3, the value to \u0027"},{"line_number":289,"context_line":"             \u0027set would be `0: [0,1], 1: [2, 3]`.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"0f6d9a31_22e941d4","line":286,"in_reply_to":"8269bbfc_c5176966","updated":"2022-12-13 20:31:19.000000000","message":"Sure thing!","commit_id":"5aecf722211f45dfad2903327f808121947d1306"}]}
