)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23992c19_1c7f6c65","updated":"2022-09-19 08:45:58.000000000","message":"-1 for the conditional, the rest are nits. +Kashyap for the actual test logic :)","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"590b2c81eb4f94ffbc35d0afa2ac7be19916417e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a4112ae_30667557","updated":"2022-09-19 17:40:31.000000000","message":"Looks good to me. Up to James if he wants to get Kashya\u0027s review, or is happy merging this as is.","commit_id":"b1f8aa20f10d5cec8168265d401ad1189b3f2ffa"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"bd1a0ead9d3492f19e6ffaf4d706b639df61ac47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"66bb68c1_fed2ca15","updated":"2022-09-19 17:41:42.000000000","message":"Thanks Artom, I\u0027ll sync up with Kashyap tomorrow to get his thoughts.","commit_id":"b1f8aa20f10d5cec8168265d401ad1189b3f2ffa"}],"playbooks/whitebox/pre.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":true,"context_lines":[{"line_number":8,"context_line":"          name: crudini"},{"line_number":9,"context_line":"          state: present"},{"line_number":10,"context_line":"      become: yes"},{"line_number":11,"context_line":"    - name: Install ovmf"},{"line_number":12,"context_line":"      package:"},{"line_number":13,"context_line":"        name: ovmf"},{"line_number":14,"context_line":"        state: present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"882c3cfb_fe28626b","line":11,"updated":"2022-09-19 08:45:58.000000000","message":"nit: maybe a comment to indicate why this is needed. This is also Ubuntu-specific, but fine for now.","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6fd08424acf65a71c428fec42fa3418c801bfe51","unresolved":false,"context_lines":[{"line_number":8,"context_line":"          name: crudini"},{"line_number":9,"context_line":"          state: present"},{"line_number":10,"context_line":"      become: yes"},{"line_number":11,"context_line":"    - name: Install ovmf"},{"line_number":12,"context_line":"      package:"},{"line_number":13,"context_line":"        name: ovmf"},{"line_number":14,"context_line":"        state: present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"36102556_c1e10a05","line":11,"in_reply_to":"882c3cfb_fe28626b","updated":"2022-09-19 13:40:20.000000000","message":"Ack","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aba5a1a1_e9fa2783","line":27,"updated":"2022-09-19 08:45:58.000000000","message":"nit: something went screwy with the whitespace here","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6fd08424acf65a71c428fec42fa3418c801bfe51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"faa6bfb5_e5daab9b","line":27,"in_reply_to":"aba5a1a1_e9fa2783","updated":"2022-09-19 13:40:20.000000000","message":"Ack","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"}],"whitebox_tempest_plugin/api/compute/test_uefi.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"import testtools"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2c4705a_afc43618","line":14,"updated":"2022-09-19 08:45:58.000000000","message":"nit: newline (weird that pep8 didn\u0027t catch this?)","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6fd08424acf65a71c428fec42fa3418c801bfe51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"import testtools"}],"source_content_type":"text/x-python","patch_set":3,"id":"42d32108_8854692d","line":14,"in_reply_to":"e2c4705a_afc43618","updated":"2022-09-19 13:40:20.000000000","message":"Ack","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        image_properties \u003d {\u0027hw_firmware_type\u0027: \u0027uefi\u0027}"},{"line_number":70,"context_line":"        if not CONF.compute_feature_enabled.default_machine_type_q35:"},{"line_number":71,"context_line":"            image_properties[\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Create image with UEFI firmware type"},{"line_number":74,"context_line":"        uefi_image_id \u003d self.copy_default_image(**image_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"074e4a7e_1b99c099","line":71,"updated":"2022-09-19 08:45:58.000000000","message":"Why do we need the conditional at all? What happens if the default is q35 and we set it again for good measure on the image?","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6fd08424acf65a71c428fec42fa3418c801bfe51","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        image_properties \u003d {\u0027hw_firmware_type\u0027: \u0027uefi\u0027}"},{"line_number":70,"context_line":"        if not CONF.compute_feature_enabled.default_machine_type_q35:"},{"line_number":71,"context_line":"            image_properties[\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Create image with UEFI firmware type"},{"line_number":74,"context_line":"        uefi_image_id \u003d self.copy_default_image(**image_properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e5a2ff6_d489bee2","line":71,"in_reply_to":"074e4a7e_1b99c099","updated":"2022-09-19 13:40:20.000000000","message":"It\u0027s the same result either way so I\u0027m ok with removing this.","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"280738f45ec6c38fd7ce19826996074cea857ad2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9588193b_1816fbff","line":117,"updated":"2022-09-29 16:00:56.000000000","message":"Looks good to me; you\u0027ve tested both plain UEFI and UEFI secure boot (SB).\n\nThe final XML for SB should be something like:\n\n  \u003cos\u003e\n    \u003ctype arch\u003d\"x86_64\" machine\u003d\"pc-q35-2.9\"\u003ehvm\u003c/type\u003e\n    \u003cloader readonly\u003d\"yes\" secure\u003d\"yes\" type\u003d\"pflash\"\u003e/usr/share/edk2/ovmf/OVMF_CODE.secboot.fd\u003c/loader\u003e\n    \u003cnvram\u003e/var/lib/libvirt/qemu/nvram/f26-ovmf-vm2_VARS.fd\u003c/nvram\u003e\n    \u003cbootmenu enable\u003d\"yes\" timeout\u003d\"3000\"/\u003e\n  \u003c/os\u003e","commit_id":"b1f8aa20f10d5cec8168265d401ad1189b3f2ffa"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1123680405e55818a4e9ea13bdc271bbce29329f","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    cfg.BoolOpt(\u0027uefi_secure_boot\u0027,"},{"line_number":302,"context_line":"                default\u003dFalse,"},{"line_number":303,"context_line":"                help\u003d\"If false, skip uefi secure boot tests\"),"},{"line_number":304,"context_line":"    cfg.BoolOpt(\u0027default_machine_type_q35\u0027,"},{"line_number":305,"context_line":"                default\u003dFalse,"},{"line_number":306,"context_line":"                help\u003d\"Default machine type for deployment is q35\")"},{"line_number":307,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3b58d2e_b5a37e9c","line":304,"updated":"2022-09-19 08:45:58.000000000","message":"... and if we lose the conditional in the test code, this can disappear as well.","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6fd08424acf65a71c428fec42fa3418c801bfe51","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    cfg.BoolOpt(\u0027uefi_secure_boot\u0027,"},{"line_number":302,"context_line":"                default\u003dFalse,"},{"line_number":303,"context_line":"                help\u003d\"If false, skip uefi secure boot tests\"),"},{"line_number":304,"context_line":"    cfg.BoolOpt(\u0027default_machine_type_q35\u0027,"},{"line_number":305,"context_line":"                default\u003dFalse,"},{"line_number":306,"context_line":"                help\u003d\"Default machine type for deployment is q35\")"},{"line_number":307,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f7755dd_d940bba3","line":304,"in_reply_to":"f3b58d2e_b5a37e9c","updated":"2022-09-19 13:40:20.000000000","message":"Ack","commit_id":"6d4be60f387d60dfb03642831aeebae7895457a1"}]}