)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"944fc9969fcd1619b148875292cbabebca3e9358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce342d34_b66b8d1e","updated":"2022-09-19 18:17:35.000000000","message":"Downstream Run with volume restriction enforced:\n(overcloud) [stack@undercloud tempest]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_virtio_scsi_attach.VirtioSCSIDisk\n{0} whitebox_tempest_plugin.api.compute.test_virtio_scsi_attach.VirtioSCSIDisk.test_attach_multiple_scsi_disks [36.550276s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_virtio_scsi_attach.VirtioSCSIDisk.test_boot_with_multiple_disks [38.483027s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 75.0418 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 75.0333 sec.\n","commit_id":"46165312d0f7e3214e98d6cf90b1e948a3f52af9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b713f0677402ca8e01bee2a5bc58de1e2d0837ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93449e94_8232e550","updated":"2022-09-19 18:55:14.000000000","message":"OK, tell me if what I\u0027m proposing makes sense:\n\n1. always set [compute]/max_disk_devices (for upstream, either in .zuul.yaml directly, or in the python code, with a preference for the former. For downstream, through t-h-t)\n2. have the test always try attaching a (max_disk_devices + 1)th volume, and asserting that it fails.\n","commit_id":"46165312d0f7e3214e98d6cf90b1e948a3f52af9"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ef185f2cb91ca7a8825f0880ee8d48240989640e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b3189ea_6f0fbbb7","in_reply_to":"93449e94_8232e550","updated":"2022-09-19 19:23:11.000000000","message":"For 17.1+ that works, I think as long as the parameter can be set in 16.x - 17.0 via the puppet style setup I think this can work also. If it is not exposed though,  it defaults to -1 in nova.conf and would not fail on the max + 1 volume attachment.  Let me see if I can get a 16.x deployment to overwrite the default and if so I\u0027ll update the commit to do the extra attach.","commit_id":"46165312d0f7e3214e98d6cf90b1e948a3f52af9"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"738f5734ae28646ac9731056fcf38da1dd479c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72b3a1eb_21c14284","updated":"2022-09-30 13:41:16.000000000","message":"LGTM, and address the nits in  FUP.","commit_id":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1"}],"whitebox_tempest_plugin/api/compute/test_virtio_scsi_attach.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"738f5734ae28646ac9731056fcf38da1dd479c70","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from tempest import config"},{"line_number":18,"context_line":"from tempest.lib.exceptions import Forbidden"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6a600299_e2619ea3","line":18,"updated":"2022-09-30 13:41:16.000000000","message":"fempto nit: I\u0027m not a fan of importing bare classes, makes it harder to figure out what they are without the module in front.","commit_id":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"738f5734ae28646ac9731056fcf38da1dd479c70","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                      \"is %s or more devices\" % cls.disks_to_create"},{"line_number":113,"context_line":"                raise cls.skipException(msg)"},{"line_number":114,"context_line":"        required_disk_space \u003d \\"},{"line_number":115,"context_line":"            CONF.whitebox.flavor_volume_size + cls.disks_to_create"},{"line_number":116,"context_line":"        if CONF.whitebox.available_cinder_storage \u003c required_disk_space:"},{"line_number":117,"context_line":"            msg \u003d \"Need more than  %sGB of storage to execute\" \\"},{"line_number":118,"context_line":"                % required_disk_space"}],"source_content_type":"text/x-python","patch_set":2,"id":"57704370_de0dc8e6","line":115,"updated":"2022-09-30 13:41:16.000000000","message":"This assumes each created disk is 1G, right? Maybe add a comment to that effect...","commit_id":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"738f5734ae28646ac9731056fcf38da1dd479c70","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                  \"in the deployment to test\""},{"line_number":224,"context_line":"            raise cls.skipException(msg)"},{"line_number":225,"context_line":"        required_disk_space \u003d CONF.whitebox.flavor_volume_size + \\"},{"line_number":226,"context_line":"            CONF.whitebox.max_disk_devices_to_attach"},{"line_number":227,"context_line":"        if CONF.whitebox.available_cinder_storage \u003c required_disk_space:"},{"line_number":228,"context_line":"            msg \u003d \"Need more than  %sGB of storage to execute\" \\"},{"line_number":229,"context_line":"                % required_disk_space"}],"source_content_type":"text/x-python","patch_set":2,"id":"0929832f_e11583f3","line":226,"updated":"2022-09-30 13:41:16.000000000","message":"Same here, about the 1G disk size","commit_id":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"738f5734ae28646ac9731056fcf38da1dd479c70","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        vol_ids \u003d []"},{"line_number":244,"context_line":"        # A virtio-scsi disk has already been attached to the server\u0027s disk"},{"line_number":245,"context_line":"        # controller since hw_scsi_model of the image was already set to"},{"line_number":246,"context_line":"        # \u0027virtio-scsi\u0027 in self.setUp(). Decrementing disks_to_create by 1."},{"line_number":247,"context_line":"        for _ in range(disks_to_create - 1):"},{"line_number":248,"context_line":"            volume \u003d self.create_volume(size\u003d1)"},{"line_number":249,"context_line":"            vol_ids.append(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"809c5a2a_2a56859c","line":246,"updated":"2022-09-30 13:41:16.000000000","message":"This is an awesome comment - explains the \"why\" and gives context, without just repeating what the code is doing.","commit_id":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1"}]}