)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~858443","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I78f7f47ffa2644c71945bba2b5c1af29e0603363","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"max_dev_to_attach","attention_set":{},"removed_from_attention_set":{"8864":{"account":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"last_update":"2022-09-30 13:41:16.000000000","reason":"\u003cGERRIT_ACCOUNT_8864\u003e replied on the change","reason_account":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2022-09-30 15:14:25.000000000","reason":"Change was submitted"},"31033":{"account":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"last_update":"2022-09-30 15:14:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I78f7f47ffa2644c71945bba2b5c1af29e0603363","subject":"Add check for max disk attach","status":"MERGED","created":"2022-09-19 18:16:38.000000000","updated":"2022-09-30 15:14:25.000000000","submitted":"2022-09-30 15:14:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"858443-max_dev_to_attach","meta_rev_id":"1c45d5e2b9b52f9a24bc6bd7be541be9286d8700","_number":858443,"virtual_id_number":858443,"owner":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-09-30 15:14:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2022-09-30 13:41:16.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2022-09-30 13:41:16.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 18:17:35.000000000","updated_by":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2022-09-19 18:17:35.000000000","updated_by":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2022-09-19 19:29:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fd7eee728f8fdee141af5340b592719b49716dca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2022-09-19 18:16:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"944fc9969fcd1619b148875292cbabebca3e9358","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2022-09-19 18:17:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b713f0677402ca8e01bee2a5bc58de1e2d0837ca","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2022-09-19 18:55:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ef185f2cb91ca7a8825f0880ee8d48240989640e","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2022-09-19 19:23:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"abed99a569afa343f131ea312a0f262b84a21826","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-19 19:29:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0589fa27f16a4d649aea768b35e01e52\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ec781ac609324af4bb5ba7b1311b1b7f : SUCCESS in 2m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5d554596e4724688a90583990488a801 : SUCCESS in 2m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/24d7717d8c674efeb7fd7ded98484079 : SUCCESS in 2m 47s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b1e7034423e1406684395d6cb06df451 : SUCCESS in 2m 56s (non-voting)\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/11d91bc1b8cf45b7924aa9c36587447d : SUCCESS in 4m 01s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/2a4ebebb1b7a41669891ff0d8d16c2f8 : SUCCESS in 1h 11m 22s\n- whitebox-devstack-ceph-multinode https://zuul.opendev.org/t/openstack/build/bba5b62d2c1d4fe4aaf80dfa8070b5d3 : SUCCESS in 47m 54s","accounts_in_message":[],"_revision_number":1},{"id":"e10204e069ba82dbca0ac5a2572c6d973172ccf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2022-09-21 15:37:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"418de12c1eec1cf7020fc48a4d57cb4dc4a6403e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-21 16:55:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bf5ed82750794b808d9dcb3ffc829e43\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/485c16c1a5f6462c88c9a4cbcfb98628 : SUCCESS in 2m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/474dec105ef54598939136f02b8c0ffe : SUCCESS in 3m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/32a5c7bc6b634464962e38f0267a2a06 : SUCCESS in 3m 06s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/d3a076ac1f0f429bbc77b47b95898fee : SUCCESS in 3m 04s (non-voting)\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/41ed03e41dc743d281d9d1c006405e44 : SUCCESS in 4m 01s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/d4cbfc613d774940b5263bf49a7f0b6c : SUCCESS in 1h 15m 38s\n- whitebox-devstack-ceph-multinode https://zuul.opendev.org/t/openstack/build/b4d988ac75fd4dbda919e537668d2297 : SUCCESS in 48m 50s","accounts_in_message":[],"_revision_number":2},{"id":"738f5734ae28646ac9731056fcf38da1dd479c70","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2022-09-30 13:41:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"57fc31c569df760c8bfb98e3b0f97d2a497d656d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-30 13:41:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"87907af62022be0634e5e58cd46700122d0a5d67","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-30 15:14:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0326eb6fc2ff4c5fbdf58f65915b27e2\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c719a1075fd64079aa7c11e23088cece : SUCCESS in 3m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d23d71c772c74696ac552a92a985969f : SUCCESS in 3m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/51f9e71561714bc081f02b82b1e4d168 : SUCCESS in 4m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4fdaacd36a514914963188a5f4c9b0b1 : SUCCESS in 3m 36s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/bf05b22db5884549aa12e3c89c694d72 : SUCCESS in 1h 17m 27s\n- whitebox-devstack-ceph-multinode https://zuul.opendev.org/t/openstack/build/e18eb634592744e08b23728d83a1d8a7 : SUCCESS in 52m 41s","accounts_in_message":[],"_revision_number":2},{"id":"1c45d5e2b9b52f9a24bc6bd7be541be9286d8700","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-30 15:14:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9f98d0aaf9a0b59e8c78939390c2db42d52713b1","revisions":{"46165312d0f7e3214e98d6cf90b1e948a3f52af9":{"kind":"REWORK","_number":1,"created":"2022-09-19 18:16:38.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/43/858443/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/43/858443/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/1"}}},"commit":{"parents":[{"commit":"5e6f6f5fd54e273968232d5db450f97b440d7ee0","subject":"Merge \"Attach and detach an SR-IOV port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/5e6f6f5fd54e273968232d5db450f97b440d7ee0"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2022-09-19 18:13:25.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2022-09-19 18:13:28.000000000","tz":-240},"subject":"Add check for max disk attach","message":"Add check for max disk attach\n\nThe commit [1] added a THT parameter that can set the maximum number of\ndisks that can be attached to a single guest. Update\nVirtioSCSIDisk.test_attach_multiple_scsi_disks to ensure that\nrestriction is enforced. This update will not execute unless the max\ndisk size is configured via max_disk_devices_to_attach that has been\nadded to config.py.\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/708666/\n\nChange-Id: I78f7f47ffa2644c71945bba2b5c1af29e0603363\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/46165312d0f7e3214e98d6cf90b1e948a3f52af9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/46165312d0f7e3214e98d6cf90b1e948a3f52af9"}]},"branch":"refs/heads/master"},"9f98d0aaf9a0b59e8c78939390c2db42d52713b1":{"kind":"REWORK","_number":2,"created":"2022-09-21 15:37:57.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/43/858443/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/43/858443/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/43/858443/2"}}},"commit":{"parents":[{"commit":"5e6f6f5fd54e273968232d5db450f97b440d7ee0","subject":"Merge \"Attach and detach an SR-IOV port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/5e6f6f5fd54e273968232d5db450f97b440d7ee0"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2022-09-19 18:13:25.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2022-09-21 15:23:37.000000000","tz":-240},"subject":"Add check for max disk attach","message":"Add check for max disk attach\n\nThe commit [1] added a THT parameter that can set the maximum number of\ndisks that can be attached to a single guest. Refactored VirtioSCSIDisk\ninto ultimately three new classes.\n\n * VirtioSCSIBase - parent class hold standard setup and supporting\n   methods for test cases\n * VirtioSCSIDiskMultiAttachment - repuprose of the test methods from\n   VirtioSCSIDisk which are meant to test guest support of six or more\n   disks\n * VirtioSCSIDiskRestrictAttachments - New test method that validates\n   [1] is being enforced correctly.\n\nSince [1] could be set to a value less than six, added skip checks for\nVirtioSCSIDiskMultiAttachment if the max allowed disks that can be\nattached are six or less.\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/708666/\n\nChange-Id: I78f7f47ffa2644c71945bba2b5c1af29e0603363\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9f98d0aaf9a0b59e8c78939390c2db42d52713b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/9f98d0aaf9a0b59e8c78939390c2db42d52713b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}}]}],"submit_requirements":[]}